Skip to content
  1. Oct 02, 2018
    • Jacopo's avatar
      Hides Close MR button on merged MR · e2056f08
      Jacopo authored
      When a Merge request is merged, shows only the Report abuse menu item
      in the dropdown menu instead of showing the close_reopen_report toggle
      with an unusable Close button.
      The Report abuse is still hidden when the author of the Merge request
      is the current_user.
      
      Hides the Reopen button on a closed and locked issue when the
      issue.author is not the current_user
      e2056f08
  2. Jul 09, 2018
  3. Jun 01, 2018
  4. Jan 31, 2018
  5. Dec 22, 2017
  6. Dec 14, 2017
  7. Aug 02, 2017
  8. Jul 28, 2017
    • Yorick Peterse's avatar
      Merge issuable "reopened" state into "opened" · 6ef87a20
      Yorick Peterse authored
      Having two states that essentially mean the same thing is very much like
      having a boolean "true" and boolean "mostly-true": it's rather silly.
      This commit merges the "reopened" state into the "opened" state while
      taking care of system notes still showing messages along the lines of
      "Alice reopened this issue".
      
      A big benefit from having only two states (opened and closed) is that
      indexing and querying becomes simpler and more performant. For example,
      to get all the opened queries we no longer have to query both states:
      
          SELECT *
          FROM issues
          WHERE project_id = 2
          AND state IN ('opened', 'reopened');
      
      Instead we can query a single state directly, which can be much faster:
      
          SELECT *
          FROM issues
          WHERE project_id = 2
          AND state = 'opened';
      
      Further, only having two states makes indexing easier as we will only
      ever filter (and thus scan an index) using a single value. Partial
      indexes could help but aren't supported on MySQL, complicating the
      development process and not being helpful for MySQL.
      6ef87a20
  9. Apr 25, 2017
  10. Apr 03, 2017
  11. Jan 25, 2017
  12. Sep 12, 2016
  13. Jul 21, 2016
    • Robert Speicher's avatar
      Refactor Issues::BulkUpdateService spec · 97c4a1dc
      Robert Speicher authored
      - Create fewer Issue objects; 2 is as good as 5 for these cases. This
        gives us a nice little speed improvement.
      - Don't `describe` Symbols.
      - Simplify object creation.
      - Lessen "mystery guest" antipattern
      97c4a1dc
  14. Mar 18, 2016
  15. Mar 04, 2016