Skip to content
Snippets Groups Projects
  1. Jun 06, 2019
  2. Jun 05, 2019
    • Daniel Gerhardt's avatar
      Remove confusing log message · be2f311f
      Daniel Gerhardt authored
      An error was logged before destroying UserServiceImpl class without any
      reason.
      be2f311f
    • Daniel Gerhardt's avatar
      Remove confusing log message · 3d388560
      Daniel Gerhardt authored
      An error was logged before destroying UserService class without any
      reason.
      3d388560
    • Daniel Gerhardt's avatar
      Allow limited access to UserProfiles for authenticated users · 8024c57f
      Daniel Gerhardt authored and Daniel Gerhardt's avatar Daniel Gerhardt committed
      Authenticated users can read `loginId` and `authProvider` properties.
      A FindQueryService has been added to lookup UserProfiles by `loginId`.
      8024c57f
    • Christoph Thelen's avatar
      745646fc
    • Christoph Thelen's avatar
      Revert additional profile, add global Mock for EntityService<DummyEntity> · 2aaa1567
      Christoph Thelen authored and Daniel Gerhardt's avatar Daniel Gerhardt committed
      Two key changes:
      
        1. Add a factory method to create the EntityService with the
           DummyEntity, so that all other test cases can initialize
           this Bean.  This solves the IllegalStateException reported
           in this ticket.
        2. Use @Autowire instead of @MockBean to use the new factory
           method.  That resolves the known issue that the caching test
           case does not work because of different RoomRepositories being
           created for the PermissionEvaluatorAdvice and the EntityService.
      
      This makes all tests runnable again.  My current theory is that due to
      the fact that we have at least two EntityServices (one created by
      the DefaultEntityServiceImplTest, and now one by this test).  The
      @MockBean annotation could be throwing out the previous EntityService,
      since according to documentation, it replaces existing Beans with the
      same type.  This could lead to a situation where, initially, the
      PermissionEvaluatorAdvice and the DefaultEntityService share the same
      RoomRepository.  But after the @MockBean replacement occurs, the
      EntityService is recreated with a different RoomRepository, while the
      Advice keeps its initial RoomRepository, leading to testing failures
      in the testCaching test case.
      2aaa1567
    • Christoph Thelen's avatar
      Add additional profile to exclude Controller from other tests · 66cc0201
      Christoph Thelen authored and Daniel Gerhardt's avatar Daniel Gerhardt committed
      This solves the IllegalStateExceptions occurring for most of the other
      test cases.
      
      However, we now have the old problem that different Repositories are
      injected into objects. In my case, the testCaching case of the
      DefaultEntityServiceImplTest stops working, because it gets a different
      RoomRepository than the ApplicationPermissionEvaluator.
      
      This behavior is caused by the introduction of the additional profile.
      66cc0201
    • Daniel Gerhardt's avatar
      Temporarily add test logging for debugging · 0553902b
      Daniel Gerhardt authored and Daniel Gerhardt's avatar Daniel Gerhardt committed
      0553902b
    • Daniel Gerhardt's avatar
      WIP: Add tests for JsonViewControllerAdvice · 0e8cbd17
      Daniel Gerhardt authored and Daniel Gerhardt's avatar Daniel Gerhardt committed
      See commit f620b9e7.
      0e8cbd17
  3. May 31, 2019
  4. May 28, 2019
  5. May 27, 2019
  6. Apr 30, 2019
  7. Apr 17, 2019
  8. Mar 15, 2019
  9. Mar 05, 2019
  10. Feb 25, 2019
  11. Feb 18, 2019
  12. Feb 12, 2019
  13. Jan 31, 2019
    • Christoph Thelen's avatar
      Fix broken tests on Travis and some other systems · 8ad7cd84
      Christoph Thelen authored
      Both the RoomRepository as well as the CacheManager beans were
      not shared between test and production classes. Hence, when we
      set up some mocks (or caches), the mocked values were not
      present in the production classes.
      
      We explicitly force instance sharing by applying the Singleton pattern.
      8ad7cd84
    • Daniel Gerhardt's avatar
      Update default configuration · 9ad63992
      Daniel Gerhardt authored
      * Update MathJax URL to use version 2.7.5
      * Piwik was renamed to Matomo
      9ad63992
  14. Jan 30, 2019
  15. Jan 29, 2019
  16. Jan 28, 2019