• Douwe Maan's avatar
    Merge branch '20568-fix-member-data-again' into 'master' · 1aba0668
    Douwe Maan authored
    Add a data migration to fix some missing timestamps in the members table (again)
    
    ## What does this MR do?
    
    Repeats an earlier migration to fix historic bad data in the members table (missing created_at and updated_at fields)
    
    ## Are there points in the code the reviewer needs to double check?
    
    I'm expecting the WHERE clauses to be fast enough, and to return few enough rows, that the migration doesn't need to use batches, but I'm not too familiar with the size of these tables in the wild, so perhaps that's a poor assumption. 
    
    ## Why was this MR needed?
    
    8.10 introduced a dependency on the  `members.created_at` field in the project and namespace member view. If bad data is present, viewing the list of members now results in an NoMethodError and a 500 response from GitLab. Although the previous migration should have fixed all bad rows, we have evidence that it didn't in at least one case, despite the migration claiming to have run in the past.
    
    ## What are the relevant issue numbers?
    
    #20568 
    
    ## Screenshots (if relevant)
    
    ## Does this MR meet the acceptance criteria?
    
    - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
    - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
    - [ ] API support added
    - Tests
      - [ ] Added for this feature/bug
      - [ ] All builds are passing
    - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
    - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
    - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
    
    Closes #20568
    
    See merge request !5670
    1aba0668
Name
Last commit
Last update
..
fixtures Loading commit data...
migrate Loading commit data...
schema.rb Loading commit data...
seeds.rb Loading commit data...