Skip to content
  1. Aug 15, 2018
  2. Aug 07, 2018
  3. Aug 03, 2018
  4. Jul 29, 2018
  5. Jul 26, 2018
  6. Jul 25, 2018
  7. Jul 24, 2018
  8. Jul 20, 2018
  9. Jul 18, 2018
  10. Jul 14, 2018
  11. Jul 09, 2018
  12. Jul 08, 2018
  13. Jul 07, 2018
  14. Jul 06, 2018
  15. Jul 05, 2018
  16. Jun 30, 2018
  17. Jun 28, 2018
  18. Jun 27, 2018
    • Zeger-Jan van de Weg's avatar
      Gitaly metrics check for read/writeability · 65840591
      Zeger-Jan van de Weg authored
      Prior to this change, health checks checked for writeability of the NFS
      shards. Given we're moving away from that, this patch extends the checks
      for Gitaly to check for read and writeability.
      
      Potentially some dashboards will break, as over time these metrics will
      no longer appear as Prometheus doesn't get the data anymore.
      Observability in the circuit breaker will be reduced, but its not
      expected to be turned on and the circuit breaker is being removed soon
      too.
      
      Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
      65840591
  19. Jun 20, 2018
  20. Jun 18, 2018
  21. Jun 16, 2018
  22. Jun 15, 2018
  23. Jun 12, 2018
  24. Jun 09, 2018
  25. Jun 07, 2018
  26. Jun 06, 2018
  27. Jun 05, 2018
  28. May 14, 2018
  29. May 11, 2018
  30. May 03, 2018
  31. Apr 28, 2018
    • blackst0ne's avatar
      Update `Gemfile.rails5.lock` · 34a3e165
      blackst0ne authored
      34a3e165
    • blackst0ne's avatar
      [Rails5] Fix `params` for DeleteUserWorker · 4a306796
      blackst0ne authored
      This commit fixes the error:
      
      ```
        1) Admin::UsersController DELETE #user with projects deletes the user and their contributions when hard delete is specified
           Failure/Error: Users::DestroyService.new(current_user).execute(delete_user, options.symbolize_keys)
      
           NoMethodError:
             undefined method `symbolize_keys' for "{\"hard_delete\"=>\"true\"}":String
           # ./app/workers/delete_user_worker.rb:8:in `perform'
           # ./lib/gitlab/sidekiq_status/server_middleware.rb:5:in `call'
           # ./config/initializers/forbid_sidekiq_in_transactions.rb:35:in `block (2 levels) in <module:NoEnqueueingFromTransactions>'
           # ./app/models/user.rb:913:in `delete_async'
           # ./app/controllers/admin/users_controller.rb:148:in `destroy'
           # ./lib/gitlab/i18n.rb:50:in `with_locale'
           # ./lib/gitlab/i18n.rb:56:in `with_user_locale'
           # ./app/controllers/application_controller.rb:327:in `set_locale'
           # ./spec/controllers/admin/users_controller_spec.rb:28:in `block (3 levels) in <top (required)>'
      
      Finished in 6.81 seconds (files took 13.9 seconds to load)
      1 example, 1 failure
      ```
      4a306796
  32. Apr 19, 2018
  33. Apr 10, 2018
    • blackst0ne's avatar
      [Rails5] Fix running spinach tests · 1a455f3d
      blackst0ne authored
      1. Add support for `RAILS5=1|true` for the `bin/spinach` command.
      2. Synchronize used spinach versions both for rails4 and rails5.
      
      For rails5 it was accidently used spinach 0.10.1 instead of 0.8.10.
      That brought some problems on running spinach tests.
      
      Example of failure message:
      
      NoMethodError: undefined method `line' for #<Spinach::Scenario:0x000000000c86ba80>
      Did you mean?  lines
        /builds/gitlab-org/gitlab-ce/features/support/env.rb:52:in `before_scenario_run'
      1a455f3d
  34. Apr 08, 2018
  35. Apr 07, 2018