- Aug 15, 2018
-
-
Michael Kozono authored
-
- Aug 07, 2018
-
-
Rubén Dávila authored
-
- Aug 03, 2018
-
-
Jasper Maes authored
-
- Jul 29, 2018
-
-
Stan Hu authored
Fixes failing builds with gcc on Archlinux and Ruby 2.4.4. See https://gitlab.com/gitlab-org/prometheus-client-mmap/merge_requests/26 for more details.
-
- Jul 26, 2018
-
-
Jasper Maes authored
-
- Jul 25, 2018
-
-
Stan Hu authored
This will be enabled if ENABLE_RBTRACE environment variable is defined. This will allow us to debug all sorts of issues in production: https://github.com/tmm1/rbtrace
-
Stan Hu authored
Without this parameter, every load of a Wiki page will load all the Wiki pages in the repository for the sidebar. This is a significant performance penalty that can significant slow the display of all Wiki pages. Relates to #40101
-
- Jul 24, 2018
-
-
Stan Hu authored
sanitize 4.6.6 has this optimization that will benefit Markdown rendering: https://github.com/rgrove/sanitize/pull/183 nokogiri 1.4.4 has this memory leak fix: https://github.com/sparklemotion/nokogiri/pull/1771
-
- Jul 20, 2018
-
-
Gabriel Mazetto authored
This will enable bootsnap whenver the gem is available.
-
- Jul 18, 2018
-
-
Alejandro Rodríguez authored
-
- Jul 14, 2018
-
-
Kukovskii Vladimir authored
-
- Jul 09, 2018
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
- Jul 08, 2018
-
-
Matthew Dawson authored
Also update the hook logs to escape the contents properly, as the :plain filter does not do html escaping.
-
- Jul 07, 2018
-
-
Jasper Maes authored
-
- Jul 06, 2018
-
-
Jacob Vosmaer authored
-
- Jul 05, 2018
-
-
Tom Downes authored
for handling multi-valued SAML assertions. Add documentation of label argument for omniauth provider to override text in login button.
-
- Jun 30, 2018
-
-
Pirate Praveen authored
-
- Jun 28, 2018
-
-
Markus Koller authored
-
- Jun 27, 2018
-
-
Zeger-Jan van de Weg authored
Prior to this change, health checks checked for writeability of the NFS shards. Given we're moving away from that, this patch extends the checks for Gitaly to check for read and writeability. Potentially some dashboards will break, as over time these metrics will no longer appear as Prometheus doesn't get the data anymore. Observability in the circuit breaker will be reduced, but its not expected to be turned on and the circuit breaker is being removed soon too. Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
-
- Jun 20, 2018
-
-
Yorick Peterse authored
In MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15834 we removed use of the data produced by the Allocations Gem. However, we never removed the code that just enables tracking of allocations. In this commit we remove all remaining traces of this Gem.
-
- Jun 18, 2018
-
-
Douwe Maan authored
-
- Jun 16, 2018
-
-
Jasper Maes authored
-
- Jun 15, 2018
-
-
Ahmad Hassan authored
-
- Jun 12, 2018
-
-
blackst0ne authored
-
- Jun 09, 2018
-
-
blackst0ne authored
-
- Jun 07, 2018
-
-
Jasper Maes authored
-
- Jun 06, 2018
-
-
Pirate Praveen authored
-
- Jun 05, 2018
-
-
blackst0ne authored
-
- May 14, 2018
-
-
blackst0ne authored
-
- May 11, 2018
-
-
blackst0ne authored
atomic 1.1.100 was yanked by its author.
-
- May 03, 2018
-
-
blackst0ne authored
-
- Apr 28, 2018
-
-
blackst0ne authored
-
blackst0ne authored
This commit fixes the error: ``` 1) Admin::UsersController DELETE #user with projects deletes the user and their contributions when hard delete is specified Failure/Error: Users::DestroyService.new(current_user).execute(delete_user, options.symbolize_keys) NoMethodError: undefined method `symbolize_keys' for "{\"hard_delete\"=>\"true\"}":String # ./app/workers/delete_user_worker.rb:8:in `perform' # ./lib/gitlab/sidekiq_status/server_middleware.rb:5:in `call' # ./config/initializers/forbid_sidekiq_in_transactions.rb:35:in `block (2 levels) in <module:NoEnqueueingFromTransactions>' # ./app/models/user.rb:913:in `delete_async' # ./app/controllers/admin/users_controller.rb:148:in `destroy' # ./lib/gitlab/i18n.rb:50:in `with_locale' # ./lib/gitlab/i18n.rb:56:in `with_user_locale' # ./app/controllers/application_controller.rb:327:in `set_locale' # ./spec/controllers/admin/users_controller_spec.rb:28:in `block (3 levels) in <top (required)>' Finished in 6.81 seconds (files took 13.9 seconds to load) 1 example, 1 failure ```
-
- Apr 19, 2018
-
-
blackst0ne authored
This commit does two things: 1. Synchronizes `Gemfile.rails5.lock` with the latest changes in `Gemfile` 2. Adds a monkey patch for active record to avoid type casting in uniqueness validator. In Rails 5.0 there was introduced a bug [1] that causes to problems like this: ``` 1) API::Users POST /user/:id/gpg_keys/:key_id/revoke when authenticated revokes existing key Failure/Error: let(:gpg_key) { create(:gpg_key, user: user) } TypeError: can't cast Hash ``` This bug was fixed in Rails 5.1 [2]. [1]: https://github.com/rails/rails/pull/23523/commits/811a4fa8eb6ceea841e61e8ac05747ffb69595ae [2]: https://github.com/rails/rails/pull/24745/commits/aa062318c451512035c10898a1af95943b1a3803
-
- Apr 10, 2018
-
-
blackst0ne authored
1. Add support for `RAILS5=1|true` for the `bin/spinach` command. 2. Synchronize used spinach versions both for rails4 and rails5. For rails5 it was accidently used spinach 0.10.1 instead of 0.8.10. That brought some problems on running spinach tests. Example of failure message: NoMethodError: undefined method `line' for #<Spinach::Scenario:0x000000000c86ba80> Did you mean? lines /builds/gitlab-org/gitlab-ce/features/support/env.rb:52:in `before_scenario_run'
-
- Apr 08, 2018
-
-
blackst0ne authored
In Rails 5.0 `assert_template` and `assigns()` have been extracted to the `rails-controller-testing` gem. https://github.com/rails/rails/pull/20138/files This commit adds this gem for rails5.
-
- Apr 07, 2018
-
-
blackst0ne authored
-
blackst0ne authored
1. Synchronize used version of `parser` gem for both versions of rails: 4 and 5. 2. Fix broken CI pipelines for rails5 branches. The 2.5.0.4 version is removed from rubygems, so it's skipped. https://github.com/whitequark/parser/issues/478
-