Skip to content
  1. Apr 11, 2019
  2. Mar 06, 2019
  3. Feb 28, 2019
    • Mario de la Ossa's avatar
      Always use CTE for IssuableFinder counts · 39afba06
      Mario de la Ossa authored
      Since the CTE is faster than a subquery and the only reason we're using
      a subquery is that the CTE can't handle sorting by certain attributes,
      let's use the CTE always (when the feature flag is enabled) when
      counting, since we can ignore ordering if we just want a count of
      results.
      39afba06
  4. Feb 27, 2019
  5. Feb 26, 2019
  6. Feb 25, 2019
  7. Feb 22, 2019
  8. Feb 21, 2019
  9. Feb 20, 2019
    • Sean McGivern's avatar
      Ignore ordering when calling find_by on finders · 843f4b94
      Sean McGivern authored
      We shouldn't care about the ordering here; if we did, it would be more
      appropriate to use `take` or `first`. Having the ordering can result in
      the database picking a bad query plan, as it might think sorting the
      whole table first is the best option.
      843f4b94
  10. Feb 06, 2019
  11. Feb 05, 2019
  12. Jan 31, 2019
  13. Jan 28, 2019
  14. Jan 24, 2019
    • Jacopo's avatar
      Adds milestone search · 22eb2e4c
      Jacopo authored
      Adds to search ILIKE search for milestones title in:
        - Milestones dashboard
        - Group milestones page
        - Project milestones page
      22eb2e4c
  15. Jan 14, 2019
  16. Jan 11, 2019
  17. Jan 10, 2019
  18. Jan 08, 2019
  19. Dec 31, 2018
  20. Dec 19, 2018
  21. Dec 17, 2018
    • Bob Van Landuyt's avatar
      Hide confidential events in ruby · 28acd2b0
      Bob Van Landuyt authored
      We're filtering the events using `Event#visible_to_user?`.
      
      At most we're loading 100 events at once.
      
      Pagination is also dealt with in the finder, but the resulting array
      is wrapped in a `Kaminari.paginate_array` so the API's pagination
      helpers keep working. We're passing the total count into that
      paginatable array, which would include confidential events. But we're
      not disclosing anything.
      28acd2b0
  22. Dec 16, 2018
    • Thong Kuah's avatar
      Use finder to decide to show note to user · f82c9dbe
      Thong Kuah authored
      Given the note is about how to interpret ancestor clusters, use the
      finder which actually knows if there are any ancestor clusters to find
      out if the note should be shown, rather than passing the same info via a
      view to a helper
      
      Added note about Kaminari.paginate_array
      
      Link to followup issue too
      f82c9dbe
    • Thong Kuah's avatar
      Check can :read_clusters in finder · 2ad5f999
      Thong Kuah authored
      This is in addtion to the can checks we have in the controller, as a
      finder can be used elsewhere in the future.
      2ad5f999
    • Thong Kuah's avatar
      Show clusters of ancestors in cluster list page · 7e4f76ea
      Thong Kuah authored
      Show both the cluster(s) of the clusterable, and the cluster(s) of
      ancestor groups.
      7e4f76ea
  23. Dec 12, 2018
  24. Dec 07, 2018