Commit 2444c040 authored by Steffen Köhler's avatar Steffen Köhler
Browse files

Fix signup for some OAuth providers

some OAuth providers (kerberos for example) only provide a username and an email, but no name. Therefore
a signup fails because the name is empty. Best guess for the name is
probably the username, therefore use it as name.
parent 03604b39
......@@ -17,6 +17,7 @@ v 8.4.0 (unreleased)
- Expire view caches when application settings change (e.g. Gravatar disabled) (Stan Hu)
- Don't notify users twice if they are both project watchers and subscribers (Stan Hu)
- Remove gray background from layout in UI
- Fix signup for OAuth providers that don't provide a name
- Implement new UI for group page
- Implement search inside emoji picker
- Add API support for looking up a user by username (Stan Hu)
......@@ -141,9 +141,12 @@ def user_attributes
username = auth_hash.username
email =
name =
name = ::Namespace.clean_path(username) if name.strip.empty?
name: name,
username: ::Namespace.clean_path(username),
email: email,
password: auth_hash.password,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment