Skip to content
Snippets Groups Projects
Commit d97fa987 authored by Daniel Gerhardt's avatar Daniel Gerhardt
Browse files

Removed obsolete login redirection code

parent a0bcb7da
No related merge requests found
...@@ -245,30 +245,24 @@ public class LoginController extends AbstractController { ...@@ -245,30 +245,24 @@ public class LoginController extends AbstractController {
@ResponseBody @ResponseBody
public final View dialog( public final View dialog(
@RequestParam("type") final String type, @RequestParam("type") final String type,
@RequestParam(value = "referer", required = false) final String forcedReferer, @RequestParam(value = "successurl", defaultValue = "/") String successUrl,
@RequestParam(value = "successurl", required = false) final String successUrl, @RequestParam(value = "failureurl", defaultValue = "/") String failureUrl,
@RequestParam(value = "failureurl", required = false) final String failureUrl,
final HttpServletRequest request, final HttpServletRequest request,
final HttpServletResponse response final HttpServletResponse response
) throws IOException, ServletException { ) throws IOException, ServletException {
View result = null; View result = null;
String referer = request.getHeader("referer"); /* Use URLs from a request parameters for redirection as long as the
if (null != forcedReferer && null != referer && !UrlUtils.isAbsoluteUrl(referer)) { * URL is not absolute (to prevent abuse of the redirection). */
/* Use a url from a request parameter as referer as long as the url is not absolute (to prevent if (UrlUtils.isAbsoluteUrl(successUrl)) {
* abuse of the redirection). */ successUrl = "/";
referer = forcedReferer;
} }
if (null == referer) { if (UrlUtils.isAbsoluteUrl(failureUrl)) {
referer = "/"; failureUrl = "/";
} }
request.getSession().setAttribute("ars-login-success-url", request.getSession().setAttribute("ars-login-success-url", successUrl);
null == successUrl ? referer : successUrl request.getSession().setAttribute("ars-login-failure-url", failureUrl);
);
request.getSession().setAttribute("ars-login-failure-url",
null == failureUrl ? referer : failureUrl
);
if ("cas".equals(type)) { if ("cas".equals(type)) {
casEntryPoint.commence(request, response, null); casEntryPoint.commence(request, response, null);
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment