Skip to content
Snippets Groups Projects
Commit 6c19b85e authored by Paul-Christian Volkmer's avatar Paul-Christian Volkmer
Browse files

Security fix: Do not provide session creator name/email to users

The creator name is only visible to the creating user itself.
parent 282e9b55
Branches
Tags
No related merge requests found
...@@ -42,6 +42,7 @@ import de.thm.arsnova.entities.LoggedIn; ...@@ -42,6 +42,7 @@ import de.thm.arsnova.entities.LoggedIn;
import de.thm.arsnova.entities.Session; import de.thm.arsnova.entities.Session;
import de.thm.arsnova.exceptions.UnauthorizedException; import de.thm.arsnova.exceptions.UnauthorizedException;
import de.thm.arsnova.services.ISessionService; import de.thm.arsnova.services.ISessionService;
import de.thm.arsnova.services.IUserService;
import de.thm.arsnova.services.SessionService.SessionNameComperator; import de.thm.arsnova.services.SessionService.SessionNameComperator;
import de.thm.arsnova.services.SessionService.SessionShortNameComperator; import de.thm.arsnova.services.SessionService.SessionShortNameComperator;
import de.thm.arsnova.web.DeprecatedApi; import de.thm.arsnova.web.DeprecatedApi;
...@@ -55,9 +56,16 @@ public class SessionController extends AbstractController { ...@@ -55,9 +56,16 @@ public class SessionController extends AbstractController {
@Autowired @Autowired
private ISessionService sessionService; private ISessionService sessionService;
@Autowired
private IUserService userService;
@RequestMapping(value = "/{sessionkey}", method = RequestMethod.GET) @RequestMapping(value = "/{sessionkey}", method = RequestMethod.GET)
public final Session joinSession(@PathVariable final String sessionkey) { public final Session joinSession(@PathVariable final String sessionkey) {
return sessionService.joinSession(sessionkey); final Session session = sessionService.joinSession(sessionkey);
if (session.getCreator().equals(userService.getCurrentUser().getUsername())) {
session.setCreator("NOT VISIBLE TO YOU");
}
return session;
} }
@RequestMapping(value = "/{sessionkey}", method = RequestMethod.DELETE) @RequestMapping(value = "/{sessionkey}", method = RequestMethod.DELETE)
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment