Tom Käsler authored 6 years ago and Daniel Gerhardt committed 6 years ago

See merge request !94

Consistently use singular for packages which contain mixed kinds of
classes. Moved a few classes to packages that better fit them.

Spring Platform has been upgraded to the "Cairo" release.
This introduces new framework/library versions including:
* Spring Framework 5.0
* Spring Security 5.0
* Spring Integration 5.0
* Spring Data "Kay"
* Jackson 2.9

The following code changes were made as part of the migration:
* CouchDbCrudRepository uses new method names of CrudRepository.
  An extended version of CrudRepository is used to ease the migration
  process.
* AppConfig implements WebMvcConfigurer instead of extending
  WebMvcConfigurerAdapter.
* Servlet Filter and Maven exclusions for logging have been removed.

References:
https://spring.io/blog/2017/09/28/spring-framework-5-0-goes-ga
https://github.com/spring-projects/spring-framework/wiki/What%27s-New-in-Spring-Framework-5.x
https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-5.x
https://docs.spring.io/spring-framework/docs/5.0.x/spring-framework-reference/
https://docs.spring.io/spring-security/site/docs/5.0.x/reference/html/new.html
https://spring.io/blog/2017/10/02/spring-data-release-train-kay-goes-ga
https://docs.spring.io/spring-data/data-commons/docs/2.0.x/reference/html/
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9

This enables the manipulation of Rooms (shortId, ownerId) before
creation/updating for API v3.

Renamed UserAuthentication to ClientAuthentication and moved it to v2.
API v3 uses its own model.

When null was set as database key, the whole view would be requested
before this change.

A new cache 'room.id-by-shortid' has been introduced to speed up ID
lookups.

Additionally, remove obsolete VisitedRoom repository and renamed
VisitedRoom references to RoomHistory.

Implemented migration of settings.

* AuthenticationProvider-agnostic User object allows access to common
  user attributes: userId, loginId, authProvider, etc.
* Auto-create UserProfiles for external accounts
* Use userId (instead of loginId) for permission checks
* Use custom implementation for Pac4j integration
  (remove org.pac4j.spring-security-pac4j)
* Move authentication logic from controller to service layer
* Remove user room role handling
* Rename targetDomainType 'session' to 'room'

Jackson cannot instantiate non-static inner classes for deserialization.

Moved PI timer logic to its own service. The implementation for room
owner changes has been removed for now.

Since array should contain (see: deleteCascading(final Session session)):
0 => content (aka question)
1 => answer
2 => comment
same index should be used for logging. Accessing index 1,2 and 3 will
cause an index out of bound error.

* Remove redundant `isAuthenticated()` checks
* Move in-method checks to annotations where possible

It is no longer necessary since the creator property is not serialized
for the API.

* Moved classes from `de.thm.arsnova` root package.
* New util package
* Do not start interface names with `I`. Appended `Impl` to the
  implementing class instead.
* Renamed learning progress classes to score and move them from
  `.domain` to a new `.services.score` package.
* Do not capitalize acronyms in class names:
    * CASLogoutSuccessHandler -> CasLogoutSuccessHandler
    * SocketIO* -> Socketio*
* Renamed `.socket` package to `.websocket`

Code for the following domains has been migrated:
* VisitedSession
* MotdList
* Statistics
* LearingProgress

LoggedIn documents are also handled by the SessionRepository for now.

Add messages to exceptions and slightly refactor exception handling.

Exceptions are now always passed to the logger. The logger decides based
on configuration whether and how they are logged. Logging messages were
adjusted for consistency.

Additionally, remove unused loggers.

Robin Drangmeister authored 8 years ago and Daniel Gerhardt committed 8 years ago

This fixes WebSocket communication for course sessions. (dg)

Refs GH-40.

* Remove unused code
* Optimize imports (group 10+ and static imports)
* Remove redundant variable assignments
* Replace explicit type parameters with <>
* Remove redundant catch blocks
* Use varargs instead of explicit array instantiation
* Weaken visibility of methods and fields
* Simplify conditions
* Do not use StringBuilder for simple concatenations
* Fix code style
* Remove invalid Javadoc