Update Random Algorithm according to the results of test-list
About:
- open new MR to keep separation
- theses changes try to update the random algorithm based on the testing from: !38 (closed)
- The "logic" got updated and the group creation now also works if the admin doesn't get added to the groups
- adds additional checker for edge-cases (prohibit creation of more than 10 groups, or groups that should consist of only one person)
- adds checker to determine if 1 person would be put in group on it's own (e.g when 7 Person are in waitingroom and groups should be build for 2 person each, the 7th person was left alone.
In this case the 'left over' will now be added to last group (regardless if max. size of group is reached).
Known flaws (in short):
-
Redirection from user that are connected to waitingroom via websocket is not working. I logged in as the admin/initiator and did the wohl process using our UI.
Then I opened incognito tabs and other browsers to simulate people joining the waiting room (which works).
When "Gruppen erstellen" is clicked, the groups are correctly build & stored in the database - but the user connected via websockets are not transfered to their dashboard. -
If admin doesn't want to be in a group, he is still redirected to groupDashboard which can't be accessed by him (due to not being a group member).
This should be fixed with adding a separate redirection for this case. Also if "mich hinzufügen" from the groupSettings was not checked, I think the admin should be removed from the user array.
Consideration:
- refactoring the waitingroom.component.ts and make the code more readable and reusable and also easier to understand.