Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
arsnova-lite
Manage
Activity
Members
Labels
Plan
Issues
24
Issue boards
Milestones
Wiki
Code
Merge requests
2
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Privacy
Imprint
Contact
Snippets
Groups
Projects
Show more breadcrumbs
ARSnova
arsnova-lite
Commits
5222684a
Commit
5222684a
authored
5 years ago
by
Tom Käsler
Browse files
Options
Downloads
Patches
Plain Diff
Add nullchecks for empty comments
parent
8d558244
Branches
patch-2
Branches containing commit
Tags
Tags containing commit
1 merge request
!208
Fix long loading
Pipeline
#27016
passed with stages
Stage:
Stage:
Stage:
Stage:
in 6 minutes and 20 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/app/components/shared/comment-list/comment-list.component.html
+3
-3
3 additions, 3 deletions
...omponents/shared/comment-list/comment-list.component.html
with
3 additions
and
3 deletions
src/app/components/shared/comment-list/comment-list.component.html
+
3
−
3
View file @
5222684a
...
@@ -12,12 +12,12 @@
...
@@ -12,12 +12,12 @@
<span
class=
"fill-remaining-space"
></span>
<span
class=
"fill-remaining-space"
></span>
<div
class=
"button-bar"
fxLayoutAlign=
"center center"
>
<div
class=
"button-bar"
fxLayoutAlign=
"center center"
>
<button
mat-icon-button
class=
"searchBarButton"
*ngIf=
"!searchBox.value && comments.length > 0"
<button
mat-icon-button
class=
"searchBarButton"
*ngIf=
"!searchBox.value &&
comments &&
comments.length > 0"
[matMenuTriggerFor]=
"filterMenu"
matTooltip=
"{{ 'comment-list.filter-comments' | translate }}"
>
[matMenuTriggerFor]=
"filterMenu"
matTooltip=
"{{ 'comment-list.filter-comments' | translate }}"
>
<mat-icon
class=
"searchBarIcon"
>
filter_list
</mat-icon>
<mat-icon
class=
"searchBarIcon"
>
filter_list
</mat-icon>
</button>
</button>
<button
mat-icon-button
class=
"searchBarButton"
*ngIf=
"!searchBox.value && comments.length > 0"
<button
mat-icon-button
class=
"searchBarButton"
*ngIf=
"!searchBox.value &&
comments &&
comments.length > 0"
[matMenuTriggerFor]=
"sortMenu"
matTooltip=
"{{ 'comment-list.sort-comments' | translate }}"
>
[matMenuTriggerFor]=
"sortMenu"
matTooltip=
"{{ 'comment-list.sort-comments' | translate }}"
>
<mat-icon
class=
"searchBarIcon"
>
sort
</mat-icon>
<mat-icon
class=
"searchBarIcon"
>
sort
</mat-icon>
</button>
</button>
...
@@ -71,6 +71,6 @@
...
@@ -71,6 +71,6 @@
<app-comment
*ngFor=
"let current of hideCommentsList ? filteredComments : comments"
[comment]=
"current"
[parseVote]=
"getVote(current)"
></app-comment>
<app-comment
*ngFor=
"let current of hideCommentsList ? filteredComments : comments"
[comment]=
"current"
[parseVote]=
"getVote(current)"
></app-comment>
</div>
</div>
<div
*ngIf=
"comments.length < 1"
fxLayout=
"row"
fxLayoutAlign=
"center center"
class=
"no-comments"
>
<div
*ngIf=
"comments
&& comments
.length < 1"
fxLayout=
"row"
fxLayoutAlign=
"center center"
class=
"no-comments"
>
<h4>
{{ 'comment-page.no-comments' | translate }}
</h4>
<h4>
{{ 'comment-page.no-comments' | translate }}
</h4>
</div>
</div>
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment