* Removed obsolete commented-out code.
* Fixed indentation of commented out code.
* Added FIXME comments where old code still has to be migrated.

Rules:
* (naming) ParameterName
* (naming) LocalVariableName
* (naming) MemberName
* (naming) InterfaceTypeParameterName
* (naming) AbbreviationAsWordInName
* (modifier) ModifierOrder
* (blocks) NeedBraces
* (coding) OneStatementPerLine
* (coding) MultipleVariableDeclarations
* (coding) VariableDeclarationUsageDistance
* (coding) MissingSwitchDefault
* (coding) OverloadMethodsDeclarationOrder
* (extension) RightCurlySame
* (misc) ArrayTypeStyle

The following conventions have been applied:
* Rule: (sizes) LineLength

The following conventions have been applied:
* Fix indentation levels
  Rules: (indentation) Indentation, (regexp) RegexpSinglelineJava
* Always use operators at the beginning of a new line if there is a line
  break.
  Rule: (whitespace) OperatorWrap
* Always use empty lines between method declarations.
  Rule: (whitespace) EmptyLineSeparator
* Always use new line between annotation and field/method declaration.
  Rule: (extension) AnnotationLocationMostCases
* Additional rules:
    * (whitespace) ParenPad
    * (whitespace) GenericWhitespace
    * (blocks) LeftCurly
    * (extension) RightCurlyAlone

The following conventions have been applied:
* Import order: static packages -> other packages -> ARSnova packages
  Rule: (imports) CustomImportOrder
* New line between import package groups
  Rule: (imports) CustomImportOrder
* All packages are imported explicitly (no wildcard imports)
  Rule: (imports) AvoidStarImport
* New line between license comment and package line
  Rule: (whitespace) EmptyLineSeparator

The updated Maven plugin fixes compatibilty with Checkstyle >= 8.2.
Checkstyle >= 8.11 is needed for support of the `LambdaParameterName`
rule used by Google style checks.

Updated Checkstyle to version 8.14 to support all rules.

Add placeholder in reset mail for reset key

See merge request !135

Room moderators

See merge request !131

Daniel Gerhardt authored 5 years ago and Daniel Gerhardt committed 5 years ago

This also fixes the read permission room owners. They now have read
access to closed rooms.

Daniel Gerhardt authored 5 years ago and Daniel Gerhardt committed 5 years ago

The `/room/find` endpoint has been extended to support querying rooms by
moderator user ID. It can be used in combination with the `ownerId`
property.

Daniel Gerhardt authored 5 years ago and Daniel Gerhardt committed 5 years ago

Moderators can assist a room owner in managing the room. This commit
adds API and persistence support for moderators.

Add placeholder in activation mail for activation key

See merge request !133

An error was logged before destroying UserServiceImpl class without any
reason.

An error was logged before destroying UserService class without any
reason.

Allow limited access to UserProfiles for authenticated users

See merge request !130

Daniel Gerhardt authored 5 years ago and Daniel Gerhardt committed 5 years ago

Authenticated users can read `loginId` and `authProvider` properties.
A FindQueryService has been added to lookup UserProfiles by `loginId`.

Resolve "Tests should not use env specific arsnova.properties"

Closes #41

See merge request !132

Add tests for JsonViewControllerAdvice

See merge request !129

Christoph Thelen authored 5 years ago and Daniel Gerhardt committed 5 years ago

Two key changes:

  1. Add a factory method to create the EntityService with the
     DummyEntity, so that all other test cases can initialize
     this Bean.  This solves the IllegalStateException reported
     in this ticket.
  2. Use @Autowire instead of @MockBean to use the new factory
     method.  That resolves the known issue that the caching test
     case does not work because of different RoomRepositories being
     created for the PermissionEvaluatorAdvice and the EntityService.

This makes all tests runnable again.  My current theory is that due to
the fact that we have at least two EntityServices (one created by
the DefaultEntityServiceImplTest, and now one by this test).  The
@MockBean annotation could be throwing out the previous EntityService,
since according to documentation, it replaces existing Beans with the
same type.  This could lead to a situation where, initially, the
PermissionEvaluatorAdvice and the DefaultEntityService share the same
RoomRepository.  But after the @MockBean replacement occurs, the
EntityService is recreated with a different RoomRepository, while the
Advice keeps its initial RoomRepository, leading to testing failures
in the testCaching test case.

Christoph Thelen authored 5 years ago and Daniel Gerhardt committed 5 years ago

This solves the IllegalStateExceptions occurring for most of the other
test cases.

However, we now have the old problem that different Repositories are
injected into objects. In my case, the testCaching case of the
DefaultEntityServiceImplTest stops working, because it gets a different
RoomRepository than the ApplicationPermissionEvaluator.

This behavior is caused by the introduction of the additional profile.

Daniel Gerhardt authored 5 years ago and Daniel Gerhardt committed 5 years ago

See commit f620b9e7.

Add nullpointer check for passwordResetTime

Closes #40

See merge request !127

Add a 'view' parameter for all entity endpoints

See merge request !128

A JsonView for serialization is applied based on the 'view' query
parameter.

The following values are currently supported:
* admin (View.Admin.class)
* owner (View.Owner.class)
* <unset> (Public.Admin.class)

Return 403 Forbidden on duplicated username when registering

Closes #38

See merge request !126

The RegEx unintentionally required a minimum length of 2 for IDs.