GitLab

git-svn-id: https://svn.redmine.org/redmine/trunk@17083 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17082 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17081 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17080 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@17078 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81

* remove extra empty lines
* remove trailing white space
* replace tab to two spaces

git-svn-id: https://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17064 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17063 e93f8b46-1217-0410-a6f0-8f06a7374b81

Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: https://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81

We don't have much problems here thanks to hgtarget(path) and CGI.escape(),
which prepends a repository path and encodes "=" character respectively, but
it's better to not rely on the side effect of these functions.

Contributed by Yuya Nishihara.

git-svn-id: https://svn.redmine.org/redmine/trunk@17061 e93f8b46-1217-0410-a6f0-8f06a7374b81

We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: https://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Holger Just and Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Gregor Schmidt.


git-svn-id: https://svn.redmine.org/redmine/trunk@17056 e93f8b46-1217-0410-a6f0-8f06a7374b81

The change breaks test/functional/issue_relations_controller_test.rb.



git-svn-id: https://svn.redmine.org/redmine/trunk@17055 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Gregor Schmidt.


git-svn-id: https://svn.redmine.org/redmine/trunk@17054 e93f8b46-1217-0410-a6f0-8f06a7374b81

Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: https://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Gregor Schmidt.

git-svn-id: https://svn.redmine.org/redmine/trunk@17052 e93f8b46-1217-0410-a6f0-8f06a7374b81

Previously not all data on the roadmap and version view where properly
checked against the issue visibility setting. Unprivileged users were
able to see the total number of issues, their estimations and the
open/close status - even if the user was only allowed to see their own issues.

Patch by Gregor Schmidt.

git-svn-id: https://svn.redmine.org/redmine/trunk@17051 e93f8b46-1217-0410-a6f0-8f06a7374b81

This way, we can reuse them on refined relations,
e.g. @version.fixed_issues.closed_count@ vs. @version.fixed_issues.visible.closed_count@

Patch by Gregor Schmidt.

git-svn-id: https://svn.redmine.org/redmine/trunk@17050 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Kosta Harlan and Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17049 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17048 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Javier Menéndez Riz.


git-svn-id: https://svn.redmine.org/redmine/trunk@17045 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Javier Menéndez Riz.


git-svn-id: https://svn.redmine.org/redmine/trunk@17042 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Bernhard Rohloff.


git-svn-id: https://svn.redmine.org/redmine/trunk@17039 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@17038 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@17037 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by jwjw yy.


git-svn-id: https://svn.redmine.org/redmine/trunk@17036 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by okkez.


git-svn-id: https://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81

Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@17032 e93f8b46-1217-0410-a6f0-8f06a7374b81

Contributed by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17031 e93f8b46-1217-0410-a6f0-8f06a7374b81

Contributed by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17030 e93f8b46-1217-0410-a6f0-8f06a7374b81

Contributed by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17027 e93f8b46-1217-0410-a6f0-8f06a7374b81

Contributed by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17026 e93f8b46-1217-0410-a6f0-8f06a7374b81

Contributed by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@17023 e93f8b46-1217-0410-a6f0-8f06a7374b81

Gemfile: pin mail gem version to prevent failure of MailHandlerTest#test_add_issue_with_localized_attributes

git-svn-id: https://svn.redmine.org/redmine/trunk@17019 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17018 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17017 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17004 e93f8b46-1217-0410-a6f0-8f06a7374b81

git-svn-id: https://svn.redmine.org/redmine/trunk@17003 e93f8b46-1217-0410-a6f0-8f06a7374b81