Commit ff422575 authored by jplang's avatar jplang

Converts UI tests to system tests (#23630).

git-svn-id: https://svn.redmine.org/redmine/trunk@16864 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent 9ba82064
...@@ -86,9 +86,10 @@ group :test do ...@@ -86,9 +86,10 @@ group :test do
gem "rails-dom-testing" gem "rails-dom-testing"
gem "mocha" gem "mocha"
gem "simplecov", "~> 0.14.1", :require => false gem "simplecov", "~> 0.14.1", :require => false
# For running UI tests # For running system tests
gem "capybara" gem 'puma', '~> 3.7'
gem "selenium-webdriver", "~> 2.53.4" gem "capybara", '~> 2.13'
gem "selenium-webdriver"
end end
local_gemfile = File.join(File.dirname(__FILE__), "Gemfile.local") local_gemfile = File.join(File.dirname(__FILE__), "Gemfile.local")
......
...@@ -70,4 +70,4 @@ You need to have ChromeDriver installed and available in your PATH: ...@@ -70,4 +70,4 @@ You need to have ChromeDriver installed and available in your PATH:
https://sites.google.com/a/chromium.org/chromedriver/ https://sites.google.com/a/chromium.org/chromedriver/
Capybara tests can be run with: Capybara tests can be run with:
`rake test:ui` `rails test:system`
...@@ -15,95 +15,64 @@ ...@@ -15,95 +15,64 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../test_helper', __FILE__) require File.expand_path('../test_helper', __FILE__)
require 'capybara/rails'
require 'fileutils'
require 'timeout'
module Redmine class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
module UiTest DOWNLOADS_PATH = File.expand_path(File.join(Rails.root, 'tmp', 'downloads'))
module Downloads
DOWNLOADS_PATH = File.expand_path(File.join(Rails.root, 'tmp', 'downloads'))
def clear_downloaded_files driven_by :selenium, using: :chrome, screen_size: [1024, 900], options: {
FileUtils.rm downloaded_files desired_capabilities: Selenium::WebDriver::Remote::Capabilities.chrome(
end
def downloaded_files
Dir.glob("#{DOWNLOADS_PATH}/*").reject {|f| f=~/crdownload$/}
end
def downloaded_file
Timeout.timeout(5) do
while downloaded_files.empty?
sleep 0.2
end
end
downloaded_files.first
end
end
end
end
FileUtils.mkdir_p Redmine::UiTest::Downloads::DOWNLOADS_PATH
Capybara.register_driver :chrome do |app|
Capybara::Selenium::Driver.new(app,
:browser => :chrome,
:desired_capabilities => Selenium::WebDriver::Remote::Capabilities.chrome(
'chromeOptions' => { 'chromeOptions' => {
'args' => [ "--window-size=1024,900" ],
'prefs' => { 'prefs' => {
'download.default_directory' => Redmine::UiTest::Downloads::DOWNLOADS_PATH, 'download.default_directory' => DOWNLOADS_PATH,
'download.prompt_for_download' => false, 'download.prompt_for_download' => false,
'plugins.plugins_disabled' => ["Chrome PDF Viewer"] 'plugins.plugins_disabled' => ["Chrome PDF Viewer"]
} }
} }
) )
) }
end
Capybara.default_driver = :chrome
# default: 2 setup do
Capybara.default_wait_time = 2 clear_downloaded_files
Setting.delete_all
Setting.clear_cache
end
module Redmine teardown do
module UiTest Setting.delete_all
# Base class for UI tests Setting.clear_cache
class Base < ActionDispatch::IntegrationTest end
include Capybara::DSL
include Redmine::UiTest::Downloads
# Stop ActiveRecord from wrapping tests in transactions # Should not depend on locale since Redmine displays login page
# Transactional fixtures do not work with Selenium tests, because Capybara # using default browser locale which depend on system locale for "real" browsers drivers
# uses a separate server thread, which the transactions would be hidden def log_user(login, password)
self.use_transactional_tests = false visit '/my/page'
assert_equal '/login', current_path
within('#login-form form') do
fill_in 'username', :with => login
fill_in 'password', :with => password
find('input[name=login]').click
end
assert_equal '/my/page', current_path
end
# Should not depend on locale since Redmine displays login page def clear_downloaded_files
# using default browser locale which depend on system locale for "real" browsers drivers FileUtils.rm downloaded_files
def log_user(login, password) end
visit '/my/page'
assert_equal '/login', current_path
within('#login-form form') do
fill_in 'username', :with => login
fill_in 'password', :with => password
find('input[name=login]').click
end
assert_equal '/my/page', current_path
end
setup do def downloaded_files
clear_downloaded_files Dir.glob("#{DOWNLOADS_PATH}/*").reject {|f| f=~/crdownload$/}
Setting.delete_all end
Setting.clear_cache
end
teardown do # Returns the path of the download file
Capybara.reset_sessions! # Forget the (simulated) browser state def downloaded_file
Capybara.use_default_driver # Revert Capybara.current_driver to Capybara.default_driver Timeout.timeout(5) do
Setting.delete_all while downloaded_files.empty?
Setting.clear_cache sleep 0.2
end end
end end
downloaded_files.first
end end
end end
FileUtils.mkdir_p ApplicationSystemTestCase::DOWNLOADS_PATH
...@@ -15,9 +15,9 @@ ...@@ -15,9 +15,9 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../base', __FILE__) require File.expand_path('../../application_system_test_case', __FILE__)
class Redmine::UiTest::IssuesTest < Redmine::UiTest::Base class IssuesTest < ApplicationSystemTestCase
fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles, fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
:trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues, :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
:enumerations, :custom_fields, :custom_values, :custom_fields_trackers, :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
......
...@@ -15,9 +15,9 @@ ...@@ -15,9 +15,9 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../base', __FILE__) require File.expand_path('../../application_system_test_case', __FILE__)
class Redmine::UiTest::MyPageTest < Redmine::UiTest::Base class MyPageTest < ApplicationSystemTestCase
fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles, fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
:trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues, :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
:enumerations, :custom_fields, :custom_values, :custom_fields_trackers, :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
......
...@@ -17,9 +17,9 @@ ...@@ -17,9 +17,9 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../base', __FILE__) require File.expand_path('../../application_system_test_case', __FILE__)
class Redmine::UiTest::QuickJumpTest < Redmine::UiTest::Base class QuickJumpTest < ApplicationSystemTestCase
fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles, fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
:trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues, :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
:enumerations, :custom_fields, :custom_values, :custom_fields_trackers, :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
......
...@@ -15,9 +15,9 @@ ...@@ -15,9 +15,9 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../base', __FILE__) require File.expand_path('../../application_system_test_case', __FILE__)
class Redmine::UiTest::SudoModeTest < Redmine::UiTest::Base class SudoModeTest < ApplicationSystemTestCase
fixtures :users, :email_addresses fixtures :users, :email_addresses
def setup def setup
......
...@@ -17,9 +17,11 @@ ...@@ -17,9 +17,11 @@
# along with this program; if not, write to the Free Software # along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../base', __FILE__) require File.expand_path('../../application_system_test_case', __FILE__)
class Redmine::UiTest::TimelogTest < Redmine::UiTest::Base Capybara.default_max_wait_time = 2
class TimelogTest < ApplicationSystemTestCase
fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles, fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
:trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues, :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
:enumerations, :custom_fields, :custom_values, :custom_fields_trackers, :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
...@@ -85,10 +87,10 @@ class Redmine::UiTest::TimelogTest < Redmine::UiTest::Base ...@@ -85,10 +87,10 @@ class Redmine::UiTest::TimelogTest < Redmine::UiTest::Base
visit '/settings?tab=timelog' visit '/settings?tab=timelog'
# Remove a column # Remove a column
select 'Comment', :from => 'Selected Columns' select 'Comment', :from => 'Selected Columns'
click_on "←" click_on ""
# Add a column # Add a column
select 'Tracker', :from => 'Available Columns' select 'Tracker', :from => 'Available Columns'
click_on "→" click_on ""
click_on 'Save' click_on 'Save'
# Display the list with updated settings # Display the list with updated settings
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment