Commit fa415d15 authored by tmaruyama's avatar tmaruyama

scm: fix diff revision param validation.

git-svn-id: https://svn.redmine.org/redmine/trunk@4860 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent 74c1015a
......@@ -218,7 +218,7 @@ class RepositoriesController < ApplicationController
@rev = params[:rev].blank? ? @repository.default_branch : params[:rev].strip
@rev_to = params[:rev_to]
unless @rev.to_s.match(REV_PARAM_RE) && @rev.to_s.match(REV_PARAM_RE)
unless @rev.to_s.match(REV_PARAM_RE) && @rev_to.to_s.match(REV_PARAM_RE)
if @repository.branches.blank?
raise InvalidRevisionParam
end
......
......@@ -172,6 +172,12 @@ class RepositoriesSubversionControllerTest < ActionController::TestCase
assert_error_tag :content => /was not found/
end
def test_invalid_revision_diff
get :diff, :id => 1, :rev => '1', :rev_to => 'something_weird'
assert_response 404
assert_error_tag :content => /was not found/
end
def test_empty_revision
['', ' ', nil].each do |r|
get :revision, :id => 1, :rev => r
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment