Commit c8b65bdb authored by jplang's avatar jplang

Restore rev param validation that was removed in r2840.

git-svn-id: https://svn.redmine.org/redmine/trunk@4542 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent f1b7c924
......@@ -196,7 +196,10 @@ class RepositoriesController < ApplicationController
end
end
private
private
REV_PARAM_RE = %r{^[a-f0-9]*$}i
def find_repository
@project = Project.find(params[:id])
@repository = @project.repository
......@@ -205,6 +208,12 @@ private
@path ||= ''
@rev = params[:rev].blank? ? @repository.default_branch : params[:rev].strip
@rev_to = params[:rev_to]
unless @rev.to_s.match(REV_PARAM_RE) && @rev.to_s.match(REV_PARAM_RE)
if @repository.branches.blank?
raise InvalidRevisionParam
end
end
rescue ActiveRecord::RecordNotFound
render_404
rescue InvalidRevisionParam
......
......@@ -166,6 +166,12 @@ class RepositoriesSubversionControllerTest < ActionController::TestCase
}
end
def test_invalid_revision
get :revision, :id => 1, :rev => 'something_weird'
assert_response 500
assert_error_tag :content => /was not found/
end
def test_revision_with_repository_pointing_to_a_subdirectory
r = Project.find(1).repository
# Changes repository url to a subdirectory
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment