Commit c875e52e authored by jplang's avatar jplang
Browse files

Introduce virtual MenuNodes (#15880).

They are characterized by having a blank url. they will only be rendered if the user is authorized to see at least one of its children. they render as links which do nothing when clicked.
Patch by Jan Schulz-Hofen.

git-svn-id: e93f8b46-1217-0410-a6f0-8f06a7374b81
parent ae6b1aea
......@@ -147,7 +147,15 @@ module Redmine
def render_single_menu_node(item, caption, url, selected)
link_to(h(caption), url, item.html_options(:selected => selected))
options = item.html_options(:selected => selected)
# virtual nodes are only there for their children to be displayed in the menu
# and should not do anything on click, except if otherwise defined elsewhere
if url.blank?
url = '#'
options.reverse_merge!(:onclick => 'return false;')
link_to(h(caption), url, options)
def render_unattached_menu_item(menu_item, project)
......@@ -433,7 +441,14 @@ module Redmine
# * Checking the permission or the url target (project only)
# * Checking the conditions of the item
def allowed?(user, project)
if user && project
if url.blank?
# this is a virtual node that is only there for its children to be diplayed in the menu
# it is considered an allowed node if at least one of the children is allowed
all_children = children
all_children += if child_menus
return true if all_children.detect{|child| child.allowed?(user, project) }
return false
elsif user && project
if permission
unless user.allowed_to?(permission, project)
return false
......@@ -208,6 +208,41 @@ class Redmine::MenuManager::MenuHelperTest < ActionView::TestCase
def test_render_empty_virtual_menu_node_with_children
# only empty item with no click target :menu1 do |menu|
menu.push(:parent_node, nil, { })
# parent with unallowed unattached child :menu2 do |menu|
menu.push(:parent_node, nil, {:children => {|p|
["test_child_unallowed", {:controller => 'issues', :action => 'new'}, {})]
} })
# parent with unallowed standard child :menu3 do |menu|
menu.push(:parent_node, nil, {})
menu.push(:test_child_unallowed, {:controller =>'issues', :action => 'new'}, {:parent => :parent_node})
# should not be displayed to anonymous
User.current = User.find(6)
assert_nil render_menu(:menu1, Project.find(1))
assert_nil render_menu(:menu2, Project.find(1))
assert_nil render_menu(:menu3, Project.find(1))
# should be displayed to an admin
User.current = User.find(1)
@output_buffer = render_menu(:menu2, Project.find(1))
assert_select("ul li a.parent-node", "Parent node")
@output_buffer = render_menu(:menu3, Project.find(1))
assert_select("ul li a.parent-node", "Parent node")
def test_render_menu_node_with_children_without_an_array
parent_node =,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment