Commit 730eabc7 authored by tmaruyama's avatar tmaruyama

not use assert_not_nil in Errors#[]

r7593 etc. replaced Rails2 Errors#on.
Rails3 Errors#[] always return array.
So, Rails3 Errors#[] is always not nil.

git-svn-id: https://svn.redmine.org/redmine/trunk@12070 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent 7864050b
...@@ -209,7 +209,7 @@ class ProjectsControllerTest < ActionController::TestCase ...@@ -209,7 +209,7 @@ class ProjectsControllerTest < ActionController::TestCase
assert_response :success assert_response :success
project = assigns(:project) project = assigns(:project)
assert_kind_of Project, project assert_kind_of Project, project
assert_not_nil project.errors[:parent_id] assert_not_equal [], project.errors[:parent_id]
end end
test "#create by non-admin user with add_subprojects permission should create a project with a parent_id" do test "#create by non-admin user with add_subprojects permission should create a project with a parent_id" do
...@@ -244,7 +244,7 @@ class ProjectsControllerTest < ActionController::TestCase ...@@ -244,7 +244,7 @@ class ProjectsControllerTest < ActionController::TestCase
assert_response :success assert_response :success
project = assigns(:project) project = assigns(:project)
assert_kind_of Project, project assert_kind_of Project, project
assert_not_nil project.errors[:parent_id] assert_not_equal [], project.errors[:parent_id]
end end
test "#create by non-admin user with add_subprojects permission should fail with unauthorized parent_id" do test "#create by non-admin user with add_subprojects permission should fail with unauthorized parent_id" do
...@@ -265,7 +265,7 @@ class ProjectsControllerTest < ActionController::TestCase ...@@ -265,7 +265,7 @@ class ProjectsControllerTest < ActionController::TestCase
assert_response :success assert_response :success
project = assigns(:project) project = assigns(:project)
assert_kind_of Project, project assert_kind_of Project, project
assert_not_nil project.errors[:parent_id] assert_not_equal [], project.errors[:parent_id]
end end
def test_create_subproject_with_inherit_members_should_inherit_members def test_create_subproject_with_inherit_members_should_inherit_members
......
...@@ -93,7 +93,7 @@ class AttachmentTest < ActiveSupport::TestCase ...@@ -93,7 +93,7 @@ class AttachmentTest < ActiveSupport::TestCase
def test_description_length_should_be_validated def test_description_length_should_be_validated
a = Attachment.new(:description => 'a' * 300) a = Attachment.new(:description => 'a' * 300)
assert !a.save assert !a.save
assert_not_nil a.errors[:description] assert_not_equal [], a.errors[:description]
end end
def test_destroy def test_destroy
......
...@@ -57,7 +57,7 @@ class IssueNestedSetTest < ActiveSupport::TestCase ...@@ -57,7 +57,7 @@ class IssueNestedSetTest < ActiveSupport::TestCase
child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
:subject => 'child', :parent_issue_id => issue.id) :subject => 'child', :parent_issue_id => issue.id)
assert !child.save assert !child.save
assert_not_nil child.errors[:parent_issue_id] assert_not_equal [], child.errors[:parent_issue_id]
end end
def test_move_a_root_to_child def test_move_a_root_to_child
...@@ -163,7 +163,7 @@ class IssueNestedSetTest < ActiveSupport::TestCase ...@@ -163,7 +163,7 @@ class IssueNestedSetTest < ActiveSupport::TestCase
child.reload child.reload
child.parent_issue_id = grandchild.id child.parent_issue_id = grandchild.id
assert !child.save assert !child.save
assert_not_nil child.errors[:parent_issue_id] assert_not_equal [], child.errors[:parent_issue_id]
end end
def test_destroy_should_destroy_children def test_destroy_should_destroy_children
......
...@@ -115,7 +115,7 @@ class IssueRelationTest < ActiveSupport::TestCase ...@@ -115,7 +115,7 @@ class IssueRelationTest < ActiveSupport::TestCase
:relation_type => IssueRelation::TYPE_PRECEDES :relation_type => IssueRelation::TYPE_PRECEDES
) )
assert !r.save assert !r.save
assert_not_nil r.errors[:base] assert_not_equal [], r.errors[:base]
end end
def test_validates_circular_dependency_of_subtask def test_validates_circular_dependency_of_subtask
...@@ -166,7 +166,7 @@ class IssueRelationTest < ActiveSupport::TestCase ...@@ -166,7 +166,7 @@ class IssueRelationTest < ActiveSupport::TestCase
:relation_type => IssueRelation::TYPE_BLOCKED :relation_type => IssueRelation::TYPE_BLOCKED
) )
assert !r.save assert !r.save
assert_not_nil r.errors[:base] assert_not_equal [], r.errors[:base]
end end
def test_create_should_make_journal_entry def test_create_should_make_journal_entry
......
...@@ -490,7 +490,7 @@ class IssueTest < ActiveSupport::TestCase ...@@ -490,7 +490,7 @@ class IssueTest < ActiveSupport::TestCase
issue.tracker_id = 2 issue.tracker_id = 2
issue.subject = 'New subject' issue.subject = 'New subject'
assert !issue.save assert !issue.save
assert_not_nil issue.errors[:tracker_id] assert_not_equal [], issue.errors[:tracker_id]
end end
def test_category_based_assignment def test_category_based_assignment
...@@ -1045,7 +1045,7 @@ class IssueTest < ActiveSupport::TestCase ...@@ -1045,7 +1045,7 @@ class IssueTest < ActiveSupport::TestCase
:status_id => 1, :fixed_version_id => 1, :status_id => 1, :fixed_version_id => 1,
:subject => 'New issue') :subject => 'New issue')
assert !issue.save assert !issue.save
assert_not_nil issue.errors[:fixed_version_id] assert_not_equal [], issue.errors[:fixed_version_id]
end end
def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
...@@ -1053,7 +1053,7 @@ class IssueTest < ActiveSupport::TestCase ...@@ -1053,7 +1053,7 @@ class IssueTest < ActiveSupport::TestCase
:status_id => 1, :fixed_version_id => 2, :status_id => 1, :fixed_version_id => 2,
:subject => 'New issue') :subject => 'New issue')
assert !issue.save assert !issue.save
assert_not_nil issue.errors[:fixed_version_id] assert_not_equal [], issue.errors[:fixed_version_id]
end end
def test_should_be_able_to_assign_a_new_issue_to_an_open_version def test_should_be_able_to_assign_a_new_issue_to_an_open_version
...@@ -1074,7 +1074,7 @@ class IssueTest < ActiveSupport::TestCase ...@@ -1074,7 +1074,7 @@ class IssueTest < ActiveSupport::TestCase
issue = Issue.find(11) issue = Issue.find(11)
issue.status_id = 1 issue.status_id = 1
assert !issue.save assert !issue.save
assert_not_nil issue.errors[:base] assert_not_equal [], issue.errors[:base]
end end
def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
......
...@@ -401,7 +401,7 @@ class UserTest < ActiveSupport::TestCase ...@@ -401,7 +401,7 @@ class UserTest < ActiveSupport::TestCase
u = User.new u = User.new
u.mail_notification = 'foo' u.mail_notification = 'foo'
u.save u.save
assert_not_nil u.errors[:mail_notification] assert_not_equal [], u.errors[:mail_notification]
end end
def test_password def test_password
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment