Commit 41663431 authored by jplang's avatar jplang

Fixed that 2 repositories can be created with blank/nil identifier (#19400).

git-svn-id: https://svn.redmine.org/redmine/trunk@14156 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent 2ee8c0ae
......@@ -30,6 +30,7 @@ class Repository < ActiveRecord::Base
serialize :extra_info
before_validation :normalize_identifier
before_save :check_default
# Raw SQL to delete changesets and changes in the database
......@@ -469,6 +470,10 @@ class Repository < ActiveRecord::Base
end
end
def normalize_identifier
self.identifier = identifier.to_s.strip
end
def check_default
if !is_default? && set_as_default?
self.is_default = true
......
......@@ -94,6 +94,18 @@ class RepositoryTest < ActiveSupport::TestCase
assert !r.save
end
def test_2_repositories_with_blank_identifier_and_one_as_default_should_not_be_valid
Repository::Subversion.create!(:project_id => 3, :identifier => '', :url => 'file:///foo', :is_default => true)
r = Repository::Subversion.new(:project_id => 3, :identifier => '', :url => 'file:///bar')
assert !r.save
end
def test_2_repositories_with_blank_and_nil_identifier_should_not_be_valid
Repository::Subversion.create!(:project_id => 3, :identifier => nil, :url => 'file:///foo')
r = Repository::Subversion.new(:project_id => 3, :identifier => '', :url => 'file:///bar')
assert !r.save
end
def test_first_repository_should_be_set_as_default
repository1 = Repository::Subversion.new(
:project => Project.find(3),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment