GitLab steht Mittwoch, den 23. September, zwischen 10:00 und 12:00 Uhr aufgrund von Wartungsarbeiten nicht zur Verfügung.

Commit 1a2581d3 authored by jplang's avatar jplang

Respond with 404 instead of 500 when revision/entry is not found in the repository (#7307).

git-svn-id: https://svn.redmine.org/redmine/trunk@4710 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent c54632b6
......@@ -226,7 +226,7 @@ class RepositoriesController < ApplicationController
end
def show_error_not_found
render_error l(:error_scm_not_found)
render_error :message => l(:error_scm_not_found), :status => 404
end
# Handler for Redmine::Scm::Adapters::CommandFailed exception
......
......@@ -192,7 +192,7 @@ class RepositoriesGitControllerTest < ActionController::TestCase
@repository.reload
['', ' ', nil].each do |r|
get :revision, :id => 1, :rev => r
assert_response 500
assert_response 404
assert_error_tag :content => /was not found/
end
end
......
......@@ -201,7 +201,7 @@ class RepositoriesMercurialControllerTest < ActionController::TestCase
@repository.reload
['', ' ', nil].each do |r|
get :revision, :id => 1, :rev => r
assert_response 500
assert_response 404
assert_error_tag :content => /was not found/
end
end
......
......@@ -168,14 +168,14 @@ class RepositoriesSubversionControllerTest < ActionController::TestCase
def test_invalid_revision
get :revision, :id => 1, :rev => 'something_weird'
assert_response 500
assert_response 404
assert_error_tag :content => /was not found/
end
def test_empty_revision
['', ' ', nil].each do |r|
get :revision, :id => 1, :rev => r
assert_response 500
assert_response 404
assert_error_tag :content => /was not found/
end
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment