Commit 08b24216 authored by maeda's avatar maeda
Browse files

Clear subtask assignee during copy if is locked (#28946).

Patch by Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@17390 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent e213797a
......@@ -1642,6 +1642,7 @@ class Issue < ActiveRecord::Base
copy.project = project
copy.parent_issue_id = copied_issue_ids[child.parent_id]
copy.fixed_version_id = nil unless child.fixed_version.present? && child.fixed_version.status == 'open'
copy.assigned_to = nil unless child.assigned_to_id.present? && child.assigned_to.status == User::STATUS_ACTIVE
unless copy.save
logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
next
......
......@@ -1413,6 +1413,25 @@ class IssueTest < ActiveSupport::TestCase
assert_equal [3, nil], copy.children.map(&:fixed_version_id)
end
def test_copy_should_clear_subtasks_assignee_if_is_locked
user = User.find(2)
parent = Issue.generate!
child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :assigned_to_id => 3)
child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :assigned_to_id => user.id)
user.status = User::STATUS_LOCKED
user.save!
copy = parent.reload.copy
assert_difference 'Issue.count', 3 do
assert copy.save
end
assert_equal [3, nil], copy.children.map(&:assigned_to_id)
end
def test_should_not_call_after_project_change_on_creation
issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
:subject => 'Test', :author_id => 1)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment