issues_controller_test.rb 49.4 KB
Newer Older
1
# Redmine - project management software
2
# Copyright (C) 2006-2011  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19 20 21 22 23
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
42
           :custom_fields_projects,
43
           :custom_fields_trackers,
44 45
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
46 47
           :journal_details,
           :queries
48 49 50 51 52 53 54
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
55
  
56
  def test_index
57 58
    Setting.default_language = 'en'
    
59 60 61 62 63
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
64 65 66 67 68
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 70
    # project column
    assert_tag :tag => 'th', :content => /Project/
71
  end
72 73 74 75 76 77 78 79 80 81 82
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
83

84 85 86 87 88 89 90 91 92 93 94
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
  
95
  def test_index_with_project
96
    Setting.display_subprojects_issues = 0
97 98 99 100
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
126 127
  end
  
128
  def test_index_with_project_and_default_filter
129 130 131 132
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
133 134 135 136 137 138 139 140 141
    
    query = assigns(:query)
    assert_not_nil query
    # default filter
    assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
  end
  
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1, 
jplang's avatar
jplang committed
142 143 144
      :f => ['tracker_id'],
      :op => {'tracker_id' => '='},
      :v => {'tracker_id' => ['1']} 
145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    
    query = assigns(:query)
    assert_not_nil query
    assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
  end
  
  def test_index_with_project_and_empty_filters
    get :index, :project_id => 1, :set_filter => 1, :fields => ['']
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    
    query = assigns(:query)
    assert_not_nil query
    # no filter
    assert_equal({}, query.filters)
164 165
  end
  
jplang's avatar
jplang committed
166 167 168 169 170 171 172 173
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
174
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
175 176 177 178
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
179
    assert_not_nil assigns(:issue_count_by_group)
180 181 182 183 184 185 186
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
187
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
188 189
  end
  
jplang's avatar
jplang committed
190 191 192 193 194
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
195
  def test_index_csv_with_project
196 197
    Setting.default_language = 'en'
    
198 199 200 201
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
202
    assert @response.body.starts_with?("#,")
203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
220 221 222 223 224
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
225
  end
226
  
227 228 229 230 231 232 233 234
  def test_index_pdf_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_not_nil assigns(:issue_count_by_group)
    assert_equal 'application/pdf', @response.content_type
  end
  
235
  def test_index_sort
jplang's avatar
jplang committed
236
    get :index, :sort => 'tracker,id:desc'
237 238
    assert_response :success
    
jplang's avatar
jplang committed
239 240 241 242 243 244 245 246
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
247
  end
248 249 250
  
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
251
    get :index, :set_filter => 1, :c => columns
252 253 254 255 256 257 258 259 260 261 262 263
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
  end
264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
  
  def test_index_with_custom_field_column
    columns = %w(tracker subject cf_2)
    get :index, :set_filter => 1, :c => columns
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    assert_tag :td,
      :attributes => {:class => 'cf_2 string'},
      :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
  end
279

280
  def test_show_by_anonymous
281 282 283 284
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
285 286 287 288 289 290 291
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
292 293
  end
  
294 295 296 297 298
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
299 300 301
    assert_tag :tag => 'a',
      :content => /Quote/
    
302 303 304 305 306 307 308 309 310 311 312
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
313
  
jplang's avatar
jplang committed
314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
334 335 336 337 338 339 340 341 342 343 344 345 346 347 348
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
349 350 351
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
352
    assert_template 'journals/index.rxml'
353
    # Inline image
354
    assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
355 356
  end
  
jplang's avatar
jplang committed
357
  def test_show_export_to_pdf
358
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
359 360 361 362 363 364
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

365 366 367 368 369
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
370
    
371
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
372
                                                 :value => 'Default string' }
373 374 375 376 377 378 379 380 381 382 383 384 385
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
386 387 388 389 390 391
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
392
    assert_error_tag :content => /No default issue/
393 394 395 396 397 398 399 400
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
401
    assert_error_tag :content => /No tracker/
402 403
  end
  
404 405
  def test_update_new_form
    @request.session[:user_id] = 2
406
    xhr :post, :new, :project_id => 1,
407 408 409 410 411
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
412 413 414 415 416 417 418 419
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
420
  
421
  def test_post_create
422
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
423
    assert_difference 'Issue.count' do
424
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
425
                 :issue => {:tracker_id => 3,
426
                            :status_id => 2,
edavis10's avatar
edavis10 committed
427 428 429
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
430
                            :start_date => '2010-11-07',
edavis10's avatar
edavis10 committed
431 432 433 434
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
435 436 437 438
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
439
    assert_equal 3, issue.tracker_id
440
    assert_equal 2, issue.status_id
441
    assert_equal Date.parse('2010-11-07'), issue.start_date
442
    assert_nil issue.estimated_hours
443
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
444 445
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
446 447
  end
  
448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
  def test_post_create_without_start_date
    @request.session[:user_id] = 2
    assert_difference 'Issue.count' do
      post :create, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :status_id => 2,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :start_date => '',
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_nil issue.start_date
  end
  
468
  def test_post_create_and_continue
469
    @request.session[:user_id] = 2
470
    post :create, :project_id => 1, 
471 472 473 474
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
475 476
    assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook',
                         :issue => {:tracker_id => 3}
477 478
  end
  
479
  def test_post_create_without_custom_fields_param
480
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
481
    assert_difference 'Issue.count' do
482
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
483 484 485 486 487 488
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
489
  end
490

491
  def test_post_create_with_required_custom_field_and_without_custom_fields_param
492 493 494 495
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
496
    post :create, :project_id => 1, 
497 498 499 500 501 502 503 504
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
505
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
506 507
  end
  
508
  def test_post_create_with_watchers
509 510 511 512
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
513
      post :create, :project_id => 1, 
514 515 516 517 518 519 520
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
521 522 523
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
524 525 526 527 528 529 530 531 532
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
533
  def test_post_create_subissue
jplang's avatar
jplang committed
534 535 536
    @request.session[:user_id] = 2
    
    assert_difference 'Issue.count' do
537
      post :create, :project_id => 1, 
jplang's avatar
jplang committed
538 539 540 541 542 543 544 545
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a child issue',
                            :parent_issue_id => 2}
    end
    issue = Issue.find_by_subject('This is a child issue')
    assert_not_nil issue
    assert_equal Issue.find(2), issue.parent
  end
546 547 548 549 550 551 552 553 554 555 556 557 558 559

  def test_post_create_subissue_with_non_numeric_parent_id
    @request.session[:user_id] = 2
    
    assert_difference 'Issue.count' do
      post :create, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a child issue',
                            :parent_issue_id => 'ABC'}
    end
    issue = Issue.find_by_subject('This is a child issue')
    assert_not_nil issue
    assert_nil issue.parent
  end
jplang's avatar
jplang committed
560
  
561
  def test_post_create_should_send_a_notification
562 563
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
564
    assert_difference 'Issue.count' do
565
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
566 567 568 569 570 571 572 573
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
574 575 576 577
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
578
  def test_post_create_should_preserve_fields_values_on_validation_failure
579
    @request.session[:user_id] = 2
580
    post :create, :project_id => 1, 
581
               :issue => {:tracker_id => 1,
582 583 584
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
585 586 587 588 589
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
590 591
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
592 593 594 595 596 597 598 599 600 601 602 603 604
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
605
  def test_post_create_should_ignore_non_safe_attributes
606 607
    @request.session[:user_id] = 2
    assert_nothing_raised do
608
      post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
609 610 611
    end
  end
  
612 613 614
  context "without workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
615
      Role.anonymous.add_permission! :add_issues, :add_issue_notes
616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
    end
    
    context "#new" do
      should "propose default status only" do
        get :new, :project_id => 1
        assert_response :success
        assert_template 'new'
        assert_tag :tag => 'select',
          :attributes => {:name => 'issue[status_id]'},
          :children => {:count => 1},
          :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
      end
      
      should "accept default status" do
        assert_difference 'Issue.count' do
631
          post :create, :project_id => 1, 
632 633 634 635 636 637 638 639 640 641
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 1}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Issue.count' do
642
          post :create, :project_id => 1, 
643 644 645 646 647 648 649 650
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 3}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
    end
651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738
    
    context "#update" do
      should "ignore status change" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "ignore attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal "Can't print recipes", issue.subject
        assert_nil issue.assigned_to
      end
    end
  end
  
  context "with workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
      Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
      Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
      Role.anonymous.add_permission! :add_issues, :add_issue_notes
    end
    
    context "#update" do
      should "accept authorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 3, Issue.find(1).status_id
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "accept authorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal 2, issue.assigned_to_id
      end
      
      should "ignore unauthorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
        end
        issue = Issue.find(1)
        assert_equal "Can't print recipes", issue.subject
      end
    end
    
    context "and :edit_issues permission" do
      setup do
        Role.anonymous.add_permission! :add_issues, :edit_issues
      end

      should "accept authorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 3, Issue.find(1).status_id
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "accept authorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal "changed", issue.subject
        assert_equal 2, issue.assigned_to_id
      end
    end
739 740
  end
  
741 742 743 744 745 746 747 748 749
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
750 751 752 753 754 755 756 757
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
758 759 760
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
761 762
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
        :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
780 781 782 783 784 785

    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
    assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
                        :child => { :tag => 'option',
                                    :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
    assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
786
  end
787 788 789

  def test_update_edit_form
    @request.session[:user_id] = 2
790
    xhr :post, :new, :project_id => 1,
791 792 793 794 795 796 797 798 799 800 801 802 803 804 805
                             :id => 1,
                             :issue => {:tracker_id => 2, 
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
    assert_response :success
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.id
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
806
  
807 808 809 810 811 812 813 814 815 816 817 818 819 820
  def test_update_using_invalid_http_verbs
    @request.session[:user_id] = 2
    subject = 'Updated by an invalid http verb'

    get :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    post :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    delete :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject
  end

821
  def test_put_update_without_custom_fields_param
822
    @request.session[:user_id] = 2
823 824 825
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
826
    assert_equal '125', issue.custom_value_for(2).value
827 828 829
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
830 831
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
832
        put :update, :id => 1, :issue => {:subject => new_subject,
833 834 835 836 837
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
838
    assert_redirected_to :action => 'show', :id => '1'
839 840
    issue.reload
    assert_equal new_subject, issue.subject
841 842
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
843 844 845 846 847
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
848 849
  end
  
850
  def test_put_update_with_custom_field_change
851 852 853 854 855 856
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
857
        put :update, :id => 1, :issue => {:subject => 'Custom field change',
858 859 860 861 862 863
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
864
    assert_redirected_to :action => 'show', :id => '1'
865 866 867 868 869 870 871 872
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
873
  def test_put_update_with_status_and_assignee_change
874 875 876
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
877
    assert_difference('TimeEntry.count', 0) do
878
      put :update,
879 880 881
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
882
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
883
    end
884
    assert_redirected_to :action => 'show', :id => '1'
885 886
    issue.reload
    assert_equal 2, issue.status_id
jplang's avatar
jplang committed
887
    j = Journal.find(:first, :order => 'id DESC')
888 889
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
890 891 892
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
893 894
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
895 896
  end
  
897
  def test_put_update_with_note_only
898 899
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
900
    put :update,
901 902
         :id => 1,
         :notes => notes
903
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
904
    j = Journal.find(:first, :order => 'id DESC')
905 906 907 908 909 910 911 912
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
913
  def test_put_update_with_note_and_spent_time
914 915
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
916
    assert_difference('TimeEntry.count') do
917
      put :update,
918 919
           :id => 1,
           :notes => '2.5 hours added',
920
           :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
921
    end
922
    assert_redirected_to :action => 'show', :id => '1'
923 924 925
    
    issue = Issue.find(1)
    
jplang's avatar
jplang committed
926
    j = Journal.find(:first, :order => 'id DESC')
927 928 929
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
930
    t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
931 932 933 934 935
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
936
  def test_put_update_with_attachment_only
937 938
    set_tmp_attachments_directory
    
939 940 941 942
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

943
    # anonymous user
944
    put :update,
945 946
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
947
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
948
    assert_redirected_to :action => 'show', :id => '1'
949 950 951 952 953 954 955 956 957
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978

  def test_put_update_with_attachment_that_fails_to_save
    set_tmp_attachments_directory
    
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

    # Mock out the unsaved attachment
    Attachment.any_instance.stubs(:create).returns(Attachment.new)
    
    # anonymous user
    put :update,
         :id => 1,
         :notes => '',
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
    assert_redirected_to :action => 'show', :id => '1'
    assert_equal '1 file(s) could not be saved.', flash[:warning]

  end if Object.const_defined?(:Mocha)

979
  def test_put_update_with_no_change
980 981 982 983
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
984
    put :update,
985 986
         :id => 1,
         :notes => ''
987
    assert_redirected_to :action => 'show', :id => '1'
988 989 990 991 992
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
993
  end
994

995
  def test_put_update_should_send_a_notification
996 997 998 999 1000 1001
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
1002
    put :update, :id => 1, :issue => {:subject => new_subject,
1003 1004 1005 1006 1007
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
1008
  
1009
  def test_put_update_with_invalid_spent_time_hours_only
1010 1011 1012 1013
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
1014
      put :update,
1015 1016 1017 1018 1019 1020 1021
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
1022 1023
    assert_error_tag :descendant => {:content => /Activity can't be blank/}
    assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1024 1025
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
1026
  
1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045
  def test_put_update_with_invalid_spent_time_comments_only
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
      put :update,
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_error_tag :descendant => {:content => /Activity can't be blank/}
    assert_error_tag :descendant => {:content => /Hours can't be blank/}
    assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
  end
  
1046
  def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
1047 1048 1049
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1050
    put :update,
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         }

    assert_response :redirect
    issue.reload
    assert_equal 4, issue.fixed_version_id
    assert_not_equal issue.project_id, issue.fixed_version.project_id
  end
1061

1062
  def test_put_update_should_redirect_back_using_the_back_url_parameter
1063 1064 1065
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1066
    put :update,
1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => '/issues'

    assert_response :redirect
    assert_redirected_to '/issues'
  end
  
1077
  def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1078 1079 1080
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1081
    put :update,
1082 1083 1084 1085 1086 1087 1088 1089 1090
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => 'http://google.com'

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
  end
1091
  
1092 1093 1094 1095 1096
  def test_get_bulk_edit
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
1097
    
1098 1099
    assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
    
1100 1101 1102 1103
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert_equal 'date', field.field_format
jplang's avatar
jplang committed
1104
    assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
1105
    
1106
    # System wide custom field
1107
    assert CustomField.find(1).is_for_all?
jplang's avatar
jplang committed
1108
    assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
1109
  end
1110

1111 1112 1113 1114 1115 1116
  def test_get_bulk_edit_on_different_projects
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2, 6]
    assert_response :success
    assert_template 'bulk_edit'
    
1117 1118 1119
    # Can not set issues from different projects as children of an issue
    assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
    
1120 1121 1122 1123 1124 1125
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert !field.project_ids.include?(Issue.find(6).project_id)
    assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
  end
1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157
  
  def test_get_bulk_edit_with_user_custom_field
    field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
    
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
    
    assert_tag :select,
      :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
      :children => {
        :only => {:tag => 'option'},
        :count => Project.find(1).users.count + 1
      }
  end
  
  def test_get_bulk_edit_with_version_custom_field
    field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
    
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
    
    assert_tag :select,
      :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
      :children => {
        :only => {:tag => 'option'},
        :count => Project.find(1).versions.count + 1
      }
  end
1158

1159
  def test_bulk_update
1160 1161
    @request.session[:user_id] = 2
    # update issues priority
1162
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
jplang's avatar
jplang committed
1163 1164 1165 1166
                                     :issue => {:priority_id => 7,
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => ''}}
                                     
1167 1168 1169
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
1170 1171 1172 1173 1174 1175 1176 1177
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210
  def test_bulk_update_on_different_projects
    @request.session[:user_id] = 2
    # update issues priority
    post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
                                     :issue => {:priority_id => 7,
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => ''}}
    
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

  def test_bulk_update_on_different_projects_without_rights
    @request.session[:user_id] = 3
    user = User.find(3)
    action = { :controller => "issues", :action => "bulk_update" }
    assert user.allowed_to?(action, Issue.find(1).project)
    assert ! user.allowed_to?(action, Issue.find(6).project)
    post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
                                     :issue => {:priority_id => 7,
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => ''}}
    assert_response 403
    assert_not_equal "Bulk should fail", Journal.last.notes
  end
    
1211
  def test_bullk_update_should_send_a_notification
1212 1213
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
1214
    post(:bulk_update,
1215 1216
         {
           :ids => [1, 2],
jplang's avatar
jplang committed
1217 1218 1219 1220 1221 1222
           :notes => 'Bulk editing',
           :issue => {
             :priority_id => 7,
             :assigned_to_id => '',
             :custom_field_values => {'2' => ''}
           }
1223 1224 1225 1226 1227 1228
         })

    assert_response 302
    assert_equal 2, ActionMailer::Base.deliveries.size
  end

1229
  def test_bulk_update_status
1230 1231
    @request.session[:user_id] = 2
    # update issues priority
1232
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
jplang's avatar
jplang committed
1233 1234 1235 1236
                                     :issue => {:priority_id => '',
                                                :assigned_to_id => '',
                                                :status_id => '5'}
                                     
1237 1238 1239 1240
    assert_response 302
    issue = Issue.find(1)
    assert issue.closed?
  end
1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253
  
  def test_bulk_update_parent_id
    @request.session[:user_id] = 2
    post :bulk_update, :ids => [1, 3],
      :notes => 'Bulk editing parent',
      :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
    
    assert_response 302
    parent = Issue.find(2)
    assert_equal parent.id, Issue.find(1).parent_id
    assert_equal parent.id, Issue.find(3).parent_id
    assert_equal [1, 3], parent.children.collect(&:id).sort
  end
1254

1255
  def test_bulk_update_custom_field
1256 1257
    @request.session[:user_id] = 2
    # update issues priority
1258
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
jplang's avatar
jplang committed
1259 1260 1261 1262
                                     :issue => {:priority_id => '',
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => '777'}}
                                     
1263 1264 1265 1266 1267 1268 1269 1270
    assert_response 302
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '777', issue.custom_value_for(2).value
    assert_equal 1, journal.details.size
    assert_equal '125', journal.details.first.old_value
    assert_equal '777', journal.details.first.value
1271 1272
  end

1273
  def test_bulk_update_unassign
1274 1275 1276
    assert_not_nil Issue.find(2).assigned_to
    @request.session[:user_id] = 2
    # unassign issues
1277
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
1278 1279 1280 1281 1282
    assert_response 302
    # check that the issues were updated
    assert_nil Issue.find(2).assigned_to
  end
  
1283
  def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
1284 1285
    @request.session[:user_id] = 2

1286
    post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
1287 1288 1289 1290 1291 1292 1293 1294 1295

    assert_response :redirect
    issues = Issue.find([1,2])
    issues.each do |issue|
      assert_equal 4, issue.fixed_version_id
      assert_not_equal issue.project_id, issue.fixed_version.project_id
    end
  end

1296
  def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
1297
    @request.session[:user_id] = 2
1298
    post :bulk_update, :ids => [1,2], :back_url => '/issues'
1299 1300 1301 1302 1303

    assert_response :redirect
    assert_redirected_to '/issues'
  end

1304
  def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1305
    @request.session[:user_id] = 2
1306
    post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
1307 1308 1309 1310

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
  end
1311
  
1312
  def test_destroy_issue_with_no_time_entries
1313
    assert_nil TimeEntry.find_by_issue_id(2)
1314
    @request.session[:user_id] = 2
1315
    post :destroy, :id => 2
1316
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1317
    assert_nil Issue.find_by_id(2)
1318 1319
  end

1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
  def test_destroy_issues_with_time_entries
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3]
    assert_response :success
    assert_template 'destroy'
    assert_not_nil assigns(:hours)
    assert Issue.find_by_id(1) && Issue.find_by_id(3)
  end

  def test_destroy_issues_and_destroy_time_entries
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3], :todo => 'destroy'
1332
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1333 1334 1335 1336 1337 1338 1339
    assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
    assert_nil TimeEntry.find_by_id([1, 2])
  end

  def test_destroy_issues_and_assign_time_entries_to_project
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3], :todo => 'nullify'