issues_controller_test.rb 46.4 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2008  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require File.dirname(__FILE__) + '/../test_helper'
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
42
           :custom_fields_projects,
43
           :custom_fields_trackers,
44 45
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
46 47
           :journal_details,
           :queries
48 49 50 51 52 53 54
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
55 56 57 58 59 60 61
  
  def test_index_routing
    assert_routing(
      {:method => :get, :path => '/issues'},
      :controller => 'issues', :action => 'index'
    )
  end
62 63

  def test_index
64 65
    Setting.default_language = 'en'
    
66 67 68 69 70
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
71 72 73 74 75
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
76 77
    # project column
    assert_tag :tag => 'th', :content => /Project/
78
  end
79 80 81 82 83 84 85 86 87 88 89
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
90

91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
  def test_index_with_project_routing
    assert_routing(
      {:method => :get, :path => '/projects/23/issues'},
      :controller => 'issues', :action => 'index', :project_id => '23'
    )
  end
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end

  def test_index_with_project_routing
    assert_routing(
      {:method => :get, :path => 'projects/23/issues'},
      :controller => 'issues', :action => 'index', :project_id => '23'
    )
  end
  
116
  def test_index_with_project
117
    Setting.display_subprojects_issues = 0
118 119 120 121
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
147 148
  end
  
149 150 151 152 153 154 155 156 157 158 159
  def test_index_with_project_routing_formatted
    assert_routing(
      {:method => :get, :path => 'projects/23/issues.pdf'},
      :controller => 'issues', :action => 'index', :project_id => '23', :format => 'pdf'
    )
    assert_routing(
      {:method => :get, :path => 'projects/23/issues.atom'},
      :controller => 'issues', :action => 'index', :project_id => '23', :format => 'atom'
    )
  end
  
160 161 162 163 164 165 166
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
  end
  
jplang's avatar
jplang committed
167 168 169 170 171 172 173 174
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
175
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
176 177 178 179
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
180
    assert_not_nil assigns(:issue_count_by_group)
181 182 183 184 185 186 187
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
188
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
189 190
  end
  
jplang's avatar
jplang committed
191 192 193 194 195
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
196
  def test_index_csv_with_project
197 198
    Setting.default_language = 'en'
    
199 200 201 202
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
203
    assert @response.body.starts_with?("#,")
204 205 206 207 208 209 210

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
211 212 213 214 215 216 217 218 219 220 221
  def test_index_formatted
    assert_routing(
      {:method => :get, :path => 'issues.pdf'},
      :controller => 'issues', :action => 'index', :format => 'pdf'
    )
    assert_routing(
      {:method => :get, :path => 'issues.atom'},
      :controller => 'issues', :action => 'index', :format => 'atom'
    )
  end
  
222 223 224 225 226 227 228 229 230 231
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
232 233 234 235 236
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
237
  end
238 239
  
  def test_index_sort
jplang's avatar
jplang committed
240
    get :index, :sort => 'tracker,id:desc'
241 242
    assert_response :success
    
jplang's avatar
jplang committed
243 244 245 246 247 248 249 250
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
251
  end
252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
  
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
    get :index, :set_filter => 1, :query => { 'column_names' => columns}
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
  end
268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285

  def test_gantt
    get :gantt, :project_id => 1
    assert_response :success
    assert_template 'gantt.rhtml'
    assert_not_nil assigns(:gantt)
    events = assigns(:gantt).events
    assert_not_nil events
    # Issue with start and due dates
    i = Issue.find(1)
    assert_not_nil i.due_date
    assert events.include?(Issue.find(1))
    # Issue with without due date but targeted to a version with date
    i = Issue.find(2)
    assert_nil i.due_date
    assert events.include?(i)
  end

286 287 288 289 290 291 292 293 294
  def test_cross_project_gantt
    get :gantt
    assert_response :success
    assert_template 'gantt.rhtml'
    assert_not_nil assigns(:gantt)
    events = assigns(:gantt).events
    assert_not_nil events
  end

295 296 297 298
  def test_gantt_export_to_pdf
    get :gantt, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
299
    assert @response.body.starts_with?('%PDF')
300 301
    assert_not_nil assigns(:gantt)
  end
302 303 304 305 306

  def test_cross_project_gantt_export_to_pdf
    get :gantt, :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
307
    assert @response.body.starts_with?('%PDF')
308 309
    assert_not_nil assigns(:gantt)
  end
310 311 312 313 314 315 316 317 318 319
  
  if Object.const_defined?(:Magick)
    def test_gantt_image
      get :gantt, :project_id => 1, :format => 'png'
      assert_response :success
      assert_equal 'image/png', @response.content_type
    end
  else
    puts "RMagick not installed. Skipping tests !!!"
  end
320
  
321 322 323 324 325
  def test_calendar
    get :calendar, :project_id => 1
    assert_response :success
    assert_template 'calendar'
    assert_not_nil assigns(:calendar)
326 327 328 329 330 331 332
  end
  
  def test_cross_project_calendar
    get :calendar
    assert_response :success
    assert_template 'calendar'
    assert_not_nil assigns(:calendar)
333 334
  end
  
335 336 337
  def test_changes
    get :changes, :project_id => 1
    assert_response :success
338
    assert_not_nil assigns(:journals)
339 340
    assert_equal 'application/atom+xml', @response.content_type
  end
jplang's avatar
jplang committed
341
  
342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
  def test_show_routing
    assert_routing(
      {:method => :get, :path => '/issues/64'},
      :controller => 'issues', :action => 'show', :id => '64'
    )
  end
  
  def test_show_routing_formatted
    assert_routing(
      {:method => :get, :path => '/issues/2332.pdf'},
      :controller => 'issues', :action => 'show', :id => '2332', :format => 'pdf'
    )
    assert_routing(
      {:method => :get, :path => '/issues/23123.atom'},
      :controller => 'issues', :action => 'show', :id => '23123', :format => 'atom'
    )
  end
  
360
  def test_show_by_anonymous
jplang's avatar
jplang committed
361 362 363 364
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
365 366 367 368 369 370 371
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
jplang's avatar
jplang committed
372 373
  end
  
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
390
  
jplang's avatar
jplang committed
391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
411 412 413 414 415 416 417 418 419 420 421 422 423 424 425
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
426 427 428 429 430
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
    assert_template 'changes.rxml'
    # Inline image
431
    assert @response.body.include?("&lt;img src=\"http://test.host/attachments/download/10\" alt=\"\" /&gt;"), "Body did not match. Body: #{@response.body}"
432 433
  end
  
434 435 436 437 438 439 440 441 442 443
  def test_new_routing
    assert_routing(
      {:method => :get, :path => '/projects/1/issues/new'},
      :controller => 'issues', :action => 'new', :project_id => '1'
    )
    assert_recognizes(
      {:controller => 'issues', :action => 'new', :project_id => '1'},
      {:method => :post, :path => '/projects/1/issues'}
    )
  end
444

jplang's avatar
jplang committed
445
  def test_show_export_to_pdf
446
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
447 448 449 450 451 452
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

453 454 455 456 457
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
458
    
459
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
460
                                                 :value => 'Default string' }
461 462 463 464 465 466 467 468 469 470 471 472 473
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No default issue/
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No tracker/
  end
  
496 497
  def test_update_new_form
    @request.session[:user_id] = 2
498
    xhr :post, :update_form, :project_id => 1,
499 500 501 502 503
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
504 505 506 507 508 509 510 511
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
512 513 514
  
  def test_post_new
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
515 516 517 518 519 520 521 522 523 524
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
525 526 527 528
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
529
    assert_equal 3, issue.tracker_id
530
    assert_nil issue.estimated_hours
531
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
532 533
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
534 535
  end
  
536 537 538 539 540 541 542 543 544 545
  def test_post_new_and_continue
    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
    assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3
  end
  
546 547
  def test_post_new_without_custom_fields_param
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
548 549 550 551 552 553 554 555
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
556
  end
557

558 559 560 561 562 563 564 565 566 567 568 569 570 571
  def test_post_new_with_required_custom_field_and_without_custom_fields_param
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
572
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
573 574
  end
  
575 576 577 578 579 580 581 582 583 584 585 586 587
  def test_post_new_with_watchers
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
588 589 590
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
591 592 593 594 595 596 597 598 599
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
600 601 602
  def test_post_new_should_send_a_notification
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
603 604 605 606 607 608 609 610 611 612
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
613 614 615 616
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
617 618 619 620
  def test_post_should_preserve_fields_values_on_validation_failure
    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 1,
621 622 623
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
624 625 626 627 628
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
629 630
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
631 632 633 634 635 636 637 638 639 640 641 642 643
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
644 645 646 647 648 649 650
  def test_copy_routing
    assert_routing(
      {:method => :get, :path => '/projects/world_domination/issues/567/copy'},
      :controller => 'issues', :action => 'new', :project_id => 'world_domination', :copy_from => '567'
    )
  end
  
651 652 653 654 655 656 657 658 659
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
660 661 662 663 664 665 666 667 668 669 670
  def test_edit_routing
    assert_routing(
      {:method => :get, :path => '/issues/1/edit'},
      :controller => 'issues', :action => 'edit', :id => '1'
    )
    assert_recognizes( #TODO: use a PUT on the issue URI isntead, need to adjust form
      {:controller => 'issues', :action => 'edit', :id => '1'},
      {:method => :post, :path => '/issues/1/edit'}
    )
  end
  
jplang's avatar
jplang committed
671 672 673 674 675 676 677 678
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
  end
701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719

  def test_update_edit_form
    @request.session[:user_id] = 2
    xhr :post, :update_form, :project_id => 1,
                             :id => 1,
                             :issue => {:tracker_id => 2, 
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
    assert_response :success
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.id
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
720
  
721 722 723 724 725 726 727
  def test_reply_routing
    assert_routing(
      {:method => :post, :path => '/issues/1/quoted'},
      :controller => 'issues', :action => 'reply', :id => '1'
    )
  end
  
728 729 730 731 732 733 734 735 736 737 738 739 740
  def test_reply_to_issue
    @request.session[:user_id] = 2
    get :reply, :id => 1
    assert_response :success
    assert_select_rjs :show, "update"
  end

  def test_reply_to_note
    @request.session[:user_id] = 2
    get :reply, :id => 1, :journal_id => 2
    assert_response :success
    assert_select_rjs :show, "update"
  end
jplang's avatar
jplang committed
741

742
  def test_post_edit_without_custom_fields_param
jplang's avatar
jplang committed
743
    @request.session[:user_id] = 2
744 745 746
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
747
    assert_equal '125', issue.custom_value_for(2).value
748 749 750
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
751 752 753 754 755 756 757 758
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
        post :edit, :id => 1, :issue => {:subject => new_subject,
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
759
    assert_redirected_to :action => 'show', :id => '1'
760 761
    issue.reload
    assert_equal new_subject, issue.subject
762 763
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
764 765 766 767 768
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
jplang's avatar
jplang committed
769 770
  end
  
771 772 773 774 775 776 777 778 779 780 781 782 783 784
  def test_post_edit_with_custom_field_change
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
        post :edit, :id => 1, :issue => {:subject => 'Custom field change',
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
785
    assert_redirected_to :action => 'show', :id => '1'
786 787 788 789 790 791 792 793
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
794
  def test_post_edit_with_status_and_assignee_change
jplang's avatar
jplang committed
795 796 797
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
798 799 800 801 802
    assert_difference('TimeEntry.count', 0) do
      post :edit,
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
803
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
804
    end
805
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
806 807
    issue.reload
    assert_equal 2, issue.status_id
jplang's avatar
jplang committed
808
    j = Journal.find(:first, :order => 'id DESC')
jplang's avatar
jplang committed
809 810
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
811 812 813
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
814 815
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
816 817
  end
  
818
  def test_post_edit_with_note_only
819 820
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
821
    post :edit,
822 823
         :id => 1,
         :notes => notes
824
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
825
    j = Journal.find(:first, :order => 'id DESC')
826 827 828 829 830 831 832 833
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
834
  def test_post_edit_with_note_and_spent_time
835 836
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
837 838 839 840
    assert_difference('TimeEntry.count') do
      post :edit,
           :id => 1,
           :notes => '2.5 hours added',
841
           :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first }
842
    end
843
    assert_redirected_to :action => 'show', :id => '1'
844 845 846
    
    issue = Issue.find(1)
    
jplang's avatar
jplang committed
847
    j = Journal.find(:first, :order => 'id DESC')
848 849 850 851 852 853 854 855 856
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
    t = issue.time_entries.find(:first, :order => 'id DESC')
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
857
  def test_post_edit_with_attachment_only
jplang's avatar
jplang committed
858 859
    set_tmp_attachments_directory
    
860 861 862 863
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

864
    # anonymous user
865
    post :edit,
866 867
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
868
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
869
    assert_redirected_to :action => 'show', :id => '1'
870 871 872 873 874 875 876 877 878 879
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
  
880
  def test_post_edit_with_no_change
881 882 883 884
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
885
    post :edit,
886 887
         :id => 1,
         :notes => ''
888
    assert_redirected_to :action => 'show', :id => '1'
889 890 891 892 893
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
jplang's avatar
jplang committed
894
  end
895 896 897 898 899 900 901 902 903 904 905 906 907 908

  def test_post_edit_should_send_a_notification
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
    post :edit, :id => 1, :issue => {:subject => new_subject,
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926
  
  def test_post_edit_with_invalid_spent_time
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
      post :edit,
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_tag :textarea, :attributes => { :name => 'notes' },
                          :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
927
  
928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943
  def test_post_edit_should_allow_fixed_version_to_be_set_to_a_subproject
    issue = Issue.find(2)
    @request.session[:user_id] = 2

    post :edit,
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         }

    assert_response :redirect
    issue.reload
    assert_equal 4, issue.fixed_version_id
    assert_not_equal issue.project_id, issue.fixed_version.project_id
  end
  
944 945 946 947 948
  def test_get_bulk_edit
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
949 950 951 952 953 954 955
    
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert_equal 'date', field.field_format
    assert_tag :input, :attributes => {:name => 'custom_field_values[9]'}
    
956
    # System wide custom field
957
    assert CustomField.find(1).is_for_all?
958
    assert_tag :select, :attributes => {:name => 'custom_field_values[1]'}
959
  end
960 961 962 963

  def test_bulk_edit
    @request.session[:user_id] = 2
    # update issues priority
964 965 966 967
    post :bulk_edit, :ids => [1, 2], :priority_id => 7,
                                     :assigned_to_id => '',
                                     :custom_field_values => {'2' => ''},
                                     :notes => 'Bulk editing'
968 969 970
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
971 972 973 974 975 976 977 978
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994
  def test_bullk_edit_should_send_a_notification
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    post(:bulk_edit,
         {
           :ids => [1, 2],
           :priority_id => 7,
           :assigned_to_id => '',
           :custom_field_values => {'2' => ''},
           :notes => 'Bulk editing'
         })

    assert_response 302
    assert_equal 2, ActionMailer::Base.deliveries.size
  end

995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006
  def test_bulk_edit_status
    @request.session[:user_id] = 2
    # update issues priority
    post :bulk_edit, :ids => [1, 2], :priority_id => '',
                                     :assigned_to_id => '',
                                     :status_id => '5',
                                     :notes => 'Bulk editing status'
    assert_response 302
    issue = Issue.find(1)
    assert issue.closed?
  end

1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021
  def test_bulk_edit_custom_field
    @request.session[:user_id] = 2
    # update issues priority
    post :bulk_edit, :ids => [1, 2], :priority_id => '',
                                     :assigned_to_id => '',
                                     :custom_field_values => {'2' => '777'},
                                     :notes => 'Bulk editing custom field'
    assert_response 302
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '777', issue.custom_value_for(2).value
    assert_equal 1, journal.details.size
    assert_equal '125', journal.details.first.old_value
    assert_equal '777', journal.details.first.value
1022 1023
  end

1024 1025 1026 1027 1028 1029 1030 1031 1032 1033
  def test_bulk_unassign
    assert_not_nil Issue.find(2).assigned_to
    @request.session[:user_id] = 2
    # unassign issues
    post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :assigned_to_id => 'none'
    assert_response 302
    # check that the issues were updated
    assert_nil Issue.find(2).assigned_to
  end
  
1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048
  def test_post_bulk_edit_should_allow_fixed_version_to_be_set_to_a_subproject
    @request.session[:user_id] = 2

    post :bulk_edit,
         :ids => [1,2],
         :fixed_version_id => 4

    assert_response :redirect
    issues = Issue.find([1,2])
    issues.each do |issue|
      assert_equal 4, issue.fixed_version_id
      assert_not_equal issue.project_id, issue.fixed_version.project_id
    end
  end

1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059
  def test_move_routing
    assert_routing(
      {:method => :get, :path => '/issues/1/move'},
      :controller => 'issues', :action => 'move', :id => '1'
    )
    assert_recognizes(
      {:controller => 'issues', :action => 'move', :id => '1'},
      {:method => :post, :path => '/issues/1/move'}
    )
  end
  
1060
  def test_move_one_issue_to_another_project
1061
    @request.session[:user_id] = 2
1062
    post :move, :id => 1, :new_project_id => 2, :tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => ''
1063
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1064 1065 1066
    assert_equal 2, Issue.find(1).project_id
  end

1067 1068 1069 1070 1071 1072
  def test_move_one_issue_to_another_project_should_follow_when_needed
    @request.session[:user_id] = 2
    post :move, :id => 1, :new_project_id => 2, :follow => '1'
    assert_redirected_to '/issues/1'
  end

1073
  def test_bulk_move_to_another_project
1074
    @request.session[:user_id] = 2
1075
    post :move, :ids => [1, 2], :new_project_id => 2
1076
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1077 1078 1079 1080 1081 1082 1083 1084 1085
    # Issues moved to project 2
    assert_equal 2, Issue.find(1).project_id
    assert_equal 2, Issue.find(2).project_id
    # No tracker change
    assert_equal 1, Issue.find(1).tracker_id
    assert_equal 2, Issue.find(2).tracker_id
  end
 
  def test_bulk_move_to_another_tracker
1086
    @request.session[:user_id] = 2
1087
    post :move, :ids => [1, 2], :new_tracker_id => 2
1088
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1089 1090 1091
    assert_equal 2, Issue.find(1).tracker_id
    assert_equal 2, Issue.find(2).tracker_id
  end
1092 1093

  def test_bulk_copy_to_another_project
1094
    @request.session[:user_id] = 2
1095 1096 1097 1098 1099 1100 1101
    assert_difference 'Issue.count', 2 do
      assert_no_difference 'Project.find(1).issues.count' do
        post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}
      end
    end
    assert_redirected_to 'projects/ecookbook/issues'
  end
1102

1103
  context "#move via bulk copy" do
1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117
    should "allow not changing the issue's attributes" do
      @request.session[:user_id] = 2
      issue_before_move = Issue.find(1)
      assert_difference 'Issue.count', 1 do
        assert_no_difference 'Project.find(1).issues.count' do
          post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => ''
        end
      end
      issue_after_move = Issue.first(:order => 'id desc', :conditions => {:project_id => 2})
      assert_equal issue_before_move.tracker_id, issue_after_move.tracker_id
      assert_equal issue_before_move.status_id, issue_after_move.status_id
      assert_equal issue_before_move.assigned_to_id, issue_after_move.assigned_to_id
    end
    
1118 1119 1120 1121
    should "allow changing the issue's attributes" do
      @request.session[:user_id] = 2
      assert_difference 'Issue.count', 2 do
        assert_no_difference 'Project.find(1).issues.count' do
1122
          post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => 4, :status_id => 3, :start_date => '2009-12-01', :due_date => '2009-12-31'
1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137
        end
      end

      copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
      assert_equal 2, copied_issues.size
      copied_issues.each do |issue|
        assert_equal 2, issue.project_id, "Project is incorrect"
        assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
        assert_equal 3, issue.status_id, "Status is incorrect"
        assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
        assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
      end
    end
  end
  
1138 1139 1140 1141 1142 1143
  def test_copy_to_another_project_should_follow_when_needed
    @request.session[:user_id] = 2
    post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :follow => '1'
    issue = Issue.first(:order => 'id DESC')
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
  end
jplang's avatar
jplang committed
1144
  
1145 1146 1147 1148 1149 1150
  def test_context_menu_one_issue
    @request.session[:user_id] = 2
    get :context_menu, :ids => [1]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Edit',
1151
                            :attributes => { :href => '/issues/1/edit',
1152 1153
                                             :class => 'icon-edit' }
    assert_tag :tag => 'a', :content => 'Closed',
1154
                            :attributes => { :href => '/issues/1/edit?issue%5Bstatus_id%5D=5',
1155 1156
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Immediate',
1157
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;priority_id=8',
1158
                                             :class => '' }
1159 1160 1161 1162 1163 1164 1165 1166
    # Versions
    assert_tag :tag => 'a', :content => '2.0',
                            :attributes => { :href => '/issues/bulk_edit?fixed_version_id=3&amp;ids%5B%5D=1',
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'eCookbook Subproject 1 - 2.0',
                            :attributes => { :href => '/issues/bulk_edit?fixed_version_id=4&amp;ids%5B%5D=1',
                                             :class => '' }

1167
    assert_tag :tag => 'a', :content => 'Dave Lopper',
1168
                            :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1',
1169
                                             :class => '' }
jplang's avatar
jplang committed
1170
    assert_tag :tag => 'a', :content => 'Duplicate',
1171
                            :attributes => { :href => '/projects/ecookbook/issues/1/copy',
jplang's avatar
jplang committed
1172 1173 1174
                                             :class => 'icon-duplicate' }
    assert_tag :tag => 'a', :content => 'Copy',
                            :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&amp;ids%5B%5D=1',
1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200
                                             :class => 'icon-copy' }
    assert_tag :tag => 'a', :content => 'Move',
                            :attributes => { :href => '/issues/move?ids%5B%5D=1',
                                             :class => 'icon-move' }
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '/issues/destroy?ids%5B%5D=1',
                                             :class => 'icon-del' }
  end

  def test_context_menu_one_issue_by_anonymous
    get :context_menu, :ids => [1]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes =>