issue_test.rb 40 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2011  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
jplang's avatar
jplang committed
21
  fixtures :projects, :users, :members, :member_roles, :roles,
22
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
23
           :enabled_modules,
24
           :versions,
25
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 27 28 29
           :enumerations,
           :issues,
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
30

31
  def test_create
32 33 34 35
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 37 38 39
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
40

41
  def test_create_minimal
42 43 44
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create')
45 46 47
    assert issue.save
    assert issue.description.nil?
  end
48

49 50 51
  def test_create_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
52

53 54 55
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
56 57 58
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
59
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
60 61 62
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
63
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
64 65 66
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
67
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
68 69 70 71 72 73
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
74

75 76
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
77 78 79
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
80 81 82 83 84
      issue = Issue.first(:order => 'id DESC')
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
85

86 87 88 89
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
90 91 92 93 94
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
95
    assert_nil issues.detect {|issue| issue.is_private?}
96 97
    assert_visibility_match User.anonymous, issues
  end
98

99 100 101
  def test_visible_scope_for_anonymous_with_own_issues_visibility
    Role.anonymous.update_attribute :issues_visibility, 'own'
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
102

103 104 105 106 107
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != User.anonymous}
    assert_visibility_match User.anonymous, issues
  end
108

109
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
110 111 112 113
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
    issues = Issue.visible(User.anonymous).all
    assert issues.empty?
114
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
115
  end
116

117
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
118 119 120 121 122 123
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
124
    assert_nil issues.detect {|issue| issue.is_private?}
125 126
    assert_visibility_match user, issues
  end
127

128 129 130 131
  def test_visible_scope_for_non_member_with_own_issues_visibility
    Role.non_member.update_attribute :issues_visibility, 'own'
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
132

133 134 135 136 137
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
138

139
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
140 141
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
142 143
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
144 145
    issues = Issue.visible(user).all
    assert issues.empty?
146 147
    assert_visibility_match user, issues
  end
148

149 150
  def test_visible_scope_for_member
    user = User.find(9)
jplang's avatar
jplang committed
151
    # User should see issues of projects for which he has view_issues permissions only
152
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
153
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
154 155
    issues = Issue.visible(user).all
    assert issues.any?
jplang's avatar
jplang committed
156 157
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
158
    assert_visibility_match user, issues
jplang's avatar
jplang committed
159
  end
160

jplang's avatar
jplang committed
161 162 163 164 165 166 167 168
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
    issues = Issue.visible(user).all
    assert issues.any?
    # Admin should see issues on private projects that he does not belong to
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
169 170
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
171
    assert_visibility_match user, issues
jplang's avatar
jplang committed
172
  end
173

174 175 176 177 178 179 180
  def test_visible_scope_with_project
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project).all
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
181

182 183 184 185 186 187 188
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
189

190 191 192
  def test_visible_and_nested_set_scopes
    assert_equal 0, Issue.find(1).descendants.visible.all.size
  end
193

194 195
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
196

tmaruyama's avatar
tmaruyama committed
197 198 199
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
200 201 202
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
203

204 205 206 207
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
  end
208

209 210 211
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
212

213 214 215 216 217 218 219 220 221 222 223 224 225 226
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
227

228 229 230 231
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
232

233 234 235
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
236

237 238 239
    issue.reload
    assert_equal "Can't print recipes", issue.subject
  end
240

241 242
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
243

244 245 246 247 248 249 250 251 252 253
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
254

255 256 257 258 259 260
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
261

262 263 264 265 266 267 268 269 270
  def test_assigning_attributes_should_assign_tracker_id_first
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
    assert_not_nil issue.custom_value_for(1)
    assert_equal 'MySQL', issue.custom_value_for(1).value
  end
271

272 273 274
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
275

276 277
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
278

279 280 281 282
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
283

284 285 286
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
287

288 289 290 291
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
292
    assert_not_nil issue.errors[:tracker_id]
293
  end
294

295
  def test_category_based_assignment
296 297 298 299
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
300 301
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
302

303 304
  def test_new_statuses_allowed_to
    Workflow.delete_all
305

306 307 308 309 310 311 312 313
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
314

315 316
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
317

318
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
jplang's avatar
jplang committed
319
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
320

321
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
jplang's avatar
jplang committed
322
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
323

324 325 326
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  end
327

328 329 330 331 332 333 334
  def test_copy
    issue = Issue.new.copy_from(1)
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
335
    assert_equal "125", issue.custom_value_for(2).value
336
  end
337 338 339 340

  def test_copy_should_copy_status
    orig = Issue.find(8)
    assert orig.status != IssueStatus.default
341

342 343 344 345 346
    issue = Issue.new.copy_from(orig)
    assert issue.save
    issue.reload
    assert_equal orig.status, issue.status
  end
347

348
  def test_should_close_duplicates
349
    # Create 3 issues
350 351 352
    issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                       :status_id => 1, :priority => IssuePriority.all.first,
                       :subject => 'Duplicates test', :description => 'Duplicates test')
353 354 355 356 357
    assert issue1.save
    issue2 = issue1.clone
    assert issue2.save
    issue3 = issue1.clone
    assert issue3.save
358

359
    # 2 is a dupe of 1
360
    IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
361
    # And 3 is a dupe of 2
362
    IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
363
    # And 3 is a dupe of 1 (circular duplicates)
364
    IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
365

366
    assert issue1.reload.duplicates.include?(issue2)
367

368 369 370 371 372 373
    # Closing issue 1
    issue1.init_journal(User.find(:first), "Closing issue1")
    issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
    assert issue1.save
    # 2 and 3 should be also closed
    assert issue2.reload.closed?
374
    assert issue3.reload.closed?
375
  end
376

377 378
  def test_should_not_close_duplicated_issue
    # Create 3 issues
379 380 381
    issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                       :status_id => 1, :priority => IssuePriority.all.first,
                       :subject => 'Duplicates test', :description => 'Duplicates test')
382 383 384
    assert issue1.save
    issue2 = issue1.clone
    assert issue2.save
385

386 387 388 389
    # 2 is a dupe of 1
    IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
    # 2 is a dup of 1 but 1 is not a duplicate of 2
    assert !issue2.reload.duplicates.include?(issue1)
390

391 392 393 394 395 396 397
    # Closing issue 2
    issue2.init_journal(User.find(:first), "Closing issue2")
    issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
    assert issue2.save
    # 1 should not be also closed
    assert !issue1.reload.closed?
  end
398

399 400 401 402
  def test_assignable_versions
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
    assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  end
403

404 405 406 407 408
  def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
    assert !issue.save
    assert_not_nil issue.errors.on(:fixed_version_id)
  end
409

410 411 412 413 414
  def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
    assert !issue.save
    assert_not_nil issue.errors.on(:fixed_version_id)
  end
415

416 417 418 419
  def test_should_be_able_to_assign_a_new_issue_to_an_open_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
    assert issue.save
  end
420

421 422 423 424 425 426
  def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    assert_equal 'closed', issue.fixed_version.status
    issue.subject = 'Subject changed'
    assert issue.save
  end
427

428 429 430 431 432 433
  def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    assert !issue.save
    assert_not_nil issue.errors.on_base
  end
434

435 436 437 438 439 440
  def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    issue.fixed_version_id = 3
    assert issue.save
  end
441

442 443 444 445 446 447
  def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
    issue = Issue.find(12)
    assert_equal 'locked', issue.fixed_version.status
    issue.status_id = 1
    assert issue.save
  end
448

449
  def test_move_to_another_project_with_same_category
450
    issue = Issue.find(1)
jplang's avatar
jplang committed
451
    assert issue.move_to_project(Project.find(2))
452 453
    issue.reload
    assert_equal 2, issue.project_id
454 455
    # Category changes
    assert_equal 4, issue.category_id
456 457 458
    # Make sure time entries were move to the target project
    assert_equal 2, issue.time_entries.first.project_id
  end
459

460 461
  def test_move_to_another_project_without_same_category
    issue = Issue.find(2)
jplang's avatar
jplang committed
462
    assert issue.move_to_project(Project.find(2))
463 464 465 466 467
    issue.reload
    assert_equal 2, issue.project_id
    # Category cleared
    assert_nil issue.category_id
  end
468

469 470 471
  def test_move_to_another_project_should_clear_fixed_version_when_not_shared
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 1)
jplang's avatar
jplang committed
472
    assert issue.move_to_project(Project.find(2))
473 474 475 476 477
    issue.reload
    assert_equal 2, issue.project_id
    # Cleared fixed_version
    assert_equal nil, issue.fixed_version
  end
478

479 480 481
  def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 4)
jplang's avatar
jplang committed
482
    assert issue.move_to_project(Project.find(5))
483 484 485 486 487
    issue.reload
    assert_equal 5, issue.project_id
    # Keep fixed_version
    assert_equal 4, issue.fixed_version_id
  end
488

489 490 491
  def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 1)
jplang's avatar
jplang committed
492
    assert issue.move_to_project(Project.find(5))
493 494 495 496 497
    issue.reload
    assert_equal 5, issue.project_id
    # Cleared fixed_version
    assert_equal nil, issue.fixed_version
  end
498

499 500 501
  def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 7)
jplang's avatar
jplang committed
502
    assert issue.move_to_project(Project.find(2))
503 504 505 506 507
    issue.reload
    assert_equal 2, issue.project_id
    # Keep fixed_version
    assert_equal 7, issue.fixed_version_id
  end
508

509 510 511 512 513
  def test_move_to_another_project_with_disabled_tracker
    issue = Issue.find(1)
    target = Project.find(2)
    target.tracker_ids = [3]
    target.save
jplang's avatar
jplang committed
514
    assert_equal false, issue.move_to_project(target)
515 516 517
    issue.reload
    assert_equal 1, issue.project_id
  end
518

519 520 521 522
  def test_copy_to_the_same_project
    issue = Issue.find(1)
    copy = nil
    assert_difference 'Issue.count' do
jplang's avatar
jplang committed
523
      copy = issue.move_to_project(issue.project, nil, :copy => true)
524 525 526 527 528
    end
    assert_kind_of Issue, copy
    assert_equal issue.project, copy.project
    assert_equal "125", copy.custom_value_for(2).value
  end
529

530 531 532 533
  def test_copy_to_another_project_and_tracker
    issue = Issue.find(1)
    copy = nil
    assert_difference 'Issue.count' do
jplang's avatar
jplang committed
534
      copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
535
    end
jplang's avatar
jplang committed
536
    copy.reload
537 538 539 540 541 542
    assert_kind_of Issue, copy
    assert_equal Project.find(3), copy.project
    assert_equal Tracker.find(2), copy.tracker
    # Custom field #2 is not associated with target tracker
    assert_nil copy.custom_value_for(2)
  end
543

jplang's avatar
jplang committed
544
  context "#move_to_project" do
545 546 547 548 549
    context "as a copy" do
      setup do
        @issue = Issue.find(1)
        @copy = nil
      end
550

551 552 553 554
      should "not create a journal" do
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
        assert_equal 0, @copy.reload.journals.size
      end
555 556

      should "allow assigned_to changes" do
jplang's avatar
jplang committed
557
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
558 559 560 561
        assert_equal 3, @copy.assigned_to_id
      end

      should "allow status changes" do
jplang's avatar
jplang committed
562
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
563 564 565 566 567
        assert_equal 2, @copy.status_id
      end

      should "allow start date changes" do
        date = Date.today
jplang's avatar
jplang committed
568
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
569 570 571 572 573
        assert_equal date, @copy.start_date
      end

      should "allow due date changes" do
        date = Date.today
jplang's avatar
jplang committed
574
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
575 576 577

        assert_equal date, @copy.due_date
      end
578

579 580 581 582 583 584
      should "set current user as author" do
        User.current = User.find(9)
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})

        assert_equal User.current, @copy.author
      end
585

586 587 588 589 590 591 592 593 594 595 596 597
      should "keep journal notes" do
        date = Date.today
        notes = "Notes added when copying"
        User.current = User.find(9)
        @issue.init_journal(User.current, notes)
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})

        assert_equal 1, @copy.journals.size
        journal = @copy.journals.first
        assert_equal 0, journal.details.size
        assert_equal notes, journal.notes
      end
598 599
    end
  end
600

601 602 603 604
  def test_recipients_should_not_include_users_that_cannot_view_the_issue
    issue = Issue.find(12)
    assert issue.recipients.include?(issue.author.mail)
    # move the issue to a private project
jplang's avatar
jplang committed
605
    copy  = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
606 607 608
    # author is not a member of project anymore
    assert !copy.recipients.include?(copy.author.mail)
  end
609

610 611 612 613
  def test_recipients_should_include_the_assigned_group_members
    group_member = User.generate_with_protected!
    group = Group.generate!
    group.users << group_member
614

615 616 617 618
    issue = Issue.find(12)
    issue.assigned_to = group
    assert issue.recipients.include?(group_member.mail)
  end
619 620 621 622 623 624 625 626

  def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
    user = User.find(3)
    issue = Issue.find(9)
    Watcher.create!(:user => user, :watchable => issue)
    assert issue.watched_by?(user)
    assert !issue.watcher_recipients.include?(user.mail)
  end
627

628 629 630 631 632
  def test_issue_destroy
    Issue.find(1).destroy
    assert_nil Issue.find_by_id(1)
    assert_nil TimeEntry.find_by_issue_id(1)
  end
633

634 635 636
  def test_blocked
    blocked_issue = Issue.find(9)
    blocking_issue = Issue.find(10)
637

638 639 640
    assert blocked_issue.blocked?
    assert !blocking_issue.blocked?
  end
641

642 643
  def test_blocked_issues_dont_allow_closed_statuses
    blocked_issue = Issue.find(9)
644

645 646 647 648 649
    allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
    assert !allowed_statuses.empty?
    closed_statuses = allowed_statuses.select {|st| st.is_closed?}
    assert closed_statuses.empty?
  end
650

651 652
  def test_unblocked_issues_allow_closed_statuses
    blocking_issue = Issue.find(10)
653

654 655 656 657 658
    allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
    assert !allowed_statuses.empty?
    closed_statuses = allowed_statuses.select {|st| st.is_closed?}
    assert !closed_statuses.empty?
  end
659

660 661 662 663 664
  def test_rescheduling_an_issue_should_reschedule_following_issue
    issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
    issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
    IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
    assert_equal issue1.due_date + 1, issue2.reload.start_date
665

666 667 668 669
    issue1.due_date = Date.today + 5
    issue1.save!
    assert_equal issue1.due_date + 1, issue2.reload.start_date
  end
670

671
  def test_overdue
672
    assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
673
    assert !Issue.new(:due_date => Date.today).overdue?
674
    assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
675
    assert !Issue.new(:due_date => nil).overdue?
676
    assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
677
  end
edavis10's avatar
edavis10 committed
678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699

  context "#behind_schedule?" do
    should "be false if the issue has no start_date" do
      assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
    end

    should "be false if the issue has no end_date" do
      assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
    end

    should "be false if the issue has more done than it's calendar time" do
      assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
    end

    should "be true if the issue hasn't been started at all" do
      assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
    end

    should "be true if the issue has used more calendar time than it's done ratio" do
      assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
    end
  end
700 701 702 703 704 705 706 707 708 709 710 711 712

  context "#assignable_users" do
    should "be Users" do
      assert_kind_of User, Issue.find(1).assignable_users.first
    end

    should "include the issue author" do
      project = Project.find(1)
      non_project_member = User.generate!
      issue = Issue.generate_for_project!(project, :author => non_project_member)

      assert issue.assignable_users.include?(non_project_member)
    end
713

714 715 716 717 718 719 720 721 722
    should "include the current assignee" do
      project = Project.find(1)
      user = User.generate!
      issue = Issue.generate_for_project!(project, :assigned_to => user)
      user.lock!

      assert Issue.find(issue.id).assignable_users.include?(user)
    end

723 724 725
    should "not show the issue author twice" do
      assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
      assert_equal 2, assignable_user_ids.length
726

727
      assignable_user_ids.each do |user_id|
728
        assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
729 730
      end
    end
731

732 733 734
    context "with issue_group_assignment" do
      should "include groups" do
        issue = Issue.new(:project => Project.find(2))
735

736 737 738 739 740 741
        with_settings :issue_group_assignment => '1' do
          assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
          assert issue.assignable_users.include?(Group.find(11))
        end
      end
    end
742

743 744 745
    context "without issue_group_assignment" do
      should "not include groups" do
        issue = Issue.new(:project => Project.find(2))
746

747 748 749 750 751 752
        with_settings :issue_group_assignment => '0' do
          assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
          assert !issue.assignable_users.include?(Group.find(11))
        end
      end
    end
753
  end
754

755 756
  def test_create_should_send_email_notification
    ActionMailer::Base.deliveries.clear
757 758 759 760
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 3, :status_id => 1,
                      :priority => IssuePriority.all.first,
                      :subject => 'test_create', :estimated_hours => '1:30')
761 762 763 764

    assert issue.save
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
edavis10's avatar
edavis10 committed
765

766 767 768 769
  def test_stale_issue_should_not_send_email_notification
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    stale = Issue.find(1)
770

771 772 773 774 775
    issue.init_journal(User.find(1))
    issue.subject = 'Subjet update'
    assert issue.save
    assert_equal 1, ActionMailer::Base.deliveries.size
    ActionMailer::Base.deliveries.clear
776

777 778 779 780 781 782 783
    stale.init_journal(User.find(1))
    stale.subject = 'Another subjet update'
    assert_raise ActiveRecord::StaleObjectError do
      stale.save
    end
    assert ActionMailer::Base.deliveries.empty?
  end
784

785
  def test_journalized_description
jplang's avatar
jplang committed
786
    IssueCustomField.delete_all
787

788 789 790
    i = Issue.first
    old_description = i.description
    new_description = "This is the new description"
791

792 793 794 795 796 797 798
    i.init_journal(User.find(2))
    i.description = new_description
    assert_difference 'Journal.count', 1 do
      assert_difference 'JournalDetail.count', 1 do
        i.save!
      end
    end
799

800 801 802 803 804 805 806
    detail = JournalDetail.first(:order => 'id DESC')
    assert_equal i, detail.journal.journalized
    assert_equal 'attr', detail.property
    assert_equal 'description', detail.prop_key
    assert_equal old_description, detail.old_value
    assert_equal new_description, detail.value
  end
807

808 809 810
  def test_blank_descriptions_should_not_be_journalized
    IssueCustomField.delete_all
    Issue.update_all("description = NULL", "id=1")
811

812
    i = Issue.find(1)
813 814 815
    i.init_journal(User.find(2))
    i.subject = "blank description"
    i.description = "\r\n"
816

817 818 819 820 821 822
    assert_difference 'Journal.count', 1 do
      assert_difference 'JournalDetail.count', 1 do
        i.save!
      end
    end
  end
823

824 825 826 827
  def test_description_eol_should_be_normalized
    i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
    assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
  end
828

829 830 831
  def test_saving_twice_should_not_duplicate_journal_details
    i = Issue.find(:first)
    i.init_journal(User.find(2), 'Some notes')
832
    # initial changes
833 834 835
    i.subject = 'New subject'
    i.done_ratio = i.done_ratio + 10
    assert_difference 'Journal.count' do
836
      assert i.save
837 838 839 840 841 842 843 844 845 846 847 848 849 850 851
    end
    # 1 more change
    i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
    assert_no_difference 'Journal.count' do
      assert_difference 'JournalDetail.count', 1 do
        i.save
      end
    end
    # no more change
    assert_no_difference 'Journal.count' do
      assert_no_difference 'JournalDetail.count' do
        i.save
      end
    end
  end
852

853 854
  def test_all_dependent_issues
    IssueRelation.delete_all
855 856 857 858 859 860 861 862 863
    assert IssueRelation.create!(:issue_from => Issue.find(1),
                                 :issue_to   => Issue.find(2),
                                 :relation_type => IssueRelation::TYPE_PRECEDES)
    assert IssueRelation.create!(:issue_from => Issue.find(2),
                                 :issue_to   => Issue.find(3),
                                 :relation_type => IssueRelation::TYPE_PRECEDES)
    assert IssueRelation.create!(:issue_from => Issue.find(3),
                                 :issue_to   => Issue.find(8),
                                 :relation_type => IssueRelation::TYPE_PRECEDES)
864

865 866 867 868 869
    assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
  end

  def test_all_dependent_issues_with_persistent_circular_dependency
    IssueRelation.delete_all
tmaruyama's avatar
tmaruyama committed
870 871 872 873 874 875
    assert IssueRelation.create!(:issue_from => Issue.find(1),
                                 :issue_to   => Issue.find(2),
                                 :relation_type => IssueRelation::TYPE_PRECEDES)
    assert IssueRelation.create!(:issue_from => Issue.find(2),
                                 :issue_to   => Issue.find(3),
                                 :relation_type => IssueRelation::TYPE_PRECEDES)
876
    # Validation skipping
tmaruyama's avatar
tmaruyama committed
877 878 879
    assert IssueRelation.new(:issue_from => Issue.find(3),
                             :issue_to   => Issue.find(1),
                             :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
880

881 882
    assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
  end
883 884 885

  def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
    IssueRelation.delete_all
tmaruyama's avatar
tmaruyama committed
886 887 888 889 890 891 892 893 894
    assert IssueRelation.create!(:issue_from => Issue.find(1),
                                 :issue_to   => Issue.find(2),
                                 :relation_type => IssueRelation::TYPE_RELATES)
    assert IssueRelation.create!(:issue_from => Issue.find(2),
                                 :issue_to   => Issue.find(3),
                                 :relation_type => IssueRelation::TYPE_RELATES)
    assert IssueRelation.create!(:issue_from => Issue.find(3),
                                 :issue_to   => Issue.find(8),
                                 :relation_type => IssueRelation::TYPE_RELATES)
895
    # Validation skipping
tmaruyama's avatar
tmaruyama committed
896 897 898 899 900 901
    assert IssueRelation.new(:issue_from => Issue.find(8),
                             :issue_to   => Issue.find(2),
                             :relation_type => IssueRelation::TYPE_RELATES).save(false)
    assert IssueRelation.new(:issue_from => Issue.find(3),
                             :issue_to   => Issue.find(1),
                             :relation_type => IssueRelation::TYPE_RELATES).save(false)
902

903 904
    assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
  end
905

906 907 908 909 910
  context "#done_ratio" do
    setup do
      @issue = Issue.find(1)
      @issue_status = IssueStatus.find(1)
      @issue_status.update_attribute(:default_done_ratio, 50)
911 912 913
      @issue2 = Issue.find(2)
      @issue_status2 = IssueStatus.find(2)
      @issue_status2.update_attribute(:default_done_ratio, 0)
914
    end
915

916 917 918 919
    context "with Setting.issue_done_ratio using the issue_field" do
      setup do
        Setting.issue_done_ratio = 'issue_field'
      end
920

921 922
      should "read the issue's field" do
        assert_equal 0, @issue.done_ratio
923
        assert_equal 30, @issue2.done_ratio
924 925 926 927 928 929 930
      end
    end

    context "with Setting.issue_done_ratio using the issue_status" do
      setup do
        Setting.issue_done_ratio = 'issue_status'
      end
931

932 933
      should "read the Issue Status's default done ratio" do
        assert_equal 50, @issue.done_ratio
934
        assert_equal 0, @issue2.done_ratio
935 936 937 938 939 940 941 942 943
      end
    end
  end

  context "#update_done_ratio_from_issue_status" do
    setup do
      @issue = Issue.find(1)
      @issue_status = IssueStatus.find(1)
      @issue_status.update_attribute(:default_done_ratio, 50)
944 945 946
      @issue2 = Issue.find(2)
      @issue_status2 = IssueStatus.find(2)
      @issue_status2.update_attribute(:default_done_ratio, 0)
947
    end
948

949 950 951 952
    context "with Setting.issue_done_ratio using the issue_field" do
      setup do
        Setting.issue_done_ratio = 'issue_field'
      end
953

954 955
      should "not change the issue" do
        @issue.update_done_ratio_from_issue_status
956
        @issue2.update_done_ratio_from_issue_status
957

958 959
        assert_equal 0, @issue.read_attribute(:done_ratio)
        assert_equal 30, @issue2.read_attribute(:done_ratio)
960 961 962 963 964 965 966
      end
    end

    context "with Setting.issue_done_ratio using the issue_status" do
      setup do
        Setting.issue_done_ratio = 'issue_status'
      end
967

968
      should "change the issue's done ratio" do
969
        @issue.update_done_ratio_from_issue_status
970
        @issue2.update_done_ratio_from_issue_status
971

972 973
        assert_equal 50, @issue.read_attribute(:done_ratio)
        assert_equal 0, @issue2.read_attribute(:done_ratio)
974 975 976
      end
    end
  end
977 978

  test "#by_tracker" do
979
    User.current = User.anonymous
980 981 982 983 984 985
    groups = Issue.by_tracker(Project.find(1))
    assert_equal 3, groups.size
    assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  end

  test "#by_version" do
986
    User.current = User.anonymous
987 988 989 990 991 992
    groups = Issue.by_version(Project.find(1))
    assert_equal 3, groups.size
    assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  end

  test "#by_priority" do
993
    User.current = User.anonymous
994 995 996 997 998 999
    groups = Issue.by_priority(Project.find(1))
    assert_equal 4, groups.size
    assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  end

  test "#by_category" do
1000
    User.current = User.anonymous
1001 1002 1003 1004 1005 1006
    groups = Issue.by_category(Project.find(1))
    assert_equal 2, groups.size
    assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  end

  test "#by_assigned_to" do
1007
    User.current = User.anonymous
1008 1009 1010 1011 1012 1013
    groups = Issue.by_assigned_to(Project.find(1))
    assert_equal 2, groups.size
    assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  end

  test "#by_author" do
1014
    User.current = User.anonymous
1015 1016 1017 1018 1019 1020
    groups = Issue.by_author(Project.find(1))
    assert_equal 4, groups.size
    assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  end

  test "#by_subproject" do
1021
    User.current = User.anonymous
1022
    groups = Issue.by_subproject(Project.find(1))
1023 1024 1025
    # Private descendant not visible
    assert_equal 1, groups.size
    assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1026
  end
1027

1028 1029 1030 1031 1032
  context ".allowed_target_projects_on_move" do
    should "return all active projects for admin users" do
      User.current = User.find(1)
      assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
    end
1033

1034 1035 1036 1037
    should "return allowed projects for non admin users" do
      User.current = User.find(2)
      Role.non_member.remove_permission! :move_issues
      assert_equal 3, Issue.allowed_target_projects_on_move.size
1038

1039 1040 1041 1042
      Role.non_member.add_permission! :move_issues
      assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
    end
  end
1043 1044 1045 1046 1047 1048 1049 1050 1051

  def test_recently_updated_with_limit_scopes
    #should return the last updated issue
    assert_equal 1, Issue.recently_updated.with_limit(1).length
    assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
  end

  def test_on_active_projects_scope
    assert Project.find(2).archive
1052

1053 1054 1055 1056 1057 1058 1059