issue_test.rb 92.7 KB
Newer Older
1
# Redmine - project management software
marutosijp's avatar
marutosijp committed
2
# Copyright (C) 2006-2014  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
jplang's avatar
jplang committed
21
  fixtures :projects, :users, :members, :member_roles, :roles,
22
           :groups_users,
23
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
24
           :enabled_modules,
25
           :versions,
26
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
27
           :enumerations,
28
           :issues, :journals, :journal_details,
29 30
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
31

32 33
  include Redmine::I18n

34 35 36 37
  def teardown
    User.current = nil
  end

38 39 40 41 42 43 44 45 46 47 48 49 50
  def test_initialize
    issue = Issue.new

    assert_nil issue.project_id
    assert_nil issue.tracker_id
    assert_nil issue.author_id
    assert_nil issue.assigned_to_id
    assert_nil issue.category_id

    assert_equal IssueStatus.default, issue.status
    assert_equal IssuePriority.default, issue.priority
  end

51
  def test_create
52 53 54 55
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
56 57 58 59
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
60

61
  def test_create_minimal
62 63 64
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create')
65 66
    assert issue.save
    assert issue.description.nil?
67
    assert_nil issue.estimated_hours
68
  end
69

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87
  def test_start_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:start_date => invalid_date)
      assert !issue.valid?
      assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

  def test_due_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:due_date => invalid_date)
      assert !issue.valid?
      assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

88 89 90 91 92 93 94
  def test_due_date_lesser_than_start_date_should_not_validate
    set_language_if_valid 'en'
    issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
    assert !issue.valid?
    assert_include 'Due date must be greater than start date', issue.errors.full_messages
  end

95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
  def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
    issue = Issue.generate(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    assert !issue.valid?
    assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  end

  def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
    issue = Issue.generate!(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    issue.start_date = '2013-06-07'
    assert !issue.valid?
    assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  end

  def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
    issue = Issue.generate!(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    assert issue.valid?
  end

116 117 118 119 120 121 122 123 124
  def test_estimated_hours_should_be_validated
    set_language_if_valid 'en'
    ['-2'].each do |invalid|
      issue = Issue.new(:estimated_hours => invalid)
      assert !issue.valid?
      assert_include 'Estimated time is invalid', issue.errors.full_messages
    end
  end

125
  def test_create_with_required_custom_field
126
    set_language_if_valid 'en'
127 128
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
129

130 131 132
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
133 134 135
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
136
    assert_equal ["Database can't be blank"], issue.errors.full_messages
137 138 139
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
140
    assert_equal ["Database can't be blank"], issue.errors.full_messages
141 142 143
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
144
    assert_equal ["Database is not included in the list"], issue.errors.full_messages
145 146 147 148 149 150
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
151

152 153
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
154 155 156
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
157
      issue = Issue.order('id DESC').first
158 159 160 161
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
162

163
  def test_create_with_parent_issue_id
164 165 166
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => 1)
167 168 169 170 171
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

172 173 174 175 176 177 178 179 180
  def test_create_with_sharp_parent_issue_id
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => "#1")
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

181
  def test_create_with_invalid_parent_issue_id
182
    set_language_if_valid 'en'
183 184 185
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '01ABC')
186 187 188 189 190
    assert !issue.save
    assert_equal '01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

191 192 193 194 195 196 197 198 199 200
  def test_create_with_invalid_sharp_parent_issue_id
    set_language_if_valid 'en'
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '#01ABC')
    assert !issue.save
    assert_equal '#01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

201 202 203 204
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
205 206
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
jplang's avatar
jplang committed
207
    issues = Issue.visible(User.anonymous).to_a
jplang's avatar
jplang committed
208 209
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
210
    assert_nil issues.detect {|issue| issue.is_private?}
211 212
    assert_visibility_match User.anonymous, issues
  end
213

214
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
215 216
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
jplang's avatar
jplang committed
217
    issues = Issue.visible(User.anonymous).to_a
jplang's avatar
jplang committed
218
    assert issues.empty?
219
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
220
  end
221

222 223 224 225 226 227 228 229 230 231
  def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
    Role.anonymous.remove_permission!(:view_issues)
    Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])

    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_equal [1], issues.map(&:project_id).uniq.sort
    assert_visibility_match User.anonymous, issues
  end

232 233
  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
    assert Role.anonymous.update_attribute(:issues_visibility, 'default')
234
    issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
235 236 237 238 239 240
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
    assert Role.anonymous.update_attribute(:issues_visibility, 'own')
241
    issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
242 243 244 245
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

246
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
247 248 249
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
jplang's avatar
jplang committed
250
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
251 252
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
253
    assert_nil issues.detect {|issue| issue.is_private?}
254 255
    assert_visibility_match user, issues
  end
256

257 258 259 260
  def test_visible_scope_for_non_member_with_own_issues_visibility
    Role.non_member.update_attribute :issues_visibility, 'own'
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
261

jplang's avatar
jplang committed
262
    issues = Issue.visible(user).to_a
263 264 265 266
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
267

268
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
269 270
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
271 272
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
273
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
274
    assert issues.empty?
275 276
    assert_visibility_match user, issues
  end
277

278 279 280 281 282 283 284 285 286 287 288
  def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
    Role.non_member.remove_permission!(:view_issues)
    Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
    user = User.find(9)

    issues = Issue.visible(user).all
    assert issues.any?
    assert_equal [1], issues.map(&:project_id).uniq.sort
    assert_visibility_match user, issues
  end

289 290
  def test_visible_scope_for_member
    user = User.find(9)
291
    # User should see issues of projects for which user has view_issues permissions only
292
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
293
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
294
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
295
    assert issues.any?
jplang's avatar
jplang committed
296 297
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
298
    assert_visibility_match user, issues
jplang's avatar
jplang committed
299
  end
300

301 302 303 304 305
  def test_visible_scope_for_member_with_groups_should_return_assigned_issues
    user = User.find(8)
    assert user.groups.any?
    Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
    Role.non_member.remove_permission!(:view_issues)
306

307 308 309 310 311
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
      :status_id => 1, :priority => IssuePriority.all.first,
      :subject => 'Assignment test',
      :assigned_to => user.groups.first,
      :is_private => true)
312

313
    Role.find(2).update_attribute :issues_visibility, 'default'
jplang's avatar
jplang committed
314
    issues = Issue.visible(User.find(8)).to_a
315 316
    assert issues.any?
    assert issues.include?(issue)
317

318
    Role.find(2).update_attribute :issues_visibility, 'own'
jplang's avatar
jplang committed
319
    issues = Issue.visible(User.find(8)).to_a
320 321 322 323
    assert issues.any?
    assert issues.include?(issue)
  end

jplang's avatar
jplang committed
324 325 326 327
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
jplang's avatar
jplang committed
328
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
329
    assert issues.any?
330
    # Admin should see issues on private projects that admin does not belong to
jplang's avatar
jplang committed
331
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
332 333
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
334
    assert_visibility_match user, issues
jplang's avatar
jplang committed
335
  end
336

337 338
  def test_visible_scope_with_project
    project = Project.find(1)
jplang's avatar
jplang committed
339
    issues = Issue.visible(User.find(2), :project => project).to_a
340 341 342 343
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
344

345 346
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
jplang's avatar
jplang committed
347
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
348 349 350 351
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
352

353
  def test_visible_and_nested_set_scopes
354 355 356 357 358 359 360 361 362 363 364 365
    user = User.generate!
    parent = Issue.generate!(:assigned_to => user)
    assert parent.visible?(user)
    child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
    child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
    parent.reload
    child1.reload
    child2.reload
    assert child1.visible?(user)
    assert child2.visible?(user)
    assert_equal 2, parent.descendants.count
    assert_equal 2, parent.descendants.visible(user).count
366
    # awesome_nested_set 2-1-stable branch has regression.
367 368 369 370
    # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
    # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
    assert_equal 2, parent.descendants.collect{|i| i}.size
    assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
371
  end
372

jplang's avatar
jplang committed
373 374 375 376 377 378 379
  def test_visible_scope_with_unsaved_user_should_not_raise_an_error
    user = User.new
    assert_nothing_raised do
      Issue.visible(user).to_a
    end
  end

380
  def test_open_scope
jplang's avatar
jplang committed
381
    issues = Issue.open.to_a
382 383 384 385
    assert_nil issues.detect(&:closed?)
  end

  def test_open_scope_with_arg
jplang's avatar
jplang committed
386
    issues = Issue.open(false).to_a
387 388 389
    assert_equal issues, issues.select(&:closed?)
  end

390 391 392 393 394 395 396 397 398 399
  def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
    version = Version.find(2)
    assert version.fixed_issues.any?
    assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  end

  def test_fixed_version_scope_with_empty_array_should_return_no_result
    assert_equal 0, Issue.fixed_version([]).count
  end

400 401
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
402

tmaruyama's avatar
tmaruyama committed
403 404 405
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
406 407 408
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
409

410 411
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
tmaruyama's avatar
tmaruyama committed
412 413
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                 issue.errors.full_messages.first
414
  end
415

416 417 418
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
419

420 421 422 423 424 425 426 427 428 429 430 431 432 433
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
434

435 436 437 438
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
439

440 441 442
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
443

444 445 446
    issue.reload
    assert_equal "Can't print recipes", issue.subject
  end
447

448 449
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
450

451 452 453 454 455 456 457 458 459 460
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
461

462
  def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
tmaruyama's avatar
tmaruyama committed
463 464 465
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
                          :status_id => 1, :subject => 'Test',
                          :custom_field_values => {'2' => 'Test'})
466 467 468 469 470 471 472 473 474 475 476
    assert !Tracker.find(2).custom_field_ids.include?(2)

    issue = Issue.find(issue.id)
    issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}

    issue = Issue.find(issue.id)
    custom_value = issue.custom_value_for(2)
    assert_not_nil custom_value
    assert_equal 'Test', custom_value.value
  end

477 478 479 480 481 482
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
483

484 485 486 487 488 489 490 491 492 493
  def test_assigning_attributes_should_assign_project_and_tracker_first
    seq = sequence('seq')
    issue = Issue.new
    issue.expects(:project_id=).in_sequence(seq)
    issue.expects(:tracker_id=).in_sequence(seq)
    issue.expects(:subject=).in_sequence(seq)
    issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  end

  def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
494 495 496 497 498
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
499
    assert_equal 'MySQL', issue.custom_field_value(1)
500
  end
501

502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
  def test_reload_should_reload_custom_field_values
    issue = Issue.generate!
    issue.custom_field_values = {'2' => 'Foo'}
    issue.save!

    issue = Issue.order('id desc').first
    assert_equal 'Foo', issue.custom_field_value(2)

    issue.custom_field_values = {'2' => 'Bar'}
    assert_equal 'Bar', issue.custom_field_value(2)

    issue.reload
    assert_equal 'Foo', issue.custom_field_value(2)
  end

517 518 519
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
520

521 522
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
523

524 525 526 527
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
528

529 530 531
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
532

533 534 535 536
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
537
    assert_not_equal [], issue.errors[:tracker_id]
538
  end
539

540
  def test_category_based_assignment
541 542 543 544
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
545 546
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
547

548
  def test_new_statuses_allowed_to
549
    WorkflowTransition.delete_all
550 551 552 553 554 555
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 2,
                               :author => false, :assignee => false)
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 3,
                               :author => true, :assignee => false)
556 557 558
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 4,
                               :author => false, :assignee => true)
559 560 561
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 5,
                               :author => true, :assignee => true)
562 563 564 565
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
566

567 568
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1)
569
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
570

571 572
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user)
jplang's avatar
jplang committed
573
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
574

575 576 577
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1,
                            :assigned_to => user)
jplang's avatar
jplang committed
578
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
579

580 581 582
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user,
                            :assigned_to => user)
583
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603

    group = Group.generate!
    group.users << user
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user,
                            :assigned_to => group)
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  end

  def test_new_statuses_allowed_to_should_consider_group_assignment
    WorkflowTransition.delete_all
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 4,
                               :author => false, :assignee => true)
    user = User.find(2)
    group = Group.generate!
    group.users << user
 
    issue = Issue.generate!(:author_id => 1, :assigned_to => group)
    assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
604
  end
605

606 607 608 609
  def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
    admin = User.find(1)
    issue = Issue.find(1)
    assert !admin.member_of?(issue.project)
610
    expected_statuses = [issue.status] +
611
                            WorkflowTransition.where(:old_status_id => issue.status_id).
612
                                map(&:new_status).uniq.sort
613 614 615
    assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  end

616 617 618 619 620 621 622
  def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
    issue = Issue.find(1).copy
    assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)

    issue = Issue.find(2).copy
    assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  end
623

624
  def test_safe_attributes_names_should_not_include_disabled_field
625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655
    tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))

    issue = Issue.new(:tracker => tracker)
    assert_include 'tracker_id', issue.safe_attribute_names
    assert_include 'status_id', issue.safe_attribute_names
    assert_include 'subject', issue.safe_attribute_names
    assert_include 'description', issue.safe_attribute_names
    assert_include 'custom_field_values', issue.safe_attribute_names
    assert_include 'custom_fields', issue.safe_attribute_names
    assert_include 'lock_version', issue.safe_attribute_names

    tracker.core_fields.each do |field|
      assert_include field, issue.safe_attribute_names
    end

    tracker.disabled_core_fields.each do |field|
      assert_not_include field, issue.safe_attribute_names
    end
  end

  def test_safe_attributes_should_ignore_disabled_fields
    tracker = Tracker.find(1)
    tracker.core_fields = %w(assigned_to_id due_date)
    tracker.save!

    issue = Issue.new(:tracker => tracker)
    issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
    assert_nil issue.start_date
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end

656
  def test_safe_attributes_should_accept_target_tracker_enabled_fields
657 658 659 660 661 662 663 664 665 666 667 668
    source = Tracker.find(1)
    source.core_fields = []
    source.save!
    target = Tracker.find(2)
    target.core_fields = %w(assigned_to_id due_date)
    target.save!

    issue = Issue.new(:tracker => source)
    issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
    assert_equal target, issue.tracker
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end
669 670 671

  def test_safe_attributes_should_not_include_readonly_fields
    WorkflowPermission.delete_all
672 673 674
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
675 676 677 678 679 680 681 682 683 684 685 686
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
    assert_not_include 'due_date', issue.safe_attribute_names(user)

    issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
    assert_equal Date.parse('2012-07-14'), issue.start_date
    assert_nil issue.due_date
  end

  def test_safe_attributes_should_not_include_readonly_custom_fields
tmaruyama's avatar
tmaruyama committed
687 688 689 690 691 692
    cf1 = IssueCustomField.create!(:name => 'Writable field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
    cf2 = IssueCustomField.create!(:name => 'Readonly field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
693
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
694 695 696
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf2.id.to_s,
                               :rule => 'readonly')
697 698 699 700 701
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
    assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)

tmaruyama's avatar
tmaruyama committed
702 703 704
    issue.send :safe_attributes=, {'custom_field_values' => {
                                       cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
                                     }}, user
705 706 707
    assert_equal 'value1', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)

tmaruyama's avatar
tmaruyama committed
708 709 710 711
    issue.send :safe_attributes=, {'custom_fields' => [
                                      {'id' => cf1.id.to_s, 'value' => 'valuea'},
                                      {'id' => cf2.id.to_s, 'value' => 'valueb'}
                                    ]}, user
712 713 714 715 716
    assert_equal 'valuea', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)
  end

  def test_editable_custom_field_values_should_return_non_readonly_custom_values
tmaruyama's avatar
tmaruyama committed
717 718 719 720
    cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
    cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
721
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
722 723
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
                               :field_name => cf2.id.to_s, :rule => 'readonly')
724 725 726 727 728 729 730 731 732 733 734 735 736
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert_nil values.detect {|value| value.custom_field == cf2}

    issue.tracker_id = 2
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert values.detect {|value| value.custom_field == cf2}
  end

737 738 739 740 741 742 743 744 745 746
  def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
    enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
    disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)

    assert_include enabled_cf, issue.editable_custom_fields(user)
    assert_not_include disabled_cf, issue.editable_custom_fields(user)
  end

747 748
  def test_safe_attributes_should_accept_target_tracker_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
749 750 751 752 753 754
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
755 756 757 758
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
759 760
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'}, user
761 762 763
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
764 765 766
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                   'due_date' => '2012-07-16',
                                   'tracker_id' => 2}, user
767 768 769 770 771 772
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_safe_attributes_should_accept_target_status_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
773 774 775 776 777 778
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
779 780 781 782
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
783 784 785
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'},
                                   user
786 787 788
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
789 790 791 792
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                    'due_date' => '2012-07-16',
                                    'status_id' => 2},
                                  user
793 794 795 796 797
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_required_attributes_should_be_validated
798 799
    cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
                                  :is_for_all => true, :tracker_ids => [1, 2])
800 801

    WorkflowPermission.delete_all
802 803 804 805 806 807 808 809 810
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'category_id',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
811

812 813 814 815 816 817
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
818 819
    user = User.find(2)

820 821 822 823 824
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :status_id => 1, :subject => 'Required fields',
                      :author => user)
    assert_equal [cf.id.to_s, "category_id", "due_date"],
                 issue.required_attribute_names(user).sort
825
    assert !issue.save, "Issue was saved"
826 827
    assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
                  issue.errors.full_messages.sort
828 829 830 831

    issue.tracker_id = 2
    assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
    assert !issue.save, "Issue was saved"
832 833
    assert_equal ["Foo can't be blank", "Start date can't be blank"],
                 issue.errors.full_messages.sort
834 835 836 837 838 839 840 841

    issue.start_date = Date.today
    issue.custom_field_values = {cf.id.to_s => 'bar'}
    assert issue.save
  end

  def test_required_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
842 843 844 845 846 847
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
848 849 850 851 852 853 854 855 856 857
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
858 859 860
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 2, :field_name => 'due_date',
                               :rule => 'required')
861 862 863 864 865 866
    assert_equal %w(due_date), issue.required_attribute_names(user)

    member.role_ids = [1, 2, 3]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
867 868 869
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 2, :field_name => 'due_date',
                               :rule => 'readonly')
870 871 872 873 874 875
    # required + readonly => required
    assert_equal %w(due_date), issue.required_attribute_names(user)
  end

  def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
876 877 878 879 880 881
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
882 883 884 885 886 887 888 889 890 891
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.read_only_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
892 893 894
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                              :role_id => 2, :field_name => 'due_date',
                              :rule => 'readonly')
895 896
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
  end
897

898 899
  def test_copy
    issue = Issue.new.copy_from(1)
900
    assert issue.copy?
901 902 903 904 905
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
906
    assert_equal "125", issue.custom_value_for(2).value
907
  end
908 909 910 911

  def test_copy_should_copy_status
    orig = Issue.find(8)
    assert orig.status != IssueStatus.default
912

913 914 915 916 917
    issue = Issue.new.copy_from(orig)
    assert issue.save
    issue.reload
    assert_equal orig.status, issue.status
  end
918

919 920 921 922 923 924 925 926 927 928 929 930 931
  def test_copy_should_add_relation_with_copied_issue
    copied = Issue.find(1)
    issue = Issue.new.copy_from(copied)
    assert issue.save
    issue.reload

    assert_equal 1, issue.relations.size
    relation = issue.relations.first
    assert_equal 'copied_to', relation.relation_type
    assert_equal copied, relation.issue_from
    assert_equal issue, relation.issue_to
  end

932
  def test_copy_should_copy_subtasks
933
    issue = Issue.generate_with_descendants!
934 935 936 937 938 939 940 941 942 943 944 945 946

    copy = issue.reload.copy
    copy.author = User.find(7)
    assert_difference 'Issue.count', 1+issue.descendants.count do
      assert copy.save
    end
    copy.reload
    assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
    child_copy = copy.children.detect {|c| c.subject == 'Child1'}
    assert_equal %w(Child11), child_copy.children.map(&:subject).sort
    assert_equal copy.author, child_copy.author
  end

947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989
  def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
    parent = Issue.generate!
    child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
    child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')

    copy = parent.reload.copy
    copy.parent_issue_id = parent.id
    copy.author = User.find(7)
    assert_difference 'Issue.count', 3 do
      assert copy.save
    end
    parent.reload
    copy.reload
    assert_equal parent, copy.parent
    assert_equal 3, parent.children.count
    assert_equal 5, parent.descendants.count
    assert_equal 2, copy.children.count
    assert_equal 2, copy.descendants.count
  end

  def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
    parent = Issue.generate!
    child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
    child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')

    copy = parent.reload.copy
    copy.parent_issue_id = child1.id
    copy.author = User.find(7)
    assert_difference 'Issue.count', 3 do
      assert copy.save
    end
    parent.reload
    child1.reload
    copy.reload
    assert_equal child1, copy.parent
    assert_equal 2, parent.children.count
    assert_equal 5, parent.descendants.count
    assert_equal 1, child1.children.count
    assert_equal 3, child1.descendants.count
    assert_equal 2, copy.children.count
    assert_equal 2, copy.descendants.count
  end

990
  def test_copy_should_copy_subtasks_to_target_project
991
    issue = Issue.generate_with_descendants!
992 993 994 995 996 997 998 999 1000

    copy = issue.copy(:project_id => 3)
    assert_difference 'Issue.count', 1+issue.descendants.count do
      assert copy.save
    end
    assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
  end

  def test_copy_should_not_copy_subtasks_twice_when_saving_twice
1001
    issue = Issue.generate_with_descendants!
1002 1003 1004 1005 1006 1007 1008 1009

    copy = issue.reload.copy
    assert_difference 'Issue.count', 1+issue.descendants.count do
      assert copy.save
      assert copy.save
    end
  end

1010
  def test_should_not_call_after_project_change_on_creation
1011 1012
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Test', :author_id => 1)
1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031
    issue.expects(:after_project_change).never
    issue.save!
  end

  def test_should_not_call_after_project_change_on_update
    issue = Issue.find(1)
    issue.project = Project.find(1)
    issue.subject = 'No project change'
    issue.expects(:after_project_change).never
    issue.save!
  end

  def test_should_call_after_project_change_on_project_change
    issue = Issue.find(1)
    issue.project = Project.find(2)
    issue.expects(:after_project_change).once
    issue.save!
  end

1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
  def test_adding_journal_should_update_timestamp
    issue = Issue.find(1)
    updated_on_was = issue.updated_on

    issue.init_journal(User.first, "Adding notes")
    assert_difference 'Journal.count' do
      assert issue.save
    end
    issue.reload

    assert_not_equal updated_on_was, issue.updated_on
  end

1045
  def test_should_close_duplicates
1046
    # Create 3 issues
1047 1048 1049
    issue1 = Issue.generate!
    issue2 = Issue.generate!
    issue3 = Issue.generate!
1050

1051
    # 2 is a dupe of 1
1052 1053
    IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
                          :relation_type => IssueRelation::TYPE_DUPLICATES)
1054
    # And 3 is a dupe of 2
1055 1056
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
                          :relation_type => IssueRelation::TYPE_DUPLICATES)
1057
    # And 3 is a dupe of 1 (circular duplicates)
1058 1059
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
                          :relation_type => IssueRelation::TYPE_DUPLICATES)
1060

1061
    assert issue1.reload.duplicates.include?(issue2)
1062

1063
    # Closing issue 1
jplang's avatar
jplang committed
1064
    issue1.init_journal(User.first, "Closing issue1")
jplang's avatar
jplang committed
1065
    issue1.status = IssueStatus.where(:is_closed => true).first
1066 1067 1068
    assert issue1.save
    # 2 and 3 should be also closed
    assert issue2.reload.closed?
1069
    assert issue3.reload.closed?
1070
  end
1071

1072
  def test_should_not_close_duplicated_issue
1073 1074
    issue1 = Issue.generate!
    issue2 = Issue.generate!
1075

1076
    # 2 is a dupe of 1
1077 1078
    IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
                         :relation_type => IssueRelation::TYPE_DUPLICATES)
1079 1080
    # 2 is a dup of 1 but 1 is not a duplicate of 2
    assert !issue2.reload.duplicates.include?(issue1)
1081

1082
    # Closing issue 2
jplang's avatar
jplang committed
1083
    issue2.init_journal(User.first, "Closing issue2")
jplang's avatar
jplang committed
1084
    issue2.status = IssueStatus.where(:is_closed => true).first
1085 1086 1087 1088
    assert issue2.save
    # 1 should not be also closed
    assert !issue1.reload.closed?
  end
1089

1090
  def test_assignable_versions
1091 1092 1093
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 1,
                      :subject => 'New issue')
1094 1095
    assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  end
1096

1097
  def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
tmaruyama's avatar
tmaruyama committed
1098 1099 1100
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 1,
                      :subject => 'New issue')
1101
    assert !issue.save
1102
    assert_not_equal [], issue.errors[:fixed_version_id]
1103
  end
1104

1105
  def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
tmaruyama's avatar
tmaruyama committed
1106 1107 1108
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 2,
                      :subject => 'New issue')
1109
    assert !issue.save
1110
    assert_not_equal [], issue.errors[:fixed_version_id]
1111
  end
1112

1113
  def test_should_be_able_to_assign_a_new_issue_to_an_open_version
tmaruyama's avatar
tmaruyama committed
1114 1115 1116
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 3,
                      :subject => 'New issue')
1117 1118
    assert issue.save
  end
1119

1120 1121 1122 1123 1124 1125
  def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    assert_equal 'closed', issue.fixed_version.status
    issue.subject = 'Subject changed'
    assert issue.save
  end
1126

1127 1128 1129 1130
  def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    assert !issue.save
1131
    assert_not_equal [], issue.errors[:base]
1132
  end
1133

1134 1135 1136 1137 1138 1139
  def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    issue.fixed_version_id = 3
    assert issue.save
  end
1140

1141 1142 1143 1144 1145 1146
  def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
    issue = Issue.find(12)
    assert_equal 'locked', issue.fixed_version.status
    issue.status_id = 1
    assert issue.save
  end
1147

1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159
  def test_should_not_be_able_to_keep_unshared_version_when_changing_project
    issue = Issue.find(2)
    assert_equal 2, issue.fixed_version_id
    issue.project_id = 3
    assert_nil issue.fixed_version_id
    issue.fixed_version_id = 2
    assert !issue.save
    assert_include 'Target version is not included in the list', issue.errors.full_messages
  end

  def test_should_keep_shared_version_when_changing_project
    Version.find(2).update_attribute :sharing, 'tree'
1160

1161 1162 1163 1164 1165 1166 1167
    issue = Issue.find(2)
    assert_equal 2, issue.fixed_version_id
    issue.project_id = 3
    assert_equal 2, issue.fixed_version_id
    assert issue.save
  end

1168 1169 1170 1171 1172 1173 1174 1175 1176
  def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
    assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  end

  def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
    Project.find(2).disable_module! :issue_tracking
    assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  end

1177
  def test_move_to_another_project_with_same_category