GitLab steht wegen Wartungsarbeiten am Montag, den 10. Mai, zwischen 17:00 und 19:00 Uhr nicht zur Verfügung.

issues_controller_test.rb 45.2 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2008  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require File.dirname(__FILE__) + '/../test_helper'
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
42
           :custom_fields_projects,
43
           :custom_fields_trackers,
44 45
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
46 47
           :journal_details,
           :queries
48 49 50 51 52 53 54
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
55
  
56
  def test_index
57 58
    Setting.default_language = 'en'
    
59 60 61 62 63
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
64 65 66 67 68
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 70
    # project column
    assert_tag :tag => 'th', :content => /Project/
71
  end
72 73 74 75 76 77 78 79 80 81 82
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
83

84 85 86 87 88 89 90 91 92 93 94
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
  
95
  def test_index_with_project
96
    Setting.display_subprojects_issues = 0
97 98 99 100
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
126 127
  end
  
128
  def test_index_with_project_and_default_filter
129 130 131 132
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
    
    query = assigns(:query)
    assert_not_nil query
    # default filter
    assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
  end
  
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1, 
      :fields => ['tracker_id'],
      :operators => {'tracker_id' => '='},
      :values => {'tracker_id' => ['1']} 
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    
    query = assigns(:query)
    assert_not_nil query
    assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
  end
  
  def test_index_with_project_and_empty_filters
    get :index, :project_id => 1, :set_filter => 1, :fields => ['']
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    
    query = assigns(:query)
    assert_not_nil query
    # no filter
    assert_equal({}, query.filters)
164 165
  end
  
jplang's avatar
jplang committed
166 167 168 169 170 171 172 173
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
174
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
175 176 177 178
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
179
    assert_not_nil assigns(:issue_count_by_group)
180 181 182 183 184 185 186
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
187
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
188 189
  end
  
jplang's avatar
jplang committed
190 191 192 193 194
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
195
  def test_index_csv_with_project
196 197
    Setting.default_language = 'en'
    
198 199 200 201
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
202
    assert @response.body.starts_with?("#,")
203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
220 221 222 223 224
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
225
  end
226
  
227 228 229 230 231 232 233 234
  def test_index_pdf_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_not_nil assigns(:issue_count_by_group)
    assert_equal 'application/pdf', @response.content_type
  end
  
235
  def test_index_sort
jplang's avatar
jplang committed
236
    get :index, :sort => 'tracker,id:desc'
237 238
    assert_response :success
    
jplang's avatar
jplang committed
239 240 241 242 243 244 245 246
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
247
  end
248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
  
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
    get :index, :set_filter => 1, :query => { 'column_names' => columns}
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
  end
264

265
  def test_show_by_anonymous
jplang's avatar
jplang committed
266 267 268 269
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
270 271 272 273 274 275 276
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
jplang's avatar
jplang committed
277 278
  end
  
279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
295
  
jplang's avatar
jplang committed
296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
331 332 333
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
334
    assert_template 'journals/index.rxml'
335
    # Inline image
336
    assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
337 338
  end
  
jplang's avatar
jplang committed
339
  def test_show_export_to_pdf
340
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
341 342 343 344 345 346
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

347 348 349 350 351
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
352
    
353
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
354
                                                 :value => 'Default string' }
355 356 357 358 359 360 361 362 363 364 365 366 367
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
368 369 370 371 372 373
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
374
    assert_error_tag :content => /No default issue/
375 376 377 378 379 380 381 382
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
383
    assert_error_tag :content => /No tracker/
384 385
  end
  
386 387
  def test_update_new_form
    @request.session[:user_id] = 2
388
    xhr :post, :new, :project_id => 1,
389 390 391 392 393
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
394 395 396 397 398 399 400 401
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
402
  
403
  def test_post_create
404
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
405
    assert_difference 'Issue.count' do
406
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
407
                 :issue => {:tracker_id => 3,
408
                            :status_id => 2,
edavis10's avatar
edavis10 committed
409 410 411
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
412
                            :start_date => '2010-11-07',
edavis10's avatar
edavis10 committed
413 414 415 416
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
417 418 419 420
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
421
    assert_equal 3, issue.tracker_id
422
    assert_equal 2, issue.status_id
423
    assert_equal Date.parse('2010-11-07'), issue.start_date
424
    assert_nil issue.estimated_hours
425
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
426 427
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
428 429
  end
  
430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449
  def test_post_create_without_start_date
    @request.session[:user_id] = 2
    assert_difference 'Issue.count' do
      post :create, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :status_id => 2,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :start_date => '',
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_nil issue.start_date
  end
  
450
  def test_post_create_and_continue
451
    @request.session[:user_id] = 2
452
    post :create, :project_id => 1, 
453 454 455 456
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
457 458
    assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook',
                         :issue => {:tracker_id => 3}
459 460
  end
  
461
  def test_post_create_without_custom_fields_param
462
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
463
    assert_difference 'Issue.count' do
464
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
465 466 467 468 469 470
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
471
  end
472

473
  def test_post_create_with_required_custom_field_and_without_custom_fields_param
474 475 476 477
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
478
    post :create, :project_id => 1, 
479 480 481 482 483 484 485 486
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
487
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
488 489
  end
  
490
  def test_post_create_with_watchers
491 492 493 494
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
495
      post :create, :project_id => 1, 
496 497 498 499 500 501 502
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
503 504 505
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
506 507 508 509 510 511 512 513 514
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
515
  def test_post_create_subissue
jplang's avatar
jplang committed
516 517 518
    @request.session[:user_id] = 2
    
    assert_difference 'Issue.count' do
519
      post :create, :project_id => 1, 
jplang's avatar
jplang committed
520 521 522 523 524 525 526 527 528
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a child issue',
                            :parent_issue_id => 2}
    end
    issue = Issue.find_by_subject('This is a child issue')
    assert_not_nil issue
    assert_equal Issue.find(2), issue.parent
  end
  
529
  def test_post_create_should_send_a_notification
530 531
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
532
    assert_difference 'Issue.count' do
533
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
534 535 536 537 538 539 540 541
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
542 543 544 545
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
546
  def test_post_create_should_preserve_fields_values_on_validation_failure
547
    @request.session[:user_id] = 2
548
    post :create, :project_id => 1, 
549
               :issue => {:tracker_id => 1,
550 551 552
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
553 554 555 556 557
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
558 559
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
560 561 562 563 564 565 566 567 568 569 570 571 572
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
573
  def test_post_create_should_ignore_non_safe_attributes
574 575
    @request.session[:user_id] = 2
    assert_nothing_raised do
576
      post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
577 578 579
    end
  end
  
580 581 582
  context "without workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
583
      Role.anonymous.add_permission! :add_issues, :add_issue_notes
584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
    end
    
    context "#new" do
      should "propose default status only" do
        get :new, :project_id => 1
        assert_response :success
        assert_template 'new'
        assert_tag :tag => 'select',
          :attributes => {:name => 'issue[status_id]'},
          :children => {:count => 1},
          :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
      end
      
      should "accept default status" do
        assert_difference 'Issue.count' do
599
          post :create, :project_id => 1, 
600 601 602 603 604 605 606 607
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 1}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
      
608 609 610 611 612 613 614 615 616 617 618
      should "accept default status" do
        assert_difference 'Issue.count' do
          post :create, :project_id => 1, 
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 1}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
      
619 620
      should "ignore unauthorized status" do
        assert_difference 'Issue.count' do
621
          post :create, :project_id => 1, 
622 623 624 625 626 627 628 629
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 3}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
    end
630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717
    
    context "#update" do
      should "ignore status change" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "ignore attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal "Can't print recipes", issue.subject
        assert_nil issue.assigned_to
      end
    end
  end
  
  context "with workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
      Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
      Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
      Role.anonymous.add_permission! :add_issues, :add_issue_notes
    end
    
    context "#update" do
      should "accept authorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 3, Issue.find(1).status_id
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "accept authorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal 2, issue.assigned_to_id
      end
      
      should "ignore unauthorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
        end
        issue = Issue.find(1)
        assert_equal "Can't print recipes", issue.subject
      end
    end
    
    context "and :edit_issues permission" do
      setup do
        Role.anonymous.add_permission! :add_issues, :edit_issues
      end

      should "accept authorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 3, Issue.find(1).status_id
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "accept authorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal "changed", issue.subject
        assert_equal 2, issue.assigned_to_id
      end
    end
718 719
  end
  
720 721 722 723 724 725 726 727 728
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
jplang's avatar
jplang committed
729 730 731 732 733 734 735 736
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
  end
759 760 761

  def test_update_edit_form
    @request.session[:user_id] = 2
762
    xhr :post, :new, :project_id => 1,
763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
                             :id => 1,
                             :issue => {:tracker_id => 2, 
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
    assert_response :success
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.id
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
778
  
779 780 781 782 783 784 785 786 787 788 789 790 791 792
  def test_update_using_invalid_http_verbs
    @request.session[:user_id] = 2
    subject = 'Updated by an invalid http verb'

    get :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    post :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    delete :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject
  end

793
  def test_put_update_without_custom_fields_param
jplang's avatar
jplang committed
794
    @request.session[:user_id] = 2
795 796 797
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
798
    assert_equal '125', issue.custom_value_for(2).value
799 800 801
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
802 803
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
804
        put :update, :id => 1, :issue => {:subject => new_subject,
805 806 807 808 809
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
810
    assert_redirected_to :action => 'show', :id => '1'
811 812
    issue.reload
    assert_equal new_subject, issue.subject
813 814
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
815 816 817 818 819
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
jplang's avatar
jplang committed
820 821
  end
  
822
  def test_put_update_with_custom_field_change
823 824 825 826 827 828
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
829
        put :update, :id => 1, :issue => {:subject => 'Custom field change',
830 831 832 833 834 835
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
836
    assert_redirected_to :action => 'show', :id => '1'
837 838 839 840 841 842 843 844
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
845
  def test_put_update_with_status_and_assignee_change
jplang's avatar
jplang committed
846 847 848
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
849
    assert_difference('TimeEntry.count', 0) do
850
      put :update,
851 852 853
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
854
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
855
    end
856
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
857 858
    issue.reload
    assert_equal 2, issue.status_id
jplang's avatar
jplang committed
859
    j = Journal.find(:first, :order => 'id DESC')
jplang's avatar
jplang committed
860 861
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
862 863 864
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
865 866
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
867 868
  end
  
869
  def test_put_update_with_note_only
870 871
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
872
    put :update,
873 874
         :id => 1,
         :notes => notes
875
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
876
    j = Journal.find(:first, :order => 'id DESC')
877 878 879 880 881 882 883 884
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
885
  def test_put_update_with_note_and_spent_time
886 887
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
888
    assert_difference('TimeEntry.count') do
889
      put :update,
890 891
           :id => 1,
           :notes => '2.5 hours added',
892
           :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
893
    end
894
    assert_redirected_to :action => 'show', :id => '1'
895 896 897
    
    issue = Issue.find(1)
    
jplang's avatar
jplang committed
898
    j = Journal.find(:first, :order => 'id DESC')
899 900 901
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
902
    t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
903 904 905 906 907
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
908
  def test_put_update_with_attachment_only
jplang's avatar
jplang committed
909 910
    set_tmp_attachments_directory
    
911 912 913 914
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

915
    # anonymous user
916
    put :update,
917 918
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
919
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
920
    assert_redirected_to :action => 'show', :id => '1'
921 922 923 924 925 926 927 928 929
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950

  def test_put_update_with_attachment_that_fails_to_save
    set_tmp_attachments_directory
    
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

    # Mock out the unsaved attachment
    Attachment.any_instance.stubs(:create).returns(Attachment.new)
    
    # anonymous user
    put :update,
         :id => 1,
         :notes => '',
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
    assert_redirected_to :action => 'show', :id => '1'
    assert_equal '1 file(s) could not be saved.', flash[:warning]

  end if Object.const_defined?(:Mocha)

951
  def test_put_update_with_no_change
952 953 954 955
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
956
    put :update,
957 958
         :id => 1,
         :notes => ''
959
    assert_redirected_to :action => 'show', :id => '1'
960 961 962 963 964
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
jplang's avatar
jplang committed
965
  end
966

967
  def test_put_update_should_send_a_notification
968 969 970 971 972 973
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
974
    put :update, :id => 1, :issue => {:subject => new_subject,
975 976 977 978 979
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
980
  
981
  def test_put_update_with_invalid_spent_time
982 983 984 985
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
986
      put :update,
987 988 989 990 991 992 993 994 995 996 997
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_tag :textarea, :attributes => { :name => 'notes' },
                          :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
998
  
999
  def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
1000 1001 1002
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1003
    put :update,
1004 1005 1006 1007 1008 1009 1010 1011 1012 1013
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         }

    assert_response :redirect
    issue.reload
    assert_equal 4, issue.fixed_version_id
    assert_not_equal issue.project_id, issue.fixed_version.project_id
  end
1014

1015
  def test_put_update_should_redirect_back_using_the_back_url_parameter
1016 1017 1018
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1019
    put :update,
1020 1021 1022 1023 1024 1025 1026 1027 1028 1029
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => '/issues'

    assert_response :redirect
    assert_redirected_to '/issues'
  end
  
1030
  def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1031 1032 1033
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1034
    put :update,
1035 1036 1037 1038 1039 1040 1041 1042 1043
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => 'http://google.com'

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
  end
1044
  
1045 1046 1047 1048 1049
  def test_get_bulk_edit
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
1050 1051 1052 1053 1054
    
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert_equal 'date', field.field_format
jplang's avatar
jplang committed
1055
    assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
1056
    
1057
    # System wide custom field
1058
    assert CustomField.find(1).is_for_all?
jplang's avatar
jplang committed
1059
    assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
1060
  end
1061

1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074
  def test_get_bulk_edit_on_different_projects
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2, 6]
    assert_response :success
    assert_template 'bulk_edit'
    
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert !field.project_ids.include?(Issue.find(6).project_id)
    assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
  end

1075
  def test_bulk_update
1076 1077
    @request.session[:user_id] = 2
    # update issues priority
1078
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
jplang's avatar
jplang committed
1079 1080 1081 1082
                                     :issue => {:priority_id => 7,
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => ''}}
                                     
1083 1084 1085
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
1086 1087 1088 1089 1090 1091 1092 1093
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108