issue_test.rb 114 KB
Newer Older
1
# Redmine - project management software
jplang's avatar
jplang committed
2
# Copyright (C) 2006-2017  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
21
  fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles,
22
           :groups_users,
23
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
24
           :enabled_modules,
25
           :versions,
26
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
27
           :enumerations,
28
           :issues, :journals, :journal_details,
29
           :watchers,
30 31
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
32

33 34
  include Redmine::I18n

jplang's avatar
jplang committed
35 36 37 38
  def setup
    set_language_if_valid 'en'
  end

39 40 41 42
  def teardown
    User.current = nil
  end

43 44 45 46 47
  def test_initialize
    issue = Issue.new

    assert_nil issue.project_id
    assert_nil issue.tracker_id
jplang's avatar
jplang committed
48
    assert_nil issue.status_id
49 50 51 52 53 54 55
    assert_nil issue.author_id
    assert_nil issue.assigned_to_id
    assert_nil issue.category_id

    assert_equal IssuePriority.default, issue.priority
  end

56
  def test_create
57 58 59 60
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
61 62 63 64
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
65

66
  def test_create_minimal
jplang's avatar
jplang committed
67
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
68
    assert issue.save
jplang's avatar
jplang committed
69
    assert_equal issue.tracker.default_status, issue.status
70
    assert issue.description.nil?
71
    assert_nil issue.estimated_hours
72
  end
73

74 75 76 77 78 79 80 81 82
  def test_create_with_all_fields_disabled
    tracker = Tracker.find(1)
    tracker.core_fields = []
    tracker.save!

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
    assert_save issue
  end

83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100
  def test_start_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:start_date => invalid_date)
      assert !issue.valid?
      assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

  def test_due_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:due_date => invalid_date)
      assert !issue.valid?
      assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

101 102 103 104 105 106 107
  def test_due_date_lesser_than_start_date_should_not_validate
    set_language_if_valid 'en'
    issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
    assert !issue.valid?
    assert_include 'Due date must be greater than start date', issue.errors.full_messages
  end

108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
  def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
    issue = Issue.generate(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    assert !issue.valid?
    assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  end

  def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
    issue = Issue.generate!(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    issue.start_date = '2013-06-07'
    assert !issue.valid?
    assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  end

  def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
    issue = Issue.generate!(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    assert issue.valid?
  end

129 130
  def test_estimated_hours_should_be_validated
    set_language_if_valid 'en'
131
    ['-2', '123abc'].each do |invalid|
132 133 134 135 136 137
      issue = Issue.new(:estimated_hours => invalid)
      assert !issue.valid?
      assert_include 'Estimated time is invalid', issue.errors.full_messages
    end
  end

138
  def test_create_with_required_custom_field
139
    set_language_if_valid 'en'
140
    field = IssueCustomField.find_by_name('Database')
141
    field.update!(:is_required => true)
142

143 144 145
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
146 147 148
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
149
    assert_equal ["Database cannot be blank"], issue.errors.full_messages
150 151 152
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
153
    assert_equal ["Database cannot be blank"], issue.errors.full_messages
154 155 156
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
157
    assert_equal ["Database is not included in the list"], issue.errors.full_messages
158 159 160 161 162 163
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
164

165 166
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
167 168 169
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
170
      issue = Issue.order('id DESC').first
171 172 173 174
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
175

176
  def test_create_with_parent_issue_id
177 178 179
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => 1)
180 181 182 183 184
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

185 186 187 188 189 190 191 192 193
  def test_create_with_sharp_parent_issue_id
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => "#1")
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

194
  def test_create_with_invalid_parent_issue_id
195
    set_language_if_valid 'en'
196 197 198
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '01ABC')
199 200 201 202 203
    assert !issue.save
    assert_equal '01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

204 205 206 207 208 209 210 211 212 213
  def test_create_with_invalid_sharp_parent_issue_id
    set_language_if_valid 'en'
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '#01ABC')
    assert !issue.save
    assert_equal '#01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

214 215 216 217
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
218 219
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
jplang's avatar
jplang committed
220
    issues = Issue.visible(User.anonymous).to_a
jplang's avatar
jplang committed
221 222
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
223
    assert_nil issues.detect {|issue| issue.is_private?}
224 225
    assert_visibility_match User.anonymous, issues
  end
226

227
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
228 229
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
jplang's avatar
jplang committed
230
    issues = Issue.visible(User.anonymous).to_a
jplang's avatar
jplang committed
231
    assert issues.empty?
232
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
233
  end
234

235 236 237 238 239 240 241 242 243 244
  def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
    Role.anonymous.remove_permission!(:view_issues)
    Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])

    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_equal [1], issues.map(&:project_id).uniq.sort
    assert_visibility_match User.anonymous, issues
  end

245
  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
246
    Role.anonymous.update!(:issues_visibility => 'default')
247
    issue = Issue.generate!(:author => User.anonymous, :is_private => true)
248 249 250 251 252
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
253
    assert Role.anonymous.update!(:issues_visibility => 'own')
254
    issue = Issue.generate!(:author => User.anonymous, :is_private => true)
255 256 257 258
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

259
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
260 261 262
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
jplang's avatar
jplang committed
263
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
264 265
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
266
    assert_nil issues.detect {|issue| issue.is_private?}
267 268
    assert_visibility_match user, issues
  end
269

270
  def test_visible_scope_for_non_member_with_own_issues_visibility
271
    Role.non_member.update! :issues_visibility => 'own'
272 273
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
274

jplang's avatar
jplang committed
275
    issues = Issue.visible(user).to_a
276 277 278 279
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
280

281
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
282 283
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
284 285
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
286
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
287
    assert issues.empty?
288 289
    assert_visibility_match user, issues
  end
290

291 292 293 294 295 296 297 298 299 300 301
  def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
    Role.non_member.remove_permission!(:view_issues)
    Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
    user = User.find(9)

    issues = Issue.visible(user).all
    assert issues.any?
    assert_equal [1], issues.map(&:project_id).uniq.sort
    assert_visibility_match user, issues
  end

302 303
  def test_visible_scope_for_member
    user = User.find(9)
304
    # User should see issues of projects for which user has view_issues permissions only
305
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
306
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
307
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
308
    assert issues.any?
jplang's avatar
jplang committed
309 310
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
311
    assert_visibility_match user, issues
jplang's avatar
jplang committed
312
  end
313

314 315 316 317 318 319 320 321 322
  def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
    Role.non_member.add_permission!(:view_issues)
    Role.find(1).remove_permission!(:view_issues)
    user = User.find(2)

    assert_equal 0, Issue.where(:project_id => 1).visible(user).count
    assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
  end

323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344
  def test_visible_scope_with_custom_non_member_role_having_restricted_permission
    role = Role.generate!(:permissions => [:view_project])
    assert Role.non_member.has_permission?(:view_issues)
    user = User.generate!
    Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])

    issues = Issue.visible(user).to_a
    assert issues.any?
    assert_nil issues.detect {|issue| issue.project_id == 1}
  end

  def test_visible_scope_with_custom_non_member_role_having_extended_permission
    role = Role.generate!(:permissions => [:view_project, :view_issues])
    Role.non_member.remove_permission!(:view_issues)
    user = User.generate!
    Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])

    issues = Issue.visible(user).to_a
    assert issues.any?
    assert_not_nil issues.detect {|issue| issue.project_id == 1}
  end

345 346 347
  def test_visible_scope_for_member_with_groups_should_return_assigned_issues
    user = User.find(8)
    assert user.groups.any?
348 349
    group = user.groups.first
    Member.create!(:principal => group, :project_id => 1, :role_ids => [2])
350
    Role.non_member.remove_permission!(:view_issues)
351

352 353 354 355 356 357
    with_settings :issue_group_assignment => '1' do
      issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
        :status_id => 1, :priority => IssuePriority.all.first,
        :subject => 'Assignment test',
        :assigned_to => group,
        :is_private => true)
358

359 360 361 362
      Role.find(2).update! :issues_visibility => 'default'
      issues = Issue.visible(User.find(8)).to_a
      assert issues.any?
      assert issues.include?(issue)
363

364 365 366 367 368
      Role.find(2).update! :issues_visibility => 'own'
      issues = Issue.visible(User.find(8)).to_a
      assert issues.any?
      assert_include issue, issues
    end
369 370
  end

371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433
  def test_visible_scope_for_member_with_limited_tracker_ids
    role = Role.find(1)
    role.set_permission_trackers :view_issues, [2]
    role.save!
    user = User.find(2)

    issues = Issue.where(:project_id => 1).visible(user).to_a
    assert issues.any?
    assert_equal [2], issues.map(&:tracker_id).uniq

    assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  end

  def test_visible_scope_should_consider_tracker_ids_on_each_project
    user = User.generate!

    project1 = Project.generate!
    role1 = Role.generate!
    role1.add_permission! :view_issues
    role1.set_permission_trackers :view_issues, :all
    role1.save!
    User.add_to_project(user, project1, role1)

    project2 = Project.generate!
    role2 = Role.generate!
    role2.add_permission! :view_issues
    role2.set_permission_trackers :view_issues, [2]
    role2.save!
    User.add_to_project(user, project2, role2)

    visible_issues = [
      Issue.generate!(:project => project1, :tracker_id => 1),
      Issue.generate!(:project => project1, :tracker_id => 2),
      Issue.generate!(:project => project2, :tracker_id => 2)
    ]
    hidden_issue = Issue.generate!(:project => project2, :tracker_id => 1)

    issues = Issue.where(:project_id => [project1.id, project2.id]).visible(user)
    assert_equal visible_issues.map(&:id), issues.ids.sort

    assert visible_issues.all? {|issue| issue.visible?(user)}
    assert !hidden_issue.visible?(user)
  end

  def test_visible_scope_should_not_consider_roles_without_view_issues_permission
    user = User.generate!
    role1 = Role.generate!
    role1.remove_permission! :view_issues
    role1.set_permission_trackers :view_issues, :all
    role1.save!
    role2 = Role.generate!
    role2.add_permission! :view_issues
    role2.set_permission_trackers :view_issues, [2]
    role2.save!
    User.add_to_project(user, Project.find(1), [role1, role2])

    issues = Issue.where(:project_id => 1).visible(user).to_a
    assert issues.any?
    assert_equal [2], issues.map(&:tracker_id).uniq

    assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  end

jplang's avatar
jplang committed
434 435 436 437
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
jplang's avatar
jplang committed
438
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
439
    assert issues.any?
440
    # Admin should see issues on private projects that admin does not belong to
jplang's avatar
jplang committed
441
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
442 443
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
444
    assert_visibility_match user, issues
jplang's avatar
jplang committed
445
  end
446

447 448
  def test_visible_scope_with_project
    project = Project.find(1)
jplang's avatar
jplang committed
449
    issues = Issue.visible(User.find(2), :project => project).to_a
450 451 452 453
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
454

455 456
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
jplang's avatar
jplang committed
457
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
458 459 460 461
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
462

463
  def test_visible_and_nested_set_scopes
464
    user = User.generate!
465
    Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
466 467 468 469 470 471 472 473 474 475 476
    parent = Issue.generate!(:assigned_to => user)
    assert parent.visible?(user)
    child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
    child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
    parent.reload
    child1.reload
    child2.reload
    assert child1.visible?(user)
    assert child2.visible?(user)
    assert_equal 2, parent.descendants.count
    assert_equal 2, parent.descendants.visible(user).count
477
    # awesome_nested_set 2-1-stable branch has regression.
478 479 480 481
    # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
    # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
    assert_equal 2, parent.descendants.collect{|i| i}.size
    assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
482
  end
483

jplang's avatar
jplang committed
484 485 486 487 488 489 490
  def test_visible_scope_with_unsaved_user_should_not_raise_an_error
    user = User.new
    assert_nothing_raised do
      Issue.visible(user).to_a
    end
  end

491
  def test_open_scope
jplang's avatar
jplang committed
492
    issues = Issue.open.to_a
493 494 495 496
    assert_nil issues.detect(&:closed?)
  end

  def test_open_scope_with_arg
jplang's avatar
jplang committed
497
    issues = Issue.open(false).to_a
498 499 500
    assert_equal issues, issues.select(&:closed?)
  end

501 502 503 504 505 506 507 508 509 510
  def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
    version = Version.find(2)
    assert version.fixed_issues.any?
    assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  end

  def test_fixed_version_scope_with_empty_array_should_return_no_result
    assert_equal 0, Issue.fixed_version([]).count
  end

511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526
  def test_assigned_to_scope_should_return_issues_assigned_to_the_user
    user = User.generate!
    issue = Issue.generate!
    Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
    assert_equal [issue], Issue.assigned_to(user).to_a
  end

  def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
    group = Group.generate!
    user = User.generate!
    group.users << user
    issue = Issue.generate!
    Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
    assert_equal [issue], Issue.assigned_to(user).to_a
  end

527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542
  def test_issue_should_be_readonly_on_closed_project
    issue = Issue.find(1)
    user = User.find(1)

    assert_equal true, issue.visible?(user)
    assert_equal true, issue.editable?(user)
    assert_equal true, issue.deletable?(user)

    issue.project.close
    issue.reload

    assert_equal true, issue.visible?(user)
    assert_equal false, issue.editable?(user)
    assert_equal false, issue.deletable?(user)
  end

543 544
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
545

tmaruyama's avatar
tmaruyama committed
546 547 548
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
549 550 551
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
552

553 554
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
tmaruyama's avatar
tmaruyama committed
555 556
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                 issue.errors.full_messages.first
557
  end
558

559 560
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
561
    field.update!(:is_required => true)
562

563 564 565 566 567 568 569 570 571 572 573 574 575 576
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
577

578 579 580 581
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
582

583 584 585
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
586

587
    issue.reload
588
    assert_equal "Cannot print recipes", issue.subject
589
  end
590

591 592
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
593

594 595 596 597 598 599 600 601 602 603
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
604

605 606
  def test_setting_project_should_set_version_to_default_version
    version = Version.generate!(:project_id => 1)
607
    Project.find(1).update!(:default_version_id => version.id)
608 609 610 611 612

    issue = Issue.new(:project_id => 1)
    assert_equal version, issue.fixed_version
  end

613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
  def test_default_assigned_to_based_on_category_should_be_set_on_create
    user = User.find(3)
    category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)

    issue = Issue.generate!(:project_id => 1, :category_id => category.id)
    assert_equal user, issue.assigned_to
  end

  def test_default_assigned_to_based_on_project_should_be_set_on_create
    user = User.find(3)
    Project.find(1).update!(:default_assigned_to_id => user.id)

    issue = Issue.generate!(:project_id => 1)
    assert_equal user, issue.assigned_to
  end

629 630 631 632 633 634 635 636 637 638 639 640
  def test_default_assigned_to_with_required_assignee_should_validate
    category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
    Issue.any_instance.stubs(:required_attribute_names).returns(['assigned_to_id'])

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default')
    assert !issue.save
    assert issue.errors['assigned_to_id'].present?

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default', :category_id => category.id)
    assert_save issue
  end

641
  def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
tmaruyama's avatar
tmaruyama committed
642 643 644
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
                          :status_id => 1, :subject => 'Test',
                          :custom_field_values => {'2' => 'Test'})
645 646 647 648 649 650 651 652 653 654 655
    assert !Tracker.find(2).custom_field_ids.include?(2)

    issue = Issue.find(issue.id)
    issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}

    issue = Issue.find(issue.id)
    custom_value = issue.custom_value_for(2)
    assert_not_nil custom_value
    assert_equal 'Test', custom_value.value
  end

656 657 658 659 660 661
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
662

663 664 665 666 667 668 669 670 671 672
  def test_assigning_attributes_should_assign_project_and_tracker_first
    seq = sequence('seq')
    issue = Issue.new
    issue.expects(:project_id=).in_sequence(seq)
    issue.expects(:tracker_id=).in_sequence(seq)
    issue.expects(:subject=).in_sequence(seq)
    issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  end

  def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
673 674 675 676 677
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
678
    assert_equal 'MySQL', issue.custom_field_value(1)
679
  end
680

681 682 683 684 685 686 687 688 689 690 691 692 693 694
  def test_changing_tracker_should_clear_disabled_core_fields
    tracker = Tracker.find(2)
    tracker.core_fields = tracker.core_fields - %w(due_date)
    tracker.save!

    issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
    issue.save!

    issue.tracker_id = 2
    issue.save!
    assert_not_nil issue.start_date
    assert_nil issue.due_date
  end

695 696
  def test_attribute_cleared_on_tracker_change_should_be_journalized
    CustomField.delete_all
697 698 699 700 701 702 703 704 705 706 707 708 709 710
    tracker = Tracker.find(2)
    tracker.core_fields = tracker.core_fields - %w(due_date)
    tracker.save!

    issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
    issue.save!

    assert_difference 'Journal.count' do
      issue.init_journal User.find(1)
      issue.tracker_id = 2
      issue.save!
      assert_nil issue.due_date
    end
    journal = Journal.order('id DESC').first
711 712
    details = journal.details.select {|d| d.prop_key == 'due_date'}
    assert_equal 1, details.count
713 714
  end

715 716 717 718 719 720 721 722 723 724 725 726 727 728 729
  def test_reload_should_reload_custom_field_values
    issue = Issue.generate!
    issue.custom_field_values = {'2' => 'Foo'}
    issue.save!

    issue = Issue.order('id desc').first
    assert_equal 'Foo', issue.custom_field_value(2)

    issue.custom_field_values = {'2' => 'Bar'}
    assert_equal 'Bar', issue.custom_field_value(2)

    issue.reload
    assert_equal 'Foo', issue.custom_field_value(2)
  end

730 731 732
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
733

734 735
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
736

737 738 739 740
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
741

742 743 744
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
745

746 747 748 749
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
750
    assert_not_equal [], issue.errors[:tracker_id]
751
  end
752

753
  def test_category_based_assignment
754 755 756 757
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
758 759
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
760

761
  def test_new_statuses_allowed_to
762
    WorkflowTransition.delete_all
763 764 765 766 767 768
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 2,
                               :author => false, :assignee => false)
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 3,
                               :author => true, :assignee => false)
769 770 771
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 4,
                               :author => false, :assignee => true)
772 773 774
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 5,
                               :author => true, :assignee => true)
775 776 777 778
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
779

780 781
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1)
782
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
783

784 785
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user)
jplang's avatar
jplang committed
786
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
787

788 789 790
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1,
                            :assigned_to => user)
jplang's avatar
jplang committed
791
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
792

793 794 795
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user,
                            :assigned_to => user)
796
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
797 798 799 800 801 802 803 804
  end

  def test_new_statuses_allowed_to_should_consider_group_assignment
    WorkflowTransition.delete_all
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 4,
                               :author => false, :assignee => true)
    group = Group.generate!
805 806 807
    Member.create!(:project_id => 1, :principal => group, :role_ids => [1])

    user = User.find(2)
808
    group.users << user
809

810 811 812 813
    with_settings :issue_group_assignment => '1' do
      issue = Issue.generate!(:author_id => 1, :assigned_to => group)
      assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
    end
814
  end
815

816 817 818 819
  def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
    admin = User.find(1)
    issue = Issue.find(1)
    assert !admin.member_of?(issue.project)
820
    expected_statuses = [issue.status] +
821
                            WorkflowTransition.where(:old_status_id => issue.status_id).
822
                                map(&:new_status).uniq.sort
823 824 825
    assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  end

826
  def test_new_statuses_allowed_to_should_return_allowed_statuses_when_copying
827
    Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
828

829 830
    orig = Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 4)
    issue = orig.copy
831 832
    assert_equal [1, 3], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
    assert_equal 1, issue.status_id
833
  end
834

835 836 837 838 839 840 841 842 843 844
  def test_safe_attributes_names_should_be_updated_when_changing_project
    issue = Issue.new
    with_current_user(User.find(2)) do
      assert_not_include 'watcher_user_ids', issue.safe_attribute_names

      issue.project_id = 1
      assert_include 'watcher_user_ids', issue.safe_attribute_names
    end
  end

845
  def test_safe_attributes_names_should_not_include_disabled_field
846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875
    tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))

    issue = Issue.new(:tracker => tracker)
    assert_include 'tracker_id', issue.safe_attribute_names
    assert_include 'status_id', issue.safe_attribute_names
    assert_include 'subject', issue.safe_attribute_names
    assert_include 'custom_field_values', issue.safe_attribute_names
    assert_include 'custom_fields', issue.safe_attribute_names
    assert_include 'lock_version', issue.safe_attribute_names

    tracker.core_fields.each do |field|
      assert_include field, issue.safe_attribute_names
    end

    tracker.disabled_core_fields.each do |field|
      assert_not_include field, issue.safe_attribute_names
    end
  end

  def test_safe_attributes_should_ignore_disabled_fields
    tracker = Tracker.find(1)
    tracker.core_fields = %w(assigned_to_id due_date)
    tracker.save!

    issue = Issue.new(:tracker => tracker)
    issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
    assert_nil issue.start_date
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end

876
  def test_safe_attributes_should_accept_target_tracker_enabled_fields
877 878 879 880 881 882
    source = Tracker.find(1)
    source.core_fields = []
    source.save!
    target = Tracker.find(2)
    target.core_fields = %w(assigned_to_id due_date)
    target.save!
883
    user = User.find(2)
884

885 886
    issue = Issue.new(:project => Project.find(1), :tracker => source)
    issue.send :safe_attributes=, {'tracker_id' => 2, 'due_date' => '2012-07-14'}, user
887 888 889
    assert_equal target, issue.tracker
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end
890 891 892

  def test_safe_attributes_should_not_include_readonly_fields
    WorkflowPermission.delete_all
893 894 895
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
896 897 898 899 900 901 902 903 904 905 906 907
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
    assert_not_include 'due_date', issue.safe_attribute_names(user)

    issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
    assert_equal Date.parse('2012-07-14'), issue.start_date
    assert_nil issue.due_date
  end

  def test_safe_attributes_should_not_include_readonly_custom_fields
tmaruyama's avatar
tmaruyama committed
908 909 910 911 912 913
    cf1 = IssueCustomField.create!(:name => 'Writable field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
    cf2 = IssueCustomField.create!(:name => 'Readonly field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
914
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
915 916 917
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf2.id.to_s,
                               :rule => 'readonly')
918 919 920 921 922
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
    assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)

tmaruyama's avatar
tmaruyama committed
923 924 925
    issue.send :safe_attributes=, {'custom_field_values' => {
                                       cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
                                     }}, user
926 927 928
    assert_equal 'value1', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)

tmaruyama's avatar
tmaruyama committed
929 930 931 932
    issue.send :safe_attributes=, {'custom_fields' => [
                                      {'id' => cf1.id.to_s, 'value' => 'valuea'},
                                      {'id' => cf2.id.to_s, 'value' => 'valueb'}
                                    ]}, user
933 934 935 936 937
    assert_equal 'valuea', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)
  end

  def test_editable_custom_field_values_should_return_non_readonly_custom_values
tmaruyama's avatar
tmaruyama committed
938 939 940 941
    cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
    cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
942
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
943 944
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
                               :field_name => cf2.id.to_s, :rule => 'readonly')
945 946 947 948 949 950 951 952 953 954 955 956 957
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert_nil values.detect {|value| value.custom_field == cf2}

    issue.tracker_id = 2
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert values.detect {|value| value.custom_field == cf2}
  end

958 959 960 961 962 963 964 965 966 967
  def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
    enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
    disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)

    assert_include enabled_cf, issue.editable_custom_fields(user)
    assert_not_include disabled_cf, issue.editable_custom_fields(user)
  end

968 969
  def test_safe_attributes_should_accept_target_tracker_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
970 971 972 973 974 975
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
976 977 978 979
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
980 981
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'}, user
982 983 984
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
985 986 987
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                   'due_date' => '2012-07-16',
                                   'tracker_id' => 2}, user
988 989 990 991 992 993
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_safe_attributes_should_accept_target_status_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
994 995 996 997 998 999
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
1000 1001 1002 1003
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
1004 1005 1006
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'},
                                   user
1007 1008 1009
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
1010 1011 1012 1013
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                    'due_date' => '2012-07-16',
                                    'status_id' => 2},
                                  user
1014 1015 1016 1017 1018
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_required_attributes_should_be_validated
1019 1020
    cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
                                  :is_for_all => true, :tracker_ids => [1, 2])
1021 1022

    WorkflowPermission.delete_all
1023 1024 1025 1026 1027 1028 1029 1030 1031
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'category_id',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
1032

1033 1034 1035 1036 1037 1038
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
1039 1040
    user = User.find(2)

1041 1042 1043 1044 1045
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :status_id => 1, :subject => 'Required fields',
                      :author => user)
    assert_equal [cf.id.to_s, "category_id", "due_date"],
                 issue.required_attribute_names(user).sort
1046
    assert !issue.save, "Issue was saved"
1047
    assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
1048
                  issue.errors.full_messages.sort
1049 1050 1051 1052

    issue.tracker_id = 2
    assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
    assert !issue.save, "Issue was saved"
1053
    assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
1054
                 issue.errors.full_messages.sort
1055 1056 1057 1058 1059 1060

    issue.start_date = Date.today
    issue.custom_field_values = {cf.id.to_s => 'bar'}
    assert issue.save
  end

1061 1062 1063 1064 1065 1066 1067 1068 1069 1070
  def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert !issue.save
1071
    assert_include "Start date cannot be blank", issue.errors.full_messages
1072 1073 1074 1075 1076 1077 1078 1079 1080

    tracker = Tracker.find(1)
    tracker.core_fields -= %w(start_date)
    tracker.save!
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert issue.save
  end

1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104
  def test_category_should_not_be_required_if_project_has_no_categories
    Project.find(1).issue_categories.delete_all
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
      :role_id => 1, :field_name => 'category_id',:rule => 'required')
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert_save issue
  end

  def test_fixed_version_should_not_be_required_no_assignable_versions
    Version.delete_all
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
      :role_id => 1, :field_name => 'fixed_version_id',:rule => 'required')
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert_save issue
  end

1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127
  def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
    CustomField.delete_all
    field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
    user = User.generate!
    User.add_to_project(user, Project.find(1), Role.find(2))

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert_save issue
  end

  def test_required_custom_field_that_is_visible_for_the_user_should_be_required
    CustomField.delete_all
    field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
    user = User.generate!
    User.add_to_project(user, Project.find(1), Role.find(1))

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert !issue.save
    assert_include "#{field.name} cannot be blank", issue.errors.full_messages
  end

1128 1129
  def test_required_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
1130 1131 1132 1133 1134 1135
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
1136 1137 1138 1139 1140 1141 1142 1143 1144 1145
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
1146 1147 1148
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 2, :field_name => 'due_date',
                               :rule => 'required')
1149 1150 1151 1152 1153 1154
    assert_equal %w(due_date), issue.required_attribute_names(user)

    member.role_ids = [1, 2, 3]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
1155
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1156
                               :role_id => 3, :field_name => 'due_date',
tmaruyama's avatar
tmaruyama committed
1157
                               :rule => 'readonly')
1158 1159 1160 1161 1162 1163
    # required + readonly => required
    assert_equal %w(due_date), issue.required_attribute_names(user)
  end

  def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
1164 1165 1166 1167 1168 1169
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
1170 1171 1172 1173 1174 1175 1176 1177 1178 1179
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.read_only_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
1180 1181 1182
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                              :role_id => 2, :field_name => 'due_date',
                              :rule => 'readonly')
1183 1184
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
  end
1185

1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202
  # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
  def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
    field = IssueCustomField.generate!(
      :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
    )
    WorkflowPermission.delete_all
    WorkflowPermission.create!(
      :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
    )
    user = User.generate!
    project = Project.find(1)
    User.add_to_project(user, project, Role.where(:id => [1, 2]))

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
    assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
  end

1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225
  def test_workflow_rules_should_ignore_roles_without_issue_permissions
    role = Role.generate! :permissions => [:view_issues, :edit_issues]
    ignored_role = Role.generate! :permissions => [:view_issues]

    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role => role, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role => role, :field_name => 'start_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role => role, :field_name => 'done_ratio',
                               :rule => 'readonly')
    user = User.generate!
    User.add_to_project user, Project.find(1), [role, ignored_role]

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date), issue.required_attribute_names(user)
    assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
  end

1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246
  def test_workflow_rules_should_work_for_member_with_duplicate_role
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')

    user = User.generate!
    m = Member.new(:user_id => user.id, :project_id => 1)
    m.member_roles.build(:role_id => 1)
    m.member_roles.build(:role_id => 1)
    m.save!

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date), issue.required_attribute_names(user)
    assert_equal %w(start_date), issue.read_only_attribute_names(user)
  end

1247 1248
  def test_copy
    issue = Issue.new.copy_from(1)
1249
    assert issue.copy?
1250 1251 1252 1253 1254
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
1255
    assert_equal "125", issue.custom_value_for(2).value
1256
  end