issue_test.rb 47 KB
Newer Older
1
# Redmine - project management software
2
# Copyright (C) 2006-2012  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
jplang's avatar
jplang committed
21
  fixtures :projects, :users, :members, :member_roles, :roles,
22
           :groups_users,
23
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
24
           :enabled_modules,
25
           :versions,
26
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 28 29 30
           :enumerations,
           :issues,
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
31

32 33
  include Redmine::I18n

34
  def test_create
35 36 37 38
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
39 40 41 42
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
43

44
  def test_create_minimal
45 46 47
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create')
48 49 50
    assert issue.save
    assert issue.description.nil?
  end
51

52
  def test_create_with_required_custom_field
53
    set_language_if_valid 'en'
54 55
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
56

57 58 59
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
60 61 62
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
63
    assert_equal ["Database can't be blank"], issue.errors.full_messages
64 65 66
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
67
    assert_equal ["Database can't be blank"], issue.errors.full_messages
68 69 70
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
71
    assert_equal ["Database is not included in the list"], issue.errors.full_messages
72 73 74 75 76 77
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
78

79 80
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
81 82 83
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
84 85 86 87 88
      issue = Issue.first(:order => 'id DESC')
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
89

90 91 92 93
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
94 95 96 97 98
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
99
    assert_nil issues.detect {|issue| issue.is_private?}
100 101
    assert_visibility_match User.anonymous, issues
  end
102

103 104
  def test_visible_scope_for_anonymous_with_own_issues_visibility
    Role.anonymous.update_attribute :issues_visibility, 'own'
tmaruyama's avatar
tmaruyama committed
105 106 107
    Issue.create!(:project_id => 1, :tracker_id => 1,
                  :author_id => User.anonymous.id,
                  :subject => 'Issue by anonymous')
108

109 110 111 112 113
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != User.anonymous}
    assert_visibility_match User.anonymous, issues
  end
114

115
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
116 117 118 119
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
    issues = Issue.visible(User.anonymous).all
    assert issues.empty?
120
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
121
  end
122

123
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
124 125 126 127 128 129
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
130
    assert_nil issues.detect {|issue| issue.is_private?}
131 132
    assert_visibility_match user, issues
  end
133

134 135 136 137
  def test_visible_scope_for_non_member_with_own_issues_visibility
    Role.non_member.update_attribute :issues_visibility, 'own'
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
138

139 140 141 142 143
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
144

145
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
146 147
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
148 149
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
150 151
    issues = Issue.visible(user).all
    assert issues.empty?
152 153
    assert_visibility_match user, issues
  end
154

155 156
  def test_visible_scope_for_member
    user = User.find(9)
jplang's avatar
jplang committed
157
    # User should see issues of projects for which he has view_issues permissions only
158
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
159
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
160 161
    issues = Issue.visible(user).all
    assert issues.any?
jplang's avatar
jplang committed
162 163
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
164
    assert_visibility_match user, issues
jplang's avatar
jplang committed
165
  end
166

167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189
  def test_visible_scope_for_member_with_groups_should_return_assigned_issues
    user = User.find(8)
    assert user.groups.any?
    Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
    Role.non_member.remove_permission!(:view_issues)
    
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
      :status_id => 1, :priority => IssuePriority.all.first,
      :subject => 'Assignment test',
      :assigned_to => user.groups.first,
      :is_private => true)
    
    Role.find(2).update_attribute :issues_visibility, 'default'
    issues = Issue.visible(User.find(8)).all
    assert issues.any?
    assert issues.include?(issue)
    
    Role.find(2).update_attribute :issues_visibility, 'own'
    issues = Issue.visible(User.find(8)).all
    assert issues.any?
    assert issues.include?(issue)
  end

jplang's avatar
jplang committed
190 191 192 193 194 195 196 197
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
    issues = Issue.visible(user).all
    assert issues.any?
    # Admin should see issues on private projects that he does not belong to
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
198 199
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
200
    assert_visibility_match user, issues
jplang's avatar
jplang committed
201
  end
202

203 204 205 206 207 208 209
  def test_visible_scope_with_project
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project).all
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
210

211 212 213 214 215 216 217
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
218

219 220 221
  def test_visible_and_nested_set_scopes
    assert_equal 0, Issue.find(1).descendants.visible.all.size
  end
222

223 224 225 226 227 228 229 230 231 232
  def test_open_scope
    issues = Issue.open.all
    assert_nil issues.detect(&:closed?)
  end

  def test_open_scope_with_arg
    issues = Issue.open(false).all
    assert_equal issues, issues.select(&:closed?)
  end

233 234
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
235

tmaruyama's avatar
tmaruyama committed
236 237 238
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
239 240 241
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
242

243 244
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
tmaruyama's avatar
tmaruyama committed
245 246
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                 issue.errors.full_messages.first
247
  end
248

249 250 251
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
252

253 254 255 256 257 258 259 260 261 262 263 264 265 266
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
267

268 269 270 271
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
272

273 274 275
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
276

277 278 279
    issue.reload
    assert_equal "Can't print recipes", issue.subject
  end
280

281 282
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
283

284 285 286 287 288 289 290 291 292 293
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
294

295
  def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
296
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'Test', :custom_field_values => {'2' => 'Test'})
297 298 299 300 301 302 303 304 305 306 307
    assert !Tracker.find(2).custom_field_ids.include?(2)

    issue = Issue.find(issue.id)
    issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}

    issue = Issue.find(issue.id)
    custom_value = issue.custom_value_for(2)
    assert_not_nil custom_value
    assert_equal 'Test', custom_value.value
  end

308 309 310 311 312 313
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
314

315 316 317 318 319 320 321 322 323 324
  def test_assigning_attributes_should_assign_project_and_tracker_first
    seq = sequence('seq')
    issue = Issue.new
    issue.expects(:project_id=).in_sequence(seq)
    issue.expects(:tracker_id=).in_sequence(seq)
    issue.expects(:subject=).in_sequence(seq)
    issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  end

  def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
325 326 327 328 329
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
330
    assert_equal 'MySQL', issue.custom_field_value(1)
331
  end
332

333 334 335
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
336

337 338
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
339

340 341 342 343
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
344

345 346 347
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
348

349 350 351 352
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
353
    assert_not_nil issue.errors[:tracker_id]
354
  end
355

356
  def test_category_based_assignment
357 358 359 360
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
361 362
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
363

364 365
  def test_new_statuses_allowed_to
    Workflow.delete_all
366

367 368 369 370 371 372 373 374
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
375

jplang's avatar
jplang committed
376
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author_id => 1)
377
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
378

379
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
jplang's avatar
jplang committed
380
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
381

jplang's avatar
jplang committed
382
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author_id => 1, :assigned_to => user)
jplang's avatar
jplang committed
383
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
384

385 386 387
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  end
388

389 390 391 392 393 394 395 396 397
  def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
    admin = User.find(1)
    issue = Issue.find(1)
    assert !admin.member_of?(issue.project)
    expected_statuses = [issue.status] + Workflow.find_all_by_old_status_id(issue.status_id).map(&:new_status).uniq.sort

    assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  end

398 399 400 401 402 403 404
  def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
    issue = Issue.find(1).copy
    assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)

    issue = Issue.find(2).copy
    assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  end
405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450

  def test_safe_attributes_should_not_include_disabled_field
    tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))

    issue = Issue.new(:tracker => tracker)
    assert_include 'tracker_id', issue.safe_attribute_names
    assert_include 'status_id', issue.safe_attribute_names
    assert_include 'subject', issue.safe_attribute_names
    assert_include 'description', issue.safe_attribute_names
    assert_include 'custom_field_values', issue.safe_attribute_names
    assert_include 'custom_fields', issue.safe_attribute_names
    assert_include 'lock_version', issue.safe_attribute_names

    tracker.core_fields.each do |field|
      assert_include field, issue.safe_attribute_names
    end

    tracker.disabled_core_fields.each do |field|
      assert_not_include field, issue.safe_attribute_names
    end
  end

  def test_safe_attributes_should_ignore_disabled_fields
    tracker = Tracker.find(1)
    tracker.core_fields = %w(assigned_to_id due_date)
    tracker.save!

    issue = Issue.new(:tracker => tracker)
    issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
    assert_nil issue.start_date
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end

  def test_safe_attributes_should_accept_target_tracker_fields
    source = Tracker.find(1)
    source.core_fields = []
    source.save!
    target = Tracker.find(2)
    target.core_fields = %w(assigned_to_id due_date)
    target.save!

    issue = Issue.new(:tracker => source)
    issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
    assert_equal target, issue.tracker
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end
451

jplang's avatar
jplang committed
452 453
  def test_copy
    issue = Issue.new.copy_from(1)
454
    assert issue.copy?
jplang's avatar
jplang committed
455 456 457 458 459
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
460
    assert_equal "125", issue.custom_value_for(2).value
jplang's avatar
jplang committed
461
  end
462 463 464 465

  def test_copy_should_copy_status
    orig = Issue.find(8)
    assert orig.status != IssueStatus.default
466

467 468 469 470 471
    issue = Issue.new.copy_from(orig)
    assert issue.save
    issue.reload
    assert_equal orig.status, issue.status
  end
472

473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
  def test_should_not_call_after_project_change_on_creation
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Test', :author_id => 1)
    issue.expects(:after_project_change).never
    issue.save!
  end

  def test_should_not_call_after_project_change_on_update
    issue = Issue.find(1)
    issue.project = Project.find(1)
    issue.subject = 'No project change'
    issue.expects(:after_project_change).never
    issue.save!
  end

  def test_should_call_after_project_change_on_project_change
    issue = Issue.find(1)
    issue.project = Project.find(2)
    issue.expects(:after_project_change).once
    issue.save!
  end

494 495 496 497 498 499 500 501 502 503 504 505 506
  def test_adding_journal_should_update_timestamp
    issue = Issue.find(1)
    updated_on_was = issue.updated_on

    issue.init_journal(User.first, "Adding notes")
    assert_difference 'Journal.count' do
      assert issue.save
    end
    issue.reload

    assert_not_equal updated_on_was, issue.updated_on
  end

507
  def test_should_close_duplicates
508
    # Create 3 issues
jplang's avatar
jplang committed
509 510 511 512
    project = Project.find(1)
    issue1 = Issue.generate_for_project!(project)
    issue2 = Issue.generate_for_project!(project)
    issue3 = Issue.generate_for_project!(project)
513

514
    # 2 is a dupe of 1
jplang's avatar
jplang committed
515
    IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
516
    # And 3 is a dupe of 2
jplang's avatar
jplang committed
517
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
518
    # And 3 is a dupe of 1 (circular duplicates)
jplang's avatar
jplang committed
519
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
520

521
    assert issue1.reload.duplicates.include?(issue2)
522

523 524 525 526 527 528
    # Closing issue 1
    issue1.init_journal(User.find(:first), "Closing issue1")
    issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
    assert issue1.save
    # 2 and 3 should be also closed
    assert issue2.reload.closed?
529
    assert issue3.reload.closed?
530
  end
531

532
  def test_should_not_close_duplicated_issue
jplang's avatar
jplang committed
533 534 535
    project = Project.find(1)
    issue1 = Issue.generate_for_project!(project)
    issue2 = Issue.generate_for_project!(project)
536

537 538 539 540
    # 2 is a dupe of 1
    IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
    # 2 is a dup of 1 but 1 is not a duplicate of 2
    assert !issue2.reload.duplicates.include?(issue1)
541

542 543 544 545 546 547 548
    # Closing issue 2
    issue2.init_journal(User.find(:first), "Closing issue2")
    issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
    assert issue2.save
    # 1 should not be also closed
    assert !issue1.reload.closed?
  end
549

550 551 552 553
  def test_assignable_versions
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
    assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  end
554

555 556 557
  def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
    assert !issue.save
558
    assert_not_nil issue.errors[:fixed_version_id]
559
  end
560

561 562 563
  def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
    assert !issue.save
564
    assert_not_nil issue.errors[:fixed_version_id]
565
  end
566

567 568 569 570
  def test_should_be_able_to_assign_a_new_issue_to_an_open_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
    assert issue.save
  end
571

572 573 574 575 576 577
  def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    assert_equal 'closed', issue.fixed_version.status
    issue.subject = 'Subject changed'
    assert issue.save
  end
578

579 580 581 582
  def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    assert !issue.save
583
    assert_not_nil issue.errors[:base]
584
  end
585

586 587 588 589 590 591
  def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    issue.fixed_version_id = 3
    assert issue.save
  end
592

593 594 595 596 597 598
  def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
    issue = Issue.find(12)
    assert_equal 'locked', issue.fixed_version.status
    issue.status_id = 1
    assert issue.save
  end
599

600 601 602 603 604 605 606 607 608
  def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
    assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  end

  def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
    Project.find(2).disable_module! :issue_tracking
    assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  end

609
  def test_move_to_another_project_with_same_category
610
    issue = Issue.find(1)
jplang's avatar
jplang committed
611 612
    issue.project = Project.find(2)
    assert issue.save
613 614
    issue.reload
    assert_equal 2, issue.project_id
615 616
    # Category changes
    assert_equal 4, issue.category_id
617 618 619
    # Make sure time entries were move to the target project
    assert_equal 2, issue.time_entries.first.project_id
  end
620

621 622
  def test_move_to_another_project_without_same_category
    issue = Issue.find(2)
jplang's avatar
jplang committed
623 624
    issue.project = Project.find(2)
    assert issue.save
625 626 627 628 629
    issue.reload
    assert_equal 2, issue.project_id
    # Category cleared
    assert_nil issue.category_id
  end
630

631 632 633
  def test_move_to_another_project_should_clear_fixed_version_when_not_shared
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 1)
jplang's avatar
jplang committed
634 635
    issue.project = Project.find(2)
    assert issue.save
636 637 638 639 640
    issue.reload
    assert_equal 2, issue.project_id
    # Cleared fixed_version
    assert_equal nil, issue.fixed_version
  end
641

642 643 644
  def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 4)
jplang's avatar
jplang committed
645 646
    issue.project = Project.find(5)
    assert issue.save
647 648 649 650 651
    issue.reload
    assert_equal 5, issue.project_id
    # Keep fixed_version
    assert_equal 4, issue.fixed_version_id
  end
652

653 654 655
  def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 1)
jplang's avatar
jplang committed
656 657
    issue.project = Project.find(5)
    assert issue.save
658 659 660 661 662
    issue.reload
    assert_equal 5, issue.project_id
    # Cleared fixed_version
    assert_equal nil, issue.fixed_version
  end
663

664 665 666
  def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 7)
jplang's avatar
jplang committed
667 668
    issue.project = Project.find(2)
    assert issue.save
669 670 671 672 673
    issue.reload
    assert_equal 2, issue.project_id
    # Keep fixed_version
    assert_equal 7, issue.fixed_version_id
  end
674

675 676 677 678 679
  def test_move_to_another_project_with_disabled_tracker
    issue = Issue.find(1)
    target = Project.find(2)
    target.tracker_ids = [3]
    target.save
jplang's avatar
jplang committed
680 681
    issue.project = target
    assert issue.save
682
    issue.reload
jplang's avatar
jplang committed
683 684
    assert_equal 2, issue.project_id
    assert_equal 3, issue.tracker_id
685
  end
686

687 688
  def test_copy_to_the_same_project
    issue = Issue.find(1)
jplang's avatar
jplang committed
689
    copy = issue.copy
690
    assert_difference 'Issue.count' do
jplang's avatar
jplang committed
691
      copy.save!
692 693 694 695 696
    end
    assert_kind_of Issue, copy
    assert_equal issue.project, copy.project
    assert_equal "125", copy.custom_value_for(2).value
  end
697

698 699
  def test_copy_to_another_project_and_tracker
    issue = Issue.find(1)
jplang's avatar
jplang committed
700
    copy = issue.copy(:project_id => 3, :tracker_id => 2)
701
    assert_difference 'Issue.count' do
jplang's avatar
jplang committed
702
      copy.save!
703
    end
jplang's avatar
jplang committed
704
    copy.reload
705 706 707 708 709 710
    assert_kind_of Issue, copy
    assert_equal Project.find(3), copy.project
    assert_equal Tracker.find(2), copy.tracker
    # Custom field #2 is not associated with target tracker
    assert_nil copy.custom_value_for(2)
  end
711

jplang's avatar
jplang committed
712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761
  context "#copy" do
    setup do
      @issue = Issue.find(1)
    end

    should "not create a journal" do
      copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
      copy.save!
      assert_equal 0, copy.reload.journals.size
    end

    should "allow assigned_to changes" do
      copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
      assert_equal 3, copy.assigned_to_id
    end

    should "allow status changes" do
      copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
      assert_equal 2, copy.status_id
    end

    should "allow start date changes" do
      date = Date.today
      copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
      assert_equal date, copy.start_date
    end

    should "allow due date changes" do
      date = Date.today
      copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
      assert_equal date, copy.due_date
    end

    should "set current user as author" do
      User.current = User.find(9)
      copy = @issue.copy(:project_id => 3, :tracker_id => 2)
      assert_equal User.current, copy.author
    end

    should "create a journal with notes" do
      date = Date.today
      notes = "Notes added when copying"
      copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
      copy.init_journal(User.current, notes)
      copy.save!

      assert_equal 1, copy.journals.size
      journal = copy.journals.first
      assert_equal 0, journal.details.size
      assert_equal notes, journal.notes
762 763
    end
  end
764

765 766 767 768 769 770 771 772 773 774 775 776
  def test_recipients_should_include_previous_assignee
    user = User.find(3)
    user.members.update_all ["mail_notification = ?", false]
    user.update_attribute :mail_notification, 'only_assigned'

    issue = Issue.find(2)
    issue.assigned_to = nil
    assert_include user.mail, issue.recipients
    issue.save!
    assert !issue.recipients.include?(user.mail)
  end

777 778 779
  def test_recipients_should_not_include_users_that_cannot_view_the_issue
    issue = Issue.find(12)
    assert issue.recipients.include?(issue.author.mail)
jplang's avatar
jplang committed
780 781
    # copy the issue to a private project
    copy  = issue.copy(:project_id => 5, :tracker_id => 2)
782 783 784
    # author is not a member of project anymore
    assert !copy.recipients.include?(copy.author.mail)
  end
785

786
  def test_recipients_should_include_the_assigned_group_members
787
    group_member = User.generate!
788 789
    group = Group.generate!
    group.users << group_member
790

791 792 793 794
    issue = Issue.find(12)
    issue.assigned_to = group
    assert issue.recipients.include?(group_member.mail)
  end
795 796 797 798 799 800 801 802

  def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
    user = User.find(3)
    issue = Issue.find(9)
    Watcher.create!(:user => user, :watchable => issue)
    assert issue.watched_by?(user)
    assert !issue.watcher_recipients.include?(user.mail)
  end
803

804 805 806 807 808
  def test_issue_destroy
    Issue.find(1).destroy
    assert_nil Issue.find_by_id(1)
    assert_nil TimeEntry.find_by_issue_id(1)
  end
809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832

  def test_destroying_a_deleted_issue_should_not_raise_an_error
    issue = Issue.find(1)
    Issue.find(1).destroy

    assert_nothing_raised do
      assert_no_difference 'Issue.count' do
        issue.destroy
      end
      assert issue.destroyed?
    end
  end

  def test_destroying_a_stale_issue_should_not_raise_an_error
    issue = Issue.find(1)
    Issue.find(1).update_attribute :subject, "Updated"

    assert_nothing_raised do
      assert_difference 'Issue.count', -1 do
        issue.destroy
      end
      assert issue.destroyed?
    end
  end
833

834 835 836
  def test_blocked
    blocked_issue = Issue.find(9)
    blocking_issue = Issue.find(10)
837

838 839 840
    assert blocked_issue.blocked?
    assert !blocking_issue.blocked?
  end
841

842 843
  def test_blocked_issues_dont_allow_closed_statuses
    blocked_issue = Issue.find(9)
844

845 846 847 848 849
    allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
    assert !allowed_statuses.empty?
    closed_statuses = allowed_statuses.select {|st| st.is_closed?}
    assert closed_statuses.empty?
  end
850

851 852
  def test_unblocked_issues_allow_closed_statuses
    blocking_issue = Issue.find(10)
853

854 855 856 857 858
    allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
    assert !allowed_statuses.empty?
    closed_statuses = allowed_statuses.select {|st| st.is_closed?}
    assert !closed_statuses.empty?
  end
859

860 861 862 863 864
  def test_rescheduling_an_issue_should_reschedule_following_issue
    issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
    issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
    IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
    assert_equal issue1.due_date + 1, issue2.reload.start_date
865

866 867 868 869
    issue1.due_date = Date.today + 5
    issue1.save!
    assert_equal issue1.due_date + 1, issue2.reload.start_date
  end
870

871 872 873 874 875 876 877 878 879 880 881 882 883
  def test_rescheduling_a_stale_issue_should_not_raise_an_error
    stale = Issue.find(1)
    issue = Issue.find(1)
    issue.subject = "Updated"
    issue.save!

    date = 10.days.from_now.to_date
    assert_nothing_raised do
      stale.reschedule_after(date)
    end
    assert_equal date, stale.reload.start_date
  end

884
  def test_overdue
885
    assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
886
    assert !Issue.new(:due_date => Date.today).overdue?
887
    assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
888
    assert !Issue.new(:due_date => nil).overdue?
889
    assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
890
  end
edavis10's avatar
edavis10 committed
891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912

  context "#behind_schedule?" do
    should "be false if the issue has no start_date" do
      assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
    end

    should "be false if the issue has no end_date" do
      assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
    end

    should "be false if the issue has more done than it's calendar time" do
      assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
    end

    should "be true if the issue hasn't been started at all" do
      assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
    end

    should "be true if the issue has used more calendar time than it's done ratio" do
      assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
    end
  end
913 914 915 916 917 918 919 920 921 922 923 924 925

  context "#assignable_users" do
    should "be Users" do
      assert_kind_of User, Issue.find(1).assignable_users.first
    end

    should "include the issue author" do
      project = Project.find(1)
      non_project_member = User.generate!
      issue = Issue.generate_for_project!(project, :author => non_project_member)

      assert issue.assignable_users.include?(non_project_member)
    end
926

927 928 929 930 931 932 933 934 935
    should "include the current assignee" do
      project = Project.find(1)
      user = User.generate!
      issue = Issue.generate_for_project!(project, :assigned_to => user)
      user.lock!

      assert Issue.find(issue.id).assignable_users.include?(user)
    end

936 937 938
    should "not show the issue author twice" do
      assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
      assert_equal 2, assignable_user_ids.length
939

940
      assignable_user_ids.each do |user_id|
941
        assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
942 943
      end
    end
944

945 946 947
    context "with issue_group_assignment" do
      should "include groups" do
        issue = Issue.new(:project => Project.find(2))
948

949 950 951 952 953