issues_controller_test.rb 45.1 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2008  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require File.dirname(__FILE__) + '/../test_helper'
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
42
           :custom_fields_projects,
43
           :custom_fields_trackers,
44 45
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
46 47
           :journal_details,
           :queries
48 49 50 51 52 53 54
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
55
  
56
  def test_index
57 58
    Setting.default_language = 'en'
    
59 60 61 62 63
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
64 65 66 67 68
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 70
    # project column
    assert_tag :tag => 'th', :content => /Project/
71
  end
72 73 74 75 76 77 78 79 80 81 82
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
83

84 85 86 87 88 89 90 91 92 93 94
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
  
95
  def test_index_with_project
96
    Setting.display_subprojects_issues = 0
97 98 99 100
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
126 127 128 129 130 131 132 133 134
  end
  
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
  end
  
jplang's avatar
jplang committed
135 136 137 138 139 140 141 142
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
143
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
144 145 146 147
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
148
    assert_not_nil assigns(:issue_count_by_group)
149 150 151 152 153 154 155
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
156
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
157 158
  end
  
jplang's avatar
jplang committed
159 160 161 162 163
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
164
  def test_index_csv_with_project
165 166
    Setting.default_language = 'en'
    
167 168 169 170
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
171
    assert @response.body.starts_with?("#,")
172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
189 190 191 192 193
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
194
  end
195
  
196 197 198 199 200 201 202 203
  def test_index_pdf_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_not_nil assigns(:issue_count_by_group)
    assert_equal 'application/pdf', @response.content_type
  end
  
204
  def test_index_sort
jplang's avatar
jplang committed
205
    get :index, :sort => 'tracker,id:desc'
206 207
    assert_response :success
    
jplang's avatar
jplang committed
208 209 210 211 212 213 214 215
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
216
  end
217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232
  
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
    get :index, :set_filter => 1, :query => { 'column_names' => columns}
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
  end
233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250

  def test_gantt
    get :gantt, :project_id => 1
    assert_response :success
    assert_template 'gantt.rhtml'
    assert_not_nil assigns(:gantt)
    events = assigns(:gantt).events
    assert_not_nil events
    # Issue with start and due dates
    i = Issue.find(1)
    assert_not_nil i.due_date
    assert events.include?(Issue.find(1))
    # Issue with without due date but targeted to a version with date
    i = Issue.find(2)
    assert_nil i.due_date
    assert events.include?(i)
  end

251 252 253 254 255 256 257 258 259
  def test_cross_project_gantt
    get :gantt
    assert_response :success
    assert_template 'gantt.rhtml'
    assert_not_nil assigns(:gantt)
    events = assigns(:gantt).events
    assert_not_nil events
  end

260 261 262 263
  def test_gantt_export_to_pdf
    get :gantt, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
264
    assert @response.body.starts_with?('%PDF')
265 266
    assert_not_nil assigns(:gantt)
  end
267 268 269 270 271

  def test_cross_project_gantt_export_to_pdf
    get :gantt, :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
272
    assert @response.body.starts_with?('%PDF')
273 274
    assert_not_nil assigns(:gantt)
  end
275 276 277 278 279 280 281 282 283 284
  
  if Object.const_defined?(:Magick)
    def test_gantt_image
      get :gantt, :project_id => 1, :format => 'png'
      assert_response :success
      assert_equal 'image/png', @response.content_type
    end
  else
    puts "RMagick not installed. Skipping tests !!!"
  end
285
  
286 287 288 289 290
  def test_calendar
    get :calendar, :project_id => 1
    assert_response :success
    assert_template 'calendar'
    assert_not_nil assigns(:calendar)
291 292 293 294 295 296 297
  end
  
  def test_cross_project_calendar
    get :calendar
    assert_response :success
    assert_template 'calendar'
    assert_not_nil assigns(:calendar)
298 299
  end
  
300 301 302
  def test_changes
    get :changes, :project_id => 1
    assert_response :success
303
    assert_not_nil assigns(:journals)
304 305
    assert_equal 'application/atom+xml', @response.content_type
  end
jplang's avatar
jplang committed
306
  
307
  def test_show_by_anonymous
jplang's avatar
jplang committed
308 309 310 311
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
312 313 314 315 316 317 318
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
jplang's avatar
jplang committed
319 320
  end
  
321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
337
  
jplang's avatar
jplang committed
338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
358 359 360 361 362 363 364 365 366 367 368 369 370 371 372
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
373 374 375 376 377
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
    assert_template 'changes.rxml'
    # Inline image
378
    assert @response.body.include?("&lt;img src=\"http://test.host/attachments/download/10\" alt=\"\" /&gt;"), "Body did not match. Body: #{@response.body}"
379 380
  end
  
jplang's avatar
jplang committed
381
  def test_show_export_to_pdf
382
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
383 384 385 386 387 388
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

389 390 391 392 393
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
394
    
395
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
396
                                                 :value => 'Default string' }
397 398 399 400 401 402 403 404 405 406 407 408 409
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No default issue/
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No tracker/
  end
  
432 433
  def test_update_new_form
    @request.session[:user_id] = 2
434
    xhr :post, :update_form, :project_id => 1,
435 436 437 438 439
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
440 441 442 443 444 445 446 447
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
448 449 450
  
  def test_post_new
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
451 452 453 454 455 456 457 458 459 460
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
461 462 463 464
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
465
    assert_equal 3, issue.tracker_id
466
    assert_nil issue.estimated_hours
467
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
468 469
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
470 471
  end
  
472 473 474 475 476 477 478 479 480 481
  def test_post_new_and_continue
    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
    assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3
  end
  
482 483
  def test_post_new_without_custom_fields_param
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
484 485 486 487 488 489 490 491
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
492
  end
493

494 495 496 497 498 499 500 501 502 503 504 505 506 507
  def test_post_new_with_required_custom_field_and_without_custom_fields_param
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
508
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
509 510
  end
  
511 512 513 514 515 516 517 518 519 520 521 522 523
  def test_post_new_with_watchers
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
524 525 526
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
527 528 529 530 531 532 533 534 535
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
536 537 538
  def test_post_new_should_send_a_notification
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
539 540 541 542 543 544 545 546 547 548
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
549 550 551 552
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
553 554 555 556
  def test_post_should_preserve_fields_values_on_validation_failure
    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 1,
557 558 559
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
560 561 562 563 564
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
565 566
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
567 568 569 570 571 572 573 574 575 576 577 578 579
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
580 581 582 583 584 585 586
  def test_post_new_should_ignore_non_safe_attributes
    @request.session[:user_id] = 2
    assert_nothing_raised do
      post :new, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
    end
  end
  
587 588 589 590 591 592 593 594 595
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
jplang's avatar
jplang committed
596 597 598 599 600 601 602 603
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
  end
626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644

  def test_update_edit_form
    @request.session[:user_id] = 2
    xhr :post, :update_form, :project_id => 1,
                             :id => 1,
                             :issue => {:tracker_id => 2, 
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
    assert_response :success
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.id
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
645 646 647 648 649 650 651 652 653 654 655 656 657 658
  
  def test_reply_to_issue
    @request.session[:user_id] = 2
    get :reply, :id => 1
    assert_response :success
    assert_select_rjs :show, "update"
  end

  def test_reply_to_note
    @request.session[:user_id] = 2
    get :reply, :id => 1, :journal_id => 2
    assert_response :success
    assert_select_rjs :show, "update"
  end
jplang's avatar
jplang committed
659

660
  def test_post_edit_without_custom_fields_param
jplang's avatar
jplang committed
661
    @request.session[:user_id] = 2
662 663 664
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
665
    assert_equal '125', issue.custom_value_for(2).value
666 667 668
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
669 670 671 672 673 674 675 676
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
        post :edit, :id => 1, :issue => {:subject => new_subject,
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
677
    assert_redirected_to :action => 'show', :id => '1'
678 679
    issue.reload
    assert_equal new_subject, issue.subject
680 681
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
682 683 684 685 686
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
jplang's avatar
jplang committed
687 688
  end
  
689 690 691 692 693 694 695 696 697 698 699 700 701 702
  def test_post_edit_with_custom_field_change
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
        post :edit, :id => 1, :issue => {:subject => 'Custom field change',
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
703
    assert_redirected_to :action => 'show', :id => '1'
704 705 706 707 708 709 710 711
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
712
  def test_post_edit_with_status_and_assignee_change
jplang's avatar
jplang committed
713 714 715
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
716 717 718 719 720
    assert_difference('TimeEntry.count', 0) do
      post :edit,
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
721
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
722
    end
723
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
724 725
    issue.reload
    assert_equal 2, issue.status_id
jplang's avatar
jplang committed
726
    j = Journal.find(:first, :order => 'id DESC')
jplang's avatar
jplang committed
727 728
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
729 730 731
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
732 733
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
734 735
  end
  
736
  def test_post_edit_with_note_only
737 738
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
739
    post :edit,
740 741
         :id => 1,
         :notes => notes
742
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
743
    j = Journal.find(:first, :order => 'id DESC')
744 745 746 747 748 749 750 751
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
752
  def test_post_edit_with_note_and_spent_time
753 754
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
755 756 757 758
    assert_difference('TimeEntry.count') do
      post :edit,
           :id => 1,
           :notes => '2.5 hours added',
759
           :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first }
760
    end
761
    assert_redirected_to :action => 'show', :id => '1'
762 763 764
    
    issue = Issue.find(1)
    
jplang's avatar
jplang committed
765
    j = Journal.find(:first, :order => 'id DESC')
766 767 768 769 770 771 772 773 774
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
    t = issue.time_entries.find(:first, :order => 'id DESC')
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
775
  def test_post_edit_with_attachment_only
jplang's avatar
jplang committed
776 777
    set_tmp_attachments_directory
    
778 779 780 781
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

782
    # anonymous user
783
    post :edit,
784 785
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
786
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
787
    assert_redirected_to :action => 'show', :id => '1'
788 789 790 791 792 793 794 795 796 797
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
  
798
  def test_post_edit_with_no_change
799 800 801 802
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
803
    post :edit,
804 805
         :id => 1,
         :notes => ''
806
    assert_redirected_to :action => 'show', :id => '1'
807 808 809 810 811
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
jplang's avatar
jplang committed
812
  end
813 814 815 816 817 818 819 820 821 822 823 824 825 826

  def test_post_edit_should_send_a_notification
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
    post :edit, :id => 1, :issue => {:subject => new_subject,
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844
  
  def test_post_edit_with_invalid_spent_time
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
      post :edit,
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_tag :textarea, :attributes => { :name => 'notes' },
                          :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
845
  
846 847 848 849 850 851 852 853 854 855 856 857 858 859 860
  def test_post_edit_should_allow_fixed_version_to_be_set_to_a_subproject
    issue = Issue.find(2)
    @request.session[:user_id] = 2

    post :edit,
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         }

    assert_response :redirect
    issue.reload
    assert_equal 4, issue.fixed_version_id
    assert_not_equal issue.project_id, issue.fixed_version.project_id
  end
861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890

  def test_post_edit_should_redirect_back_using_the_back_url_parameter
    issue = Issue.find(2)
    @request.session[:user_id] = 2

    post :edit,
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => '/issues'

    assert_response :redirect
    assert_redirected_to '/issues'
  end
  
  def test_post_edit_should_not_redirect_back_using_the_back_url_parameter_off_the_host
    issue = Issue.find(2)
    @request.session[:user_id] = 2

    post :edit,
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => 'http://google.com'

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
  end
891
  
892 893 894 895 896
  def test_get_bulk_edit
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
897 898 899 900 901
    
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert_equal 'date', field.field_format
jplang's avatar
jplang committed
902
    assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
903
    
904
    # System wide custom field
905
    assert CustomField.find(1).is_for_all?
jplang's avatar
jplang committed
906
    assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
907
  end
908 909 910 911

  def test_bulk_edit
    @request.session[:user_id] = 2
    # update issues priority
jplang's avatar
jplang committed
912 913 914 915 916
    post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing',
                                     :issue => {:priority_id => 7,
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => ''}}
                                     
917 918 919
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
920 921 922 923 924 925 926 927
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

928 929 930 931 932 933
  def test_bullk_edit_should_send_a_notification
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    post(:bulk_edit,
         {
           :ids => [1, 2],
jplang's avatar
jplang committed
934 935 936 937 938 939
           :notes => 'Bulk editing',
           :issue => {
             :priority_id => 7,
             :assigned_to_id => '',
             :custom_field_values => {'2' => ''}
           }
940 941 942 943 944 945
         })

    assert_response 302
    assert_equal 2, ActionMailer::Base.deliveries.size
  end

946 947 948
  def test_bulk_edit_status
    @request.session[:user_id] = 2
    # update issues priority
jplang's avatar
jplang committed
949 950 951 952 953
    post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing status',
                                     :issue => {:priority_id => '',
                                                :assigned_to_id => '',
                                                :status_id => '5'}
                                     
954 955 956 957 958
    assert_response 302
    issue = Issue.find(1)
    assert issue.closed?
  end

959 960 961
  def test_bulk_edit_custom_field
    @request.session[:user_id] = 2
    # update issues priority
jplang's avatar
jplang committed
962 963 964 965 966
    post :bulk_edit, :ids => [1, 2], :notes => 'Bulk editing custom field',
                                     :issue => {:priority_id => '',
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => '777'}}
                                     
967 968 969 970 971 972 973 974
    assert_response 302
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '777', issue.custom_value_for(2).value
    assert_equal 1, journal.details.size
    assert_equal '125', journal.details.first.old_value
    assert_equal '777', journal.details.first.value
975 976
  end

977 978 979 980
  def test_bulk_unassign
    assert_not_nil Issue.find(2).assigned_to
    @request.session[:user_id] = 2
    # unassign issues
jplang's avatar
jplang committed
981
  post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
982 983 984 985 986
    assert_response 302
    # check that the issues were updated
    assert_nil Issue.find(2).assigned_to
  end
  
987 988 989
  def test_post_bulk_edit_should_allow_fixed_version_to_be_set_to_a_subproject
    @request.session[:user_id] = 2

jplang's avatar
jplang committed
990
    post :bulk_edit, :ids => [1,2], :issue => {:fixed_version_id => 4}
991 992 993 994 995 996 997 998 999

    assert_response :redirect
    issues = Issue.find([1,2])
    issues.each do |issue|
      assert_equal 4, issue.fixed_version_id
      assert_not_equal issue.project_id, issue.fixed_version.project_id
    end
  end

1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015
  def test_post_bulk_edit_should_redirect_back_using_the_back_url_parameter
    @request.session[:user_id] = 2
    post :bulk_edit, :ids => [1,2], :back_url => '/issues'

    assert_response :redirect
    assert_redirected_to '/issues'
  end

  def test_post_bulk_edit_should_not_redirect_back_using_the_back_url_parameter_off_the_host
    @request.session[:user_id] = 2
    post :bulk_edit, :ids => [1,2], :back_url => 'http://google.com'

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
  end

1016
  def test_move_one_issue_to_another_project
1017
    @request.session[:user_id] = 2
1018
    post :move, :id => 1, :new_project_id => 2, :tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => ''
1019
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1020 1021 1022
    assert_equal 2, Issue.find(1).project_id
  end

1023 1024 1025 1026 1027 1028
  def test_move_one_issue_to_another_project_should_follow_when_needed
    @request.session[:user_id] = 2
    post :move, :id => 1, :new_project_id => 2, :follow => '1'
    assert_redirected_to '/issues/1'
  end

1029
  def test_bulk_move_to_another_project
1030
    @request.session[:user_id] = 2
1031
    post :move, :ids => [1, 2], :new_project_id => 2
1032
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1033 1034 1035 1036 1037 1038 1039 1040 1041
    # Issues moved to project 2
    assert_equal 2, Issue.find(1).project_id
    assert_equal 2, Issue.find(2).project_id
    # No tracker change
    assert_equal 1, Issue.find(1).tracker_id
    assert_equal 2, Issue.find(2).tracker_id
  end
 
  def test_bulk_move_to_another_tracker
1042
    @request.session[:user_id] = 2
1043
    post :move, :ids => [1, 2], :new_tracker_id => 2
1044
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1045 1046 1047
    assert_equal 2, Issue.find(1).tracker_id
    assert_equal 2, Issue.find(2).tracker_id
  end
1048 1049

  def test_bulk_copy_to_another_project
1050
    @request.session[:user_id] = 2
1051 1052 1053 1054 1055 1056 1057
    assert_difference 'Issue.count', 2 do
      assert_no_difference 'Project.find(1).issues.count' do
        post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}
      end
    end
    assert_redirected_to 'projects/ecookbook/issues'
  end
1058

1059
  context "#move via bulk copy" do
1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073
    should "allow not changing the issue's attributes" do
      @request.session[:user_id] = 2
      issue_before_move = Issue.find(1)
      assert_difference 'Issue.count', 1 do
        assert_no_difference 'Project.find(1).issues.count' do
          post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => '', :status_id => '', :start_date => '', :due_date => ''
        end
      end
      issue_after_move = Issue.first(:order => 'id desc', :conditions => {:project_id => 2})
      assert_equal issue_before_move.tracker_id, issue_after_move.tracker_id
      assert_equal issue_before_move.status_id, issue_after_move.status_id
      assert_equal issue_before_move.assigned_to_id, issue_after_move.assigned_to_id
    end
    
1074 1075 1076 1077
    should "allow changing the issue's attributes" do
      @request.session[:user_id] = 2
      assert_difference 'Issue.count', 2 do
        assert_no_difference 'Project.find(1).issues.count' do
1078
          post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}, :new_tracker_id => '', :assigned_to_id => 4, :status_id => 3, :start_date => '2009-12-01', :due_date => '2009-12-31'
1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093
        end
      end

      copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
      assert_equal 2, copied_issues.size
      copied_issues.each do |issue|
        assert_equal 2, issue.project_id, "Project is incorrect"
        assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
        assert_equal 3, issue.status_id, "Status is incorrect"
        assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
        assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
      end
    end
  end
  
1094 1095 1096 1097 1098 1099
  def test_copy_to_another_project_should_follow_when_needed
    @request.session[:user_id] = 2
    post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :follow => '1'
    issue = Issue.first(:order => 'id DESC')
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
  end
jplang's avatar
jplang committed
1100
  
1101 1102 1103 1104 1105 1106
  def test_context_menu_one_issue
    @request.session[:user_id] = 2
    get :context_menu, :ids => [1]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Edit',
1107
                            :attributes => { :href => '/issues/1/edit',
1108 1109
                                             :class => 'icon-edit' }
    assert_tag :tag => 'a', :content => 'Closed',
1110
                            :attributes => { :href => '/issues/1/edit?issue%5Bstatus_id%5D=5',
1111 1112
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Immediate',
1113
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;priority_id=8',
1114
                                             :class => '' }
1115 1116 1117 1118 1119 1120 1121 1122
    # Versions
    assert_tag :tag => 'a', :content => '2.0',
                            :attributes => { :href => '/issues/bulk_edit?fixed_version_id=3&amp;ids%5B%5D=1',
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'eCookbook Subproject 1 - 2.0',
                            :attributes => { :href => '/issues/bulk_edit?fixed_version_id=4&amp;ids%5B%5D=1',
                                             :class => '' }

1123
    assert_tag :tag => 'a', :content => 'Dave Lopper',
1124
                            :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1',
1125
                                             :class => '' }
jplang's avatar
jplang committed
1126
    assert_tag :tag => 'a', :content => 'Duplicate',
1127
                            :attributes => { :href => '/projects/ecookbook/issues/1/copy',
jplang's avatar
jplang committed
1128 1129 1130
                                             :class => 'icon-duplicate' }
    assert_tag :tag => 'a', :content => 'Copy',
                            :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&amp;ids%5B%5D=1',
1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156
                                             :class => 'icon-copy' }
    assert_tag :tag => 'a', :content => 'Move',
                            :attributes => { :href => '/issues/move?ids%5B%5D=1',
                                             :class => 'icon-move' }
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '/issues/destroy?ids%5B%5D=1',
                                             :class => 'icon-del' }
  end

  def test_context_menu_one_issue_by_anonymous
    get :context_menu, :ids => [1]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '#',
                                             :class => 'icon-del disabled' }
  end
  
  def test_context_menu_multiple_issues_of_same_project
    @request.session[:user_id] = 2
    get :context_menu, :ids => [1, 2]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Edit',
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => 'icon-edit' }
1157 1158 1159 1160 1161 1162
    assert_tag :tag => 'a', :content => 'Immediate',
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2&amp;priority_id=8',
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Dave Lopper',
                            :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => '' }
1163 1164 1165
    assert_tag :tag => 'a', :content => 'Copy',
                            :attributes => { :href => '/issues/move?copy_options%5Bcopy%5D=t&amp;ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => 'icon-copy' }