issue_test.rb 41.9 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2011  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
jplang's avatar
jplang committed
21
  fixtures :projects, :users, :members, :member_roles, :roles,
22
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
23
           :enabled_modules,
24
           :versions,
25
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 27 28 29
           :enumerations,
           :issues,
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
30

31
  def test_create
32 33 34 35
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 37 38 39
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
40

41
  def test_create_minimal
42 43 44
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create')
45 46 47
    assert issue.save
    assert issue.description.nil?
  end
48

49 50 51
  def test_create_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
52

53 54 55
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
56 57 58
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
59 60
    assert_equal I18n.translate('activerecord.errors.messages.invalid'),
                 issue.errors[:custom_values].to_s
61 62 63
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
64 65
    assert_equal I18n.translate('activerecord.errors.messages.invalid'),
                 issue.errors[:custom_values].to_s
66 67 68
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
69 70
    assert_equal I18n.translate('activerecord.errors.messages.invalid'),
                 issue.errors[:custom_values].to_s
71 72 73 74 75 76
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
77

78 79
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
80 81 82
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
83 84 85 86 87
      issue = Issue.first(:order => 'id DESC')
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
88

89 90 91 92
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
93 94 95 96 97
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
98
    assert_nil issues.detect {|issue| issue.is_private?}
99 100
    assert_visibility_match User.anonymous, issues
  end
101

102 103
  def test_visible_scope_for_anonymous_with_own_issues_visibility
    Role.anonymous.update_attribute :issues_visibility, 'own'
tmaruyama's avatar
tmaruyama committed
104 105 106
    Issue.create!(:project_id => 1, :tracker_id => 1,
                  :author_id => User.anonymous.id,
                  :subject => 'Issue by anonymous')
107

108 109 110 111 112
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != User.anonymous}
    assert_visibility_match User.anonymous, issues
  end
113

114
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
115 116 117 118
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
    issues = Issue.visible(User.anonymous).all
    assert issues.empty?
119
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
120
  end
121

122
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
123 124 125 126 127 128
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
129
    assert_nil issues.detect {|issue| issue.is_private?}
130 131
    assert_visibility_match user, issues
  end
132

133 134 135 136
  def test_visible_scope_for_non_member_with_own_issues_visibility
    Role.non_member.update_attribute :issues_visibility, 'own'
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
137

138 139 140 141 142
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
143

144
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
145 146
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
147 148
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
149 150
    issues = Issue.visible(user).all
    assert issues.empty?
151 152
    assert_visibility_match user, issues
  end
153

154 155
  def test_visible_scope_for_member
    user = User.find(9)
jplang's avatar
jplang committed
156
    # User should see issues of projects for which he has view_issues permissions only
157
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
158
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
159 160
    issues = Issue.visible(user).all
    assert issues.any?
jplang's avatar
jplang committed
161 162
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
163
    assert_visibility_match user, issues
jplang's avatar
jplang committed
164
  end
165

166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188
  def test_visible_scope_for_member_with_groups_should_return_assigned_issues
    user = User.find(8)
    assert user.groups.any?
    Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
    Role.non_member.remove_permission!(:view_issues)
    
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
      :status_id => 1, :priority => IssuePriority.all.first,
      :subject => 'Assignment test',
      :assigned_to => user.groups.first,
      :is_private => true)
    
    Role.find(2).update_attribute :issues_visibility, 'default'
    issues = Issue.visible(User.find(8)).all
    assert issues.any?
    assert issues.include?(issue)
    
    Role.find(2).update_attribute :issues_visibility, 'own'
    issues = Issue.visible(User.find(8)).all
    assert issues.any?
    assert issues.include?(issue)
  end

jplang's avatar
jplang committed
189 190 191 192 193 194 195 196
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
    issues = Issue.visible(user).all
    assert issues.any?
    # Admin should see issues on private projects that he does not belong to
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
197 198
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
199
    assert_visibility_match user, issues
jplang's avatar
jplang committed
200
  end
201

202 203 204 205 206 207 208
  def test_visible_scope_with_project
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project).all
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
209

210 211 212 213 214 215 216
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
217

218 219 220
  def test_visible_and_nested_set_scopes
    assert_equal 0, Issue.find(1).descendants.visible.all.size
  end
221

222 223 224 225 226 227 228 229 230 231
  def test_open_scope
    issues = Issue.open.all
    assert_nil issues.detect(&:closed?)
  end

  def test_open_scope_with_arg
    issues = Issue.open(false).all
    assert_equal issues, issues.select(&:closed?)
  end

232 233
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
234

tmaruyama's avatar
tmaruyama committed
235 236 237
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
238 239 240
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
241

242 243
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
tmaruyama's avatar
tmaruyama committed
244 245
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                 issue.errors.full_messages.first
246
  end
247

248 249 250
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
251

252 253 254 255 256 257 258 259 260 261 262 263 264 265
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
266

267 268 269 270
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
271

272 273 274
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
275

276 277 278
    issue.reload
    assert_equal "Can't print recipes", issue.subject
  end
279

280 281
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
282

283 284 285 286 287 288 289 290 291 292
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
293

294
  def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
295
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'Test', :custom_field_values => {'2' => 'Test'})
296 297 298 299 300 301 302 303 304 305 306
    assert !Tracker.find(2).custom_field_ids.include?(2)

    issue = Issue.find(issue.id)
    issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}

    issue = Issue.find(issue.id)
    custom_value = issue.custom_value_for(2)
    assert_not_nil custom_value
    assert_equal 'Test', custom_value.value
  end

307 308 309 310 311 312
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
313

314 315 316 317 318 319 320 321 322 323
  def test_assigning_attributes_should_assign_project_and_tracker_first
    seq = sequence('seq')
    issue = Issue.new
    issue.expects(:project_id=).in_sequence(seq)
    issue.expects(:tracker_id=).in_sequence(seq)
    issue.expects(:subject=).in_sequence(seq)
    issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  end

  def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
324 325 326 327 328 329 330 331
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
    assert_not_nil issue.custom_value_for(1)
    assert_equal 'MySQL', issue.custom_value_for(1).value
  end
332

333 334 335
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
336

337 338
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
339

340 341 342 343
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
344

345 346 347
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
348

349 350 351 352
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
353
    assert_not_nil issue.errors[:tracker_id]
354
  end
355

356
  def test_category_based_assignment
357 358 359 360
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
361 362
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
363

364 365
  def test_new_statuses_allowed_to
    Workflow.delete_all
366

367 368 369 370 371 372 373 374
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
    Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
375

376 377
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
378

379
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
jplang's avatar
jplang committed
380
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
381

382
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
jplang's avatar
jplang committed
383
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
384

385 386 387
    issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  end
388

jplang's avatar
jplang committed
389 390 391 392 393 394 395
  def test_copy
    issue = Issue.new.copy_from(1)
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
396
    assert_equal "125", issue.custom_value_for(2).value
jplang's avatar
jplang committed
397
  end
398 399 400 401

  def test_copy_should_copy_status
    orig = Issue.find(8)
    assert orig.status != IssueStatus.default
402

403 404 405 406 407
    issue = Issue.new.copy_from(orig)
    assert issue.save
    issue.reload
    assert_equal orig.status, issue.status
  end
408

409
  def test_should_close_duplicates
410
    # Create 3 issues
jplang's avatar
jplang committed
411 412 413 414
    project = Project.find(1)
    issue1 = Issue.generate_for_project!(project)
    issue2 = Issue.generate_for_project!(project)
    issue3 = Issue.generate_for_project!(project)
415

416
    # 2 is a dupe of 1
jplang's avatar
jplang committed
417
    IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
418
    # And 3 is a dupe of 2
jplang's avatar
jplang committed
419
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
420
    # And 3 is a dupe of 1 (circular duplicates)
jplang's avatar
jplang committed
421
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
422

423
    assert issue1.reload.duplicates.include?(issue2)
424

425 426 427 428 429 430
    # Closing issue 1
    issue1.init_journal(User.find(:first), "Closing issue1")
    issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
    assert issue1.save
    # 2 and 3 should be also closed
    assert issue2.reload.closed?
431
    assert issue3.reload.closed?
432
  end
433

434 435
  def test_should_not_close_duplicated_issue
    # Create 3 issues
436 437 438
    issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                       :status_id => 1, :priority => IssuePriority.all.first,
                       :subject => 'Duplicates test', :description => 'Duplicates test')
439 440 441
    assert issue1.save
    issue2 = issue1.clone
    assert issue2.save
442

443 444 445 446
    # 2 is a dupe of 1
    IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
    # 2 is a dup of 1 but 1 is not a duplicate of 2
    assert !issue2.reload.duplicates.include?(issue1)
447

448 449 450 451 452 453 454
    # Closing issue 2
    issue2.init_journal(User.find(:first), "Closing issue2")
    issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
    assert issue2.save
    # 1 should not be also closed
    assert !issue1.reload.closed?
  end
455

456 457 458 459
  def test_assignable_versions
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
    assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  end
460

461 462 463
  def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
    assert !issue.save
464
    assert_not_nil issue.errors[:fixed_version_id]
465
  end
466

467 468 469
  def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
    assert !issue.save
470
    assert_not_nil issue.errors[:fixed_version_id]
471
  end
472

473 474 475 476
  def test_should_be_able_to_assign_a_new_issue_to_an_open_version
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
    assert issue.save
  end
477

478 479 480 481 482 483
  def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    assert_equal 'closed', issue.fixed_version.status
    issue.subject = 'Subject changed'
    assert issue.save
  end
484

485 486 487 488
  def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    assert !issue.save
489
    assert_not_nil issue.errors[:base]
490
  end
491

492 493 494 495 496 497
  def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    issue.fixed_version_id = 3
    assert issue.save
  end
498

499 500 501 502 503 504
  def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
    issue = Issue.find(12)
    assert_equal 'locked', issue.fixed_version.status
    issue.status_id = 1
    assert issue.save
  end
505

506
  def test_move_to_another_project_with_same_category
507
    issue = Issue.find(1)
jplang's avatar
jplang committed
508
    assert issue.move_to_project(Project.find(2))
509 510
    issue.reload
    assert_equal 2, issue.project_id
511 512
    # Category changes
    assert_equal 4, issue.category_id
513 514 515
    # Make sure time entries were move to the target project
    assert_equal 2, issue.time_entries.first.project_id
  end
516

517 518
  def test_move_to_another_project_without_same_category
    issue = Issue.find(2)
jplang's avatar
jplang committed
519
    assert issue.move_to_project(Project.find(2))
520 521 522 523 524
    issue.reload
    assert_equal 2, issue.project_id
    # Category cleared
    assert_nil issue.category_id
  end
525

526 527 528
  def test_move_to_another_project_should_clear_fixed_version_when_not_shared
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 1)
jplang's avatar
jplang committed
529
    assert issue.move_to_project(Project.find(2))
530 531 532 533 534
    issue.reload
    assert_equal 2, issue.project_id
    # Cleared fixed_version
    assert_equal nil, issue.fixed_version
  end
535

536 537 538
  def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 4)
jplang's avatar
jplang committed
539
    assert issue.move_to_project(Project.find(5))
540 541 542 543 544
    issue.reload
    assert_equal 5, issue.project_id
    # Keep fixed_version
    assert_equal 4, issue.fixed_version_id
  end
545

546 547 548
  def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 1)
jplang's avatar
jplang committed
549
    assert issue.move_to_project(Project.find(5))
550 551 552 553 554
    issue.reload
    assert_equal 5, issue.project_id
    # Cleared fixed_version
    assert_equal nil, issue.fixed_version
  end
555

556 557 558
  def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
    issue = Issue.find(1)
    issue.update_attribute(:fixed_version_id, 7)
jplang's avatar
jplang committed
559
    assert issue.move_to_project(Project.find(2))
560 561 562 563 564
    issue.reload
    assert_equal 2, issue.project_id
    # Keep fixed_version
    assert_equal 7, issue.fixed_version_id
  end
565

566 567 568 569 570
  def test_move_to_another_project_with_disabled_tracker
    issue = Issue.find(1)
    target = Project.find(2)
    target.tracker_ids = [3]
    target.save
jplang's avatar
jplang committed
571
    assert_equal false, issue.move_to_project(target)
572 573 574
    issue.reload
    assert_equal 1, issue.project_id
  end
575

576 577 578 579
  def test_copy_to_the_same_project
    issue = Issue.find(1)
    copy = nil
    assert_difference 'Issue.count' do
jplang's avatar
jplang committed
580
      copy = issue.move_to_project(issue.project, nil, :copy => true)
581 582 583 584 585
    end
    assert_kind_of Issue, copy
    assert_equal issue.project, copy.project
    assert_equal "125", copy.custom_value_for(2).value
  end
586

587 588 589 590
  def test_copy_to_another_project_and_tracker
    issue = Issue.find(1)
    copy = nil
    assert_difference 'Issue.count' do
jplang's avatar
jplang committed
591
      copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
592
    end
jplang's avatar
jplang committed
593
    copy.reload
594 595 596 597 598 599
    assert_kind_of Issue, copy
    assert_equal Project.find(3), copy.project
    assert_equal Tracker.find(2), copy.tracker
    # Custom field #2 is not associated with target tracker
    assert_nil copy.custom_value_for(2)
  end
600

jplang's avatar
jplang committed
601
  context "#move_to_project" do
602 603 604 605 606
    context "as a copy" do
      setup do
        @issue = Issue.find(1)
        @copy = nil
      end
607

608 609 610 611
      should "not create a journal" do
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
        assert_equal 0, @copy.reload.journals.size
      end
612 613

      should "allow assigned_to changes" do
jplang's avatar
jplang committed
614
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
615 616 617 618
        assert_equal 3, @copy.assigned_to_id
      end

      should "allow status changes" do
jplang's avatar
jplang committed
619
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
620 621 622 623 624
        assert_equal 2, @copy.status_id
      end

      should "allow start date changes" do
        date = Date.today
jplang's avatar
jplang committed
625
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
626 627 628 629 630
        assert_equal date, @copy.start_date
      end

      should "allow due date changes" do
        date = Date.today
jplang's avatar
jplang committed
631
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
632 633 634

        assert_equal date, @copy.due_date
      end
635

636 637 638 639 640 641
      should "set current user as author" do
        User.current = User.find(9)
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})

        assert_equal User.current, @copy.author
      end
642

emassip's avatar
emassip committed
643
      should "create a journal with notes" do
644 645
        date = Date.today
        notes = "Notes added when copying"
emassip's avatar
emassip committed
646
        @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :notes => notes, :attributes => {:start_date => date}})
647 648 649 650 651 652

        assert_equal 1, @copy.journals.size
        journal = @copy.journals.first
        assert_equal 0, journal.details.size
        assert_equal notes, journal.notes
      end
653 654
    end
  end
655

656 657 658 659
  def test_recipients_should_not_include_users_that_cannot_view_the_issue
    issue = Issue.find(12)
    assert issue.recipients.include?(issue.author.mail)
    # move the issue to a private project
jplang's avatar
jplang committed
660
    copy  = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
661 662 663
    # author is not a member of project anymore
    assert !copy.recipients.include?(copy.author.mail)
  end
664

665 666 667 668
  def test_recipients_should_include_the_assigned_group_members
    group_member = User.generate_with_protected!
    group = Group.generate!
    group.users << group_member
669

670 671 672 673
    issue = Issue.find(12)
    issue.assigned_to = group
    assert issue.recipients.include?(group_member.mail)
  end
674 675 676 677 678 679 680 681

  def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
    user = User.find(3)
    issue = Issue.find(9)
    Watcher.create!(:user => user, :watchable => issue)
    assert issue.watched_by?(user)
    assert !issue.watcher_recipients.include?(user.mail)
  end
682

683 684 685 686 687
  def test_issue_destroy
    Issue.find(1).destroy
    assert_nil Issue.find_by_id(1)
    assert_nil TimeEntry.find_by_issue_id(1)
  end
688

689 690 691
  def test_blocked
    blocked_issue = Issue.find(9)
    blocking_issue = Issue.find(10)
692

693 694 695
    assert blocked_issue.blocked?
    assert !blocking_issue.blocked?
  end
696

697 698
  def test_blocked_issues_dont_allow_closed_statuses
    blocked_issue = Issue.find(9)
699

700 701 702 703 704
    allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
    assert !allowed_statuses.empty?
    closed_statuses = allowed_statuses.select {|st| st.is_closed?}
    assert closed_statuses.empty?
  end
705

706 707
  def test_unblocked_issues_allow_closed_statuses
    blocking_issue = Issue.find(10)
708

709 710 711 712 713
    allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
    assert !allowed_statuses.empty?
    closed_statuses = allowed_statuses.select {|st| st.is_closed?}
    assert !closed_statuses.empty?
  end
714

715 716 717 718 719
  def test_rescheduling_an_issue_should_reschedule_following_issue
    issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
    issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
    IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
    assert_equal issue1.due_date + 1, issue2.reload.start_date
720

721 722 723 724
    issue1.due_date = Date.today + 5
    issue1.save!
    assert_equal issue1.due_date + 1, issue2.reload.start_date
  end
725

726
  def test_overdue
727
    assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
728
    assert !Issue.new(:due_date => Date.today).overdue?
729
    assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
730
    assert !Issue.new(:due_date => nil).overdue?
731
    assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
732
  end
edavis10's avatar
edavis10 committed
733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754

  context "#behind_schedule?" do
    should "be false if the issue has no start_date" do
      assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
    end

    should "be false if the issue has no end_date" do
      assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
    end

    should "be false if the issue has more done than it's calendar time" do
      assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
    end

    should "be true if the issue hasn't been started at all" do
      assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
    end

    should "be true if the issue has used more calendar time than it's done ratio" do
      assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
    end
  end
755 756 757 758 759 760 761 762 763 764 765 766 767

  context "#assignable_users" do
    should "be Users" do
      assert_kind_of User, Issue.find(1).assignable_users.first
    end

    should "include the issue author" do
      project = Project.find(1)
      non_project_member = User.generate!
      issue = Issue.generate_for_project!(project, :author => non_project_member)

      assert issue.assignable_users.include?(non_project_member)
    end
768

769 770 771 772 773 774 775 776 777
    should "include the current assignee" do
      project = Project.find(1)
      user = User.generate!
      issue = Issue.generate_for_project!(project, :assigned_to => user)
      user.lock!

      assert Issue.find(issue.id).assignable_users.include?(user)
    end

778 779 780
    should "not show the issue author twice" do
      assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
      assert_equal 2, assignable_user_ids.length
781

782
      assignable_user_ids.each do |user_id|
783
        assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
784 785
      end
    end
786

787 788 789
    context "with issue_group_assignment" do
      should "include groups" do
        issue = Issue.new(:project => Project.find(2))
790

791 792 793 794 795 796
        with_settings :issue_group_assignment => '1' do
          assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
          assert issue.assignable_users.include?(Group.find(11))
        end
      end
    end
797

798 799 800
    context "without issue_group_assignment" do
      should "not include groups" do
        issue = Issue.new(:project => Project.find(2))
801

802 803 804 805 806 807
        with_settings :issue_group_assignment => '0' do
          assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
          assert !issue.assignable_users.include?(Group.find(11))
        end
      end
    end
808
  end
809

810 811
  def test_create_should_send_email_notification
    ActionMailer::Base.deliveries.clear
812 813 814 815
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 3, :status_id => 1,
                      :priority => IssuePriority.all.first,
                      :subject => 'test_create', :estimated_hours => '1:30')
816 817 818 819

    assert issue.save
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
edavis10's avatar
edavis10 committed
820

821 822 823 824
  def test_stale_issue_should_not_send_email_notification
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    stale = Issue.find(1)
825

826 827 828 829 830
    issue.init_journal(User.find(1))
    issue.subject = 'Subjet update'
    assert issue.save
    assert_equal 1, ActionMailer::Base.deliveries.size
    ActionMailer::Base.deliveries.clear
831

832 833 834 835 836 837 838
    stale.init_journal(User.find(1))
    stale.subject = 'Another subjet update'
    assert_raise ActiveRecord::StaleObjectError do
      stale.save
    end
    assert ActionMailer::Base.deliveries.empty?
  end
839

840
  def test_journalized_description
jplang's avatar
jplang committed
841
    IssueCustomField.delete_all
842

843 844 845
    i = Issue.first
    old_description = i.description
    new_description = "This is the new description"
846

847 848 849 850 851 852 853
    i.init_journal(User.find(2))
    i.description = new_description
    assert_difference 'Journal.count', 1 do
      assert_difference 'JournalDetail.count', 1 do
        i.save!
      end
    end
854

855 856 857 858 859 860 861
    detail = JournalDetail.first(:order => 'id DESC')
    assert_equal i, detail.journal.journalized
    assert_equal 'attr', detail.property
    assert_equal 'description', detail.prop_key
    assert_equal old_description, detail.old_value
    assert_equal new_description, detail.value
  end
862

863 864 865
  def test_blank_descriptions_should_not_be_journalized
    IssueCustomField.delete_all
    Issue.update_all("description = NULL", "id=1")
866

867
    i = Issue.find(1)
868 869 870
    i.init_journal(User.find(2))
    i.subject = "blank description"
    i.description = "\r\n"