issues_controller_test.rb 41.2 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2008  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require File.dirname(__FILE__) + '/../test_helper'
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
42
           :custom_fields_trackers,
43 44
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
45 46
           :journal_details,
           :queries
47 48 49 50 51 52 53
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
54 55 56 57 58 59 60
  
  def test_index_routing
    assert_routing(
      {:method => :get, :path => '/issues'},
      :controller => 'issues', :action => 'index'
    )
  end
61 62

  def test_index
63 64
    Setting.default_language = 'en'
    
65 66 67 68 69
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
70 71 72 73 74
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
75 76
    # project column
    assert_tag :tag => 'th', :content => /Project/
77
  end
78 79 80 81 82 83 84 85 86 87 88
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
89

90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114
  def test_index_with_project_routing
    assert_routing(
      {:method => :get, :path => '/projects/23/issues'},
      :controller => 'issues', :action => 'index', :project_id => '23'
    )
  end
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end

  def test_index_with_project_routing
    assert_routing(
      {:method => :get, :path => 'projects/23/issues'},
      :controller => 'issues', :action => 'index', :project_id => '23'
    )
  end
  
115
  def test_index_with_project
116
    Setting.display_subprojects_issues = 0
117 118 119 120
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
146 147
  end
  
148 149 150 151 152 153 154 155 156 157 158
  def test_index_with_project_routing_formatted
    assert_routing(
      {:method => :get, :path => 'projects/23/issues.pdf'},
      :controller => 'issues', :action => 'index', :project_id => '23', :format => 'pdf'
    )
    assert_routing(
      {:method => :get, :path => 'projects/23/issues.atom'},
      :controller => 'issues', :action => 'index', :project_id => '23', :format => 'atom'
    )
  end
  
159 160 161 162 163 164 165
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
  end
  
jplang's avatar
jplang committed
166 167 168 169 170 171 172 173
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
174
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
175 176 177 178
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
179 180 181 182 183 184 185 186 187 188 189 190 191 192 193
    count_by_group = assigns(:issue_count_by_group)
    assert_kind_of Hash, count_by_group
    assert_kind_of Tracker, count_by_group.keys.first
    assert_not_nil count_by_group[Tracker.find(1)]
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    count_by_group = assigns(:issue_count_by_group)
    assert_kind_of Hash, count_by_group
    assert_kind_of String, count_by_group.keys.first
    assert_not_nil count_by_group['MySQL']
jplang's avatar
jplang committed
194 195
  end
  
jplang's avatar
jplang committed
196 197 198 199 200
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
201
  def test_index_csv_with_project
202 203
    Setting.default_language = 'en'
    
204 205 206 207
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
208
    assert @response.body.starts_with?("#,")
209 210 211 212 213 214 215

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
216 217 218 219 220 221 222 223 224 225 226
  def test_index_formatted
    assert_routing(
      {:method => :get, :path => 'issues.pdf'},
      :controller => 'issues', :action => 'index', :format => 'pdf'
    )
    assert_routing(
      {:method => :get, :path => 'issues.atom'},
      :controller => 'issues', :action => 'index', :format => 'atom'
    )
  end
  
227 228 229 230 231 232 233 234 235 236
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
237 238 239 240 241
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
242
  end
243 244
  
  def test_index_sort
jplang's avatar
jplang committed
245
    get :index, :sort => 'tracker,id:desc'
246 247
    assert_response :success
    
jplang's avatar
jplang committed
248 249 250 251 252 253 254 255
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
256
  end
257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274

  def test_gantt
    get :gantt, :project_id => 1
    assert_response :success
    assert_template 'gantt.rhtml'
    assert_not_nil assigns(:gantt)
    events = assigns(:gantt).events
    assert_not_nil events
    # Issue with start and due dates
    i = Issue.find(1)
    assert_not_nil i.due_date
    assert events.include?(Issue.find(1))
    # Issue with without due date but targeted to a version with date
    i = Issue.find(2)
    assert_nil i.due_date
    assert events.include?(i)
  end

275 276 277 278 279 280 281 282 283
  def test_cross_project_gantt
    get :gantt
    assert_response :success
    assert_template 'gantt.rhtml'
    assert_not_nil assigns(:gantt)
    events = assigns(:gantt).events
    assert_not_nil events
  end

284 285 286 287
  def test_gantt_export_to_pdf
    get :gantt, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
288
    assert @response.body.starts_with?('%PDF')
289 290
    assert_not_nil assigns(:gantt)
  end
291 292 293 294 295

  def test_cross_project_gantt_export_to_pdf
    get :gantt, :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
296
    assert @response.body.starts_with?('%PDF')
297 298
    assert_not_nil assigns(:gantt)
  end
299 300 301 302 303 304 305 306 307 308
  
  if Object.const_defined?(:Magick)
    def test_gantt_image
      get :gantt, :project_id => 1, :format => 'png'
      assert_response :success
      assert_equal 'image/png', @response.content_type
    end
  else
    puts "RMagick not installed. Skipping tests !!!"
  end
309
  
310 311 312 313 314
  def test_calendar
    get :calendar, :project_id => 1
    assert_response :success
    assert_template 'calendar'
    assert_not_nil assigns(:calendar)
315 316 317 318 319 320 321
  end
  
  def test_cross_project_calendar
    get :calendar
    assert_response :success
    assert_template 'calendar'
    assert_not_nil assigns(:calendar)
322 323
  end
  
324 325 326
  def test_changes
    get :changes, :project_id => 1
    assert_response :success
327
    assert_not_nil assigns(:journals)
328 329
    assert_equal 'application/atom+xml', @response.content_type
  end
330
  
331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348
  def test_show_routing
    assert_routing(
      {:method => :get, :path => '/issues/64'},
      :controller => 'issues', :action => 'show', :id => '64'
    )
  end
  
  def test_show_routing_formatted
    assert_routing(
      {:method => :get, :path => '/issues/2332.pdf'},
      :controller => 'issues', :action => 'show', :id => '2332', :format => 'pdf'
    )
    assert_routing(
      {:method => :get, :path => '/issues/23123.atom'},
      :controller => 'issues', :action => 'show', :id => '23123', :format => 'atom'
    )
  end
  
349
  def test_show_by_anonymous
350 351 352 353
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
354 355 356 357 358 359 360
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
361 362
  end
  
363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
379
  
jplang's avatar
jplang committed
380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
415 416 417 418 419
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
    assert_template 'changes.rxml'
    # Inline image
420
    assert @response.body.include?("&lt;img src=\"http://test.host/attachments/download/10\" alt=\"\" /&gt;"), "Body did not match. Body: #{@response.body}"
421 422
  end
  
423 424 425 426 427 428 429 430 431 432
  def test_new_routing
    assert_routing(
      {:method => :get, :path => '/projects/1/issues/new'},
      :controller => 'issues', :action => 'new', :project_id => '1'
    )
    assert_recognizes(
      {:controller => 'issues', :action => 'new', :project_id => '1'},
      {:method => :post, :path => '/projects/1/issues'}
    )
  end
433

jplang's avatar
jplang committed
434
  def test_show_export_to_pdf
435
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
436 437 438 439 440 441
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

442 443 444 445 446
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
447
    
448
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
449
                                                 :value => 'Default string' }
450 451 452 453 454 455 456 457 458 459 460 461 462
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No default issue/
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No tracker/
  end
  
485 486 487 488 489 490 491 492 493
  def test_update_new_form
    @request.session[:user_id] = 2
    xhr :post, :new, :project_id => 1,
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
    assert_template 'new'
494
  end 
495 496 497
  
  def test_post_new
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
498 499 500 501 502 503 504 505 506 507
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
508 509 510 511
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
512
    assert_equal 3, issue.tracker_id
513
    assert_nil issue.estimated_hours
514
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
515 516
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
517 518
  end
  
519 520 521 522 523 524 525 526 527 528
  def test_post_new_and_continue
    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
    assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3
  end
  
529 530
  def test_post_new_without_custom_fields_param
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
531 532 533 534 535 536 537 538
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
539
  end
540

541 542 543 544 545 546 547 548 549 550 551 552 553 554
  def test_post_new_with_required_custom_field_and_without_custom_fields_param
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
555
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
556 557
  end
  
558 559 560 561 562 563 564 565 566 567 568 569 570
  def test_post_new_with_watchers
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
571 572 573
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
574 575 576 577 578 579 580 581 582
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
583 584 585
  def test_post_new_should_send_a_notification
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
586 587 588 589 590 591 592 593 594 595
    assert_difference 'Issue.count' do
      post :new, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
596 597 598 599
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
600 601 602 603
  def test_post_should_preserve_fields_values_on_validation_failure
    @request.session[:user_id] = 2
    post :new, :project_id => 1, 
               :issue => {:tracker_id => 1,
604 605 606
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
607 608 609 610 611
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
612 613
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
614 615 616 617 618 619 620 621 622 623 624 625 626
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
627 628 629 630 631 632 633
  def test_copy_routing
    assert_routing(
      {:method => :get, :path => '/projects/world_domination/issues/567/copy'},
      :controller => 'issues', :action => 'new', :project_id => 'world_domination', :copy_from => '567'
    )
  end
  
634 635 636 637 638 639 640 641 642
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
643 644 645 646 647 648 649 650 651 652 653
  def test_edit_routing
    assert_routing(
      {:method => :get, :path => '/issues/1/edit'},
      :controller => 'issues', :action => 'edit', :id => '1'
    )
    assert_recognizes( #TODO: use a PUT on the issue URI isntead, need to adjust form
      {:controller => 'issues', :action => 'edit', :id => '1'},
      {:method => :post, :path => '/issues/1/edit'}
    )
  end
  
654 655 656 657 658 659 660 661
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
  end
684
  
685 686 687 688 689 690 691
  def test_reply_routing
    assert_routing(
      {:method => :post, :path => '/issues/1/quoted'},
      :controller => 'issues', :action => 'reply', :id => '1'
    )
  end
  
692 693 694 695 696 697 698 699 700 701 702 703 704
  def test_reply_to_issue
    @request.session[:user_id] = 2
    get :reply, :id => 1
    assert_response :success
    assert_select_rjs :show, "update"
  end

  def test_reply_to_note
    @request.session[:user_id] = 2
    get :reply, :id => 1, :journal_id => 2
    assert_response :success
    assert_select_rjs :show, "update"
  end
705

706
  def test_post_edit_without_custom_fields_param
707
    @request.session[:user_id] = 2
708 709 710
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
711
    assert_equal '125', issue.custom_value_for(2).value
712 713 714
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
715 716 717 718 719 720 721 722
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
        post :edit, :id => 1, :issue => {:subject => new_subject,
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
723
    assert_redirected_to :action => 'show', :id => '1'
724 725
    issue.reload
    assert_equal new_subject, issue.subject
726 727
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
728 729 730 731 732
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
733 734
  end
  
735 736 737 738 739 740 741 742 743 744 745 746 747 748
  def test_post_edit_with_custom_field_change
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
        post :edit, :id => 1, :issue => {:subject => 'Custom field change',
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
749
    assert_redirected_to :action => 'show', :id => '1'
750 751 752 753 754 755 756 757
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
758
  def test_post_edit_with_status_and_assignee_change
759 760 761
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
762 763 764 765 766
    assert_difference('TimeEntry.count', 0) do
      post :edit,
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
767
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
768
    end
769
    assert_redirected_to :action => 'show', :id => '1'
770 771
    issue.reload
    assert_equal 2, issue.status_id
772
    j = issue.journals.find(:first, :order => 'id DESC')
773 774
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
775 776 777
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
778 779
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
780 781
  end
  
782
  def test_post_edit_with_note_only
783 784
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
785
    post :edit,
786 787
         :id => 1,
         :notes => notes
788
    assert_redirected_to :action => 'show', :id => '1'
789 790 791 792 793 794 795 796 797
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
798
  def test_post_edit_with_note_and_spent_time
799 800
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
801 802 803 804
    assert_difference('TimeEntry.count') do
      post :edit,
           :id => 1,
           :notes => '2.5 hours added',
805
           :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first }
806
    end
807
    assert_redirected_to :action => 'show', :id => '1'
808 809 810 811 812 813 814 815 816 817 818 819 820
    
    issue = Issue.find(1)
    
    j = issue.journals.find(:first, :order => 'id DESC')
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
    t = issue.time_entries.find(:first, :order => 'id DESC')
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
821
  def test_post_edit_with_attachment_only
822 823
    set_tmp_attachments_directory
    
824 825 826 827
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

828
    # anonymous user
829
    post :edit,
830 831
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
832
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
833
    assert_redirected_to :action => 'show', :id => '1'
834 835 836 837 838 839 840 841 842 843
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
  
844
  def test_post_edit_with_no_change
845 846 847 848
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
849
    post :edit,
850 851
         :id => 1,
         :notes => ''
852
    assert_redirected_to :action => 'show', :id => '1'
853 854 855 856 857
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
858
  end
859 860 861 862 863 864 865 866 867 868 869 870 871 872

  def test_post_edit_should_send_a_notification
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
    post :edit, :id => 1, :issue => {:subject => new_subject,
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890
  
  def test_post_edit_with_invalid_spent_time
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
      post :edit,
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_tag :textarea, :attributes => { :name => 'notes' },
                          :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
891 892 893 894 895 896 897
  
  def test_get_bulk_edit
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
  end
898 899 900 901

  def test_bulk_edit
    @request.session[:user_id] = 2
    # update issues priority
902 903 904 905
    post :bulk_edit, :ids => [1, 2], :priority_id => 7,
                                     :assigned_to_id => '',
                                     :custom_field_values => {'2' => ''},
                                     :notes => 'Bulk editing'
906 907 908
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
909 910 911 912 913 914 915 916
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932
  def test_bullk_edit_should_send_a_notification
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    post(:bulk_edit,
         {
           :ids => [1, 2],
           :priority_id => 7,
           :assigned_to_id => '',
           :custom_field_values => {'2' => ''},
           :notes => 'Bulk editing'
         })

    assert_response 302
    assert_equal 2, ActionMailer::Base.deliveries.size
  end

933 934 935 936 937 938 939 940 941 942 943 944
  def test_bulk_edit_status
    @request.session[:user_id] = 2
    # update issues priority
    post :bulk_edit, :ids => [1, 2], :priority_id => '',
                                     :assigned_to_id => '',
                                     :status_id => '5',
                                     :notes => 'Bulk editing status'
    assert_response 302
    issue = Issue.find(1)
    assert issue.closed?
  end

945 946 947 948 949 950 951 952 953 954 955 956 957 958 959
  def test_bulk_edit_custom_field
    @request.session[:user_id] = 2
    # update issues priority
    post :bulk_edit, :ids => [1, 2], :priority_id => '',
                                     :assigned_to_id => '',
                                     :custom_field_values => {'2' => '777'},
                                     :notes => 'Bulk editing custom field'
    assert_response 302
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '777', issue.custom_value_for(2).value
    assert_equal 1, journal.details.size
    assert_equal '125', journal.details.first.old_value
    assert_equal '777', journal.details.first.value
960 961
  end

962 963 964 965 966 967 968 969 970 971
  def test_bulk_unassign
    assert_not_nil Issue.find(2).assigned_to
    @request.session[:user_id] = 2
    # unassign issues
    post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :assigned_to_id => 'none'
    assert_response 302
    # check that the issues were updated
    assert_nil Issue.find(2).assigned_to
  end
  
972 973 974 975 976 977 978 979 980 981 982
  def test_move_routing
    assert_routing(
      {:method => :get, :path => '/issues/1/move'},
      :controller => 'issues', :action => 'move', :id => '1'
    )
    assert_recognizes(
      {:controller => 'issues', :action => 'move', :id => '1'},
      {:method => :post, :path => '/issues/1/move'}
    )
  end
  
983
  def test_move_one_issue_to_another_project
984
    @request.session[:user_id] = 2
985
    post :move, :id => 1, :new_project_id => 2
986
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
987 988 989
    assert_equal 2, Issue.find(1).project_id
  end

990 991 992 993 994 995
  def test_move_one_issue_to_another_project_should_follow_when_needed
    @request.session[:user_id] = 2
    post :move, :id => 1, :new_project_id => 2, :follow => '1'
    assert_redirected_to '/issues/1'
  end

996
  def test_bulk_move_to_another_project
997
    @request.session[:user_id] = 2
998
    post :move, :ids => [1, 2], :new_project_id => 2
999
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1000 1001 1002 1003 1004 1005 1006 1007 1008
    # Issues moved to project 2
    assert_equal 2, Issue.find(1).project_id
    assert_equal 2, Issue.find(2).project_id
    # No tracker change
    assert_equal 1, Issue.find(1).tracker_id
    assert_equal 2, Issue.find(2).tracker_id
  end
 
  def test_bulk_move_to_another_tracker
1009
    @request.session[:user_id] = 2
1010
    post :move, :ids => [1, 2], :new_tracker_id => 2
1011
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1012 1013 1014
    assert_equal 2, Issue.find(1).tracker_id
    assert_equal 2, Issue.find(2).tracker_id
  end
1015 1016

  def test_bulk_copy_to_another_project
1017
    @request.session[:user_id] = 2
1018 1019 1020 1021 1022 1023 1024
    assert_difference 'Issue.count', 2 do
      assert_no_difference 'Project.find(1).issues.count' do
        post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}
      end
    end
    assert_redirected_to 'projects/ecookbook/issues'
  end
1025 1026 1027 1028 1029 1030 1031

  def test_copy_to_another_project_should_follow_when_needed
    @request.session[:user_id] = 2
    post :move, :ids => [1], :new_project_id => 2, :copy_options => {:copy => '1'}, :follow => '1'
    issue = Issue.first(:order => 'id DESC')
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
  end
1032
  
1033 1034 1035 1036 1037 1038
  def test_context_menu_one_issue
    @request.session[:user_id] = 2
    get :context_menu, :ids => [1]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Edit',
1039
                            :attributes => { :href => '/issues/1/edit',
1040 1041
                                             :class => 'icon-edit' }
    assert_tag :tag => 'a', :content => 'Closed',
1042
                            :attributes => { :href => '/issues/1/edit?issue%5Bstatus_id%5D=5',
1043 1044
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Immediate',
1045
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;priority_id=8',
1046 1047
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Dave Lopper',
1048
                            :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1',
1049 1050
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Copy',
1051
                            :attributes => { :href => '/projects/ecookbook/issues/1/copy',
1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077
                                             :class => 'icon-copy' }
    assert_tag :tag => 'a', :content => 'Move',
                            :attributes => { :href => '/issues/move?ids%5B%5D=1',
                                             :class => 'icon-move' }
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '/issues/destroy?ids%5B%5D=1',
                                             :class => 'icon-del' }
  end

  def test_context_menu_one_issue_by_anonymous
    get :context_menu, :ids => [1]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '#',
                                             :class => 'icon-del disabled' }
  end
  
  def test_context_menu_multiple_issues_of_same_project
    @request.session[:user_id] = 2
    get :context_menu, :ids => [1, 2]
    assert_response :success
    assert_template 'context_menu'
    assert_tag :tag => 'a', :content => 'Edit',
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => 'icon-edit' }
1078 1079 1080 1081 1082 1083
    assert_tag :tag => 'a', :content => 'Immediate',
                            :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2&amp;priority_id=8',
                                             :class => '' }
    assert_tag :tag => 'a', :content => 'Dave Lopper',
                            :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => '' }
1084 1085 1086 1087 1088 1089 1090 1091 1092
    assert_tag :tag => 'a', :content => 'Move',
                            :attributes => { :href => '/issues/move?ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => 'icon-move' }
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '/issues/destroy?ids%5B%5D=1&amp;ids%5B%5D=2',
                                             :class => 'icon-del' }
  end

  def test_context_menu_multiple_issues_of_different_project
1093
    @request.session[:user_id] = 2
1094
    get :context_menu, :ids => [1, 2, 4]
1095 1096
    assert_response :success
    assert_template 'context_menu'
1097 1098 1099
    assert_tag :tag => 'a', :content => 'Delete',
                            :attributes => { :href => '#',
                                             :class => 'icon-del disabled' }
1100 1101
  end
  
1102 1103 1104 1105 1106 1107 1108
  def test_destroy_routing
    assert_recognizes( #TODO: use DELETE on issue URI (need to change forms)
      {:controller => 'issues', :action => 'destroy', :id => '1'},
      {:method => :post, :path => '/issues/1/destroy'}
    )
  end
  
1109
  def test_destroy_issue_with_no_time_entries
1110
    assert_nil TimeEntry.find_by_issue_id(2)
1111
    @request.session[:user_id] = 2
1112
    post :destroy, :id => 2
1113
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1114
    assert_nil Issue.find_by_id(2)
1115 1116
  end

1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
  def test_destroy_issues_with_time_entries
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3]
    assert_response :success
    assert_template 'destroy'
    assert_not_nil assigns(:hours)
    assert Issue.find_by_id(1) && Issue.find_by_id(3)
  end

  def test_destroy_issues_and_destroy_time_entries
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3], :todo => 'destroy'
1129
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1130 1131 1132 1133 1134 1135 1136
    assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
    assert_nil TimeEntry.find_by_id([1, 2])
  end

  def test_destroy_issues_and_assign_time_entries_to_project
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3], :todo => 'nullify'
1137
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1138 1139 1140 1141 1142 1143 1144 1145
    assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
    assert_nil TimeEntry.find(1).issue_id
    assert_nil TimeEntry.find(2).issue_id
  end
  
  def test_destroy_issues_and_reassign_time_entries_to_another_issue
    @request.session[:user_id] = 2
    post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
1146
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1147 1148 1149 1150
    assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
    assert_equal 2, TimeEntry.find(1).issue_id
    assert_equal 2, TimeEntry.find(2).issue_id
  end
jplang's avatar
jplang committed
1151 1152 1153 1154 1155 1156 1157
  
  def test_default_search_scope
    get :index
    assert_tag :div, :attributes => {:id => 'quick-search'},
                     :child => {:tag => 'form',
                                :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
  end
1158
end