issues_controller_test.rb 147 KB
Newer Older
1
# Redmine - project management software
marutosijp's avatar
marutosijp committed
2
# Copyright (C) 2006-2014  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssuesControllerTest < ActionController::TestCase
21 22 23 24
  fixtures :projects,
           :users,
           :roles,
           :members,
25
           :member_roles,
26 27
           :issues,
           :issue_statuses,
28
           :issue_relations,
29
           :versions,
30
           :trackers,
31
           :projects_trackers,
32 33 34
           :issue_categories,
           :enabled_modules,
           :enumerations,
35
           :attachments,
36 37 38
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
39
           :custom_fields_projects,
40
           :custom_fields_trackers,
41 42
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
43
           :journal_details,
44 45 46
           :queries,
           :repositories,
           :changesets
47

48 49
  include Redmine::I18n

50 51 52
  def setup
    User.current = nil
  end
53

54
  def test_index
55 56 57 58 59 60
    with_settings :default_language => "en" do
      get :index
      assert_response :success
      assert_template 'index'
      assert_not_nil assigns(:issues)
      assert_nil assigns(:project)
61 62

      # links to visible issues
63
      assert_select 'a[href=/issues/1]', :text => /#{ESCAPED_UCANT} print recipes/
64
      assert_select 'a[href=/issues/5]', :text => /Subproject issue/
65
      # private projects hidden
66 67
      assert_select 'a[href=/issues/6]', 0
      assert_select 'a[href=/issues/4]', 0
68
      # project column
69
      assert_select 'th', :text => /Project/
70
    end
71
  end
72

73 74
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
75 76
    get :index
    assert_response :success
77
    assert_template 'index'
78 79
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
80 81 82

    assert_select 'a[href=/issues/1]', 0
    assert_select 'a[href=/issues/5]', :text => /Subproject issue/
83
  end
jplang's avatar
jplang committed
84 85 86 87 88 89 90

  def test_index_should_list_visible_issues_only
    get :index, :per_page => 100
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issues).detect {|issue| !issue.visible?}
  end
91

92
  def test_index_with_project
93
    Setting.display_subprojects_issues = 0
94 95
    get :index, :project_id => 1
    assert_response :success
96
    assert_template 'index'
97
    assert_not_nil assigns(:issues)
98

99
    assert_select 'a[href=/issues/1]', :text => /#{ESCAPED_UCANT} print recipes/
100
    assert_select 'a[href=/issues/5]', 0
101
  end
102

103 104 105 106
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
107
    assert_template 'index'
108
    assert_not_nil assigns(:issues)
109

110
    assert_select 'a[href=/issues/1]', :text => /#{ESCAPED_UCANT} print recipes/
111 112
    assert_select 'a[href=/issues/5]', :text => /Subproject issue/
    assert_select 'a[href=/issues/6]', 0
113
  end
114

115
  def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
116 117 118 119
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
120
    assert_template 'index'
121
    assert_not_nil assigns(:issues)
122

123
    assert_select 'a[href=/issues/1]', :text => /#{ESCAPED_UCANT} print recipes/
124 125
    assert_select 'a[href=/issues/5]', :text => /Subproject issue/
    assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
126
  end
127

128
  def test_index_with_project_and_default_filter
129 130
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
131
    assert_template 'index'
132
    assert_not_nil assigns(:issues)
133

134 135 136 137 138
    query = assigns(:query)
    assert_not_nil query
    # default filter
    assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
  end
139

140
  def test_index_with_project_and_filter
141
    get :index, :project_id => 1, :set_filter => 1,
jplang's avatar
jplang committed
142 143
      :f => ['tracker_id'],
      :op => {'tracker_id' => '='},
144
      :v => {'tracker_id' => ['1']}
145
    assert_response :success
146
    assert_template 'index'
147
    assert_not_nil assigns(:issues)
148

149 150 151 152
    query = assigns(:query)
    assert_not_nil query
    assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
  end
153

154 155 156 157 158 159 160 161 162 163 164 165 166 167 168
  def test_index_with_short_filters
    to_test = {
      'status_id' => {
        'o' => { :op => 'o', :values => [''] },
        'c' => { :op => 'c', :values => [''] },
        '7' => { :op => '=', :values => ['7'] },
        '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
        '=7' => { :op => '=', :values => ['7'] },
        '!3' => { :op => '!', :values => ['3'] },
        '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
      'subject' => {
        'This is a subject' => { :op => '=', :values => ['This is a subject'] },
        'o' => { :op => '=', :values => ['o'] },
        '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
        '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
169 170
      'tracker_id' => {
        '3' => { :op => '=', :values => ['3'] },
emassip's avatar
emassip committed
171
        '=3' => { :op => '=', :values => ['3'] }},
172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187
      'start_date' => {
        '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
        '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
        '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
        '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
        '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
        '<t+2' => { :op => '<t+', :values => ['2'] },
        '>t+2' => { :op => '>t+', :values => ['2'] },
        't+2' => { :op => 't+', :values => ['2'] },
        't' => { :op => 't', :values => [''] },
        'w' => { :op => 'w', :values => [''] },
        '>t-2' => { :op => '>t-', :values => ['2'] },
        '<t-2' => { :op => '<t-', :values => ['2'] },
        't-2' => { :op => 't-', :values => ['2'] }},
      'created_on' => {
        '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
188 189 190
        '<t-2' => { :op => '<t-', :values => ['2'] },
        '>t-2' => { :op => '>t-', :values => ['2'] },
        't-2' => { :op => 't-', :values => ['2'] }},
191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
      'cf_1' => {
        'c' => { :op => '=', :values => ['c'] },
        '!c' => { :op => '!', :values => ['c'] },
        '!*' => { :op => '!*', :values => [''] },
        '*' => { :op => '*', :values => [''] }},
      'estimated_hours' => {
        '=13.4' => { :op => '=', :values => ['13.4'] },
        '>=45' => { :op => '>=', :values => ['45'] },
        '<=125' => { :op => '<=', :values => ['125'] },
        '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
        '!*' => { :op => '!*', :values => [''] },
        '*' => { :op => '*', :values => [''] }}
    }

    default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}

    to_test.each do |field, expression_and_expected|
      expression_and_expected.each do |filter_expression, expected|
emassip's avatar
emassip committed
209

210 211 212 213 214 215 216 217 218 219 220 221 222 223
        get :index, :set_filter => 1, field => filter_expression

        assert_response :success
        assert_template 'index'
        assert_not_nil assigns(:issues)

        query = assigns(:query)
        assert_not_nil query
        assert query.has_filter?(field)
        assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
      end
    end
  end

224 225 226
  def test_index_with_project_and_empty_filters
    get :index, :project_id => 1, :set_filter => 1, :fields => ['']
    assert_response :success
227
    assert_template 'index'
228
    assert_not_nil assigns(:issues)
229

230 231 232 233
    query = assigns(:query)
    assert_not_nil query
    # no filter
    assert_equal({}, query.filters)
234
  end
235

236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251
  def test_index_with_project_custom_field_filter
    field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
    CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
    CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
    filter_name = "project.cf_#{field.id}"
    @request.session[:user_id] = 1

    get :index, :set_filter => 1,
      :f => [filter_name],
      :op => {filter_name => '='},
      :v => {filter_name => ['Foo']}
    assert_response :success
    assert_template 'index'
    assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
  end

jplang's avatar
jplang committed
252 253 254
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
255
    assert_template 'index'
jplang's avatar
jplang committed
256 257 258
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
259

260
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
261 262
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
263
    assert_template 'index'
jplang's avatar
jplang committed
264
    assert_not_nil assigns(:issues)
265
    assert_not_nil assigns(:issue_count_by_group)
266
  end
267

268 269 270
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
271
    assert_template 'index'
272
    assert_not_nil assigns(:issues)
273
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
274
  end
275

276 277 278 279 280 281 282 283 284 285 286 287 288
  def test_index_with_query_grouped_by_user_custom_field
    cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')

    get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
    assert_response :success

    assert_select 'tr.group', 3
    assert_select 'tr.group' do
      assert_select 'a', :text => 'John Smith'
jplang's avatar
jplang committed
289
      assert_select 'span.count', :text => '1'
290 291 292
    end
    assert_select 'tr.group' do
      assert_select 'a', :text => 'Dave Lopper'
jplang's avatar
jplang committed
293
      assert_select 'span.count', :text => '2'
294 295 296
    end
  end

297
  def test_index_with_query_grouped_by_tracker_in_normal_order
298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316
    3.times {|i| Issue.generate!(:tracker_id => (i + 1))}

    get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
    assert_response :success

    trackers = assigns(:issues).map(&:tracker).uniq
    assert_equal [1, 2, 3], trackers.map(&:id)
  end

  def test_index_with_query_grouped_by_tracker_in_reverse_order
    3.times {|i| Issue.generate!(:tracker_id => (i + 1))}

    get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
    assert_response :success

    trackers = assigns(:issues).map(&:tracker).uniq
    assert_equal [3, 2, 1], trackers.map(&:id)
  end

317 318 319 320 321 322 323 324
  def test_index_with_query_id_and_project_id_should_set_session_query
    get :index, :project_id => 1, :query_id => 4
    assert_response :success
    assert_kind_of Hash, session[:query]
    assert_equal 4, session[:query][:id]
    assert_equal 1, session[:query][:project_id]
  end

325 326 327 328 329
  def test_index_with_invalid_query_id_should_respond_404
    get :index, :project_id => 1, :query_id => 999
    assert_response 404
  end

330
  def test_index_with_cross_project_query_in_session_should_show_project_issues
jplang's avatar
jplang committed
331
    q = IssueQuery.create!(:name => "test", :user_id => 2, :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
332 333 334 335 336 337 338 339 340 341 342 343
    @request.session[:query] = {:id => q.id, :project_id => 1}

    with_settings :display_subprojects_issues => '0' do
      get :index, :project_id => 1
    end
    assert_response :success
    assert_not_nil assigns(:query)
    assert_equal q.id, assigns(:query).id
    assert_equal 1, assigns(:query).project_id
    assert_equal [1], assigns(:issues).map(&:project_id).uniq
  end

344
  def test_private_query_should_not_be_available_to_other_users
jplang's avatar
jplang committed
345
    q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
346
    @request.session[:user_id] = 3
347

348 349 350
    get :index, :query_id => q.id
    assert_response 403
  end
351

352
  def test_private_query_should_be_available_to_its_user
jplang's avatar
jplang committed
353
    q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
354
    @request.session[:user_id] = 2
355

356 357 358
    get :index, :query_id => q.id
    assert_response :success
  end
359

360
  def test_public_query_should_be_available_to_other_users
jplang's avatar
jplang committed
361
    q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PUBLIC, :project => nil)
362
    @request.session[:user_id] = 3
363

364 365 366
    get :index, :query_id => q.id
    assert_response :success
  end
367

368 369 370 371 372 373 374 375 376
  def test_index_should_omit_page_param_in_export_links
    get :index, :page => 2
    assert_response :success
    assert_select 'a.atom[href=/issues.atom]'
    assert_select 'a.csv[href=/issues.csv]'
    assert_select 'a.pdf[href=/issues.pdf]'
    assert_select 'form#csv-export-form[action=/issues.csv]'
  end

377 378 379 380 381 382 383 384 385 386 387 388 389 390
  def test_index_should_not_warn_when_not_exceeding_export_limit
    with_settings :issues_export_limit => 200 do
      get :index
      assert_select '#csv-export-options p.icon-warning', 0
    end
  end

  def test_index_should_warn_when_exceeding_export_limit
    with_settings :issues_export_limit => 2 do
      get :index
      assert_select '#csv-export-options p.icon-warning', :text => %r{limit: 2}
    end
  end

391
  def test_index_csv
392 393 394
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
jplang's avatar
jplang committed
395
    assert_equal 'text/csv; header=present', @response.content_type
396
    assert @response.body.starts_with?("#,")
397
    lines = @response.body.chomp.split("\n")
398
    assert_equal assigns(:query).columns.size, lines[0].split(',').size
399
  end
400

401
  def test_index_csv_with_project
402 403 404
    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
jplang's avatar
jplang committed
405
    assert_equal 'text/csv; header=present', @response.content_type
406
  end
407

408
  def test_index_csv_with_description
409 410 411 412 413 414 415 416 417 418 419 420
    Issue.generate!(:description => 'test_index_csv_with_description')

    with_settings :default_language => 'en' do
      get :index, :format => 'csv', :description => '1'
      assert_response :success
      assert_not_nil assigns(:issues)
    end

    assert_equal 'text/csv; header=present', response.content_type
    headers = response.body.chomp.split("\n").first.split(',')
    assert_include 'Description', headers
    assert_include 'test_index_csv_with_description', response.body
421 422
  end

423
  def test_index_csv_with_spent_time_column
jplang's avatar
jplang committed
424 425
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
    TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
426 427 428

    get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
    assert_response :success
jplang's avatar
jplang committed
429
    assert_equal 'text/csv; header=present', @response.content_type
430 431 432 433
    lines = @response.body.chomp.split("\n")
    assert_include "#{issue.id},#{issue.subject},7.33", lines
  end

434 435 436 437
  def test_index_csv_with_all_columns
    get :index, :format => 'csv', :columns => 'all'
    assert_response :success
    assert_not_nil assigns(:issues)
jplang's avatar
jplang committed
438
    assert_equal 'text/csv; header=present', @response.content_type
439 440 441
    assert_match /\A#,/, response.body
    lines = response.body.chomp.split("\n")
    assert_equal assigns(:query).available_inline_columns.size, lines[0].split(',').size
442 443
  end

jplang's avatar
jplang committed
444 445 446 447 448 449 450 451 452 453 454 455
  def test_index_csv_with_multi_column_field
    CustomField.find(1).update_attribute :multiple, true
    issue = Issue.find(1)
    issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
    issue.save!

    get :index, :format => 'csv', :columns => 'all'
    assert_response :success
    lines = @response.body.chomp.split("\n")
    assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
  end

456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474
  def test_index_csv_should_format_float_custom_fields_with_csv_decimal_separator
    field = IssueCustomField.create!(:name => 'Float', :is_for_all => true, :tracker_ids => [1], :field_format => 'float')
    issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id => '185.6'})

    with_settings :default_language => 'fr' do
      get :index, :format => 'csv', :columns => 'all'
      assert_response :success
      issue_line = response.body.chomp.split("\n").map {|line| line.split(';')}.detect {|line| line[0]==issue.id.to_s}
      assert_include '185,60', issue_line
    end

    with_settings :default_language => 'en' do
      get :index, :format => 'csv', :columns => 'all'
      assert_response :success
      issue_line = response.body.chomp.split("\n").map {|line| line.split(',')}.detect {|line| line[0]==issue.id.to_s}
      assert_include '185.60', issue_line
    end
  end

475 476
  def test_index_csv_big_5
    with_settings :default_language => "zh-TW" do
jplang's avatar
jplang committed
477 478
      str_utf8  = "\xe4\xb8\x80\xe6\x9c\x88".force_encoding('UTF-8')
      str_big5  = "\xa4@\xa4\xeb".force_encoding('Big5')
jplang's avatar
jplang committed
479
      issue = Issue.generate!(:subject => str_utf8)
480 481 482 483 484

      get :index, :project_id => 1, 
                  :f => ['subject'], 
                  :op => '=', :values => [str_utf8],
                  :format => 'csv'
jplang's avatar
jplang committed
485
      assert_equal 'text/csv; header=present', @response.content_type
486
      lines = @response.body.chomp.split("\n")
jplang's avatar
jplang committed
487
      s1 = "\xaa\xac\xbaA".force_encoding('Big5')
488 489
      assert_include s1, lines[0]
      assert_include str_big5, lines[1]
490 491 492
    end
  end

493 494
  def test_index_csv_cannot_convert_should_be_replaced_big_5
    with_settings :default_language => "zh-TW" do
jplang's avatar
jplang committed
495
      str_utf8  = "\xe4\xbb\xa5\xe5\x86\x85".force_encoding('UTF-8')
jplang's avatar
jplang committed
496
      issue = Issue.generate!(:subject => str_utf8)
497 498 499 500

      get :index, :project_id => 1, 
                  :f => ['subject'], 
                  :op => '=', :values => [str_utf8],
501 502 503
                  :c => ['status', 'subject'],
                  :format => 'csv',
                  :set_filter => 1
jplang's avatar
jplang committed
504
      assert_equal 'text/csv; header=present', @response.content_type
505
      lines = @response.body.chomp.split("\n")
jplang's avatar
jplang committed
506
      s1 = "\xaa\xac\xbaA".force_encoding('Big5') # status
507
      assert lines[0].include?(s1)
508
      s2 = lines[1].split(",")[2]
jplang's avatar
jplang committed
509 510
      s3 = "\xa5H?".force_encoding('Big5') # subject
      assert_equal s3, s2
511 512 513
    end
  end

514 515 516
  def test_index_csv_tw
    with_settings :default_language => "zh-TW" do
      str1  = "test_index_csv_tw"
jplang's avatar
jplang committed
517
      issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
518 519 520 521 522 523 524

      get :index, :project_id => 1, 
                  :f => ['subject'], 
                  :op => '=', :values => [str1],
                  :c => ['estimated_hours', 'subject'],
                  :format => 'csv',
                  :set_filter => 1
jplang's avatar
jplang committed
525
      assert_equal 'text/csv; header=present', @response.content_type
526
      lines = @response.body.chomp.split("\n")
527
      assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
528 529 530 531 532 533
    end
  end

  def test_index_csv_fr
    with_settings :default_language => "fr" do
      str1  = "test_index_csv_fr"
jplang's avatar
jplang committed
534
      issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
535 536 537 538 539 540 541

      get :index, :project_id => 1, 
                  :f => ['subject'], 
                  :op => '=', :values => [str1],
                  :c => ['estimated_hours', 'subject'],
                  :format => 'csv',
                  :set_filter => 1
jplang's avatar
jplang committed
542
      assert_equal 'text/csv; header=present', @response.content_type
543
      lines = @response.body.chomp.split("\n")
544
      assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
545 546 547
    end
  end

548
  def test_index_pdf
549 550
    ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
      with_settings :default_language => lang do
551

552 553 554
        get :index
        assert_response :success
        assert_template 'index'
555

556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
        get :index, :format => 'pdf'
        assert_response :success
        assert_not_nil assigns(:issues)
        assert_equal 'application/pdf', @response.content_type

        get :index, :project_id => 1, :format => 'pdf'
        assert_response :success
        assert_not_nil assigns(:issues)
        assert_equal 'application/pdf', @response.content_type

        get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
        assert_response :success
        assert_not_nil assigns(:issues)
        assert_equal 'application/pdf', @response.content_type
      end
    end
572
  end
573

574 575 576 577 578 579 580
  def test_index_pdf_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_not_nil assigns(:issue_count_by_group)
    assert_equal 'application/pdf', @response.content_type
  end
581

582 583 584 585
  def test_index_atom
    get :index, :project_id => 'ecookbook', :format => 'atom'
    assert_response :success
    assert_template 'common/feed'
586
    assert_equal 'application/atom+xml', response.content_type
587

588 589 590 591 592
    assert_select 'feed' do
      assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
      assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
      assert_select 'entry link[href=?]', 'http://test.host/issues/1'
    end
593 594
  end

595
  def test_index_sort
jplang's avatar
jplang committed
596
    get :index, :sort => 'tracker,id:desc'
597
    assert_response :success
598

jplang's avatar
jplang committed
599 600 601
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
602

jplang's avatar
jplang committed
603 604 605 606
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
607
    assert_select 'table.issues.sort-by-tracker.sort-asc'
608
  end
609 610 611 612 613 614 615 616 617 618 619

  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
  def test_index_sort_by_assigned_to
    get :index, :sort => 'assigned_to'
    assert_response :success
    assignees = assigns(:issues).collect(&:assigned_to).compact
    assert_equal assignees.sort, assignees
620
    assert_select 'table.issues.sort-by-assigned-to.sort-asc'
621 622 623 624 625 626 627
  end
  
  def test_index_sort_by_assigned_to_desc
    get :index, :sort => 'assigned_to:desc'
    assert_response :success
    assignees = assigns(:issues).collect(&:assigned_to).compact
    assert_equal assignees.sort.reverse, assignees
628
    assert_select 'table.issues.sort-by-assigned-to.sort-desc'
629 630 631 632 633 634
  end
  
  def test_index_group_by_assigned_to
    get :index, :group_by => 'assigned_to', :sort => 'priority'
    assert_response :success
  end
635 636 637 638
  
  def test_index_sort_by_author
    get :index, :sort => 'author'
    assert_response :success
639 640 641 642 643 644 645 646 647
    authors = assigns(:issues).collect(&:author)
    assert_equal authors.sort, authors
  end
  
  def test_index_sort_by_author_desc
    get :index, :sort => 'author:desc'
    assert_response :success
    authors = assigns(:issues).collect(&:author)
    assert_equal authors.sort.reverse, authors
648 649 650 651 652 653
  end
  
  def test_index_group_by_author
    get :index, :group_by => 'author', :sort => 'priority'
    assert_response :success
  end
654
  
jplang's avatar
jplang committed
655 656
  def test_index_sort_by_spent_hours
    get :index, :sort => 'spent_hours:desc'
657 658 659 660
    assert_response :success
    hours = assigns(:issues).collect(&:spent_hours)
    assert_equal hours.sort.reverse, hours
  end
661

662 663 664 665 666 667 668 669 670 671 672 673 674
  def test_index_sort_by_user_custom_field
    cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
    CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')

    get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
    assert_response :success

    assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
  end

675 676
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
677
    get :index, :set_filter => 1, :c => columns
678
    assert_response :success
679

680 681
    # query should use specified columns
    query = assigns(:query)
682
    assert_kind_of IssueQuery, query
683
    assert_equal columns, query.column_names.map(&:to_s)
684

685 686 687 688
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
689 690

    # ensure only these columns are kept in the selected columns list
691 692 693 694 695
    assert_select 'select#selected_columns option' do
      assert_select 'option', 3
      assert_select 'option[value=tracker]'
      assert_select 'option[value=project]', 0
    end
696
  end
697

698 699 700 701 702 703
  def test_index_without_project_should_implicitly_add_project_column_to_default_columns
    Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
    get :index, :set_filter => 1

    # query should use specified columns
    query = assigns(:query)
704
    assert_kind_of IssueQuery, query
705
    assert_equal [:id, :project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
706 707 708 709
  end

  def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
    Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
710
    columns = ['id', 'tracker', 'subject', 'assigned_to']
711 712 713 714
    get :index, :set_filter => 1, :c => columns

    # query should use specified columns
    query = assigns(:query)
715
    assert_kind_of IssueQuery, query
716 717 718
    assert_equal columns.map(&:to_sym), query.columns.map(&:name)
  end

719 720 721 722
  def test_index_with_custom_field_column
    columns = %w(tracker subject cf_2)
    get :index, :set_filter => 1, :c => columns
    assert_response :success
723

724 725
    # query should use specified columns
    query = assigns(:query)
726
    assert_kind_of IssueQuery, query
727
    assert_equal columns, query.column_names.map(&:to_s)
728

729
    assert_select 'table.issues td.cf_2.string'
730
  end
731

732 733 734 735 736 737 738 739 740 741
  def test_index_with_multi_custom_field_column
    field = CustomField.find(1)
    field.update_attribute :multiple, true
    issue = Issue.find(1)
    issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
    issue.save!

    get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
    assert_response :success

742
    assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
743 744 745 746 747 748 749 750 751 752 753 754
  end

  def test_index_with_multi_user_custom_field_column
    field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
      :tracker_ids => [1], :is_for_all => true)
    issue = Issue.find(1)
    issue.custom_field_values = {field.id => ['2', '3']}
    issue.save!

    get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
    assert_response :success

755 756 757 758 759
    assert_select "table.issues td.cf_#{field.id}" do
      assert_select 'a', 2
      assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
      assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
    end
760 761
  end

762 763
  def test_index_with_date_column
    with_settings :date_format => '%d/%m/%Y' do
764
      Issue.find(1).update_attribute :start_date, '1987-08-24'
765
      get :index, :set_filter => 1, :c => %w(start_date)
766
      assert_select "table.issues td.start_date", :text => '24/08/1987'
767 768 769
    end
  end

770
  def test_index_with_done_ratio_column
771 772
    Issue.find(1).update_attribute :done_ratio, 40
    get :index, :set_filter => 1, :c => %w(done_ratio)
773 774 775 776 777
    assert_select 'table.issues td.done_ratio' do
      assert_select 'table.progress' do
        assert_select 'td.closed[style=?]', 'width: 40%;'
      end
    end
778 779
  end

780 781
  def test_index_with_spent_hours_column
    get :index, :set_filter => 1, :c => %w(subject spent_hours)
782
    assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
783 784 785 786 787
  end

  def test_index_should_not_show_spent_hours_column_without_permission
    Role.anonymous.remove_permission! :view_time_entries
    get :index, :set_filter => 1, :c => %w(subject spent_hours)
788
    assert_select 'td.spent_hours', 0
789 790
  end

791
  def test_index_with_fixed_version_column
792
    get :index, :set_filter => 1, :c => %w(fixed_version)
793
    assert_select 'table.issues td.fixed_version' do
794
      assert_select 'a[href=?]', '/versions/2', :text => '1.0'
795
    end
796 797
  end

798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833
  def test_index_with_relations_column
    IssueRelation.delete_all
    IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
    IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
    IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
    IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))

    get :index, :set_filter => 1, :c => %w(subject relations)
    assert_response :success
    assert_select "tr#issue-1 td.relations" do
      assert_select "span", 3
      assert_select "span", :text => "Related to #7"
      assert_select "span", :text => "Related to #8"
      assert_select "span", :text => "Blocks #11"
    end
    assert_select "tr#issue-2 td.relations" do
      assert_select "span", 1
      assert_select "span", :text => "Blocked by #12"
    end
    assert_select "tr#issue-3 td.relations" do
      assert_select "span", 0
    end

    get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
    assert_response :success
    assert_equal 'text/csv; header=present', response.content_type
    lines = response.body.chomp.split("\n")
    assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
    assert_include '2,Blocked by #12', lines
    assert_include '3,""', lines

    get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', response.content_type
  end

834 835 836 837 838 839 840 841 842 843 844
  def test_index_with_description_column
    get :index, :set_filter => 1, :c => %w(subject description)

    assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
    assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'

    get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
    assert_response :success
    assert_equal 'application/pdf', response.content_type
  end

845 846 847 848 849 850
  def test_index_send_html_if_query_is_invalid
    get :index, :f => ['start_date'], :op => {:start_date => '='}
    assert_equal 'text/html', @response.content_type
    assert_template 'index'
  end

851 852 853 854 855 856
  def test_index_send_nothing_if_query_is_invalid
    get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
    assert_equal 'text/csv', @response.content_type
    assert @response.body.blank?
  end

857
  def test_show_by_anonymous
858 859
    get :show, :id => 1
    assert_response :success
860
    assert_template 'show'
861
    assert_equal Issue.find(1), assigns(:issue)
862
    assert_select 'div.issue div.description', :text => /Unable to print recipes/
863
    # anonymous role is allowed to add a note
864 865 866 867 868 869
    assert_select 'form#issue-form' do
      assert_select 'fieldset' do
        assert_select 'legend', :text => 'Notes'
        assert_select 'textarea[name=?]', 'issue[notes]'
      end
    end
870
    assert_select 'title', :text => "Bug #1: #{ESCAPED_UCANT} print recipes - eCookbook - Redmine"
871
  end
872

873 874 875 876
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
877 878 879 880 881 882 883 884 885 886 887 888 889 890 891
    assert_select 'a', :text => /Quote/
    assert_select 'form#issue-form' do
      assert_select 'fieldset' do
        assert_select 'legend', :text => 'Change properties'
        assert_select 'input[name=?]', 'issue[subject]'
      end
      assert_select 'fieldset' do
        assert_select 'legend', :text => 'Log time'
        assert_select 'input[name=?]', 'time_entry[hours]'
      end
      assert_select 'fieldset' do
        assert_select 'legend', :text => 'Notes'
        assert_select 'textarea[name=?]', 'issue[notes]'
      end
    end
892
  end
893

894 895 896 897 898
  def test_show_should_display_update_form
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success

899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917
    assert_select 'form#issue-form' do
      assert_select 'input[name=?]', 'issue[is_private]'
      assert_select 'select[name=?]', 'issue[project_id]'
      assert_select 'select[name=?]', 'issue[tracker_id]'
      assert_select 'input[name=?]', 'issue[subject]'
      assert_select 'textarea[name=?]', 'issue[description]'
      assert_select 'select[name=?]', 'issue[status_id]'
      assert_select 'select[name=?]', 'issue[priority_id]'
      assert_select 'select[name=?]', 'issue[assigned_to_id]'
      assert_select 'select[name=?]', 'issue[category_id]'
      assert_select 'select[name=?]', 'issue[fixed_version_id]'
      assert_select 'input[name=?]', 'issue[parent_issue_id]'
      assert_select 'input[name=?]', 'issue[start_date]'
      assert_select 'input[name=?]', 'issue[due_date]'
      assert_select 'select[name=?]', 'issue[done_ratio]'
      assert_select 'input[name=?]', 'issue[custom_field_values][2]'
      assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
      assert_select 'textarea[name=?]', 'issue[notes]'
    end
918 919 920 921
  end

  def test_show_should_display_update_form_with_minimal_permissions
    Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
922
    WorkflowTransition.delete_all :role_id => 1
923 924 925 926 927

    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success

928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946
    assert_select 'form#issue-form' do
      assert_select 'input[name=?]', 'issue[is_private]', 0
      assert_select 'select[name=?]', 'issue[project_id]', 0
      assert_select 'select[name=?]', 'issue[tracker_id]', 0
      assert_select 'input[name=?]', 'issue[subject]', 0
      assert_select 'textarea[name=?]', 'issue[description]', 0
      assert_select 'select[name=?]', 'issue[status_id]', 0
      assert_select 'select[name=?]', 'issue[priority_id]', 0
      assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
      assert_select 'select[name=?]', 'issue[category_id]', 0
      assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
      assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
      assert_select 'input[name=?]', 'issue[start_date]', 0
      assert_select 'input[name=?]', 'issue[due_date]', 0
      assert_select 'select[name=?]', 'issue[done_ratio]', 0
      assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
      assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
      assert_select 'textarea[name=?]', 'issue[notes]'
    end
947 948 949 950 951 952 953 954 955
  end

  def test_show_should_display_update_form_with_workflow_permissions
    Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]

    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success

956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974
    assert_select 'form#issue-form' do
      assert_select 'input[name=?]', 'issue[is_private]', 0
      assert_select 'select[name=?]', 'issue[project_id]', 0
      assert_select 'select[name=?]', 'issue[tracker_id]', 0
      assert_select 'input[name=?]', 'issue[subject]', 0
      assert_select 'textarea[name=?]', 'issue[description]', 0
      assert_select 'select[name=?]', 'issue[status_id]'
      assert_select 'select[name=?]', 'issue[priority_id]', 0
      assert_select 'select[name=?]', 'issue[assigned_to_id]'
      assert_select 'select[name=?]', 'issue[category_id]', 0
      assert_select 'select[name=?]', 'issue[fixed_version_id]'
      assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
      assert_select 'input[name=?]', 'issue[start_date]', 0
      assert_select 'input[name=?]', 'issue[due_date]', 0
      assert_select 'select[name=?]', 'issue[done_ratio]'
      assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
      assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
      assert_select 'textarea[name=?]', 'issue[notes]'
    end
975 976 977 978 979 980 981 982 983
  end

  def test_show_should_not_display_update_form_without_permissions
    Role.find(1).update_attribute :permissions, [:view_issues]

    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success

984
    assert_select 'form#issue-form', 0
985 986
  end

987
  def test_update_form_should_not_display_inactive_enumerations
988 989
    assert !IssuePriority.find(15).active?

990 991 992 993
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success

994 995 996 997 998 999
    assert_select 'form#issue-form' do
      assert_select 'select[name=?]', 'issue[priority_id]' do
        assert_select 'option[value=4]'
        assert_select 'option[value=15]', 0
      end
    end
1000
  end
1001

1002 1003 1004
  def test_update_form_should_allow_attachment_upload
    @request.session[:user_id] = 2
    get :show, :id => 1
1005

1006
    assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1007
      assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1008
    end
1009
  end
1010

jplang's avatar
jplang committed
1011 1012 1013 1014 1015
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
1016

jplang's avatar
jplang committed
1017
  def test_show_should_deny_anonymous_access_to_private_issue
1018
    Issue.where(:id => 1).update_all(["is_private = ?", true])
jplang's avatar
jplang committed
1019 1020 1021
    get :show, :id => 1
    assert_response :redirect
  end
1022

jplang's avatar
jplang committed
1023 1024 1025 1026 1027 1028
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
1029

jplang's avatar
jplang committed
1030
  def test_show_should_deny_non_member_access_to_private_issue
1031
    Issue.where(:id => 1).update_all(["is_private = ?", true])
jplang's avatar
jplang committed
1032 1033 1034 1035
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
1036

jplang's avatar
jplang committed
1037 1038 1039 1040 1041 1042
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
1043

jplang's avatar
jplang committed
1044
  def test_show_should_deny_member_access_to_private_issue_without_permission
1045
    Issue.where(:id => 1).update_all(["is_private = ?", true])
jplang's avatar
jplang committed
1046 1047 1048 1049
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response 403
  end
1050

jplang's avatar
jplang committed
1051
  def test_show_should_allow_author_access_to_private_issue
1052
    Issue.where(:id => 1).update_all(["is_private = ?, author_id = 3", true])
jplang's avatar
jplang committed
1053 1054 1055 1056
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response :success
  end
1057

jplang's avatar
jplang committed
1058
  def test_show_should_allow_assignee_access_to_private_issue
1059
    Issue.where(:id => 1).update_all(["is_private = ?, assigned_to_id = 3", true])
jplang's avatar
jplang committed
1060 1061 1062 1063
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response :success
  end
1064

jplang's avatar
jplang committed
1065
  def test_show_should_allow_member_access_to_private_issue_with_permission
1066
    Issue.where(:id => 1).update_all(["is_private = ?", true])
jplang's avatar
jplang committed
1067 1068 1069 1070 1071
    User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response :success
  end
1072

1073 1074 1075 1076 1077
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1078

1079 1080
    get :show, :id => 1
    assert_response :success
1081

1082 1083 1084 1085
    assert_select 'div#relations' do
      assert_select 'a', :text => /#2$/
      assert_select 'a', :text => /#4$/, :count => 0
    end
1086
  end
1087

jplang's avatar
jplang committed
1088
  def test_show_should_list_subtasks
jplang's avatar
jplang committed
1089
    Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
jplang's avatar
jplang committed
1090 1091 1092

    get :show, :id => 1
    assert_response :success
1093 1094 1095 1096

    assert_select 'div#issue_tree' do
      assert_select 'td.subject', :text => /Child Issue/
    end
jplang's avatar
jplang committed
1097 1098
  end

1099
  def test_show_should_list_parents
jplang's avatar
jplang committed
1100
    issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1101 1102 1103

    get :show, :id => issue.id
    assert_response :success
1104 1105 1106 1107 1108

    assert_select 'div.subject' do
      assert_select 'h3', 'Child Issue'
      assert_select 'a[href=/issues/1]'
    end
1109 1110
  end

1111 1112 1113 1114 1115
  def test_show_should_not_display_prev_next_links_without_query_in_session
    get :show, :id => 1
    assert_response :success
    assert_nil assigns(:prev_issue_id)
    assert_nil assigns(:next_issue_id)
1116