issue_test.rb 83.3 KB
Newer Older
1
# Redmine - project management software
jplang's avatar
jplang committed
2
# Copyright (C) 2006-2013  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
jplang's avatar
jplang committed
21
  fixtures :projects, :users, :members, :member_roles, :roles,
22
           :groups_users,
23
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
24
           :enabled_modules,
25
           :versions,
26
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
27
           :enumerations,
28
           :issues, :journals, :journal_details,
29 30
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
31

32 33
  include Redmine::I18n

34 35 36 37
  def teardown
    User.current = nil
  end

38 39 40 41 42 43 44 45 46 47 48 49 50
  def test_initialize
    issue = Issue.new

    assert_nil issue.project_id
    assert_nil issue.tracker_id
    assert_nil issue.author_id
    assert_nil issue.assigned_to_id
    assert_nil issue.category_id

    assert_equal IssueStatus.default, issue.status
    assert_equal IssuePriority.default, issue.priority
  end

51
  def test_create
52 53 54 55
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
56 57 58 59
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
60

61
  def test_create_minimal
62 63 64
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create')
65 66
    assert issue.save
    assert issue.description.nil?
67
    assert_nil issue.estimated_hours
68
  end
69

70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87
  def test_start_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:start_date => invalid_date)
      assert !issue.valid?
      assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

  def test_due_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:due_date => invalid_date)
      assert !issue.valid?
      assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

88 89 90 91 92 93 94
  def test_due_date_lesser_than_start_date_should_not_validate
    set_language_if_valid 'en'
    issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
    assert !issue.valid?
    assert_include 'Due date must be greater than start date', issue.errors.full_messages
  end

95 96 97 98 99 100 101 102 103
  def test_estimated_hours_should_be_validated
    set_language_if_valid 'en'
    ['-2'].each do |invalid|
      issue = Issue.new(:estimated_hours => invalid)
      assert !issue.valid?
      assert_include 'Estimated time is invalid', issue.errors.full_messages
    end
  end

104
  def test_create_with_required_custom_field
105
    set_language_if_valid 'en'
106 107
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
108

109 110 111
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
112 113 114
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
115
    assert_equal ["Database can't be blank"], issue.errors.full_messages
116 117 118
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
119
    assert_equal ["Database can't be blank"], issue.errors.full_messages
120 121 122
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
123
    assert_equal ["Database is not included in the list"], issue.errors.full_messages
124 125 126 127 128 129
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
130

131 132
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
133 134 135
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
136 137 138 139 140
      issue = Issue.first(:order => 'id DESC')
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
141

142
  def test_create_with_parent_issue_id
143 144 145
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => 1)
146 147 148 149 150
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

151 152 153 154 155 156 157 158 159
  def test_create_with_sharp_parent_issue_id
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => "#1")
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

160
  def test_create_with_invalid_parent_issue_id
161
    set_language_if_valid 'en'
162 163 164
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '01ABC')
165 166 167 168 169
    assert !issue.save
    assert_equal '01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

170 171 172 173 174 175 176 177 178 179
  def test_create_with_invalid_sharp_parent_issue_id
    set_language_if_valid 'en'
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '#01ABC')
    assert !issue.save
    assert_equal '#01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

180 181 182 183
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
184 185 186 187 188
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
189
    assert_nil issues.detect {|issue| issue.is_private?}
190 191
    assert_visibility_match User.anonymous, issues
  end
192

193
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
194 195 196 197
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
    issues = Issue.visible(User.anonymous).all
    assert issues.empty?
198
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
199
  end
200

201 202
  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
    assert Role.anonymous.update_attribute(:issues_visibility, 'default')
203
    issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
204 205 206 207 208 209
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
    assert Role.anonymous.update_attribute(:issues_visibility, 'own')
210
    issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
211 212 213 214
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

215
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
216 217 218 219 220 221
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
222
    assert_nil issues.detect {|issue| issue.is_private?}
223 224
    assert_visibility_match user, issues
  end
225

226 227 228 229
  def test_visible_scope_for_non_member_with_own_issues_visibility
    Role.non_member.update_attribute :issues_visibility, 'own'
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
230

231 232 233 234 235
    issues = Issue.visible(user).all
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
236

237
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
238 239
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
240 241
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
242 243
    issues = Issue.visible(user).all
    assert issues.empty?
244 245
    assert_visibility_match user, issues
  end
246

247 248
  def test_visible_scope_for_member
    user = User.find(9)
jplang's avatar
jplang committed
249
    # User should see issues of projects for which he has view_issues permissions only
250
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
251
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
252 253
    issues = Issue.visible(user).all
    assert issues.any?
jplang's avatar
jplang committed
254 255
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
256
    assert_visibility_match user, issues
jplang's avatar
jplang committed
257
  end
258

259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281
  def test_visible_scope_for_member_with_groups_should_return_assigned_issues
    user = User.find(8)
    assert user.groups.any?
    Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
    Role.non_member.remove_permission!(:view_issues)
    
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
      :status_id => 1, :priority => IssuePriority.all.first,
      :subject => 'Assignment test',
      :assigned_to => user.groups.first,
      :is_private => true)
    
    Role.find(2).update_attribute :issues_visibility, 'default'
    issues = Issue.visible(User.find(8)).all
    assert issues.any?
    assert issues.include?(issue)
    
    Role.find(2).update_attribute :issues_visibility, 'own'
    issues = Issue.visible(User.find(8)).all
    assert issues.any?
    assert issues.include?(issue)
  end

jplang's avatar
jplang committed
282 283 284 285 286 287 288 289
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
    issues = Issue.visible(user).all
    assert issues.any?
    # Admin should see issues on private projects that he does not belong to
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
290 291
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
292
    assert_visibility_match user, issues
jplang's avatar
jplang committed
293
  end
294

295 296 297 298 299 300 301
  def test_visible_scope_with_project
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project).all
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
302

303 304 305 306 307 308 309
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
310

311 312 313
  def test_visible_and_nested_set_scopes
    assert_equal 0, Issue.find(1).descendants.visible.all.size
  end
314

315 316 317 318 319 320 321 322 323 324
  def test_open_scope
    issues = Issue.open.all
    assert_nil issues.detect(&:closed?)
  end

  def test_open_scope_with_arg
    issues = Issue.open(false).all
    assert_equal issues, issues.select(&:closed?)
  end

325 326 327 328 329 330 331 332 333 334
  def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
    version = Version.find(2)
    assert version.fixed_issues.any?
    assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  end

  def test_fixed_version_scope_with_empty_array_should_return_no_result
    assert_equal 0, Issue.fixed_version([]).count
  end

335 336
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
337

tmaruyama's avatar
tmaruyama committed
338 339 340
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
341 342 343
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
344

345 346
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
tmaruyama's avatar
tmaruyama committed
347 348
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                 issue.errors.full_messages.first
349
  end
350

351 352 353
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)
354

355 356 357 358 359 360 361 362 363 364 365 366 367 368
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
369

370 371 372 373
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
374

375 376 377
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
378

379 380 381
    issue.reload
    assert_equal "Can't print recipes", issue.subject
  end
382

383 384
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
385

386 387 388 389 390 391 392 393 394 395
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
396

397
  def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
tmaruyama's avatar
tmaruyama committed
398 399 400
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
                          :status_id => 1, :subject => 'Test',
                          :custom_field_values => {'2' => 'Test'})
401 402 403 404 405 406 407 408 409 410 411
    assert !Tracker.find(2).custom_field_ids.include?(2)

    issue = Issue.find(issue.id)
    issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}

    issue = Issue.find(issue.id)
    custom_value = issue.custom_value_for(2)
    assert_not_nil custom_value
    assert_equal 'Test', custom_value.value
  end

412 413 414 415 416 417
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
418

419 420 421 422 423 424 425 426 427 428
  def test_assigning_attributes_should_assign_project_and_tracker_first
    seq = sequence('seq')
    issue = Issue.new
    issue.expects(:project_id=).in_sequence(seq)
    issue.expects(:tracker_id=).in_sequence(seq)
    issue.expects(:subject=).in_sequence(seq)
    issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  end

  def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
429 430 431 432 433
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
434
    assert_equal 'MySQL', issue.custom_field_value(1)
435
  end
436

437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
  def test_reload_should_reload_custom_field_values
    issue = Issue.generate!
    issue.custom_field_values = {'2' => 'Foo'}
    issue.save!

    issue = Issue.order('id desc').first
    assert_equal 'Foo', issue.custom_field_value(2)

    issue.custom_field_values = {'2' => 'Bar'}
    assert_equal 'Bar', issue.custom_field_value(2)

    issue.reload
    assert_equal 'Foo', issue.custom_field_value(2)
  end

452 453 454
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
455

456 457
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
458

459 460 461 462
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
463

464 465 466
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
467

468 469 470 471
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
472
    assert_not_nil issue.errors[:tracker_id]
473
  end
474

475
  def test_category_based_assignment
476 477 478 479
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
480 481
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
482

483
  def test_new_statuses_allowed_to
484
    WorkflowTransition.delete_all
485 486 487 488 489 490 491 492 493 494 495 496
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 2,
                               :author => false, :assignee => false)
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 3,
                               :author => true, :assignee => false)
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
                               :new_status_id => 4, :author => false,
                               :assignee => true)
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 5,
                               :author => true, :assignee => true)
497 498 499 500
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
501

502 503
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1)
504
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
505

506 507
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user)
jplang's avatar
jplang committed
508
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
509

510 511 512
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1,
                            :assigned_to => user)
jplang's avatar
jplang committed
513
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
514

515 516 517
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user,
                            :assigned_to => user)
518 519
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  end
520

521 522 523 524
  def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
    admin = User.find(1)
    issue = Issue.find(1)
    assert !admin.member_of?(issue.project)
tmaruyama's avatar
tmaruyama committed
525 526 527
    expected_statuses = [issue.status] + 
                            WorkflowTransition.find_all_by_old_status_id(
                                issue.status_id).map(&:new_status).uniq.sort
528 529 530
    assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  end

531 532 533 534 535 536 537
  def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
    issue = Issue.find(1).copy
    assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)

    issue = Issue.find(2).copy
    assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  end
538

539
  def test_safe_attributes_names_should_not_include_disabled_field
540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570
    tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))

    issue = Issue.new(:tracker => tracker)
    assert_include 'tracker_id', issue.safe_attribute_names
    assert_include 'status_id', issue.safe_attribute_names
    assert_include 'subject', issue.safe_attribute_names
    assert_include 'description', issue.safe_attribute_names
    assert_include 'custom_field_values', issue.safe_attribute_names
    assert_include 'custom_fields', issue.safe_attribute_names
    assert_include 'lock_version', issue.safe_attribute_names

    tracker.core_fields.each do |field|
      assert_include field, issue.safe_attribute_names
    end

    tracker.disabled_core_fields.each do |field|
      assert_not_include field, issue.safe_attribute_names
    end
  end

  def test_safe_attributes_should_ignore_disabled_fields
    tracker = Tracker.find(1)
    tracker.core_fields = %w(assigned_to_id due_date)
    tracker.save!

    issue = Issue.new(:tracker => tracker)
    issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
    assert_nil issue.start_date
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end

571
  def test_safe_attributes_should_accept_target_tracker_enabled_fields
572 573 574 575 576 577 578 579 580 581 582 583
    source = Tracker.find(1)
    source.core_fields = []
    source.save!
    target = Tracker.find(2)
    target.core_fields = %w(assigned_to_id due_date)
    target.save!

    issue = Issue.new(:tracker => source)
    issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
    assert_equal target, issue.tracker
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end
584 585 586

  def test_safe_attributes_should_not_include_readonly_fields
    WorkflowPermission.delete_all
587 588 589
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
590 591 592 593 594 595 596 597 598 599 600 601
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
    assert_not_include 'due_date', issue.safe_attribute_names(user)

    issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
    assert_equal Date.parse('2012-07-14'), issue.start_date
    assert_nil issue.due_date
  end

  def test_safe_attributes_should_not_include_readonly_custom_fields
tmaruyama's avatar
tmaruyama committed
602 603 604 605 606 607
    cf1 = IssueCustomField.create!(:name => 'Writable field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
    cf2 = IssueCustomField.create!(:name => 'Readonly field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
608
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
609 610 611
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf2.id.to_s,
                               :rule => 'readonly')
612 613 614 615 616
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
    assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)

tmaruyama's avatar
tmaruyama committed
617 618 619
    issue.send :safe_attributes=, {'custom_field_values' => {
                                       cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
                                     }}, user
620 621 622
    assert_equal 'value1', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)

tmaruyama's avatar
tmaruyama committed
623 624 625 626
    issue.send :safe_attributes=, {'custom_fields' => [
                                      {'id' => cf1.id.to_s, 'value' => 'valuea'},
                                      {'id' => cf2.id.to_s, 'value' => 'valueb'}
                                    ]}, user
627 628 629 630 631
    assert_equal 'valuea', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)
  end

  def test_editable_custom_field_values_should_return_non_readonly_custom_values
tmaruyama's avatar
tmaruyama committed
632 633 634 635
    cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
    cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
636
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
637 638
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
                               :field_name => cf2.id.to_s, :rule => 'readonly')
639 640 641 642 643 644 645 646 647 648 649 650 651 652 653
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert_nil values.detect {|value| value.custom_field == cf2}

    issue.tracker_id = 2
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert values.detect {|value| value.custom_field == cf2}
  end

  def test_safe_attributes_should_accept_target_tracker_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
654 655 656 657 658 659
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
660 661 662 663
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
664 665
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'}, user
666 667 668
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
669 670 671
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                   'due_date' => '2012-07-16',
                                   'tracker_id' => 2}, user
672 673 674 675 676 677
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_safe_attributes_should_accept_target_status_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
678 679 680 681 682 683
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
684 685 686 687
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
688 689 690
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'},
                                   user
691 692 693
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
694 695 696 697
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                    'due_date' => '2012-07-16',
                                    'status_id' => 2},
                                  user
698 699 700 701 702
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_required_attributes_should_be_validated
703 704
    cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
                                  :is_for_all => true, :tracker_ids => [1, 2])
705 706

    WorkflowPermission.delete_all
707 708 709 710 711 712 713 714 715
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'category_id',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
716

717 718 719 720 721 722
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
723 724
    user = User.find(2)

725 726 727 728 729
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :status_id => 1, :subject => 'Required fields',
                      :author => user)
    assert_equal [cf.id.to_s, "category_id", "due_date"],
                 issue.required_attribute_names(user).sort
730
    assert !issue.save, "Issue was saved"
731 732
    assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
                  issue.errors.full_messages.sort
733 734 735 736

    issue.tracker_id = 2
    assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
    assert !issue.save, "Issue was saved"
737 738
    assert_equal ["Foo can't be blank", "Start date can't be blank"],
                 issue.errors.full_messages.sort
739 740 741 742 743 744 745 746

    issue.start_date = Date.today
    issue.custom_field_values = {cf.id.to_s => 'bar'}
    assert issue.save
  end

  def test_required_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
747 748 749 750 751 752
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
753 754 755 756 757 758 759 760 761 762
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
763 764 765
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 2, :field_name => 'due_date',
                               :rule => 'required')
766 767 768 769 770 771
    assert_equal %w(due_date), issue.required_attribute_names(user)

    member.role_ids = [1, 2, 3]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
772 773 774
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 2, :field_name => 'due_date',
                               :rule => 'readonly')
775 776 777 778 779 780
    # required + readonly => required
    assert_equal %w(due_date), issue.required_attribute_names(user)
  end

  def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
781 782 783 784 785 786
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
787 788 789 790 791 792 793 794 795 796
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.read_only_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
797 798 799
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                              :role_id => 2, :field_name => 'due_date',
                              :rule => 'readonly')
800 801
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
  end
802

jplang's avatar
jplang committed
803 804
  def test_copy
    issue = Issue.new.copy_from(1)
805
    assert issue.copy?
jplang's avatar
jplang committed
806 807 808 809 810
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
811
    assert_equal "125", issue.custom_value_for(2).value
jplang's avatar
jplang committed
812
  end
813 814 815 816

  def test_copy_should_copy_status
    orig = Issue.find(8)
    assert orig.status != IssueStatus.default
817

818 819 820 821 822
    issue = Issue.new.copy_from(orig)
    assert issue.save
    issue.reload
    assert_equal orig.status, issue.status
  end
823

824 825 826 827 828 829 830 831 832 833 834 835 836
  def test_copy_should_add_relation_with_copied_issue
    copied = Issue.find(1)
    issue = Issue.new.copy_from(copied)
    assert issue.save
    issue.reload

    assert_equal 1, issue.relations.size
    relation = issue.relations.first
    assert_equal 'copied_to', relation.relation_type
    assert_equal copied, relation.issue_from
    assert_equal issue, relation.issue_to
  end

837
  def test_copy_should_copy_subtasks
838
    issue = Issue.generate_with_descendants!
839 840 841 842 843 844 845 846 847 848 849 850 851

    copy = issue.reload.copy
    copy.author = User.find(7)
    assert_difference 'Issue.count', 1+issue.descendants.count do
      assert copy.save
    end
    copy.reload
    assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
    child_copy = copy.children.detect {|c| c.subject == 'Child1'}
    assert_equal %w(Child11), child_copy.children.map(&:subject).sort
    assert_equal copy.author, child_copy.author
  end

852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894
  def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
    parent = Issue.generate!
    child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
    child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')

    copy = parent.reload.copy
    copy.parent_issue_id = parent.id
    copy.author = User.find(7)
    assert_difference 'Issue.count', 3 do
      assert copy.save
    end
    parent.reload
    copy.reload
    assert_equal parent, copy.parent
    assert_equal 3, parent.children.count
    assert_equal 5, parent.descendants.count
    assert_equal 2, copy.children.count
    assert_equal 2, copy.descendants.count
  end

  def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
    parent = Issue.generate!
    child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
    child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')

    copy = parent.reload.copy
    copy.parent_issue_id = child1.id
    copy.author = User.find(7)
    assert_difference 'Issue.count', 3 do
      assert copy.save
    end
    parent.reload
    child1.reload
    copy.reload
    assert_equal child1, copy.parent
    assert_equal 2, parent.children.count
    assert_equal 5, parent.descendants.count
    assert_equal 1, child1.children.count
    assert_equal 3, child1.descendants.count
    assert_equal 2, copy.children.count
    assert_equal 2, copy.descendants.count
  end

895
  def test_copy_should_copy_subtasks_to_target_project
896
    issue = Issue.generate_with_descendants!
897 898 899 900 901 902 903 904 905

    copy = issue.copy(:project_id => 3)
    assert_difference 'Issue.count', 1+issue.descendants.count do
      assert copy.save
    end
    assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
  end

  def test_copy_should_not_copy_subtasks_twice_when_saving_twice
906
    issue = Issue.generate_with_descendants!
907 908 909 910 911 912 913 914

    copy = issue.reload.copy
    assert_difference 'Issue.count', 1+issue.descendants.count do
      assert copy.save
      assert copy.save
    end
  end

915
  def test_should_not_call_after_project_change_on_creation
916 917
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Test', :author_id => 1)
918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936
    issue.expects(:after_project_change).never
    issue.save!
  end

  def test_should_not_call_after_project_change_on_update
    issue = Issue.find(1)
    issue.project = Project.find(1)
    issue.subject = 'No project change'
    issue.expects(:after_project_change).never
    issue.save!
  end

  def test_should_call_after_project_change_on_project_change
    issue = Issue.find(1)
    issue.project = Project.find(2)
    issue.expects(:after_project_change).once
    issue.save!
  end

937 938 939 940 941 942 943 944 945 946 947 948 949
  def test_adding_journal_should_update_timestamp
    issue = Issue.find(1)
    updated_on_was = issue.updated_on

    issue.init_journal(User.first, "Adding notes")
    assert_difference 'Journal.count' do
      assert issue.save
    end
    issue.reload

    assert_not_equal updated_on_was, issue.updated_on
  end

950
  def test_should_close_duplicates
951
    # Create 3 issues
952 953 954
    issue1 = Issue.generate!
    issue2 = Issue.generate!
    issue3 = Issue.generate!
955

956
    # 2 is a dupe of 1
957 958
    IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
                          :relation_type => IssueRelation::TYPE_DUPLICATES)
959
    # And 3 is a dupe of 2
960 961
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
                          :relation_type => IssueRelation::TYPE_DUPLICATES)
962
    # And 3 is a dupe of 1 (circular duplicates)
963 964
    IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
                          :relation_type => IssueRelation::TYPE_DUPLICATES)
965

966
    assert issue1.reload.duplicates.include?(issue2)
967

968
    # Closing issue 1
jplang's avatar
jplang committed
969
    issue1.init_journal(User.first, "Closing issue1")
jplang's avatar
jplang committed
970
    issue1.status = IssueStatus.where(:is_closed => true).first
971 972 973
    assert issue1.save
    # 2 and 3 should be also closed
    assert issue2.reload.closed?
974
    assert issue3.reload.closed?
975
  end
976

977
  def test_should_not_close_duplicated_issue
978 979
    issue1 = Issue.generate!
    issue2 = Issue.generate!
980

981
    # 2 is a dupe of 1
982 983
    IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
                         :relation_type => IssueRelation::TYPE_DUPLICATES)
984 985
    # 2 is a dup of 1 but 1 is not a duplicate of 2
    assert !issue2.reload.duplicates.include?(issue1)
986

987
    # Closing issue 2
jplang's avatar
jplang committed
988
    issue2.init_journal(User.first, "Closing issue2")
jplang's avatar
jplang committed
989
    issue2.status = IssueStatus.where(:is_closed => true).first
990 991 992 993
    assert issue2.save
    # 1 should not be also closed
    assert !issue1.reload.closed?
  end
994

995
  def test_assignable_versions
996 997 998
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 1,
                      :subject => 'New issue')
999 1000
    assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  end
1001

1002
  def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
tmaruyama's avatar
tmaruyama committed
1003 1004 1005
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 1,
                      :subject => 'New issue')
1006
    assert !issue.save
1007
    assert_not_nil issue.errors[:fixed_version_id]
1008
  end
1009

1010
  def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
tmaruyama's avatar
tmaruyama committed
1011 1012 1013
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 2,
                      :subject => 'New issue')
1014
    assert !issue.save
1015
    assert_not_nil issue.errors[:fixed_version_id]
1016
  end
1017

1018
  def test_should_be_able_to_assign_a_new_issue_to_an_open_version
tmaruyama's avatar
tmaruyama committed
1019 1020 1021
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :fixed_version_id => 3,
                      :subject => 'New issue')
1022 1023
    assert issue.save
  end
1024

1025 1026 1027 1028 1029 1030
  def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    assert_equal 'closed', issue.fixed_version.status
    issue.subject = 'Subject changed'
    assert issue.save
  end
1031

1032 1033 1034 1035
  def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    assert !issue.save
1036
    assert_not_nil issue.errors[:base]
1037
  end
1038

1039 1040 1041 1042 1043 1044
  def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
    issue = Issue.find(11)
    issue.status_id = 1
    issue.fixed_version_id = 3
    assert issue.save
  end
1045

1046 1047 1048 1049 1050 1051
  def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
    issue = Issue.find(12)
    assert_equal 'locked', issue.fixed_version.status
    issue.status_id = 1
    assert issue.save
  end
1052

1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072
  def test_should_not_be_able_to_keep_unshared_version_when_changing_project
    issue = Issue.find(2)
    assert_equal 2, issue.fixed_version_id
    issue.project_id = 3
    assert_nil issue.fixed_version_id
    issue.fixed_version_id = 2
    assert !issue.save
    assert_include 'Target version is not included in the list', issue.errors.full_messages
  end

  def test_should_keep_shared_version_when_changing_project
    Version.find(2).update_attribute :sharing, 'tree'
 
    issue = Issue.find(2)
    assert_equal 2, issue.fixed_version_id
    issue.project_id = 3
    assert_equal 2, issue.fixed_version_id
    assert issue.save
  end

1073 1074 1075 1076 1077 1078 1079 1080 1081
  def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
    assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  end

  def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
    Project.find(2).disable_module! :issue_tracking
    assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  end

jplang's avatar