issues_controller_test.rb 37.8 KB
Newer Older
1 2
# Redmine - project management software
# Copyright (C) 2006-2008  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

require File.dirname(__FILE__) + '/../test_helper'
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
42
           :custom_fields_projects,
43
           :custom_fields_trackers,
44 45
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
46 47
           :journal_details,
           :queries
48 49 50 51 52 53 54
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
55
  
56
  def test_index
57 58
    Setting.default_language = 'en'
    
59 60 61 62 63
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
64 65 66 67 68
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 70
    # project column
    assert_tag :tag => 'th', :content => /Project/
71
  end
72 73 74 75 76 77 78 79 80 81 82
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
83

84 85 86 87 88 89 90 91 92 93 94
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
  
95
  def test_index_with_project
96
    Setting.display_subprojects_issues = 0
97 98 99 100
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
126 127 128 129 130 131 132 133 134
  end
  
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
  end
  
jplang's avatar
jplang committed
135 136 137 138 139 140 141 142
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
143
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
144 145 146 147
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
148
    assert_not_nil assigns(:issue_count_by_group)
149 150 151 152 153 154 155
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
156
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
157 158
  end
  
jplang's avatar
jplang committed
159 160 161 162 163
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
164
  def test_index_csv_with_project
165 166
    Setting.default_language = 'en'
    
167 168 169 170
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
171
    assert @response.body.starts_with?("#,")
172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
189 190 191 192 193
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
194
  end
195
  
196 197 198 199 200 201 202 203
  def test_index_pdf_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_not_nil assigns(:issue_count_by_group)
    assert_equal 'application/pdf', @response.content_type
  end
  
204
  def test_index_sort
jplang's avatar
jplang committed
205
    get :index, :sort => 'tracker,id:desc'
206 207
    assert_response :success
    
jplang's avatar
jplang committed
208 209 210 211 212 213 214 215
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
216
  end
217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232
  
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
    get :index, :set_filter => 1, :query => { 'column_names' => columns}
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
  end
233

234
  def test_show_by_anonymous
jplang's avatar
jplang committed
235 236 237 238
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
239 240 241 242 243 244 245
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
jplang's avatar
jplang committed
246 247
  end
  
248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
264
  
jplang's avatar
jplang committed
265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
300 301 302
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
303
    assert_template 'journals/index.rxml'
304
    # Inline image
305
    assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
306 307
  end
  
jplang's avatar
jplang committed
308
  def test_show_export_to_pdf
309
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
310 311 312 313 314 315
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

316 317 318 319 320
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
321
    
322
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
323
                                                 :value => 'Default string' }
324 325 326 327 328 329 330 331 332 333 334 335 336
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No default issue/
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
    assert_not_nil flash[:error]
    assert_tag :tag => 'div', :attributes => { :class => /error/ },
                              :content => /No tracker/
  end
  
359 360
  def test_update_new_form
    @request.session[:user_id] = 2
361
    xhr :post, :new, :project_id => 1,
362 363 364 365 366
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
367 368 369 370 371 372 373 374
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
375
  
376
  def test_post_create
377
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
378
    assert_difference 'Issue.count' do
379
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
380
                 :issue => {:tracker_id => 3,
381
                            :status_id => 2,
edavis10's avatar
edavis10 committed
382 383 384 385 386 387 388
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
389 390 391 392
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
393
    assert_equal 3, issue.tracker_id
394
    assert_equal 2, issue.status_id
395
    assert_nil issue.estimated_hours
396
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
397 398
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
399 400
  end
  
401
  def test_post_create_and_continue
402
    @request.session[:user_id] = 2
403
    post :create, :project_id => 1, 
404 405 406 407
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
jplang's avatar
jplang committed
408
    assert_redirected_to :controller => 'issues', :action => 'new', :issue => {:tracker_id => 3}
409 410
  end
  
411
  def test_post_create_without_custom_fields_param
412
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
413
    assert_difference 'Issue.count' do
414
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
415 416 417 418 419 420
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
421
  end
422

423
  def test_post_create_with_required_custom_field_and_without_custom_fields_param
424 425 426 427
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
428
    post :create, :project_id => 1, 
429 430 431 432 433 434 435 436
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
437
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
438 439
  end
  
440
  def test_post_create_with_watchers
441 442 443 444
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
445
      post :create, :project_id => 1, 
446 447 448 449 450 451 452
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
453 454 455
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
456 457 458 459 460 461 462 463 464
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
465
  def test_post_create_subissue
jplang's avatar
jplang committed
466 467 468
    @request.session[:user_id] = 2
    
    assert_difference 'Issue.count' do
469
      post :create, :project_id => 1, 
jplang's avatar
jplang committed
470 471 472 473 474 475 476 477 478
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a child issue',
                            :parent_issue_id => 2}
    end
    issue = Issue.find_by_subject('This is a child issue')
    assert_not_nil issue
    assert_equal Issue.find(2), issue.parent
  end
  
479
  def test_post_create_should_send_a_notification
480 481
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
482
    assert_difference 'Issue.count' do
483
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
484 485 486 487 488 489 490 491
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
492 493 494 495
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
496
  def test_post_create_should_preserve_fields_values_on_validation_failure
497
    @request.session[:user_id] = 2
498
    post :create, :project_id => 1, 
499
               :issue => {:tracker_id => 1,
500 501 502
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
503 504 505 506 507
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
508 509
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
510 511 512 513 514 515 516 517 518 519 520 521 522
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
523
  def test_post_create_should_ignore_non_safe_attributes
524 525
    @request.session[:user_id] = 2
    assert_nothing_raised do
526
      post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
527 528 529
    end
  end
  
530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548
  context "without workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
      Role.anonymous.add_permission! :add_issues
    end
    
    context "#new" do
      should "propose default status only" do
        get :new, :project_id => 1
        assert_response :success
        assert_template 'new'
        assert_tag :tag => 'select',
          :attributes => {:name => 'issue[status_id]'},
          :children => {:count => 1},
          :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
      end
      
      should "accept default status" do
        assert_difference 'Issue.count' do
549
          post :create, :project_id => 1, 
550 551 552 553 554 555 556 557 558 559
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 1}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Issue.count' do
560
          post :create, :project_id => 1, 
561 562 563 564 565 566 567 568 569 570
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 3}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
    end
  end
  
571 572 573 574 575 576 577 578 579
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
jplang's avatar
jplang committed
580 581 582 583 584 585 586 587
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
  end
610 611 612

  def test_update_edit_form
    @request.session[:user_id] = 2
613
    xhr :post, :new, :project_id => 1,
614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
                             :id => 1,
                             :issue => {:tracker_id => 2, 
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
    assert_response :success
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.id
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
629
  
630 631 632 633 634 635 636 637 638 639 640 641 642 643
  def test_update_using_invalid_http_verbs
    @request.session[:user_id] = 2
    subject = 'Updated by an invalid http verb'

    get :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    post :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    delete :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject
  end

644
  def test_put_update_without_custom_fields_param
jplang's avatar
jplang committed
645
    @request.session[:user_id] = 2
646 647 648
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
649
    assert_equal '125', issue.custom_value_for(2).value
650 651 652
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
653 654
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
655
        put :update, :id => 1, :issue => {:subject => new_subject,
656 657 658 659 660
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
661
    assert_redirected_to :action => 'show', :id => '1'
662 663
    issue.reload
    assert_equal new_subject, issue.subject
664 665
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
666 667 668 669 670
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
jplang's avatar
jplang committed
671 672
  end
  
673
  def test_put_update_with_custom_field_change
674 675 676 677 678 679
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
680
        put :update, :id => 1, :issue => {:subject => 'Custom field change',
681 682 683 684 685 686
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
687
    assert_redirected_to :action => 'show', :id => '1'
688 689 690 691 692 693 694 695
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
696
  def test_put_update_with_status_and_assignee_change
jplang's avatar
jplang committed
697 698 699
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
700
    assert_difference('TimeEntry.count', 0) do
701
      put :update,
702 703 704
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
705
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
706
    end
707
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
708 709
    issue.reload
    assert_equal 2, issue.status_id
jplang's avatar
jplang committed
710
    j = Journal.find(:first, :order => 'id DESC')
jplang's avatar
jplang committed
711 712
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
713 714 715
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
716 717
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
718 719
  end
  
720
  def test_put_update_with_note_only
721 722
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
723
    put :update,
724 725
         :id => 1,
         :notes => notes
726
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
727
    j = Journal.find(:first, :order => 'id DESC')
728 729 730 731 732 733 734 735
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
736
  def test_put_update_with_note_and_spent_time
737 738
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
739
    assert_difference('TimeEntry.count') do
740
      put :update,
741 742
           :id => 1,
           :notes => '2.5 hours added',
743
           :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
744
    end
745
    assert_redirected_to :action => 'show', :id => '1'
746 747 748
    
    issue = Issue.find(1)
    
jplang's avatar
jplang committed
749
    j = Journal.find(:first, :order => 'id DESC')
750 751 752
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
753
    t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
754 755 756 757 758
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
759
  def test_put_update_with_attachment_only
jplang's avatar
jplang committed
760 761
    set_tmp_attachments_directory
    
762 763 764 765
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

766
    # anonymous user
767
    put :update,
768 769
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
770
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
771
    assert_redirected_to :action => 'show', :id => '1'
772 773 774 775 776 777 778 779 780
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801

  def test_put_update_with_attachment_that_fails_to_save
    set_tmp_attachments_directory
    
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

    # Mock out the unsaved attachment
    Attachment.any_instance.stubs(:create).returns(Attachment.new)
    
    # anonymous user
    put :update,
         :id => 1,
         :notes => '',
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
    assert_redirected_to :action => 'show', :id => '1'
    assert_equal '1 file(s) could not be saved.', flash[:warning]

  end if Object.const_defined?(:Mocha)

802
  def test_put_update_with_no_change
803 804 805 806
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
807
    put :update,
808 809
         :id => 1,
         :notes => ''
810
    assert_redirected_to :action => 'show', :id => '1'
811 812 813 814 815
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
jplang's avatar
jplang committed
816
  end
817

818
  def test_put_update_should_send_a_notification
819 820 821 822 823 824
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
825
    put :update, :id => 1, :issue => {:subject => new_subject,
826 827 828 829 830
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
831
  
832
  def test_put_update_with_invalid_spent_time
833 834 835 836
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
837
      put :update,
838 839 840 841 842 843 844 845 846 847 848
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_tag :textarea, :attributes => { :name => 'notes' },
                          :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
849
  
850
  def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
851 852 853
    issue = Issue.find(2)
    @request.session[:user_id] = 2

854
    put :update,
855 856 857 858 859 860 861 862 863 864
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         }

    assert_response :redirect
    issue.reload
    assert_equal 4, issue.fixed_version_id
    assert_not_equal issue.project_id, issue.fixed_version.project_id
  end
865

866
  def test_put_update_should_redirect_back_using_the_back_url_parameter
867 868 869
    issue = Issue.find(2)
    @request.session[:user_id] = 2

870
    put :update,
871 872 873 874 875 876 877 878 879 880
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => '/issues'

    assert_response :redirect
    assert_redirected_to '/issues'
  end
  
881
  def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
882 883 884
    issue = Issue.find(2)
    @request.session[:user_id] = 2

885
    put :update,
886 887 888 889 890 891 892 893 894
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         },
         :back_url => 'http://google.com'

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
  end
895
  
896 897 898 899 900
  def test_get_bulk_edit
    @request.session[:user_id] = 2
    get :bulk_edit, :ids => [1, 2]
    assert_response :success
    assert_template 'bulk_edit'
901 902 903 904 905
    
    # Project specific custom field, date type
    field = CustomField.find(9)
    assert !field.is_for_all?
    assert_equal 'date', field.field_format
jplang's avatar
jplang committed
906
    assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
907
    
908
    # System wide custom field
909
    assert CustomField.find(1).is_for_all?
jplang's avatar
jplang committed
910
    assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
911
  end
912

913
  def test_bulk_update
914 915
    @request.session[:user_id] = 2
    # update issues priority
916
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
jplang's avatar
jplang committed
917 918 919 920
                                     :issue => {:priority_id => 7,
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => ''}}
                                     
921 922 923
    assert_response 302
    # check that the issues were updated
    assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
924 925 926 927 928 929 930 931
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '125', issue.custom_value_for(2).value
    assert_equal 'Bulk editing', journal.notes
    assert_equal 1, journal.details.size
  end

932
  def test_bullk_update_should_send_a_notification
933 934
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
935
    post(:bulk_update,
936 937
         {
           :ids => [1, 2],
jplang's avatar
jplang committed
938 939 940 941 942 943
           :notes => 'Bulk editing',
           :issue => {
             :priority_id => 7,
             :assigned_to_id => '',
             :custom_field_values => {'2' => ''}
           }
944 945 946 947 948 949
         })

    assert_response 302
    assert_equal 2, ActionMailer::Base.deliveries.size
  end

950
  def test_bulk_update_status
951 952
    @request.session[:user_id] = 2
    # update issues priority
953
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
jplang's avatar
jplang committed
954 955 956 957
                                     :issue => {:priority_id => '',
                                                :assigned_to_id => '',
                                                :status_id => '5'}
                                     
958 959 960 961 962
    assert_response 302
    issue = Issue.find(1)
    assert issue.closed?
  end

963
  def test_bulk_update_custom_field
964 965
    @request.session[:user_id] = 2
    # update issues priority
966
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
jplang's avatar
jplang committed
967 968 969 970
                                     :issue => {:priority_id => '',
                                                :assigned_to_id => '',
                                                :custom_field_values => {'2' => '777'}}
                                     
971 972 973 974 975 976 977 978
    assert_response 302
    
    issue = Issue.find(1)
    journal = issue.journals.find(:first, :order => 'created_on DESC')
    assert_equal '777', issue.custom_value_for(2).value
    assert_equal 1, journal.details.size
    assert_equal '125', journal.details.first.old_value
    assert_equal '777', journal.details.first.value
979 980
  end

981
  def test_bulk_update_unassign
982 983 984
    assert_not_nil Issue.find(2).assigned_to
    @request.session[:user_id] = 2
    # unassign issues
985
    post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
986 987 988 989 990
    assert_response 302
    # check that the issues were updated
    assert_nil Issue.find(2).assigned_to
  end
  
991
  def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
992 993
    @request.session[:user_id] = 2

994
    post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
995 996 997 998 999 1000 1001 1002 1003

    assert_response :redirect
    issues = Issue.find([1,2])
    issues.each do |issue|
      assert_equal 4, issue.fixed_version_id
      assert_not_equal issue.project_id, issue.fixed_version.project_id
    end
  end

1004
  def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
1005
    @request.session[:user_id] = 2
1006
    post :bulk_update, :ids => [1,2], :back_url => '/issues'
1007 1008 1009 1010 1011

    assert_response :redirect
    assert_redirected_to '/issues'
  end

1012
  def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1013
    @request.session[:user_id] = 2
1014
    post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
1015 1016 1017 1018

    assert_response :redirect
    assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
  end
jplang's avatar
jplang committed
1019
  
1020
  def test_destroy_issue_with_no_time_entries
1021
    assert_nil TimeEntry.find_by_issue_id(2)
jplang's avatar
jplang committed
1022
    @request.session[:user_id] = 2
1023
    post :destroy, :id => 2
1024
    assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1025
    assert_nil Issue.find_by_id(2)
jplang's avatar
jplang committed
1026 1027
  end

1028 1029 1030 1031 1032 1033