issue_test.rb 111 KB
Newer Older
1
# Redmine - project management software
jplang's avatar
jplang committed
2
# Copyright (C) 2006-2016  Jean-Philippe Lang
3 4 5 6 7
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
8
#
9 10 11 12
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
13
#
14 15 16 17
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19

edavis10's avatar
edavis10 committed
20
class IssueTest < ActiveSupport::TestCase
21
  fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles,
22
           :groups_users,
23
           :trackers, :projects_trackers,
jplang's avatar
jplang committed
24
           :enabled_modules,
25
           :versions,
26
           :issue_statuses, :issue_categories, :issue_relations, :workflows,
27
           :enumerations,
28
           :issues, :journals, :journal_details,
29 30
           :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
           :time_entries
31

32 33
  include Redmine::I18n

jplang's avatar
jplang committed
34 35 36 37
  def setup
    set_language_if_valid 'en'
  end

38 39 40 41
  def teardown
    User.current = nil
  end

42 43 44 45 46
  def test_initialize
    issue = Issue.new

    assert_nil issue.project_id
    assert_nil issue.tracker_id
jplang's avatar
jplang committed
47
    assert_nil issue.status_id
48 49 50 51 52 53 54
    assert_nil issue.author_id
    assert_nil issue.assigned_to_id
    assert_nil issue.category_id

    assert_equal IssuePriority.default, issue.priority
  end

55
  def test_create
56 57 58 59
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                      :status_id => 1, :priority => IssuePriority.all.first,
                      :subject => 'test_create',
                      :description => 'IssueTest#test_create', :estimated_hours => '1:30')
60 61 62 63
    assert issue.save
    issue.reload
    assert_equal 1.5, issue.estimated_hours
  end
64

65
  def test_create_minimal
jplang's avatar
jplang committed
66
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
67
    assert issue.save
jplang's avatar
jplang committed
68
    assert_equal issue.tracker.default_status, issue.status
69
    assert issue.description.nil?
70
    assert_nil issue.estimated_hours
71
  end
72

73 74 75 76 77 78 79 80 81
  def test_create_with_all_fields_disabled
    tracker = Tracker.find(1)
    tracker.core_fields = []
    tracker.save!

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
    assert_save issue
  end

82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
  def test_start_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:start_date => invalid_date)
      assert !issue.valid?
      assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

  def test_due_date_format_should_be_validated
    set_language_if_valid 'en'
    ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
      issue = Issue.new(:due_date => invalid_date)
      assert !issue.valid?
      assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
    end
  end

100 101 102 103 104 105 106
  def test_due_date_lesser_than_start_date_should_not_validate
    set_language_if_valid 'en'
    issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
    assert !issue.valid?
    assert_include 'Due date must be greater than start date', issue.errors.full_messages
  end

107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
  def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
    issue = Issue.generate(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    assert !issue.valid?
    assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  end

  def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
    issue = Issue.generate!(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    issue.start_date = '2013-06-07'
    assert !issue.valid?
    assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  end

  def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
    issue = Issue.generate!(:start_date => '2013-06-04')
    issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
    assert issue.valid?
  end

128 129 130 131 132 133 134 135 136
  def test_estimated_hours_should_be_validated
    set_language_if_valid 'en'
    ['-2'].each do |invalid|
      issue = Issue.new(:estimated_hours => invalid)
      assert !issue.valid?
      assert_include 'Estimated time is invalid', issue.errors.full_messages
    end
  end

137
  def test_create_with_required_custom_field
138
    set_language_if_valid 'en'
139
    field = IssueCustomField.find_by_name('Database')
140
    field.update!(:is_required => true)
141

142 143 144
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
145 146 147
    assert issue.available_custom_fields.include?(field)
    # No value for the custom field
    assert !issue.save
148
    assert_equal ["Database cannot be blank"], issue.errors.full_messages
149 150 151
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
152
    assert_equal ["Database cannot be blank"], issue.errors.full_messages
153 154 155
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
    assert !issue.save
156
    assert_equal ["Database is not included in the list"], issue.errors.full_messages
157 158 159 160 161 162
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
163

164 165
  def test_create_with_group_assignment
    with_settings :issue_group_assignment => '1' do
166 167 168
      assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                       :subject => 'Group assignment',
                       :assigned_to_id => 11).save
169
      issue = Issue.order('id DESC').first
170 171 172 173
      assert_kind_of Group, issue.assigned_to
      assert_equal Group.find(11), issue.assigned_to
    end
  end
174

175
  def test_create_with_parent_issue_id
176 177 178
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => 1)
179 180 181 182 183
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

184 185 186 187 188 189 190 191 192
  def test_create_with_sharp_parent_issue_id
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => "#1")
    assert_save issue
    assert_equal 1, issue.parent_issue_id
    assert_equal Issue.find(1), issue.parent
  end

193
  def test_create_with_invalid_parent_issue_id
194
    set_language_if_valid 'en'
195 196 197
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '01ABC')
198 199 200 201 202
    assert !issue.save
    assert_equal '01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

203 204 205 206 207 208 209 210 211 212
  def test_create_with_invalid_sharp_parent_issue_id
    set_language_if_valid 'en'
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :author_id => 1, :subject => 'Group assignment',
                      :parent_issue_id => '#01ABC')
    assert !issue.save
    assert_equal '#01ABC', issue.parent_issue_id
    assert_include 'Parent task is invalid', issue.errors.full_messages
  end

213 214 215 216
  def assert_visibility_match(user, issues)
    assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  end

jplang's avatar
jplang committed
217 218
  def test_visible_scope_for_anonymous
    # Anonymous user should see issues of public projects only
jplang's avatar
jplang committed
219
    issues = Issue.visible(User.anonymous).to_a
jplang's avatar
jplang committed
220 221
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
222
    assert_nil issues.detect {|issue| issue.is_private?}
223 224
    assert_visibility_match User.anonymous, issues
  end
225

226
  def test_visible_scope_for_anonymous_without_view_issues_permissions
jplang's avatar
jplang committed
227 228
    # Anonymous user should not see issues without permission
    Role.anonymous.remove_permission!(:view_issues)
jplang's avatar
jplang committed
229
    issues = Issue.visible(User.anonymous).to_a
jplang's avatar
jplang committed
230
    assert issues.empty?
231
    assert_visibility_match User.anonymous, issues
jplang's avatar
jplang committed
232
  end
233

234 235 236 237 238 239 240 241 242 243
  def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
    Role.anonymous.remove_permission!(:view_issues)
    Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])

    issues = Issue.visible(User.anonymous).all
    assert issues.any?
    assert_equal [1], issues.map(&:project_id).uniq.sort
    assert_visibility_match User.anonymous, issues
  end

244
  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
245
    Role.anonymous.update!(:issues_visibility => 'default')
246
    issue = Issue.generate!(:author => User.anonymous, :is_private => true)
247 248 249 250 251
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

  def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
252
    assert Role.anonymous.update!(:issues_visibility => 'own')
253
    issue = Issue.generate!(:author => User.anonymous, :is_private => true)
254 255 256 257
    assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
    assert !issue.visible?(User.anonymous)
  end

258
  def test_visible_scope_for_non_member
jplang's avatar
jplang committed
259 260 261
    user = User.find(9)
    assert user.projects.empty?
    # Non member user should see issues of public projects only
jplang's avatar
jplang committed
262
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
263 264
    assert issues.any?
    assert_nil issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
265
    assert_nil issues.detect {|issue| issue.is_private?}
266 267
    assert_visibility_match user, issues
  end
268

269
  def test_visible_scope_for_non_member_with_own_issues_visibility
270
    Role.non_member.update! :issues_visibility => 'own'
271 272
    Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
    user = User.find(9)
273

jplang's avatar
jplang committed
274
    issues = Issue.visible(user).to_a
275 276 277 278
    assert issues.any?
    assert_nil issues.detect {|issue| issue.author != user}
    assert_visibility_match user, issues
  end
279

280
  def test_visible_scope_for_non_member_without_view_issues_permissions
jplang's avatar
jplang committed
281 282
    # Non member user should not see issues without permission
    Role.non_member.remove_permission!(:view_issues)
283 284
    user = User.find(9)
    assert user.projects.empty?
jplang's avatar
jplang committed
285
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
286
    assert issues.empty?
287 288
    assert_visibility_match user, issues
  end
289

290 291 292 293 294 295 296 297 298 299 300
  def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
    Role.non_member.remove_permission!(:view_issues)
    Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
    user = User.find(9)

    issues = Issue.visible(user).all
    assert issues.any?
    assert_equal [1], issues.map(&:project_id).uniq.sort
    assert_visibility_match user, issues
  end

301 302
  def test_visible_scope_for_member
    user = User.find(9)
303
    # User should see issues of projects for which user has view_issues permissions only
304
    Role.non_member.remove_permission!(:view_issues)
jplang's avatar
jplang committed
305
    Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
jplang's avatar
jplang committed
306
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
307
    assert issues.any?
jplang's avatar
jplang committed
308 309
    assert_nil issues.detect {|issue| issue.project_id != 3}
    assert_nil issues.detect {|issue| issue.is_private?}
310
    assert_visibility_match user, issues
jplang's avatar
jplang committed
311
  end
312

313 314 315 316 317 318 319 320 321
  def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
    Role.non_member.add_permission!(:view_issues)
    Role.find(1).remove_permission!(:view_issues)
    user = User.find(2)

    assert_equal 0, Issue.where(:project_id => 1).visible(user).count
    assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
  end

322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343
  def test_visible_scope_with_custom_non_member_role_having_restricted_permission
    role = Role.generate!(:permissions => [:view_project])
    assert Role.non_member.has_permission?(:view_issues)
    user = User.generate!
    Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])

    issues = Issue.visible(user).to_a
    assert issues.any?
    assert_nil issues.detect {|issue| issue.project_id == 1}
  end

  def test_visible_scope_with_custom_non_member_role_having_extended_permission
    role = Role.generate!(:permissions => [:view_project, :view_issues])
    Role.non_member.remove_permission!(:view_issues)
    user = User.generate!
    Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])

    issues = Issue.visible(user).to_a
    assert issues.any?
    assert_not_nil issues.detect {|issue| issue.project_id == 1}
  end

344 345 346
  def test_visible_scope_for_member_with_groups_should_return_assigned_issues
    user = User.find(8)
    assert user.groups.any?
347 348
    group = user.groups.first
    Member.create!(:principal => group, :project_id => 1, :role_ids => [2])
349
    Role.non_member.remove_permission!(:view_issues)
350

351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
    with_settings :issue_group_assignment => '1' do
      issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
        :status_id => 1, :priority => IssuePriority.all.first,
        :subject => 'Assignment test',
        :assigned_to => group,
        :is_private => true)
  
      Role.find(2).update! :issues_visibility => 'default'
      issues = Issue.visible(User.find(8)).to_a
      assert issues.any?
      assert issues.include?(issue)
  
      Role.find(2).update! :issues_visibility => 'own'
      issues = Issue.visible(User.find(8)).to_a
      assert issues.any?
      assert_include issue, issues
    end
368 369
  end

370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432
  def test_visible_scope_for_member_with_limited_tracker_ids
    role = Role.find(1)
    role.set_permission_trackers :view_issues, [2]
    role.save!
    user = User.find(2)

    issues = Issue.where(:project_id => 1).visible(user).to_a
    assert issues.any?
    assert_equal [2], issues.map(&:tracker_id).uniq

    assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  end

  def test_visible_scope_should_consider_tracker_ids_on_each_project
    user = User.generate!

    project1 = Project.generate!
    role1 = Role.generate!
    role1.add_permission! :view_issues
    role1.set_permission_trackers :view_issues, :all
    role1.save!
    User.add_to_project(user, project1, role1)

    project2 = Project.generate!
    role2 = Role.generate!
    role2.add_permission! :view_issues
    role2.set_permission_trackers :view_issues, [2]
    role2.save!
    User.add_to_project(user, project2, role2)

    visible_issues = [
      Issue.generate!(:project => project1, :tracker_id => 1),
      Issue.generate!(:project => project1, :tracker_id => 2),
      Issue.generate!(:project => project2, :tracker_id => 2)
    ]
    hidden_issue = Issue.generate!(:project => project2, :tracker_id => 1)

    issues = Issue.where(:project_id => [project1.id, project2.id]).visible(user)
    assert_equal visible_issues.map(&:id), issues.ids.sort

    assert visible_issues.all? {|issue| issue.visible?(user)}
    assert !hidden_issue.visible?(user)
  end

  def test_visible_scope_should_not_consider_roles_without_view_issues_permission
    user = User.generate!
    role1 = Role.generate!
    role1.remove_permission! :view_issues
    role1.set_permission_trackers :view_issues, :all
    role1.save!
    role2 = Role.generate!
    role2.add_permission! :view_issues
    role2.set_permission_trackers :view_issues, [2]
    role2.save!
    User.add_to_project(user, Project.find(1), [role1, role2])

    issues = Issue.where(:project_id => 1).visible(user).to_a
    assert issues.any?
    assert_equal [2], issues.map(&:tracker_id).uniq

    assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  end

jplang's avatar
jplang committed
433 434 435 436
  def test_visible_scope_for_admin
    user = User.find(1)
    user.members.each(&:destroy)
    assert user.projects.empty?
jplang's avatar
jplang committed
437
    issues = Issue.visible(user).to_a
jplang's avatar
jplang committed
438
    assert issues.any?
439
    # Admin should see issues on private projects that admin does not belong to
jplang's avatar
jplang committed
440
    assert issues.detect {|issue| !issue.project.is_public?}
jplang's avatar
jplang committed
441 442
    # Admin should see private issues of other users
    assert issues.detect {|issue| issue.is_private? && issue.author != user}
443
    assert_visibility_match user, issues
jplang's avatar
jplang committed
444
  end
445

446 447
  def test_visible_scope_with_project
    project = Project.find(1)
jplang's avatar
jplang committed
448
    issues = Issue.visible(User.find(2), :project => project).to_a
449 450 451 452
    projects = issues.collect(&:project).uniq
    assert_equal 1, projects.size
    assert_equal project, projects.first
  end
453

454 455
  def test_visible_scope_with_project_and_subprojects
    project = Project.find(1)
jplang's avatar
jplang committed
456
    issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
457 458 459 460
    projects = issues.collect(&:project).uniq
    assert projects.size > 1
    assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  end
461

462
  def test_visible_and_nested_set_scopes
463
    user = User.generate!
464
    Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
465 466 467 468 469 470 471 472 473 474 475
    parent = Issue.generate!(:assigned_to => user)
    assert parent.visible?(user)
    child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
    child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
    parent.reload
    child1.reload
    child2.reload
    assert child1.visible?(user)
    assert child2.visible?(user)
    assert_equal 2, parent.descendants.count
    assert_equal 2, parent.descendants.visible(user).count
476
    # awesome_nested_set 2-1-stable branch has regression.
477 478 479 480
    # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
    # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
    assert_equal 2, parent.descendants.collect{|i| i}.size
    assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
481
  end
482

jplang's avatar
jplang committed
483 484 485 486 487 488 489
  def test_visible_scope_with_unsaved_user_should_not_raise_an_error
    user = User.new
    assert_nothing_raised do
      Issue.visible(user).to_a
    end
  end

490
  def test_open_scope
jplang's avatar
jplang committed
491
    issues = Issue.open.to_a
492 493 494 495
    assert_nil issues.detect(&:closed?)
  end

  def test_open_scope_with_arg
jplang's avatar
jplang committed
496
    issues = Issue.open(false).to_a
497 498 499
    assert_equal issues, issues.select(&:closed?)
  end

500 501 502 503 504 505 506 507 508 509
  def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
    version = Version.find(2)
    assert version.fixed_issues.any?
    assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  end

  def test_fixed_version_scope_with_empty_array_should_return_no_result
    assert_equal 0, Issue.fixed_version([]).count
  end

510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525
  def test_assigned_to_scope_should_return_issues_assigned_to_the_user
    user = User.generate!
    issue = Issue.generate!
    Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
    assert_equal [issue], Issue.assigned_to(user).to_a
  end

  def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
    group = Group.generate!
    user = User.generate!
    group.users << user
    issue = Issue.generate!
    Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
    assert_equal [issue], Issue.assigned_to(user).to_a
  end

526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541
  def test_issue_should_be_readonly_on_closed_project
    issue = Issue.find(1)
    user = User.find(1)

    assert_equal true, issue.visible?(user)
    assert_equal true, issue.editable?(user)
    assert_equal true, issue.deletable?(user)

    issue.project.close
    issue.reload

    assert_equal true, issue.visible?(user)
    assert_equal false, issue.editable?(user)
    assert_equal false, issue.deletable?(user)
  end

542 543
  def test_errors_full_messages_should_include_custom_fields_errors
    field = IssueCustomField.find_by_name('Database')
544

tmaruyama's avatar
tmaruyama committed
545 546 547
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                      :status_id => 1, :subject => 'test_create',
                      :description => 'IssueTest#test_create_with_required_custom_field')
548 549 550
    assert issue.available_custom_fields.include?(field)
    # Invalid value
    issue.custom_field_values = { field.id => 'SQLServer' }
551

552 553
    assert !issue.valid?
    assert_equal 1, issue.errors.full_messages.size
tmaruyama's avatar
tmaruyama committed
554 555
    assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                 issue.errors.full_messages.first
556
  end
557

558 559
  def test_update_issue_with_required_custom_field
    field = IssueCustomField.find_by_name('Database')
560
    field.update!(:is_required => true)
561

562 563 564 565 566 567 568 569 570 571 572 573 574 575
    issue = Issue.find(1)
    assert_nil issue.custom_value_for(field)
    assert issue.available_custom_fields.include?(field)
    # No change to custom values, issue can be saved
    assert issue.save
    # Blank value
    issue.custom_field_values = { field.id => '' }
    assert !issue.save
    # Valid value
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    issue.reload
    assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  end
576

577 578 579 580
  def test_should_not_update_attributes_if_custom_fields_validation_fails
    issue = Issue.find(1)
    field = IssueCustomField.find_by_name('Database')
    assert issue.available_custom_fields.include?(field)
581

582 583 584
    issue.custom_field_values = { field.id => 'Invalid' }
    issue.subject = 'Should be not be saved'
    assert !issue.save
585

586
    issue.reload
587
    assert_equal "Cannot print recipes", issue.subject
588
  end
589

590 591
  def test_should_not_recreate_custom_values_objects_on_update
    field = IssueCustomField.find_by_name('Database')
592

593 594 595 596 597 598 599 600 601 602
    issue = Issue.find(1)
    issue.custom_field_values = { field.id => 'PostgreSQL' }
    assert issue.save
    custom_value = issue.custom_value_for(field)
    issue.reload
    issue.custom_field_values = { field.id => 'MySQL' }
    assert issue.save
    issue.reload
    assert_equal custom_value.id, issue.custom_value_for(field).id
  end
603

604 605
  def test_setting_project_should_set_version_to_default_version
    version = Version.generate!(:project_id => 1)
606
    Project.find(1).update!(:default_version_id => version.id)
607 608 609 610 611

    issue = Issue.new(:project_id => 1)
    assert_equal version, issue.fixed_version
  end

612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
  def test_default_assigned_to_based_on_category_should_be_set_on_create
    user = User.find(3)
    category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)

    issue = Issue.generate!(:project_id => 1, :category_id => category.id)
    assert_equal user, issue.assigned_to
  end

  def test_default_assigned_to_based_on_project_should_be_set_on_create
    user = User.find(3)
    Project.find(1).update!(:default_assigned_to_id => user.id)

    issue = Issue.generate!(:project_id => 1)
    assert_equal user, issue.assigned_to
  end

628
  def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
tmaruyama's avatar
tmaruyama committed
629 630 631
    issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
                          :status_id => 1, :subject => 'Test',
                          :custom_field_values => {'2' => 'Test'})
632 633 634 635 636 637 638 639 640 641 642
    assert !Tracker.find(2).custom_field_ids.include?(2)

    issue = Issue.find(issue.id)
    issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}

    issue = Issue.find(issue.id)
    custom_value = issue.custom_value_for(2)
    assert_not_nil custom_value
    assert_equal 'Test', custom_value.value
  end

643 644 645 646 647 648
  def test_assigning_tracker_id_should_reload_custom_fields_values
    issue = Issue.new(:project => Project.find(1))
    assert issue.custom_field_values.empty?
    issue.tracker_id = 1
    assert issue.custom_field_values.any?
  end
649

650 651 652 653 654 655 656 657 658 659
  def test_assigning_attributes_should_assign_project_and_tracker_first
    seq = sequence('seq')
    issue = Issue.new
    issue.expects(:project_id=).in_sequence(seq)
    issue.expects(:tracker_id=).in_sequence(seq)
    issue.expects(:subject=).in_sequence(seq)
    issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  end

  def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
660 661 662 663 664
    attributes = ActiveSupport::OrderedHash.new
    attributes['custom_field_values'] = { '1' => 'MySQL' }
    attributes['tracker_id'] = '1'
    issue = Issue.new(:project => Project.find(1))
    issue.attributes = attributes
665
    assert_equal 'MySQL', issue.custom_field_value(1)
666
  end
667

668 669 670 671 672 673 674 675 676 677 678 679 680 681
  def test_changing_tracker_should_clear_disabled_core_fields
    tracker = Tracker.find(2)
    tracker.core_fields = tracker.core_fields - %w(due_date)
    tracker.save!

    issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
    issue.save!

    issue.tracker_id = 2
    issue.save!
    assert_not_nil issue.start_date
    assert_nil issue.due_date
  end

682 683
  def test_attribute_cleared_on_tracker_change_should_be_journalized
    CustomField.delete_all
684 685 686 687 688 689 690 691 692 693 694 695 696 697
    tracker = Tracker.find(2)
    tracker.core_fields = tracker.core_fields - %w(due_date)
    tracker.save!

    issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
    issue.save!

    assert_difference 'Journal.count' do
      issue.init_journal User.find(1)
      issue.tracker_id = 2
      issue.save!
      assert_nil issue.due_date
    end
    journal = Journal.order('id DESC').first
698 699
    details = journal.details.select {|d| d.prop_key == 'due_date'}
    assert_equal 1, details.count
700 701
  end

702 703 704 705 706 707 708 709 710 711 712 713 714 715 716
  def test_reload_should_reload_custom_field_values
    issue = Issue.generate!
    issue.custom_field_values = {'2' => 'Foo'}
    issue.save!

    issue = Issue.order('id desc').first
    assert_equal 'Foo', issue.custom_field_value(2)

    issue.custom_field_values = {'2' => 'Bar'}
    assert_equal 'Bar', issue.custom_field_value(2)

    issue.reload
    assert_equal 'Foo', issue.custom_field_value(2)
  end

717 718 719
  def test_should_update_issue_with_disabled_tracker
    p = Project.find(1)
    issue = Issue.find(1)
720

721 722
    p.trackers.delete(issue.tracker)
    assert !p.trackers.include?(issue.tracker)
723

724 725 726 727
    issue.reload
    issue.subject = 'New subject'
    assert issue.save
  end
728

729 730 731
  def test_should_not_set_a_disabled_tracker
    p = Project.find(1)
    p.trackers.delete(Tracker.find(2))
732

733 734 735 736
    issue = Issue.find(1)
    issue.tracker_id = 2
    issue.subject = 'New subject'
    assert !issue.save
737
    assert_not_equal [], issue.errors[:tracker_id]
738
  end
739

740
  def test_category_based_assignment
741 742 743 744
    issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                         :status_id => 1, :priority => IssuePriority.all.first,
                         :subject => 'Assignment test',
                         :description => 'Assignment test', :category_id => 1)
745 746
    assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  end
747

748
  def test_new_statuses_allowed_to
749
    WorkflowTransition.delete_all
750 751 752 753 754 755
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 2,
                               :author => false, :assignee => false)
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 3,
                               :author => true, :assignee => false)
756 757 758
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 4,
                               :author => false, :assignee => true)
759 760 761
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 5,
                               :author => true, :assignee => true)
762 763 764 765
    status = IssueStatus.find(1)
    role = Role.find(1)
    tracker = Tracker.find(1)
    user = User.find(2)
766

767 768
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1)
769
    assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
770

771 772
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user)
jplang's avatar
jplang committed
773
    assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
774

775 776 777
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author_id => 1,
                            :assigned_to => user)
jplang's avatar
jplang committed
778
    assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
779

780 781 782
    issue = Issue.generate!(:tracker => tracker, :status => status,
                            :project_id => 1, :author => user,
                            :assigned_to => user)
783
    assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
784 785 786 787 788 789 790 791
  end

  def test_new_statuses_allowed_to_should_consider_group_assignment
    WorkflowTransition.delete_all
    WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                               :old_status_id => 1, :new_status_id => 4,
                               :author => false, :assignee => true)
    group = Group.generate!
792 793 794
    Member.create!(:project_id => 1, :principal => group, :role_ids => [1])

    user = User.find(2)
795
    group.users << user
796

797 798 799 800
    with_settings :issue_group_assignment => '1' do
      issue = Issue.generate!(:author_id => 1, :assigned_to => group)
      assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
    end
801
  end
802

803 804 805 806
  def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
    admin = User.find(1)
    issue = Issue.find(1)
    assert !admin.member_of?(issue.project)
807
    expected_statuses = [issue.status] +
808
                            WorkflowTransition.where(:old_status_id => issue.status_id).
809
                                map(&:new_status).uniq.sort
810 811 812
    assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  end

813
  def test_new_statuses_allowed_to_should_return_allowed_statuses_when_copying
814
    Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
815

816 817
    orig = Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 4)
    issue = orig.copy
818 819
    assert_equal [1, 3], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
    assert_equal 1, issue.status_id
820
  end
821

822 823 824 825 826 827 828 829 830 831
  def test_safe_attributes_names_should_be_updated_when_changing_project
    issue = Issue.new
    with_current_user(User.find(2)) do
      assert_not_include 'watcher_user_ids', issue.safe_attribute_names

      issue.project_id = 1
      assert_include 'watcher_user_ids', issue.safe_attribute_names
    end
  end

832
  def test_safe_attributes_names_should_not_include_disabled_field
833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862
    tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))

    issue = Issue.new(:tracker => tracker)
    assert_include 'tracker_id', issue.safe_attribute_names
    assert_include 'status_id', issue.safe_attribute_names
    assert_include 'subject', issue.safe_attribute_names
    assert_include 'custom_field_values', issue.safe_attribute_names
    assert_include 'custom_fields', issue.safe_attribute_names
    assert_include 'lock_version', issue.safe_attribute_names

    tracker.core_fields.each do |field|
      assert_include field, issue.safe_attribute_names
    end

    tracker.disabled_core_fields.each do |field|
      assert_not_include field, issue.safe_attribute_names
    end
  end

  def test_safe_attributes_should_ignore_disabled_fields
    tracker = Tracker.find(1)
    tracker.core_fields = %w(assigned_to_id due_date)
    tracker.save!

    issue = Issue.new(:tracker => tracker)
    issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
    assert_nil issue.start_date
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end

863
  def test_safe_attributes_should_accept_target_tracker_enabled_fields
864 865 866 867 868 869
    source = Tracker.find(1)
    source.core_fields = []
    source.save!
    target = Tracker.find(2)
    target.core_fields = %w(assigned_to_id due_date)
    target.save!
870
    user = User.find(2)
871

872 873
    issue = Issue.new(:project => Project.find(1), :tracker => source)
    issue.send :safe_attributes=, {'tracker_id' => 2, 'due_date' => '2012-07-14'}, user
874 875 876
    assert_equal target, issue.tracker
    assert_equal Date.parse('2012-07-14'), issue.due_date
  end
877 878 879

  def test_safe_attributes_should_not_include_readonly_fields
    WorkflowPermission.delete_all
880 881 882
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
883 884 885 886 887 888 889 890 891 892 893 894
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
    assert_not_include 'due_date', issue.safe_attribute_names(user)

    issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
    assert_equal Date.parse('2012-07-14'), issue.start_date
    assert_nil issue.due_date
  end

  def test_safe_attributes_should_not_include_readonly_custom_fields
tmaruyama's avatar
tmaruyama committed
895 896 897 898 899 900
    cf1 = IssueCustomField.create!(:name => 'Writable field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
    cf2 = IssueCustomField.create!(:name => 'Readonly field',
                                   :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1])
901
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
902 903 904
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf2.id.to_s,
                               :rule => 'readonly')
905 906 907 908 909
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
    assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)

tmaruyama's avatar
tmaruyama committed
910 911 912
    issue.send :safe_attributes=, {'custom_field_values' => {
                                       cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
                                     }}, user
913 914 915
    assert_equal 'value1', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)

tmaruyama's avatar
tmaruyama committed
916 917 918 919
    issue.send :safe_attributes=, {'custom_fields' => [
                                      {'id' => cf1.id.to_s, 'value' => 'valuea'},
                                      {'id' => cf2.id.to_s, 'value' => 'valueb'}
                                    ]}, user
920 921 922 923 924
    assert_equal 'valuea', issue.custom_field_value(cf1)
    assert_nil issue.custom_field_value(cf2)
  end

  def test_editable_custom_field_values_should_return_non_readonly_custom_values
tmaruyama's avatar
tmaruyama committed
925 926 927 928
    cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
    cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
                                   :is_for_all => true, :tracker_ids => [1, 2])
929
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
930 931
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
                               :field_name => cf2.id.to_s, :rule => 'readonly')
932 933 934 935 936 937 938 939 940 941 942 943 944
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1)
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert_nil values.detect {|value| value.custom_field == cf2}

    issue.tracker_id = 2
    values = issue.editable_custom_field_values(user)
    assert values.detect {|value| value.custom_field == cf1}
    assert values.detect {|value| value.custom_field == cf2}
  end

945 946 947 948 949 950 951 952 953 954
  def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
    enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
    disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
    user = User.find(2)
    issue = Issue.new(:project_id => 1, :tracker_id => 1)

    assert_include enabled_cf, issue.editable_custom_fields(user)
    assert_not_include disabled_cf, issue.editable_custom_fields(user)
  end

955 956
  def test_safe_attributes_should_accept_target_tracker_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
957 958 959 960 961 962
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
963 964 965 966
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
967 968
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'}, user
969 970 971
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
972 973 974
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                   'due_date' => '2012-07-16',
                                   'tracker_id' => 2}, user
975 976 977 978 979 980
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_safe_attributes_should_accept_target_status_writable_fields
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
981 982 983 984 985 986
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
987 988 989 990
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

tmaruyama's avatar
tmaruyama committed
991 992 993
    issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                   'due_date' => '2012-07-14'},
                                   user
994 995 996
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_nil issue.due_date

tmaruyama's avatar
tmaruyama committed
997 998 999 1000
    issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                    'due_date' => '2012-07-16',
                                    'status_id' => 2},
                                  user
1001 1002 1003 1004 1005
    assert_equal Date.parse('2012-07-12'), issue.start_date
    assert_equal Date.parse('2012-07-16'), issue.due_date
  end

  def test_required_attributes_should_be_validated
1006 1007
    cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
                                  :is_for_all => true, :tracker_ids => [1, 2])
1008 1009

    WorkflowPermission.delete_all
1010 1011 1012 1013 1014 1015 1016 1017 1018
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'category_id',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
1019

1020 1021 1022 1023 1024 1025
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                               :role_id => 1, :field_name => cf.id.to_s,
                               :rule => 'required')
1026 1027
    user = User.find(2)

1028 1029 1030 1031 1032
    issue = Issue.new(:project_id => 1, :tracker_id => 1,
                      :status_id => 1, :subject => 'Required fields',
                      :author => user)
    assert_equal [cf.id.to_s, "category_id", "due_date"],
                 issue.required_attribute_names(user).sort
1033
    assert !issue.save, "Issue was saved"
1034
    assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
1035
                  issue.errors.full_messages.sort
1036 1037 1038 1039

    issue.tracker_id = 2
    assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
    assert !issue.save, "Issue was saved"
1040
    assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
1041
                 issue.errors.full_messages.sort
1042 1043 1044 1045 1046 1047

    issue.start_date = Date.today
    issue.custom_field_values = {cf.id.to_s => 'bar'}
    assert issue.save
  end

1048 1049 1050 1051 1052 1053 1054 1055 1056 1057
  def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert !issue.save
1058
    assert_include "Start date cannot be blank", issue.errors.full_messages
1059 1060 1061 1062 1063 1064 1065 1066 1067

    tracker = Tracker.find(1)
    tracker.core_fields -= %w(start_date)
    tracker.save!
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert issue.save
  end

1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091
  def test_category_should_not_be_required_if_project_has_no_categories
    Project.find(1).issue_categories.delete_all
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
      :role_id => 1, :field_name => 'category_id',:rule => 'required')
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert_save issue
  end

  def test_fixed_version_should_not_be_required_no_assignable_versions
    Version.delete_all
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
      :role_id => 1, :field_name => 'fixed_version_id',:rule => 'required')
    user = User.find(2)

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert_save issue
  end

1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114
  def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
    CustomField.delete_all
    field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
    user = User.generate!
    User.add_to_project(user, Project.find(1), Role.find(2))

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert_save issue
  end

  def test_required_custom_field_that_is_visible_for_the_user_should_be_required
    CustomField.delete_all
    field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
    user = User.generate!
    User.add_to_project(user, Project.find(1), Role.find(1))

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                      :subject => 'Required fields', :author => user)
    assert !issue.save
    assert_include "#{field.name} cannot be blank", issue.errors.full_messages
  end

1115 1116
  def test_required_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
1117 1118 1119 1120 1121 1122
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'required')
1123 1124 1125 1126 1127 1128 1129 1130 1131 1132
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
1133 1134 1135
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 2, :field_name => 'due_date',
                               :rule => 'required')
1136 1137 1138 1139 1140 1141
    assert_equal %w(due_date), issue.required_attribute_names(user)

    member.role_ids = [1, 2, 3]
    member.save!
    assert_equal [], issue.required_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
1142
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1143
                               :role_id => 3, :field_name => 'due_date',
tmaruyama's avatar
tmaruyama committed
1144
                               :rule => 'readonly')
1145 1146 1147 1148 1149 1150
    # required + readonly => required
    assert_equal %w(due_date), issue.required_attribute_names(user)
  end

  def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
    WorkflowPermission.delete_all
tmaruyama's avatar
tmaruyama committed
1151 1152 1153 1154 1155 1156
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')
1157 1158 1159 1160 1161 1162 1163 1164 1165 1166
    user = User.find(2)
    member = Member.find(1)
    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort

    member.role_ids = [1, 2]
    member.save!
    assert_equal [], issue.read_only_attribute_names(user.reload)

tmaruyama's avatar
tmaruyama committed
1167 1168 1169
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                              :role_id => 2, :field_name => 'due_date',
                              :rule => 'readonly')
1170 1171
    assert_equal %w(due_date), issue.read_only_attribute_names(user)
  end
1172

1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189
  # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
  def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
    field = IssueCustomField.generate!(
      :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
    )
    WorkflowPermission.delete_all
    WorkflowPermission.create!(
      :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
    )
    user = User.generate!
    project = Project.find(1)
    User.add_to_project(user, project, Role.where(:id => [1, 2]))

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
    assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
  end

1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
  def test_workflow_rules_should_ignore_roles_without_issue_permissions
    role = Role.generate! :permissions => [:view_issues, :edit_issues]
    ignored_role = Role.generate! :permissions => [:view_issues]

    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role => role, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role => role, :field_name => 'start_date',
                               :rule => 'readonly')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role => role, :field_name => 'done_ratio',
                               :rule => 'readonly')
    user = User.generate!
    User.add_to_project user, Project.find(1), [role, ignored_role]

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date), issue.required_attribute_names(user)
    assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
  end

1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233
  def test_workflow_rules_should_work_for_member_with_duplicate_role
    WorkflowPermission.delete_all
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'due_date',
                               :rule => 'required')
    WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                               :role_id => 1, :field_name => 'start_date',
                               :rule => 'readonly')

    user = User.generate!
    m = Member.new(:user_id => user.id, :project_id => 1)
    m.member_roles.build(:role_id => 1)
    m.member_roles.build(:role_id => 1)
    m.save!

    issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)

    assert_equal %w(due_date), issue.required_attribute_names(user)
    assert_equal %w(start_date), issue.read_only_attribute_names(user)
  end

1234 1235
  def test_copy
    issue = Issue.new.copy_from(1)
1236
    assert issue.copy?
1237 1238 1239 1240 1241
    assert issue.save
    issue.reload
    orig = Issue.find(1)
    assert_equal orig.subject, issue.subject
    assert_equal orig.tracker, issue.tracker
jplang's avatar
jplang committed
1242
    assert_equal "125", issue.custom_value_for(2).value
1243
  end
1244

1245 1246 1247 1248 1249 1250 1251 1252 1253
  def test_copy_to_another_project_should_clear_assignee_if_not_valid
    issue = Issue.generate!(:project_id => 1, :assigned_to_id => 2)
    project = Project.generate!

    issue = Issue.new.copy_from(1)
    issue.project = project
    assert_nil issue.assigned_to
  end

1254
  def test_copy_with_keep_status_should_copy_status
1255
    orig = Issue.find(8)
jplang's avatar
jplang committed
1256
    assert orig.status != orig.default_status
1257

1258
    issue = Issue.new.copy_from(orig, :keep_status => true)
1259 1260 1261 1262
    assert issue.save