GitLab wurde erfolgreich aktualisiert. Dank regelmäßiger Updates bleibt das THM GitLab sicher und Sie profitieren von den neuesten Funktionen. Danke für Ihre Geduld.

issues_controller_test.rb 51 KB
Newer Older
1
# Redmine - project management software
2
# Copyright (C) 2006-2011  Jean-Philippe Lang
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

18
require File.expand_path('../../test_helper', __FILE__)
19 20 21 22 23
require 'issues_controller'

# Re-raise errors caught by the controller.
class IssuesController; def rescue_action(e) raise e end; end

edavis10's avatar
edavis10 committed
24
class IssuesControllerTest < ActionController::TestCase
25 26 27 28
  fixtures :projects,
           :users,
           :roles,
           :members,
29
           :member_roles,
30 31
           :issues,
           :issue_statuses,
32
           :versions,
33
           :trackers,
34
           :projects_trackers,
35 36 37
           :issue_categories,
           :enabled_modules,
           :enumerations,
38
           :attachments,
39 40 41
           :workflows,
           :custom_fields,
           :custom_values,
jplang's avatar
jplang committed
42
           :custom_fields_projects,
43
           :custom_fields_trackers,
44 45
           :time_entries,
           :journals,
edavis10's avatar
edavis10 committed
46 47
           :journal_details,
           :queries
48 49 50 51 52 53 54
  
  def setup
    @controller = IssuesController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
    User.current = nil
  end
55
  
56
  def test_index
57 58
    Setting.default_language = 'en'
    
59 60 61 62 63
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
64 65 66 67 68
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    # private projects hidden
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
    assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 70
    # project column
    assert_tag :tag => 'th', :content => /Project/
71
  end
72 73 74 75 76 77 78 79 80 81 82
  
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
83

84 85 86 87 88 89 90 91 92 93
  def test_index_should_not_list_issues_when_module_disabled
    EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
    get :index
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:project)
    assert_no_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
  end
jplang's avatar
jplang committed
94 95 96 97 98 99 100

  def test_index_should_list_visible_issues_only
    get :index, :per_page => 100
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issues).detect {|issue| !issue.visible?}
  end
101
  
102
  def test_index_with_project
103
    Setting.display_subprojects_issues = 0
104 105 106 107
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_no_tag :tag => 'a', :content => /Subproject issue/
  end
  
  def test_index_with_project_and_subprojects
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
  end
  
  def test_index_with_project_and_subprojects_should_show_private_subprojects
    @request.session[:user_id] = 2
    Setting.display_subprojects_issues = 1
    get :index, :project_id => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_tag :tag => 'a', :content => /Can't print recipes/
    assert_tag :tag => 'a', :content => /Subproject issue/
    assert_tag :tag => 'a', :content => /Issue of a private subproject/
133 134
  end
  
135
  def test_index_with_project_and_default_filter
136 137 138 139
    get :index, :project_id => 1, :set_filter => 1
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
140 141 142 143 144 145 146 147 148
    
    query = assigns(:query)
    assert_not_nil query
    # default filter
    assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
  end
  
  def test_index_with_project_and_filter
    get :index, :project_id => 1, :set_filter => 1, 
jplang's avatar
jplang committed
149 150 151
      :f => ['tracker_id'],
      :op => {'tracker_id' => '='},
      :v => {'tracker_id' => ['1']} 
152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    
    query = assigns(:query)
    assert_not_nil query
    assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
  end
  
  def test_index_with_project_and_empty_filters
    get :index, :project_id => 1, :set_filter => 1, :fields => ['']
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    
    query = assigns(:query)
    assert_not_nil query
    # no filter
    assert_equal({}, query.filters)
171 172
  end
  
jplang's avatar
jplang committed
173 174 175 176 177 178 179 180
  def test_index_with_query
    get :index, :project_id => 1, :query_id => 5
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
    assert_nil assigns(:issue_count_by_group)
  end
  
181
  def test_index_with_query_grouped_by_tracker
jplang's avatar
jplang committed
182 183 184 185
    get :index, :project_id => 1, :query_id => 6
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
186
    assert_not_nil assigns(:issue_count_by_group)
187 188 189 190 191 192 193
  end
  
  def test_index_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9
    assert_response :success
    assert_template 'index.rhtml'
    assert_not_nil assigns(:issues)
194
    assert_not_nil assigns(:issue_count_by_group)
jplang's avatar
jplang committed
195 196
  end
  
jplang's avatar
jplang committed
197 198 199 200 201
  def test_index_sort_by_field_not_included_in_columns
    Setting.issue_list_default_columns = %w(subject author)
    get :index, :sort => 'tracker'
  end
  
202
  def test_index_csv_with_project
203 204
    Setting.default_language = 'en'
    
205 206 207 208
    get :index, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
209
    assert @response.body.starts_with?("#,")
210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226

    get :index, :project_id => 1, :format => 'csv'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'text/csv', @response.content_type
  end
  
  def test_index_pdf
    get :index, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
    
    get :index, :project_id => 1, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
jplang's avatar
jplang committed
227 228 229 230 231
    
    get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_equal 'application/pdf', @response.content_type
232
  end
233
  
234 235 236 237 238 239 240 241
  def test_index_pdf_with_query_grouped_by_list_custom_field
    get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
    assert_response :success
    assert_not_nil assigns(:issues)
    assert_not_nil assigns(:issue_count_by_group)
    assert_equal 'application/pdf', @response.content_type
  end
  
242
  def test_index_sort
jplang's avatar
jplang committed
243
    get :index, :sort => 'tracker,id:desc'
244 245
    assert_response :success
    
jplang's avatar
jplang committed
246 247 248 249 250 251 252 253
    sort_params = @request.session['issues_index_sort']
    assert sort_params.is_a?(String)
    assert_equal 'tracker,id:desc', sort_params
    
    issues = assigns(:issues)
    assert_not_nil issues
    assert !issues.empty?
    assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
254
  end
255 256 257
  
  def test_index_with_columns
    columns = ['tracker', 'subject', 'assigned_to']
258
    get :index, :set_filter => 1, :c => columns
259 260 261 262 263 264 265 266 267 268 269 270
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    # columns should be stored in session
    assert_kind_of Hash, session[:query]
    assert_kind_of Array, session[:query][:column_names]
    assert_equal columns, session[:query][:column_names].map(&:to_s)
  end
271 272 273 274 275 276 277 278 279 280 281 282 283 284 285
  
  def test_index_with_custom_field_column
    columns = %w(tracker subject cf_2)
    get :index, :set_filter => 1, :c => columns
    assert_response :success
    
    # query should use specified columns
    query = assigns(:query)
    assert_kind_of Query, query
    assert_equal columns, query.column_names.map(&:to_s)
    
    assert_tag :td,
      :attributes => {:class => 'cf_2 string'},
      :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
  end
286

287
  def test_show_by_anonymous
jplang's avatar
jplang committed
288 289 290 291
    get :show, :id => 1
    assert_response :success
    assert_template 'show.rhtml'
    assert_not_nil assigns(:issue)
292 293 294 295 296 297 298
    assert_equal Issue.find(1), assigns(:issue)
    
    # anonymous role is allowed to add a note
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
jplang's avatar
jplang committed
299 300
  end
  
301 302 303 304 305
  def test_show_by_manager
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response :success
    
306 307 308
    assert_tag :tag => 'a',
      :content => /Quote/
    
309 310 311 312 313 314 315 316 317 318 319
    assert_tag :tag => 'form',
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Change properties/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Log time/ } },
               :descendant => { :tag => 'fieldset',
                                :child => { :tag => 'legend', 
                                            :content => /Notes/ } }
  end
320
  
jplang's avatar
jplang committed
321 322 323 324 325 326
  def test_show_should_deny_anonymous_access_without_permission
    Role.anonymous.remove_permission!(:view_issues)
    get :show, :id => 1
    assert_response :redirect
  end
  
jplang's avatar
jplang committed
327 328 329 330 331 332
  def test_show_should_deny_anonymous_access_to_private_issue
    Issue.update_all(["is_private = ?", true], "id = 1")
    get :show, :id => 1
    assert_response :redirect
  end
  
jplang's avatar
jplang committed
333 334 335 336 337 338 339
  def test_show_should_deny_non_member_access_without_permission
    Role.non_member.remove_permission!(:view_issues)
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
jplang's avatar
jplang committed
340 341 342 343 344 345 346
  def test_show_should_deny_non_member_access_to_private_issue
    Issue.update_all(["is_private = ?", true], "id = 1")
    @request.session[:user_id] = 9
    get :show, :id => 1
    assert_response 403
  end
  
jplang's avatar
jplang committed
347 348 349 350 351 352 353
  def test_show_should_deny_member_access_without_permission
    Role.find(1).remove_permission!(:view_issues)
    @request.session[:user_id] = 2
    get :show, :id => 1
    assert_response 403
  end
  
jplang's avatar
jplang committed
354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382
  def test_show_should_deny_member_access_to_private_issue_without_permission
    Issue.update_all(["is_private = ?", true], "id = 1")
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response 403
  end
  
  def test_show_should_allow_author_access_to_private_issue
    Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response :success
  end
  
  def test_show_should_allow_assignee_access_to_private_issue
    Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response :success
  end
  
  def test_show_should_allow_member_access_to_private_issue_with_permission
    Issue.update_all(["is_private = ?", true], "id = 1")
    User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
    @request.session[:user_id] = 3
    get :show, :id => 1
    assert_response :success
  end
  
383 384 385 386 387 388 389 390 391 392 393 394 395 396 397
  def test_show_should_not_disclose_relations_to_invisible_issues
    Setting.cross_project_issue_relations = '1'
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
    # Relation to a private project issue
    IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
    
    get :show, :id => 1
    assert_response :success
    
    assert_tag :div, :attributes => { :id => 'relations' },
                     :descendant => { :tag => 'a', :content => /#2$/ }
    assert_no_tag :div, :attributes => { :id => 'relations' },
                        :descendant => { :tag => 'a', :content => /#4$/ }
  end
  
398 399 400
  def test_show_atom
    get :show, :id => 2, :format => 'atom'
    assert_response :success
401
    assert_template 'journals/index.rxml'
402
    # Inline image
403
    assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
404 405
  end
  
jplang's avatar
jplang committed
406
  def test_show_export_to_pdf
407
    get :show, :id => 3, :format => 'pdf'
jplang's avatar
jplang committed
408 409 410 411 412 413
    assert_response :success
    assert_equal 'application/pdf', @response.content_type
    assert @response.body.starts_with?('%PDF')
    assert_not_nil assigns(:issue)
  end

414 415 416 417 418
  def test_get_new
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :tracker_id => 1
    assert_response :success
    assert_template 'new'
419
    
420
    assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
421
                                                 :value => 'Default string' }
422 423 424 425 426 427 428 429 430 431 432 433 434
  end

  def test_get_new_without_tracker_id
    @request.session[:user_id] = 2
    get :new, :project_id => 1
    assert_response :success
    assert_template 'new'
    
    issue = assigns(:issue)
    assert_not_nil issue
    assert_equal Project.find(1).trackers.first, issue.tracker
  end
  
435 436 437 438 439 440
  def test_get_new_with_no_default_status_should_display_an_error
    @request.session[:user_id] = 2
    IssueStatus.delete_all
    
    get :new, :project_id => 1
    assert_response 500
441
    assert_error_tag :content => /No default issue/
442 443 444 445 446 447 448 449
  end
  
  def test_get_new_with_no_tracker_should_display_an_error
    @request.session[:user_id] = 2
    Tracker.delete_all
    
    get :new, :project_id => 1
    assert_response 500
450
    assert_error_tag :content => /No tracker/
451 452
  end
  
453 454
  def test_update_new_form
    @request.session[:user_id] = 2
455
    xhr :post, :new, :project_id => 1,
456 457 458 459 460
                     :issue => {:tracker_id => 2, 
                                :subject => 'This is the test_new issue',
                                :description => 'This is the description',
                                :priority_id => 5}
    assert_response :success
461 462 463 464 465 466 467 468
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
469
  
470
  def test_post_create
471
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
472
    assert_difference 'Issue.count' do
473
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
474
                 :issue => {:tracker_id => 3,
475
                            :status_id => 2,
edavis10's avatar
edavis10 committed
476 477 478
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
479
                            :start_date => '2010-11-07',
edavis10's avatar
edavis10 committed
480 481 482 483
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
484 485 486 487
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_equal 2, issue.author_id
488
    assert_equal 3, issue.tracker_id
489
    assert_equal 2, issue.status_id
490
    assert_equal Date.parse('2010-11-07'), issue.start_date
491
    assert_nil issue.estimated_hours
492
    v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
493 494
    assert_not_nil v
    assert_equal 'Value for field 2', v.value
495 496
  end
  
497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
  def test_post_create_without_start_date
    @request.session[:user_id] = 2
    assert_difference 'Issue.count' do
      post :create, :project_id => 1, 
                 :issue => {:tracker_id => 3,
                            :status_id => 2,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :start_date => '',
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
    
    issue = Issue.find_by_subject('This is the test_new issue')
    assert_not_nil issue
    assert_nil issue.start_date
  end
  
517
  def test_post_create_and_continue
518
    @request.session[:user_id] = 2
519
    post :create, :project_id => 1, 
520 521 522 523
               :issue => {:tracker_id => 3,
                          :subject => 'This is first issue',
                          :priority_id => 5},
               :continue => ''
524 525
    assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook',
                         :issue => {:tracker_id => 3}
526 527
  end
  
528
  def test_post_create_without_custom_fields_param
529
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
530
    assert_difference 'Issue.count' do
531
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
532 533 534 535 536 537
                 :issue => {:tracker_id => 1,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
538
  end
539

540
  def test_post_create_with_required_custom_field_and_without_custom_fields_param
541 542 543 544
    field = IssueCustomField.find_by_name('Database')
    field.update_attribute(:is_required, true)

    @request.session[:user_id] = 2
545
    post :create, :project_id => 1, 
546 547 548 549 550 551 552 553
               :issue => {:tracker_id => 1,
                          :subject => 'This is the test_new issue',
                          :description => 'This is the description',
                          :priority_id => 5}
    assert_response :success
    assert_template 'new'
    issue = assigns(:issue)
    assert_not_nil issue
554
    assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
555 556
  end
  
557
  def test_post_create_with_watchers
558 559 560 561
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    
    assert_difference 'Watcher.count', 2 do
562
      post :create, :project_id => 1, 
563 564 565 566 567 568 569
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a new issue with watchers',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :watcher_user_ids => ['2', '3']}
    end
    issue = Issue.find_by_subject('This is a new issue with watchers')
jplang's avatar
jplang committed
570 571 572
    assert_not_nil issue
    assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
    
573 574 575 576 577 578 579 580 581
    # Watchers added
    assert_equal [2, 3], issue.watcher_user_ids.sort
    assert issue.watched_by?(User.find(3))
    # Watchers notified
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
  end
  
582
  def test_post_create_subissue
jplang's avatar
jplang committed
583 584 585
    @request.session[:user_id] = 2
    
    assert_difference 'Issue.count' do
586
      post :create, :project_id => 1, 
jplang's avatar
jplang committed
587 588 589 590 591 592 593 594
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a child issue',
                            :parent_issue_id => 2}
    end
    issue = Issue.find_by_subject('This is a child issue')
    assert_not_nil issue
    assert_equal Issue.find(2), issue.parent
  end
595 596 597 598 599 600 601 602 603 604 605 606 607 608

  def test_post_create_subissue_with_non_numeric_parent_id
    @request.session[:user_id] = 2
    
    assert_difference 'Issue.count' do
      post :create, :project_id => 1, 
                 :issue => {:tracker_id => 1,
                            :subject => 'This is a child issue',
                            :parent_issue_id => 'ABC'}
    end
    issue = Issue.find_by_subject('This is a child issue')
    assert_not_nil issue
    assert_nil issue.parent
  end
jplang's avatar
jplang committed
609
  
610
  def test_post_create_should_send_a_notification
611 612
    ActionMailer::Base.deliveries.clear
    @request.session[:user_id] = 2
edavis10's avatar
edavis10 committed
613
    assert_difference 'Issue.count' do
614
      post :create, :project_id => 1, 
edavis10's avatar
edavis10 committed
615 616 617 618 619 620 621 622
                 :issue => {:tracker_id => 3,
                            :subject => 'This is the test_new issue',
                            :description => 'This is the description',
                            :priority_id => 5,
                            :estimated_hours => '',
                            :custom_field_values => {'2' => 'Value for field 2'}}
    end
    assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
623 624 625 626
    
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
  
627
  def test_post_create_should_preserve_fields_values_on_validation_failure
628
    @request.session[:user_id] = 2
629
    post :create, :project_id => 1, 
630
               :issue => {:tracker_id => 1,
631 632 633
                          # empty subject
                          :subject => '',
                          :description => 'This is a description',
634 635 636 637 638
                          :priority_id => 6,
                          :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
    assert_response :success
    assert_template 'new'
    
639 640
    assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                          :content => 'This is a description'
641 642 643 644 645 646 647 648 649 650 651 652 653
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => '6' },
                                                      :content => 'High' }  
    # Custom fields
    assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                        :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                       :value => 'Oracle' },
                                                      :content => 'Oracle' }  
    assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                        :value => 'Value for field 2'}
  end
  
654
  def test_post_create_should_ignore_non_safe_attributes
655 656
    @request.session[:user_id] = 2
    assert_nothing_raised do
657
      post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
658 659 660
    end
  end
  
661 662 663
  context "without workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
664
      Role.anonymous.add_permission! :add_issues, :add_issue_notes
665 666 667 668 669 670 671 672 673 674 675 676 677 678 679
    end
    
    context "#new" do
      should "propose default status only" do
        get :new, :project_id => 1
        assert_response :success
        assert_template 'new'
        assert_tag :tag => 'select',
          :attributes => {:name => 'issue[status_id]'},
          :children => {:count => 1},
          :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
      end
      
      should "accept default status" do
        assert_difference 'Issue.count' do
680
          post :create, :project_id => 1, 
681 682 683 684 685 686 687 688 689 690
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 1}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Issue.count' do
691
          post :create, :project_id => 1, 
692 693 694 695 696 697 698 699
                     :issue => {:tracker_id => 1,
                                :subject => 'This is an issue',
                                :status_id => 3}
        end
        issue = Issue.last(:order => 'id')
        assert_equal IssueStatus.default, issue.status
      end
    end
700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787
    
    context "#update" do
      should "ignore status change" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "ignore attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal "Can't print recipes", issue.subject
        assert_nil issue.assigned_to
      end
    end
  end
  
  context "with workflow privilege" do
    setup do
      Workflow.delete_all(["role_id = ?", Role.anonymous.id])
      Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
      Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
      Role.anonymous.add_permission! :add_issues, :add_issue_notes
    end
    
    context "#update" do
      should "accept authorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 3, Issue.find(1).status_id
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "accept authorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal 2, issue.assigned_to_id
      end
      
      should "ignore unauthorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
        end
        issue = Issue.find(1)
        assert_equal "Can't print recipes", issue.subject
      end
    end
    
    context "and :edit_issues permission" do
      setup do
        Role.anonymous.add_permission! :add_issues, :edit_issues
      end

      should "accept authorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
        end
        assert_equal 3, Issue.find(1).status_id
      end
      
      should "ignore unauthorized status" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
        end
        assert_equal 1, Issue.find(1).status_id
      end
      
      should "accept authorized attributes changes" do
        assert_difference 'Journal.count' do
          put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
        end
        issue = Issue.find(1)
        assert_equal "changed", issue.subject
        assert_equal 2, issue.assigned_to_id
      end
    end
788 789
  end
  
790 791 792 793 794 795 796 797 798
  def test_copy_issue
    @request.session[:user_id] = 2
    get :new, :project_id => 1, :copy_from => 1
    assert_template 'new'
    assert_not_nil assigns(:issue)
    orig = Issue.find(1)
    assert_equal orig.subject, assigns(:issue).subject
  end
  
jplang's avatar
jplang committed
799 800 801 802 803 804 805 806
  def test_get_edit
    @request.session[:user_id] = 2
    get :edit, :id => 1
    assert_response :success
    assert_template 'edit'
    assert_not_nil assigns(:issue)
    assert_equal Issue.find(1), assigns(:issue)
  end
807 808 809
  
  def test_get_edit_with_params
    @request.session[:user_id] = 2
810 811
    get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
        :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828
    assert_response :success
    assert_template 'edit'
    
    issue = assigns(:issue)
    assert_not_nil issue
    
    assert_equal 5, issue.status_id
    assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Closed',
                                    :attributes => { :selected => 'selected' } }
                                    
    assert_equal 7, issue.priority_id
    assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                        :child => { :tag => 'option', 
                                    :content => 'Urgent',
                                    :attributes => { :selected => 'selected' } }
829 830 831 832 833 834

    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
    assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
                        :child => { :tag => 'option',
                                    :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
    assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
835
  end
836 837 838

  def test_update_edit_form
    @request.session[:user_id] = 2
839
    xhr :post, :new, :project_id => 1,
840 841 842 843 844 845 846 847 848 849 850 851 852 853 854
                             :id => 1,
                             :issue => {:tracker_id => 2, 
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
    assert_response :success
    assert_template 'attributes'
    
    issue = assigns(:issue)
    assert_kind_of Issue, issue
    assert_equal 1, issue.id
    assert_equal 1, issue.project_id
    assert_equal 2, issue.tracker_id
    assert_equal 'This is the test_new issue', issue.subject
  end
855
  
856 857 858 859 860 861 862 863 864 865 866 867 868 869
  def test_update_using_invalid_http_verbs
    @request.session[:user_id] = 2
    subject = 'Updated by an invalid http verb'

    get :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    post :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject

    delete :update, :id => 1, :issue => {:subject => subject}
    assert_not_equal subject, Issue.find(1).subject
  end

870
  def test_put_update_without_custom_fields_param
jplang's avatar
jplang committed
871
    @request.session[:user_id] = 2
872 873 874
    ActionMailer::Base.deliveries.clear
    
    issue = Issue.find(1)
875
    assert_equal '125', issue.custom_value_for(2).value
876 877 878
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
879 880
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 2) do
881
        put :update, :id => 1, :issue => {:subject => new_subject,
882 883 884 885 886
                                         :priority_id => '6',
                                         :category_id => '1' # no change
                                        }
      end
    end
887
    assert_redirected_to :action => 'show', :id => '1'
888 889
    issue.reload
    assert_equal new_subject, issue.subject
890 891
    # Make sure custom fields were not cleared
    assert_equal '125', issue.custom_value_for(2).value
892 893 894 895 896
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
    assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
jplang's avatar
jplang committed
897 898
  end
  
899
  def test_put_update_with_custom_field_change
900 901 902 903 904 905
    @request.session[:user_id] = 2
    issue = Issue.find(1)
    assert_equal '125', issue.custom_value_for(2).value
    
    assert_difference('Journal.count') do
      assert_difference('JournalDetail.count', 3) do
906
        put :update, :id => 1, :issue => {:subject => 'Custom field change',
907 908 909 910 911 912
                                         :priority_id => '6',
                                         :category_id => '1', # no change
                                         :custom_field_values => { '2' => 'New custom value' }
                                        }
      end
    end
913
    assert_redirected_to :action => 'show', :id => '1'
914 915 916 917 918 919 920 921
    issue.reload
    assert_equal 'New custom value', issue.custom_value_for(2).value
    
    mail = ActionMailer::Base.deliveries.last
    assert_kind_of TMail::Mail, mail
    assert mail.body.include?("Searchable field changed from 125 to New custom value")
  end
  
922
  def test_put_update_with_status_and_assignee_change
jplang's avatar
jplang committed
923 924 925
    issue = Issue.find(1)
    assert_equal 1, issue.status_id
    @request.session[:user_id] = 2
926
    assert_difference('TimeEntry.count', 0) do
927
      put :update,
928 929 930
           :id => 1,
           :issue => { :status_id => 2, :assigned_to_id => 3 },
           :notes => 'Assigned to dlopper',
931
           :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
932
    end
933
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
934 935
    issue.reload
    assert_equal 2, issue.status_id
jplang's avatar
jplang committed
936
    j = Journal.find(:first, :order => 'id DESC')
jplang's avatar
jplang committed
937 938
    assert_equal 'Assigned to dlopper', j.notes
    assert_equal 2, j.details.size
939 940 941
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?("Status changed from New to Assigned")
942 943
    # subject should contain the new status
    assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
944 945
  end
  
946
  def test_put_update_with_note_only
947 948
    notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
    # anonymous user
949
    put :update,
950 951
         :id => 1,
         :notes => notes
952
    assert_redirected_to :action => 'show', :id => '1'
jplang's avatar
jplang committed
953
    j = Journal.find(:first, :order => 'id DESC')
954 955 956 957 958 959 960 961
    assert_equal notes, j.notes
    assert_equal 0, j.details.size
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?(notes)
  end
  
962
  def test_put_update_with_note_and_spent_time
963 964
    @request.session[:user_id] = 2
    spent_hours_before = Issue.find(1).spent_hours
965
    assert_difference('TimeEntry.count') do
966
      put :update,
967 968
           :id => 1,
           :notes => '2.5 hours added',
969
           :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
970
    end
971
    assert_redirected_to :action => 'show', :id => '1'
972 973 974
    
    issue = Issue.find(1)
    
jplang's avatar
jplang committed
975
    j = Journal.find(:first, :order => 'id DESC')
976 977 978
    assert_equal '2.5 hours added', j.notes
    assert_equal 0, j.details.size
    
979
    t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
980 981 982 983 984
    assert_not_nil t
    assert_equal 2.5, t.hours
    assert_equal spent_hours_before + 2.5, issue.spent_hours
  end
  
985
  def test_put_update_with_attachment_only
jplang's avatar
jplang committed
986 987
    set_tmp_attachments_directory
    
988 989 990 991
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

992
    # anonymous user
993
    put :update,
994 995
         :id => 1,
         :notes => '',
jplang's avatar
jplang committed
996
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
997
    assert_redirected_to :action => 'show', :id => '1'
998 999 1000 1001 1002 1003 1004 1005 1006
    j = Issue.find(1).journals.find(:first, :order => 'id DESC')
    assert j.notes.blank?
    assert_equal 1, j.details.size
    assert_equal 'testfile.txt', j.details.first.value
    assert_equal User.anonymous, j.user
    
    mail = ActionMailer::Base.deliveries.last
    assert mail.body.include?('testfile.txt')
  end
1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027

  def test_put_update_with_attachment_that_fails_to_save
    set_tmp_attachments_directory
    
    # Delete all fixtured journals, a race condition can occur causing the wrong
    # journal to get fetched in the next find.
    Journal.delete_all

    # Mock out the unsaved attachment
    Attachment.any_instance.stubs(:create).returns(Attachment.new)
    
    # anonymous user
    put :update,
         :id => 1,
         :notes => '',
         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
    assert_redirected_to :action => 'show', :id => '1'
    assert_equal '1 file(s) could not be saved.', flash[:warning]

  end if Object.const_defined?(:Mocha)

1028
  def test_put_update_with_no_change
1029 1030 1031 1032
    issue = Issue.find(1)
    issue.journals.clear
    ActionMailer::Base.deliveries.clear
    
1033
    put :update,
1034 1035
         :id => 1,
         :notes => ''
1036
    assert_redirected_to :action => 'show', :id => '1'
1037 1038 1039 1040 1041
    
    issue.reload
    assert issue.journals.empty?
    # No email should be sent
    assert ActionMailer::Base.deliveries.empty?
jplang's avatar
jplang committed
1042
  end
1043

1044
  def test_put_update_should_send_a_notification
1045 1046 1047 1048 1049 1050
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
    issue = Issue.find(1)
    old_subject = issue.subject
    new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
    
1051
    put :update, :id => 1, :issue => {:subject => new_subject,
1052 1053 1054 1055 1056
                                     :priority_id => '6',
                                     :category_id => '1' # no change
                                    }
    assert_equal 1, ActionMailer::Base.deliveries.size
  end
1057
  
1058
  def test_put_update_with_invalid_spent_time_hours_only
1059 1060 1061 1062
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
1063
      put :update,
1064 1065 1066 1067 1068 1069 1070
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
    end
    assert_response :success
    assert_template 'edit'
    
1071 1072
    assert_error_tag :descendant => {:content => /Activity can't be blank/}
    assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1073 1074
    assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
  end
1075
  
1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094
  def test_put_update_with_invalid_spent_time_comments_only
    @request.session[:user_id] = 2
    notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
    
    assert_no_difference('Journal.count') do
      put :update,
           :id => 1,
           :notes => notes,
           :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
    end
    assert_response :success
    assert_template 'edit'
    
    assert_error_tag :descendant => {:content => /Activity can't be blank/}
    assert_error_tag :descendant => {:content => /Hours can't be blank/}
    assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
    assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
  end
  
1095
  def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
1096 1097 1098
    issue = Issue.find(2)
    @request.session[:user_id] = 2

1099
    put :update,
1100 1101 1102 1103 1104 1105 1106 1107 1108 1109
         :id => issue.id,
         :issue => {
           :fixed_version_id => 4
         }

    assert_response :redirect
    issue.reload
    assert_equal 4, issue.fixed_version_id
    assert_not_equal issue.project_id, issue.fixed_version.project_id
  end