• Rémy Coutable's avatar
    Merge branch '18019-fix-wiki-linking' into 'master' · 3d72cb89
    Rémy Coutable authored
    Fix wiki linking behavior for markdown wiki pages
    
    Related to #18019 
    
    - As per the documentation in !4372 
    
    ## TODO
    - [ ] !4432 Have wiki linking behave as per the documentation
        - [x] Move `WikiLinkFilter` specs to the pipeline level
        - [x] Verify current behavior on wiki `show` page
        - [x] Fix current behavior on wiki `show` page
        - [x] Verify current behaviour on wiki preview
        - [x] Fix current behaviour on wiki preview
            - [x] Rewrite all links and get preview links working
            - [x] Make sure all links are on-par with the wiki `show` page
            - [x] TDD `WikiLinkFilter` and get it working
            - [x] Hook `WikiLinkFilter` up
        - [x] Fix tests 
            - [x] Fix `markdown_spec`
            - [x] Fix `wiki` spinach feature
            - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass
            - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.)
        - [x] Test in different ruby versions
        - [x] GitLab instances hosted on a relative URL
        - [x] Non-markdown rendering formats?
            - [x] RDoc
            - [x] ASCIIDoc
            - [x] Create issues to fix things for RDoc and ASCIIDoc
        - [x] Gauge performance impact
        - [x] Refactor
        - [x] Re-organize commits
        - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/f860e9a8dcabe7d5f160c32fc549807c98baa4a1/builds) passes
        - [x] Respond to @rymai's comments
            - [x] `class WikiLinkFilter < HTML::Pipeline::Filter`
            - [x] blank line after guard clause
            - [x] keyword arguments for `wiki` and `slug`
            - [x] invert the condition
            - [x] inline `user` in spec
            - [x] Make sure spec names are not out of date
            - [x] Comment for each rewrite rule
        - [x] Add CHANGELOG entry
        - [x] Reorganize commits
        - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/19b91e749a6320d12fb299d33f1f6440777e0e26/builds) passes
        - [ ] Wait for merge
    
    See merge request !4432
    3d72cb89
Name
Last commit
Last update
app Loading commit data...
bin Loading commit data...
builds Loading commit data...
config Loading commit data...
db Loading commit data...
doc Loading commit data...
docker Loading commit data...
features Loading commit data...
fixtures/emojis Loading commit data...
generator_templates/active_record/migration Loading commit data...
lib Loading commit data...
log Loading commit data...
public Loading commit data...
scripts Loading commit data...
shared Loading commit data...
spec Loading commit data...
tmp Loading commit data...
vendor Loading commit data...
.csscomb.json Loading commit data...
.flayignore Loading commit data...
.foreman Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
.hound.yml Loading commit data...
.pkgr.yml Loading commit data...
.rspec Loading commit data...
.rubocop.yml Loading commit data...
.ruby-version Loading commit data...
.scss-lint.yml Loading commit data...
.simplecov Loading commit data...
.teatro.yml Loading commit data...
.vagrant_enabled Loading commit data...
CHANGELOG Loading commit data...
CONTRIBUTING.md Loading commit data...
GITLAB_SHELL_VERSION Loading commit data...
GITLAB_WORKHORSE_VERSION Loading commit data...
Gemfile Loading commit data...
Gemfile.lock Loading commit data...
LICENSE Loading commit data...
MAINTENANCE.md Loading commit data...
PROCESS.md Loading commit data...
Procfile Loading commit data...
README.md Loading commit data...
Rakefile Loading commit data...
VERSION Loading commit data...
config.ru Loading commit data...
doc_styleguide.md Loading commit data...
docker-compose.yml Loading commit data...