Skip to content
  1. May 09, 2018
  2. May 08, 2018
  3. Apr 30, 2018
  4. Apr 26, 2018
  5. Feb 01, 2018
    • Yorick Peterse's avatar
      Track and act upon the number of executed queries · cca61980
      Yorick Peterse authored
      This ensures that we have more visibility in the number of SQL queries
      that are executed in web requests. The current threshold is hardcoded to
      100 as we will rarely (maybe once or twice) change it.
      
      In production and development we use Sentry if enabled, in the test
      environment we raise an error. This feature is also only enabled in
      production/staging when running on GitLab.com as it's not very useful to
      other users.
      cca61980
  6. Jan 02, 2018
  7. Dec 15, 2017
  8. Dec 06, 2017
  9. Dec 05, 2017
  10. Nov 21, 2017
  11. Nov 16, 2017
  12. Nov 15, 2017
  13. Nov 07, 2017
    • Yorick Peterse's avatar
      Rewrite the GitHub importer from scratch · 4dfe26cd
      Yorick Peterse authored
      Prior to this MR there were two GitHub related importers:
      
      * Github::Import: the main importer used for GitHub projects
      * Gitlab::GithubImport: importer that's somewhat confusingly used for
        importing Gitea projects (apparently they have a compatible API)
      
      This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
      introduces a new GitHub importer in the Gitlab::GithubImport namespace.
      This new GitHub importer uses Sidekiq for importing multiple resources
      in parallel, though it also has the ability to import data sequentially
      should this be necessary.
      
      The new code is spread across the following directories:
      
      * lib/gitlab/github_import: this directory contains most of the importer
        code such as the classes used for importing resources.
      * app/workers/gitlab/github_import: this directory contains the Sidekiq
        workers, most of which simply use the code from the directory above.
      * app/workers/concerns/gitlab/github_import: this directory provides a
        few modules that are included in every GitHub importer worker.
      
      == Stages
      
      The import work is divided into separate stages, with each stage
      importing a specific set of data. Stages will schedule the work that
      needs to be performed, followed by scheduling a job for the
      "AdvanceStageWorker" worker. This worker will periodically check if all
      work is completed and schedule the next stage if this is the case. If
      work is not yet completed this worker will reschedule itself.
      
      Using this approach we don't have to block threads by calling `sleep()`,
      as doing so for large projects could block the thread from doing any
      work for many hours.
      
      == Retrying Work
      
      Workers will reschedule themselves whenever necessary. For example,
      hitting the GitHub API's rate limit will result in jobs rescheduling
      themselves. These jobs are not processed until the rate limit has been
      reset.
      
      == User Lookups
      
      Part of the importing process involves looking up user details in the
      GitHub API so we can map them to GitLab users. The old importer used
      an in-memory cache, but this obviously doesn't work when the work is
      spread across different threads.
      
      The new importer uses a Redis cache and makes sure we only perform
      API/database calls if absolutely necessary.  Frequently used keys are
      refreshed, and lookup misses are also cached; removing the need for
      performing API/database calls if we know we don't have the data we're
      looking for.
      
      == Performance & Models
      
      The new importer in various places uses raw INSERT statements (as
      generated by `Gitlab::Database.bulk_insert`) instead of using Rails
      models. This allows us to bypass any validations and callbacks,
      drastically reducing the number of SQL queries and Gitaly RPC calls
      necessary to import projects.
      
      To ensure the code produces valid data the corresponding tests check if
      the produced rows are valid according to the model validation rules.
      4dfe26cd
  14. Nov 01, 2017
  15. Oct 11, 2017
  16. Oct 09, 2017
  17. Oct 05, 2017
  18. Sep 27, 2017
  19. Sep 12, 2017
  20. Sep 11, 2017
  21. Aug 16, 2017
  22. Jul 07, 2017
    • Yorick Peterse's avatar
      Added EachBatch for iterating tables in batches · ff78af15
      Yorick Peterse authored
      This module provides a class method called `each_batch` that can be used
      to iterate tables in batches in a more efficient way compared to Rails'
      `in_batches` method. This commit also includes a RuboCop cop to
      blacklist the use of `in_batches` in favour of this new method.
      ff78af15
    • Yorick Peterse's avatar
      Added EachBatch for iterating tables in batches · 5f9c8458
      Yorick Peterse authored
      This module provides a class method called `each_batch` that can be used
      to iterate tables in batches in a more efficient way compared to Rails'
      `in_batches` method. This commit also includes a RuboCop cop to
      blacklist the use of `in_batches` in favour of this new method.
      5f9c8458
  23. Jun 29, 2017
    • Yorick Peterse's avatar
      Added code for defining SHA attributes · af1f6844
      Yorick Peterse authored
      These attributes are stored in binary in the database, but exposed as
      strings. This allows one to query/create data using plain SHA1 hashes as
      Strings, while storing them more efficiently as binary.
      af1f6844
  24. Jun 12, 2017
  25. Jun 07, 2017
  26. May 31, 2017
  27. May 16, 2017
  28. May 08, 2017
  29. May 05, 2017
  30. Apr 25, 2017
  31. Mar 29, 2017
  32. Mar 22, 2017
  33. Jan 27, 2017
  34. Nov 17, 2016