1. 06 Jul, 2017 2 commits
    • Yorick Peterse's avatar
      Rename ActiverecordSerialize cop · e1a3bf30
      Yorick Peterse authored
      This cop has been renamed to ActiveRecordSerialize to match the way
      "ActiveRecord" is usually written.
      e1a3bf30
    • Yorick Peterse's avatar
      Added Cop to blacklist the use of `dependent:` · 8fbbf41e
      Yorick Peterse authored
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
      8fbbf41e
  2. 29 Jun, 2017 1 commit
  3. 27 Jun, 2017 2 commits
  4. 26 Jun, 2017 1 commit
  5. 25 Jun, 2017 1 commit
  6. 23 Jun, 2017 6 commits
  7. 21 Jun, 2017 1 commit
  8. 19 Jun, 2017 1 commit
  9. 16 Jun, 2017 1 commit
  10. 06 Jun, 2017 1 commit
  11. 05 Jun, 2017 1 commit
  12. 02 Jun, 2017 1 commit
  13. 01 Jun, 2017 2 commits
  14. 31 May, 2017 1 commit
  15. 30 May, 2017 2 commits
  16. 26 May, 2017 1 commit
  17. 24 May, 2017 5 commits
  18. 19 May, 2017 1 commit
  19. 18 May, 2017 2 commits
  20. 17 May, 2017 2 commits
    • Yorick Peterse's avatar
      Hide nested group UI/API support for MySQL · 34974258
      Yorick Peterse authored
      This hides/disables some UI elements and API parameters related to
      nested groups when MySQL is used, since nested groups are not supported
      for MySQL.
      34974258
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
      ac382b56
  21. 15 May, 2017 1 commit
  22. 12 May, 2017 1 commit
  23. 10 May, 2017 1 commit
  24. 08 May, 2017 2 commits
    • Toon Claes's avatar
      Devise can assign trackable fields, but only allow writes once/hour · 3531ea09
      Toon Claes authored
      Not assigning the trackable fields seems to cause strange side-effects.
      3531ea09
    • Toon Claes's avatar
      Limit `update_tracked_fields` to write to database once/hour · 6a915d6f
      Toon Claes authored
      Every time a user logs in or out, the Trackable attributes are written to the
      database. This is causing a lot of load on the database, for data that isn't
      really critical.
      
      So to avoid the database being hammered, add a Gitlab::ExclusiveLease before
      writing trackable attributes to the database. This lease expires after an hour,
      so only when the attributes were written more than an hour ago, they can be
      written again. Otherwise they are ignored.
      6a915d6f