1. 06 Dec, 2018 1 commit
  2. 05 Dec, 2018 1 commit
  3. 16 Nov, 2018 1 commit
  4. 12 Nov, 2018 1 commit
  5. 09 Nov, 2018 2 commits
  6. 07 Nov, 2018 1 commit
  7. 23 Oct, 2018 1 commit
    • Sean McGivern's avatar
      Also count specs in new files in Danger check · 0e616d71
      Sean McGivern authored
      We have a Danger check that warns if you made changes in app/ but not in
      spec/. However, this only checked for changed files - not new files. If
      you added an app file with no specs, it wouldn't warn; and it would warn
      erroneously if you added a missing spec file while changing a file in
      app/.
      0e616d71
  8. 22 Oct, 2018 1 commit
    • Lukas Eipert's avatar
      Create helper to get all changed files · 253e1818
      Lukas Eipert authored
      Danger apparently has three different objects which could contain files
      you often want to check:
      
       - git.added_files
       - git.modified_files
       - git.renamed_files
      
      The problem: If a file is renamed, `modified_files` contains the file
      path before the rename. In some Danger checks we use `added_files` +
      `modified_files`, which might contain the deleted paths of renamed
      files, but missing the new paths of renamed files.
      
      So we need to consider `renamed_files` as well.
      253e1818
  9. 29 Sep, 2018 1 commit
  10. 28 Sep, 2018 1 commit
  11. 19 Sep, 2018 1 commit
  12. 18 Sep, 2018 1 commit
    • Yorick Peterse's avatar
      Improve Emoji detection in commit messages · 4ef1dd09
      Yorick Peterse authored
      This changes our Danger integration so that it is smarter about
      detecting GitLab emoji in commit messages. This is done using a two step
      process:
      
      1. We use the old regular expression to determine if a commit message
         _might_ include an emoji.
      
      2. If this regular expression matches, we then check for all existing
         emoji names in the commit message. This might be a wee bit expensive,
         but because we couple it with the previous step it should be rarely
         executed.
      
      This ensures we don't trigger an error when a commit message includes
      text such as `:foo:bar:`, which is not a valid Emoji.
      
      Fixes https://gitlab.com/gitlab-org/release/framework/issues/15
      4ef1dd09
  13. 14 Sep, 2018 2 commits
    • Lukas Eipert's avatar
      Fix typo in Danger message · 40f81458
      Lukas Eipert authored
      40f81458
    • Yorick Peterse's avatar
      Relax Danger requirements about changed lines · 42f90b5f
      Yorick Peterse authored
      This relaxes the commit rules regarding the number of changed lines.
      Previously we required a detailed description if 20 or more lines were
      changed. Starting with this commit we change the rules so Danger only
      notifies you about writing a detailed description if:
      
      1. A commit changes more than 3 files
      2. The same commit changes more than 30 lines
      
      This should make it easier to do a find replace to fix a typo, without
      having to repeat what the subject line already says, while still
      reminding developers to write a detailed description for new features
      and other larger changes.
      
      Fixes https://gitlab.com/gitlab-org/release/framework/issues/13
      42f90b5f
  14. 10 Sep, 2018 1 commit
  15. 06 Sep, 2018 1 commit
  16. 04 Sep, 2018 1 commit
  17. 24 Aug, 2018 1 commit
  18. 26 Jul, 2018 1 commit
  19. 25 Jul, 2018 1 commit
  20. 24 Jul, 2018 1 commit
  21. 17 Jul, 2018 2 commits
  22. 13 Jul, 2018 1 commit
  23. 12 Jul, 2018 2 commits
  24. 11 Jul, 2018 6 commits