1. 05 Jul, 2018 1 commit
  2. 13 Jun, 2018 1 commit
  3. 12 Jun, 2018 3 commits
  4. 11 Jun, 2018 1 commit
  5. 08 Jun, 2018 1 commit
  6. 07 Jun, 2018 2 commits
  7. 06 Jun, 2018 1 commit
  8. 05 Jun, 2018 1 commit
    • Sean McGivern's avatar
      Fix an N+1 in avatar URLs · 6ecf819f
      Sean McGivern authored
      This is tricky: the query was being run in
      `ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't
      just add batch loading there, because the `#upload=` method there would use the
      result immediately, making the batch only have one item.
      
      Instead, we can pre-emptively add an item to the batch whenever an avatarable
      object is initialized, and then reuse that batch item in
      `#retrieve_from_store!`. However, this also has problems:
      
      1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`.
      2. Some of that logic constructs a 'fake' model for the batch key. This should
         be fine, because of ActiveRecord's override of `#==`, but it relies on that
         staying the same.
      6ecf819f
  9. 04 Jun, 2018 1 commit
  10. 29 May, 2018 1 commit
  11. 28 May, 2018 1 commit
  12. 23 May, 2018 1 commit
  13. 19 Apr, 2018 1 commit
  14. 05 Apr, 2018 1 commit
  15. 04 Apr, 2018 1 commit
  16. 29 Mar, 2018 1 commit
  17. 27 Mar, 2018 1 commit
  18. 26 Mar, 2018 1 commit
  19. 09 Mar, 2018 1 commit
  20. 01 Mar, 2018 4 commits
  21. 28 Feb, 2018 2 commits