1. 22 Mar, 2019 1 commit
  2. 06 Mar, 2019 1 commit
  3. 05 Mar, 2019 1 commit
    • Horatiu Eugen Vlad's avatar
      Align EmailValidator to validate_email gem implementation. · c8c0ea6c
      Horatiu Eugen Vlad authored
      Renamed EmailValidator to DeviseEmailValidator to avoid 'email:' naming collision with ActiveModel::Validations::EmailValidator in 'validates' statement.
      Make use of the options attribute of the parent class ActiveModel::EachValidator.
      Add more options: regex.
      c8c0ea6c
  4. 20 Feb, 2019 1 commit
    • Stan Hu's avatar
      Make Admin::UsersController work with Ruby 2.6 · e87c255d
      Stan Hu authored
      Ruby 2.6 introduced `Enumerable#filter`, which takes no arguments.
      Attempting to call `filter` on an `ActiveRecord::Relation` with a scope
      will fail with a `wrong number of arguments (given 1, expected 0)`
      message because the `Enumerable#filter` implementation overrides the
      delegated `ActiveRecord::Relation#filter` method.
      
      To make Admin::UsersController compatible with Ruby 2.6, rename
      `User.filter` to `User.filter_items`.
      e87c255d
  5. 13 Feb, 2019 1 commit
    • Luke Bennett's avatar
      Improve the GitHub and Gitea import feature table interface · 534a6117
      Luke Bennett authored
      These are backend changes.
      Use Vue for the import feature UI for "githubish"
      providers (GitHub and Gitea).
      Add "Go to project" button after a successful import.
      Use CI-style status icons and improve spacing of the
      table and its component.
      Adds ETag polling to the github and gitea import
      jobs endpoint.
      534a6117
  6. 08 Feb, 2019 1 commit
  7. 06 Feb, 2019 1 commit
  8. 05 Feb, 2019 1 commit
    • Brandon Labuschagne's avatar
      Add last activity to user administration · d279cc94
      Brandon Labuschagne authored
      The columns 'Created on' and 'Last activity' have been
      added to the admin -> users view.
      
      Sorting options have also been added for last activity
      and the search bar has been moved to match the issues
      page.
      d279cc94
  9. 31 Jan, 2019 1 commit
  10. 24 Jan, 2019 1 commit
  11. 21 Jan, 2019 1 commit
  12. 15 Jan, 2019 1 commit
  13. 19 Dec, 2018 2 commits
  14. 13 Dec, 2018 1 commit
    • Alessio Caiazza's avatar
      Add name, author and sha to releases · b782ba11
      Alessio Caiazza authored
      This commit adds a name to each release, defaulting it to tag name,
      keeps track of the SHA when a new release is created and tracks the
      current user as release author.
      b782ba11
  15. 26 Nov, 2018 1 commit
  16. 19 Nov, 2018 1 commit
  17. 07 Nov, 2018 1 commit
    • Tiago Botelho's avatar
      User can keep their commit email private · c239452b
      Tiago Botelho authored
      The private commit email is automatically generated in the format:
      id-username@noreply.HOSTNAME
      
      GitLab instance admins are able to change the HOSTNAME portion,
      that defaults to Gitlab's hostname, to whatever they prefer.
      c239452b
  18. 05 Nov, 2018 1 commit
  19. 01 Nov, 2018 2 commits
  20. 29 Oct, 2018 2 commits
  21. 26 Oct, 2018 1 commit
  22. 23 Oct, 2018 1 commit
  23. 18 Oct, 2018 1 commit
  24. 12 Oct, 2018 1 commit
  25. 08 Oct, 2018 1 commit
    • Yorick Peterse's avatar
      Clean up ActiveRecord code in TodoService · 38b8ae64
      Yorick Peterse authored
      This refactors the TodoService class according to our code reuse
      guidelines. The resulting code is a wee bit more verbose, but it allows
      us to decouple the column names from the input, resulting in fewer
      changes being necessary when we change the schema.
      
      One particular noteworthy line in TodoService is the following:
      
          todos_ids = todos.update_state(state)
      
      Technically this is a violation of the guidelines, because
      `update_state` is a class method, which services are not supposed to use
      (safe for a few allowed ones). I decided to keep this, since there is no
      alternative. `update_state` doesn't produce a relation so it doesn't
      belong in a Finder, and we can't move it to another Service either. As
      such I opted to just use the method directly.
      
      Cases like this may happen more frequently, at which point we should
      update our documentation with some sort of recommendation. For now, I
      want to refrain from doing so until we have a few more examples.
      38b8ae64
  26. 24 Sep, 2018 1 commit
  27. 17 Sep, 2018 2 commits
    • Brett Walker's avatar
      Filter out archived projects from issue/mr count · 50a62b47
      Brett Walker authored
      Pass the 'non_archived' flag to finder methods
      50a62b47
    • Yorick Peterse's avatar
      Added FromUnion to easily select from a UNION · 8a72f5c4
      Yorick Peterse authored
      This commit adds the module `FromUnion`, which provides the class method
      `from_union`. This simplifies the process of selecting data from the
      result of a UNION, and reduces the likelihood of making mistakes. As a
      result, instead of this:
      
          union = Gitlab::SQL::Union.new([foo, bar])
      
          Foo.from("(#{union.to_sql}) #{Foo.table_name}")
      
      We can now write this instead:
      
          Foo.from_union([foo, bar])
      
      This commit also includes some changes to make this new setup work
      properly. For example, a bug in Rails 4
      (https://github.com/rails/rails/issues/24193) would break the use of
      `from("sub-query-here").includes(:relation)` in certain cases. There was
      also a CI query which appeared to repeat a lot of conditions from an
      outer query on an inner query, which isn't necessary.
      
      Finally, we include a RuboCop cop to ensure developers use this new
      module, instead of using Gitlab::SQL::Union directly.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
      8a72f5c4
  28. 16 Sep, 2018 1 commit
  29. 14 Sep, 2018 1 commit
  30. 11 Sep, 2018 1 commit
  31. 07 Sep, 2018 1 commit
  32. 06 Sep, 2018 1 commit
    • Bob Van Landuyt's avatar
      Port changes for CODEOWNERS to CE · c826ecc3
      Bob Van Landuyt authored
      This ports the changes for the CODEOWNERS feature to CE:
      - It adds the CODEOWNERS file.
      - It adds the mention of the `with-codeowners` branch in TestEnv
      c826ecc3
  33. 21 Aug, 2018 1 commit
  34. 20 Aug, 2018 1 commit
    • Yorick Peterse's avatar
      Refactor AutocompleteController · 6f3c4901
      Yorick Peterse authored
      This refactors the AutocompleteController according to the guidelines
      and boundaries discussed in
      https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically,
      ActiveRecord logic is moved to different finders, which are then used in
      the controller. View logic in turn is moved to presenters, instead of
      directly using ActiveRecord's "to_json" method.
      
      The finder MoveToProjectFinder is also adjusted according to the
      abstraction guidelines and boundaries, resulting in a much more simple
      finder.
      
      By using finders (and other abstractions) more actively, we can push a
      lot of logic out of the controller. We also remove the need for various
      "before_action" hooks, though this could be achieved without using
      finders as well.
      
      The various finders related to AutcompleteController have also been
      moved into a namespace. This removes the need for calling everything
      "AutocompleteSmurfFinder", instead you can use
      "Autocomplete::SmurfFinder".
      6f3c4901
  35. 16 Aug, 2018 1 commit
  36. 06 Aug, 2018 1 commit