1. 02 Oct, 2018 1 commit
  2. 10 Sep, 2018 2 commits
  3. 09 Sep, 2018 1 commit
  4. 07 Sep, 2018 1 commit
  5. 06 Sep, 2018 3 commits
  6. 05 Sep, 2018 1 commit
  7. 04 Sep, 2018 2 commits
  8. 03 Sep, 2018 3 commits
  9. 30 Aug, 2018 2 commits
  10. 29 Aug, 2018 1 commit
  11. 28 Aug, 2018 3 commits
  12. 27 Aug, 2018 1 commit
  13. 24 Aug, 2018 1 commit
    • Stan Hu's avatar
      Use slugs for default project path and sanitize names before import · f2005125
      Stan Hu authored
      Users importing from Bitbucket Cloud, Bitbucket Server, or GitHub
      often complained about getting failed imports due to 422 errors.
      This change ensures that project names are imported with names that
      are guaranteed to pass the regular expression validation.
      
      Part of #50021
      f2005125
  14. 22 Aug, 2018 2 commits
  15. 21 Aug, 2018 2 commits
  16. 20 Aug, 2018 4 commits
  17. 17 Aug, 2018 1 commit
    • Lin Jen-Shin's avatar
      Fill variable text with JS directly to speed up · 2efd5c0b
      Lin Jen-Shin authored
      It's too slow to use `set(value)`, often timing out.
      Filling with JS is much faster for longer text, especially
      when the key size is larger than 8192.
      
      Before this patch:
      
      ```
      Top 3 slowest examples (256.83 seconds, 89.4% of total time):
        cloning code using a deploy key user sets up a deploy key with QA::Runtime::Key::RSA(8192) to clone code using pipelines
          161.26 seconds ./qa/specs/features/project/deploy_key_clone_spec.rb:42
        cloning code using a deploy key user sets up a deploy key with QA::Runtime::Key::ECDSA(521) to clone code using pipelines
          47.79 seconds ./qa/specs/features/project/deploy_key_clone_spec.rb:42
        cloning code using a deploy key user sets up a deploy key with QA::Runtime::Key::ED25519() to clone code using pipelines
          47.79 seconds ./qa/specs/features/project/deploy_key_clone_spec.rb:42
      ```
      
      Note that 161.26 was timed out. So it would actually take longer if
      it could ever complete. After patch:
      
      ```
      Top 3 slowest examples (166.72 seconds, 83.8% of total time):
        cloning code using a deploy key user sets up a deploy key with QA::Runtime::Key::RSA(8192) to clone code using pipelines
          83.66 seconds ./qa/specs/features/project/deploy_key_clone_spec.rb:42
        cloning code using a deploy key user sets up a deploy key with QA::Runtime::Key::ECDSA(521) to clone code using pipelines
          42.78 seconds ./qa/specs/features/project/deploy_key_clone_spec.rb:42
        cloning code using a deploy key user sets up a deploy key with QA::Runtime::Key::ED25519() to clone code using pipelines
          40.27 seconds ./qa/specs/features/project/deploy_key_clone_spec.rb:42
      ```
      
      Not that faster for smaller keys, but it's much faster for RSA 8192
      (2 times faster). This was inspired from:
      
      https://github.com/teamcapybara/capybara/blob/679548cea10773d45e32808f4d964377cfe5e892/lib/capybara/selenium/node.rb#L217
      
      Where it's clearing the field by filling an empty string. Here we
      do the same for the exact value we want to fill.
      2efd5c0b
  18. 14 Aug, 2018 1 commit
  19. 07 Aug, 2018 2 commits
  20. 06 Aug, 2018 1 commit
  21. 03 Aug, 2018 1 commit
  22. 31 Jul, 2018 1 commit
  23. 30 Jul, 2018 2 commits
  24. 25 Jul, 2018 1 commit