1. 14 Dec, 2018 2 commits
    • Robert Speicher's avatar
      Resolve transient failure in Help page spec · fac5c0e7
      Robert Speicher authored
      Sometimes due to a slow request to load the version check image, the
      placeholder image data was still being seen, resulting in this failure:
      
          expected "data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" to end with "/version-check-url"
      
      Now we check the `data-src` attribute, which allows us to remove the
      `:js` metadata.
      
      This commit also removes a redundant test, which was just ensuring that
      the selector we were already using in the other test is visible. If this
      test were failing, the other one would always fail too, so it was
      pointless.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55372
      fac5c0e7
    • Robert Speicher's avatar
      Use class methods for VersionCheck · 04a3e48c
      Robert Speicher authored
      All of these methods are stateless, there was no point to have them as
      instance methods.
      
      Mostly this allows us to remove an `allow_any_instance_of` usage.
      04a3e48c
  2. 23 Nov, 2018 1 commit
  3. 19 Dec, 2017 1 commit
  4. 15 Dec, 2017 1 commit
    • Sean McGivern's avatar
      Don't use Markdown cache for stubbed settings in specs · 10885edf
      Sean McGivern authored
      The ApplicationSetting model uses the CacheMarkdownField concern, which updates
      the cached HTML when the field is updated in the database. However, in specs,
      when we want to test conditions using ApplicationSetting, we stub it, because
      this is accessed in different ways throughout the application.
      
      This means that if a spec runs that caches one of the Markdown fields, and a
      later spec uses `stub_application_setting` to set the raw value of that field,
      the cached value was still the original one. We can work around this by ignoring
      the Markdown cache in contexts where we're using `stub_application_setting`.
      
      We could be smarter, and only do this on the Markdown fields of the model, but
      this is probably fine.
      10885edf
  5. 16 Aug, 2017 1 commit
  6. 27 Jul, 2017 1 commit
  7. 29 Jun, 2017 1 commit
  8. 20 Jun, 2017 1 commit
  9. 14 Jun, 2017 1 commit
  10. 12 Jun, 2017 1 commit
  11. 22 Feb, 2017 1 commit
  12. 09 Dec, 2016 1 commit
  13. 01 Dec, 2016 1 commit
  14. 25 Nov, 2016 1 commit
  15. 09 Aug, 2016 1 commit
  16. 11 Jul, 2016 1 commit
  17. 15 Apr, 2015 2 commits
  18. 03 Apr, 2015 1 commit
  19. 12 Feb, 2015 1 commit
  20. 04 Feb, 2015 1 commit
  21. 18 Jan, 2015 1 commit
  22. 16 Jan, 2015 1 commit