1. 17 Oct, 2016 3 commits
  2. 14 Oct, 2016 2 commits
  3. 12 Oct, 2016 1 commit
  4. 10 Oct, 2016 1 commit
    • Yorick Peterse's avatar
      Precalculate trending projects · 237c8f66
      Yorick Peterse authored
      This commit introduces a Sidekiq worker that precalculates the list of
      trending projects on a daily basis. The resulting set is stored in a
      database table that is then queried by Project.trending.
      This setup means that Unicorn workers no longer _may_ have to calculate
      the list of trending projects. Furthermore it supports filtering without
      any complex caching mechanisms.
      The data in the "trending_projects" table is inserted in the same order
      as the project ranking. This means that getting the projects in the
      correct order is simply a matter of:
          SELECT projects.*
          FROM projects
          INNER JOIN trending_projects ON trending_projects.project_id = projects.id
          ORDER BY trending_projects.id ASC;
      Such a query will only take a few milliseconds at most (as measured on
      GitLab.com), opposed to a few seconds for the query used for calculating
      the project ranks.
      The migration in this commit does not require downtime and takes care of
      populating an initial list of trending projects.
  5. 07 Oct, 2016 1 commit
    • Nick Thomas's avatar
      Add markdown cache columns to the database, but don't use them yet · e94cd6fd
      Nick Thomas authored
      This commit adds a number of _html columns and, with the exception of Note,
      starts updating them whenever the content of their partner fields changes.
      Note has a collision with the note_html attr_accessor; that will be fixed later
      A background worker for clearing these cache columns is also introduced - use
      `rake cache:clear` to set it off. You can clear the database or Redis caches
      separately by running `rake cache:clear:db` or `rake cache:clear:redis`,
  6. 06 Oct, 2016 3 commits
  7. 04 Oct, 2016 1 commit
  8. 28 Sep, 2016 1 commit
    • Rémy Coutable's avatar
      Allow Member.add_user to handle access requesters · ec0061a9
      Rémy Coutable authored
      Changes include:
      - Ensure Member.add_user is not called directly when not necessary
      - New GroupMember.add_users_to_group to have the same abstraction level as for Project
      - Refactor Member.add_user to take a source instead of an array of members
      - Fix Rubocop offenses
      - Always use Project#add_user instead of project.team.add_user
      - Factorize users addition as members in Member.add_users_to_source
      - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
      - Destroy any requester before adding them as a member
      - Improve the way we handle access requesters in Member.add_user
        Instead of removing the requester and creating a new member,
        we now simply accepts their access request. This way, they will
        receive a "access request granted" email.
      - Fix error that was previously silently ignored
      - Stop raising when access level is invalid in Member, let Rails validation do their work
      Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
  9. 27 Sep, 2016 2 commits
  10. 23 Sep, 2016 2 commits
  11. 21 Sep, 2016 1 commit
  12. 20 Sep, 2016 5 commits
    • Timothy Andrew's avatar
      Implement a second round of review comments from @DouweM. · 918e589c
      Timothy Andrew authored
      - Don't use `TableReferences` - using `.arel_table` is shorter!
      - Move some database-related code to `Gitlab::Database`
      - Remove the `MergeRequest#issues_closed` and
        `Issue#closed_by_merge_requests`  associations. They were either
        shadowing or were too similar to existing methods. They are not being
        used anywhere, so it's better to remove them to reduce confusion.
      - Use Rails 3-style validations
      - Index for `MergeRequest::Metrics#first_deployed_to_production_at`
      - Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
        need it.
      - Other minor refactorings.
    • Timothy Andrew's avatar
      Update schema.rb · 6f194e28
      Timothy Andrew authored
    • Timothy Andrew's avatar
      Fix `ON DELETE CASCADE` migrations. · 8747f29d
      Timothy Andrew authored
      Incorrect syntax.
    • Timothy Andrew's avatar
      Implement review comments from @yorickpeterse · 8957293d
      Timothy Andrew authored
      1. Change multiple updates to a single `update_all`
      2. Use cascading deletes
      3. Extract an average function for the database median.
      4. Move database median to `lib/gitlab/database`
      5. Use `delete_all` instead of `destroy_all`
      6. Minor refactoring
    • Timothy Andrew's avatar
      Miscellaneous cycle-analytics-related changes. · b43d3af7
      Timothy Andrew authored
      1. Add indexes to `CreateMergeRequestsClosingIssues` columns.
      2. Remove an extraneous `check_if_open` check that is redundant now.
      It would've been better to rebase this in, but that's not possible
      because more people are working on this branch.
  13. 19 Sep, 2016 4 commits
  14. 17 Sep, 2016 1 commit
    • Timothy Andrew's avatar
      Add a "populate metrics directly" option to the cycle analytics seed. · 161804bf
      Timothy Andrew authored
      - The normal seed creates all the data for cycle analytics the "right"
        way. It creates issues, merge requests, commits, branches,
        deployments, etc. This is good, but too slow for perf testing.
        Generating a 1000 sets of records this way takes more than an hour.
        variable is passed in, the seed only creates issues and merge
        requests. It then adds the `metrics` for each issue and
        merge request directly, to save time.
      - The seed now takes about 4 minutes to run for 1000 sets of records.
  15. 16 Sep, 2016 2 commits
  16. 15 Sep, 2016 6 commits
    • Patricio Cano's avatar
    • Patricio Cano's avatar
      Added group-specific setting for LFS. · fd621429
      Patricio Cano authored
      Groups can enable/disable LFS, but this setting can be overridden at the project level. Admin only
    • Patricio Cano's avatar
    • Patricio Cano's avatar
      Added LFS support to SSH · e40e3fdc
      Patricio Cano authored
      - Required on the GitLab Rails side is mostly authentication and API related.
    • Timothy Andrew's avatar
      Improve performance of the cycle analytics page. · ba25e2f1
      Timothy Andrew authored
      1. These changes bring down page load time for 100 issues from more than
         a minute to about 1.5 seconds.
      2. This entire commit is composed of these types of performance
           - Cache relevant data in `IssueMetrics` wherever possible.
           - Cache relevant data in `MergeRequestMetrics` wherever possible.
           - Preload metrics
      3. Given these improvements, we now only need to make 4 SQL calls:
          - Load all issues
          - Load all merge requests
          - Load all metrics for the issues
          - Load all metrics for the merge requests
      4. A list of all the data points that are now being pre-calculated:
          a. The first time an issue is mentioned in a commit
            - In `GitPushService`, find all issues mentioned by the given commit
              using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at`
              flag for each of them.
            - There seems to be a (pre-existing) bug here - files (and
              therefore commits) created using the Web CI don't have
              cross-references created, and issues are not closed even when
              the commit title is "Fixes #xx".
          b. The first time a merge request is deployed to production
            When a `Deployment` is created, find all merge requests that
            were merged in before the deployment, and set the
            `first_deployed_to_production_at` flag for each of them.
          c. The start / end time for a merge request pipeline
            Hook into the `Pipeline` state machine. When the `status` moves to
            `running`, find the merge requests whose tip commit matches the
            pipeline, and record the `latest_build_started_at` time for each
            of them. When the `status` moves to `success`, record the
            `latest_build_finished_at` time.
          d. The merge requests that close an issue
            - This was a big cause of the performance problems we were having
              with Cycle Analytics. We need to use `ReferenceExtractor` to make
              this calculation, which is slow when we have to run it on a large
              number of merge requests.
            - When a merge request is created, updated, or refreshed, find the
              issues it closes, and create an instance of
              `MergeRequestsClosingIssues`, which acts as a join model between
              merge requests and issues.
            - If a `MergeRequestsClosingIssues` instance links a merge request
              and an issue, that issue closes that merge request.
      5. The `Queries` module was changed into a class, so we can cache the
         results of `issues` and `merge_requests_closing_issues` across
         various cycle analytics stages.
      6. The code added in this commit is untested. Tests will be added in the
         next commit.
    • Alejandro Rodríguez's avatar
      Update references to deprecated `repos_path` configuration key to avoid · 02bc717f
      Alejandro Rodríguez authored
      errors on updates from older versions
  17. 14 Sep, 2016 3 commits
    • Yorick Peterse's avatar
      Fix migration for removing MR diff indexes · fd4ad654
      Yorick Peterse authored
      For whatever reason on some PostgreSQL installations there would be a
      separate UNIQUE constraint on the merge_request_id column. Rails'
      index_exists?() returns false for this constraint (even when using the
      full name), yet the indexes() method returns it.
      This commit changes the migration so that the constraint is dropped as
      well. MySQL installations don't appear to be affected.
      Fixes gitlab-org/gitlab-ce#22136
    • Timothy Andrew's avatar
      wip: perf · 74626106
      Timothy Andrew authored
    • Timothy Andrew's avatar
      Add a `seed_fu` fixture to generate data for cycle analytics. · 2110989f
      Timothy Andrew authored
      - The fixture generates data for every stage in the cycle analytics
        dashboard. Once this fixture has run, you shouldn't be seeing any
        "<not enough data>" messages for cycle analytics.
      - This is probably not necessary for every fixture run, so it might be
        moved behind an env var in the future.
  18. 13 Sep, 2016 1 commit
    • Yorick Peterse's avatar
      Move pushes_since_gc to Redis · 4e87c023
      Yorick Peterse authored
      This moves tracking of the pushes since the last Git GC from PostgreSQL
      to Redis. This reduces the number of writes on the "projects" table.
      This in turn reduces the vacuuming overhead.
      The lease used for incrementing the counter has been removed. This lease
      was mostly put in place to prevent high database load but this isn't
      needed anymore due to the counter now being stored in Redis.
      Fixes gitlab-org/gitlab-ce#22125