1. 22 Aug, 2019 3 commits
  2. 19 Aug, 2019 1 commit
  3. 17 Aug, 2019 1 commit
  4. 16 Aug, 2019 3 commits
    • Stan Hu's avatar
      Expire project caches once per push instead of once per ref · f14647fd
      Stan Hu authored
      Previously `ProjectCacheWorker` would be scheduled once per ref, which
      would generate unnecessary I/O and load on Sidekiq, especially if many
      tags or branches were pushed at once. `ProjectCacheWorker` would expire
      three items:
      
      1. Repository size: This only needs to be updated once per push.
      2. Commit count: This only needs to be updated if the default branch
         is updated.
      3. Project method caches: This only needs to be updated if the default
         branch changes, but only if certain files change (e.g. README,
         CHANGELOG, etc.).
      
      Because the third item requires looking at the actual changes in the
      commit deltas, we schedule one `ProjectCacheWorker` to handle the first
      two cases, and schedule a separate `ProjectCacheWorker` for the third
      case if it is needed. As a result, this brings down the number of
      `ProjectCacheWorker` jobs from N to 2.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52046
      f14647fd
    • rossfuhrman's avatar
      Remove Security Dashboard feature flag · 3fbc51d3
      rossfuhrman authored
      This removes the group_overview_security_dashboard feature flag
      3fbc51d3
    • Jarka Košanová's avatar
      Add rake tasks for migrating leacy uploads · 19db3157
      Jarka Košanová authored
      - move uploads created by AttachmentUploader
      - handle also files created for legacy_diff_notes
      19db3157
  5. 15 Aug, 2019 9 commits
  6. 14 Aug, 2019 6 commits
  7. 13 Aug, 2019 7 commits
    • Kamil Trzciński's avatar
      Expand variables only when needed · 6150c3ff
      Kamil Trzciński authored
      This makes us to expand variables only when needed,
      instead of requesting all variables each time.
      
      This specifically helps in situation when explicit name
      of `environment: production` is used.
      6150c3ff
    • Stan Hu's avatar
      Only expire tag cache once per push · e658f960
      Stan Hu authored
      Previously each tag in a push would invoke the Gitaly `FindAllTags` RPC
      since the tag cache would be invalidated with every tag.
      
      We can eliminate those extraneous calls by expiring the tag cache once
      in `PostReceive` and taking advantage of the cached tags.
      
      Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/65795
      e658f960
    • Kamil Trzciński's avatar
      Require `needs:` to be present · 93e95182
      Kamil Trzciński authored
      This changes the `needs:` logic to require
      that all jobs to be present. Instead of skipping
      do fail the pipeline creation if `needs:` dependency
      is not found.
      93e95182
    • Kamil Trzciński's avatar
      Require `stage:` to be set with `needs:` · 583544d0
      Kamil Trzciński authored
      Since we are unsure what would be the behavior of `stage:`
      when we work on DAG. Let's make `stage:` to be required
      today with `needs:`.
      583544d0
    • GitalyBot's avatar
      Upgrade Gitaly to v1.59.0 · 3c5647bd
      GitalyBot authored
      3c5647bd
    • Stan Hu's avatar
      Reduce Gitaly calls in PostReceive · 4e2bb4e5
      Stan Hu authored
      This commit reduces I/O load and memory utilization during PostReceive
      for the common case when no project hooks or services are set up.
      
      We saw a Gitaly N+1 issue in `CommitDelta` when many tags or branches
      are pushed. We can reduce this overhead in the common case because we
      observe that most new projects do not have any Web hooks or services,
      especially when they are first created. Previously, `BaseHooksService`
      unconditionally iterated through the last 20 commits of each ref to
      build the `push_data` structure. The `push_data` structured was used in
      numerous places:
      
      1. Building the push payload in `EventCreateService`
      2. Creating a CI pipeline
      3. Executing project Web or system hooks
      4. Executing project services
      5. As the return value of `BaseHooksService#execute`
      6. `BranchHooksService#invalidated_file_types`
      
      We only need to generate the full `push_data` for items 3, 4, and 6.
      
      Item 1: `EventCreateService` only needs the last commit and doesn't
      actually need the commit deltas.
      
      Item 2: In addition, `Ci::CreatePipelineService` only needed a subset of
      the parameters.
      
      Item 5: The return value of `BaseHooksService#execute` also wasn't being
      used anywhere.
      
      Item 6: This is only used when pushing to the default branch, so if
      many tags are pushed we can save significant I/O here.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65878
      
      Fic
      4e2bb4e5
    • Heinrich Lee Yu's avatar
      Improve quick action error messages · 7a6ecbcb
      Heinrich Lee Yu authored
      Standardize punctuation and format
      7a6ecbcb
  8. 12 Aug, 2019 8 commits
  9. 11 Aug, 2019 1 commit
    • Stan Hu's avatar
      Properly save suggestions in project exports · 26107e93
      Stan Hu authored
      Previously imports would fail if a merge request note included a
      suggestion with an
      `ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection`
      exception.
      
      This was happening because suggestions were listed as a descendant of
      merge requests, but this doesn't work because suggestions are directly
      associated with notes, not merge requests, and that association is lost.
      Rails also disallows creating intializing a has_many association through
      a different object.
      
      We fix this by making `suggestions` a child of `notes` within a merge
      request. This doesn't fix previously broken exported project exports,
      but new exports will work.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65880
      26107e93
  10. 10 Aug, 2019 1 commit