Commit ccbebbdf authored by Douwe Maan's avatar Douwe Maan

Enable Performance/RedundantMatch

parent 215228b4
......@@ -926,6 +926,9 @@ Lint/UnusedBlockArgument:
Performance/RedundantBlockCall:
Enabled: true
Performance/RedundantMatch:
Enabled: true
Rails/HttpPositionalArguments:
Enabled: false
......
......@@ -6,16 +6,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
# Offense count: 5
# Cop supports --auto-correct.
Performance/RedundantMatch:
Exclude:
- 'app/models/external_issue.rb'
- 'lib/ci/api/helpers.rb'
- 'lib/extracts_path.rb'
- 'lib/gitlab/diff/highlight.rb'
- 'lib/gitlab/diff/parser.rb'
# Offense count: 15
# Configuration parameters: CustomIncludeMethods.
RSpec/EmptyExampleGroup:
......
......@@ -43,7 +43,7 @@ class ExternalIssue
end
def reference_link_text(from_project = nil)
return "##{id}" if /^\d+$/.match(id)
return "##{id}" if id =~ /^\d+$/
id
end
......
......@@ -60,7 +60,7 @@ module Ci
end
def build_not_found!
if headers['User-Agent'].to_s.match(/gitlab-ci-multi-runner \d+\.\d+\.\d+(~beta\.\d+\.g[0-9a-f]+)? /)
if headers['User-Agent'].to_s =~ /gitlab-ci-multi-runner \d+\.\d+\.\d+(~beta\.\d+\.g[0-9a-f]+)? /
no_content!
else
not_found!
......
......@@ -42,7 +42,7 @@ module ExtractsPath
return pair unless @project
if id.match(/^([[:alnum:]]{40})(.+)/)
if id =~ /^([[:alnum:]]{40})(.+)/
# If the ref appears to be a SHA, we're done, just split the string
pair = $~.captures
else
......
......@@ -50,7 +50,7 @@ module Gitlab
# Only update text if line is found. This will prevent
# issues with submodules given the line only exists in diff content.
if rich_line
line_prefix = diff_line.text.match(/\A(.)/) ? $1 : ' '
line_prefix = diff_line.text =~ /\A(.)/ ? $1 : ' '
"#{line_prefix}#{rich_line}".html_safe
end
end
......
......@@ -20,7 +20,7 @@ module Gitlab
full_line = line.delete("\n")
if line.match(/^@@ -/)
if line =~ /^@@ -/
type = "match"
line_old = line.match(/\-[0-9]*/)[0].to_i.abs rescue 0
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment