Commit c8755543 authored by gfyoung's avatar gfyoung

Enable even more frozen string in lib/**/*.rb

Enables frozen string for the following files:

* lib/generators/**/*.rb
* lib/gitaly/**/*.rb
* lib/google_api/**/*.rb
* lib/haml_lint/**/*.rb
* lib/json_web_token/**/*.rb
* lib/mattermost/**/*.rb
* lib/microsoft_teams/**/*.rb
* lib/object_storage/**/*.rb
* lib/omni_auth/**/*.rb
* lib/peek/**/*.rb
* lib/rouge/**/*.rb
* lib/rspec_flaky/**/*.rb
* lib/system_check/**/*.rb

Partially addresses #47424.
parent 1540d51a
......@@ -48,7 +48,8 @@ Style/FrozenStringLiteralComment:
- 'danger/**/*'
- 'db/**/*'
- 'ee/**/*'
- 'lib/**/*'
- 'lib/gitlab/**/*'
- 'lib/tasks/**/*'
- 'qa/**/*'
- 'rubocop/**/*'
- 'scripts/**/*'
......
---
title: Enable even more frozen string in lib/**/*.rb
merge_request:
author: gfyoung
type: performance
# frozen_string_literal: true
require 'rails/generators'
module Rails
......
# frozen_string_literal: true
module Gitaly
class Server
def self.all
......
# frozen_string_literal: true
module GoogleApi
class Auth
attr_reader :access_token, :redirect_uri, :state
......
# frozen_string_literal: true
require 'google/apis/compute_v1'
require 'google/apis/container_v1'
require 'google/apis/cloudbilling_v1'
......
unless Rails.env.production? # rubocop:disable Naming/FileName
# rubocop:disable Naming/FileName
# frozen_string_literal: true
unless Rails.env.production?
require 'haml_lint/haml_visitor'
require 'haml_lint/linter'
require 'haml_lint/linter_registry'
......
# frozen_string_literal: true
module JSONWebToken
class RSAToken < Token
attr_reader :key_file
......
# frozen_string_literal: true
module JSONWebToken
class Token
attr_accessor :issuer, :subject, :audience, :id
......
# frozen_string_literal: true
module Mattermost
ClientError = Class.new(Mattermost::Error)
......
# frozen_string_literal: true
module Mattermost
class Command < Client
def create(params)
......
# frozen_string_literal: true
module Mattermost
Error = Class.new(StandardError)
end
# frozen_string_literal: true
module Mattermost
class NoSessionError < Mattermost::Error
def message
......
# frozen_string_literal: true
module Mattermost
class Team < Client
# Returns all teams that the current user is a member of
......
# frozen_string_literal: true
module MicrosoftTeams
class Activity
def initialize(title:, subtitle:, text:, image:)
......
# frozen_string_literal: true
module MicrosoftTeams
class Notifier
def initialize(webhook)
......
# frozen_string_literal: true
module ObjectStorage
#
# The DirectUpload c;ass generates a set of presigned URLs
......
# frozen_string_literal: true
require 'omniauth-oauth2'
module OmniAuth
......
# frozen_string_literal: true
require 'omniauth'
require 'jwt'
......
# frozen_string_literal: true
module Peek
module Rblineprof
module CustomControllerHelpers
......@@ -41,7 +43,7 @@ module Peek
]
end.sort_by{ |a,b,c,d,e,f| -f }
output = "<div class='modal-dialog modal-xl'><div class='modal-content'>"
output = ["<div class='modal-dialog modal-xl'><div class='modal-content'>"]
output << "<div class='modal-header'>"
output << "<h4>Line profiling: #{human_description(params[:lineprofiler])}</h4>"
output << "<button class='close' type='button' data-dismiss='modal' aria-label='close'><span aria-hidden='true'>&times;</span></button>"
......@@ -93,7 +95,7 @@ module Peek
output << "</div></div></div>"
response.body += "<div class='modal' id='modal-peek-line-profile' tabindex=-1>#{output}</div>".html_safe
response.body += "<div class='modal' id='modal-peek-line-profile' tabindex=-1>#{output.join}</div>".html_safe
end
ret
......
# frozen_string_literal: true
module Peek
module Views
class Gitaly < View
......
# frozen_string_literal: true
module Peek
module Views
class Host < View
......
# frozen_string_literal: true
module Rouge
module Formatters
class HTMLGitlab < Rouge::Formatters::HTML
......
# frozen_string_literal: true
# A rouge plugin for CommonMark markdown engine.
# Used to highlight code generated by CommonMark.
......
# frozen_string_literal: true
module RspecFlaky
class Config
def self.generate_report?
......
# frozen_string_literal: true
module RspecFlaky
# This is a wrapper class for RSpec::Core::Example
class Example
......
# frozen_string_literal: true
module RspecFlaky
# This represents a flaky RSpec example and is mainly meant to be saved in a JSON file
class FlakyExample < OpenStruct
......
# frozen_string_literal: true
require 'active_support/hash_with_indifferent_access'
require_relative 'flaky_example'
......
# frozen_string_literal: true
require 'json'
require_dependency 'rspec_flaky/config'
......
# frozen_string_literal: true
require 'json'
require 'time'
......
# frozen_string_literal: true
module SystemCheck
module App
class ActiveUsersCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class DatabaseConfigExistsCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class GitConfigCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class GitUserDefaultSSHConfigCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class GitVersionCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class GitlabConfigExistsCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class GitlabConfigUpToDateCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class InitScriptExistsCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class InitScriptUpToDateCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class LogWritableCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class MigrationsAreUpCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class OrphanedGroupMembersCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class ProjectsHaveNamespaceCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class RedisVersionCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class RubyVersionCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class TmpWritableCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class UploadsDirectoryExistsCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class UploadsPathPermissionCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module App
class UploadsPathTmpPermissionCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
# Base class for Checks. You must inherit from here
# and implement the methods below when necessary
......
# frozen_string_literal: true
module SystemCheck
module Helpers
include ::Gitlab::TaskHelpers
......
# frozen_string_literal: true
module SystemCheck
module IncomingEmail
class ForemanConfiguredCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module IncomingEmail
class ImapAuthenticationCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module IncomingEmail
class InitdConfiguredCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module IncomingEmail
class MailRoomRunningCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module Orphans
class NamespaceCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
module Orphans
class RepositoryCheck < SystemCheck::BaseCheck
......
# frozen_string_literal: true
module SystemCheck
# Simple Executor is current default executor for GitLab
# It is a simple port from display logic in the old check.rake
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment