Commit 69544c1e authored by Sean McGivern's avatar Sean McGivern

Fix UrlBlocker spec

The newer version of HTTParty we now use will try harder to get a valid
URL out of a relative one. Unfortunately, when there's no room (as was
the case in this spec), the relative URL begins with `//`, which is
actually a protocol-relative URL, not a simple path.

Adding a room - which will always be the case in 'real life' - fixes
this.
parent 38d8616e
......@@ -391,7 +391,7 @@ describe HipchatService do
context 'with UrlBlocker' do
let(:user) { create(:user) }
let(:project) { create(:project, :repository) }
let(:hipchat) { described_class.new(project: project) }
let(:hipchat) { create(:hipchat_service, project: project, properties: { room: 'test' }) }
let(:push_sample_data) { Gitlab::DataBuilder::Push.build_sample(project, user) }
describe '#execute' do
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment