Commit 59b8165c authored by Stan Hu's avatar Stan Hu

Strip trailing whitespaces in submodule URLs

Users attempting to access repositories that had `.gitmodules` entries
with trailing whitespaces would encounter an Error 500. This was due
to a change in bf876ec7 that quietly removed the whitespace stripping.

Closes #33018
parent 8a9e2415
......@@ -13,6 +13,7 @@ module SubmoduleHelper
if url =~ /([^\/:]+)\/([^\/]+(?:\.git)?)\Z/
namespace, project = $1, $2
project.sub!(/\.git\z/, '')
if self_url?(url, namespace, project)
title: Strip trailing whitespaces in submodule URLs
......@@ -115,6 +115,11 @@ describe SubmoduleHelper do
expect(submodule_links(submodule_item)).to eq(['', ''])
it 'handles urls with trailing whitespace' do
stub_url(' ')
expect(submodule_links(submodule_item)).to eq(['', ''])
it 'returns original with non-standard url' do
expect(submodule_links(submodule_item)).to eq([repo.submodule_url_for, nil])
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment